From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: mengdong.lin@linux.intel.com, tiwai@suse.de,
intel-gfx@lists.freedesktop.org, liam.r.girdwood@linux.intel.com,
vinod.koul@intel.com, broonie@kernel.org,
rakesh.a.ughreja@intel.com
Subject: Re: [RFC 02/15] drm: i915: remove intel_hdmi variable declaration
Date: Fri, 11 Mar 2016 11:08:04 -0600 [thread overview]
Message-ID: <56E2FB74.2060108@linux.intel.com> (raw)
In-Reply-To: <20160310173403.GA4329@intel.com>
On 3/10/16 11:34 AM, Ville Syrjälä wrote:
> On Fri, Mar 04, 2016 at 08:50:39PM -0600, Pierre-Louis Bossart wrote:
>> 'intel_hdmi' variable is redeclared, use same variable declared in
>> function scope.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>> index d8060e6..1beb155 100644
>> --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> @@ -1418,7 +1418,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
>> intel_hdmi_unset_edid(connector);
>>
>> if (intel_hdmi_set_edid(connector, live_status)) {
>> - struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
>> + intel_hdmi = intel_attached_hdmi(connector);
>
> We're still going to get the same answer,
> so you can just kill the assignment as well.
Thanks. I wasn't sure if the set_edid would have side effects. Will
resend this one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-11 17:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 2:50 [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 01/15] drm: i915: fix inversion of definitions for LPE_PIPE_A/B Pierre-Louis Bossart
2016-03-05 13:27 ` Ville Syrjälä
2016-03-07 18:00 ` Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 02/15] drm: i915: remove intel_hdmi variable declaration Pierre-Louis Bossart
2016-03-10 17:34 ` Ville Syrjälä
2016-03-11 17:08 ` Pierre-Louis Bossart [this message]
2016-03-05 2:50 ` [RFC 03/15] Doc: sound: add description of Atom HDMI audio interface Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface Pierre-Louis Bossart
2016-03-10 17:54 ` Ville Syrjälä
2016-03-10 18:00 ` Ville Syrjälä
2016-03-11 17:27 ` Pierre-Louis Bossart
2016-03-11 19:09 ` Ville Syrjälä
2016-03-14 9:04 ` Daniel Vetter
2016-03-14 14:20 ` Ville Syrjälä
2016-03-15 8:35 ` Daniel Vetter
2016-03-15 13:30 ` Ville Syrjälä
2016-03-16 16:43 ` Ville Syrjälä
2016-03-21 8:35 ` Daniel Vetter
2016-03-15 8:36 ` Daniel Vetter
2016-03-14 15:13 ` Pierre-Louis Bossart
2016-03-14 15:21 ` Ville Syrjälä
2016-03-14 15:30 ` Ville Syrjälä
2016-03-14 17:27 ` Pierre-Louis Bossart
2016-03-15 8:39 ` Daniel Vetter
2016-03-15 13:35 ` Ville Syrjälä
2016-03-15 13:43 ` Daniel Vetter
2016-03-15 16:21 ` Vinod Koul
2016-03-15 21:14 ` Pierre-Louis Bossart
2016-03-16 3:09 ` Vinod Koul
2016-03-05 2:50 ` [RFC 05/15] drm/i915: changes " Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 06/15] drm/i915: power-related changes " Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 07/15] drm/i915: Add API code for " Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 08/15] drm/i915: enable non-HDAudio HDMI interface Makefile Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 09/15] ALSA: Intel: Atom: add Atom non-HDAudio HDMI interface Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 10/15] add dependency on PM_RUNTIME Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 11/15] hdmi_audio: Improve position reporting Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 12/15] hdmi_audio: Fixup some monitor Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 13/15] hdmi_audio: Fix mishandling of AUD_HDMI_STATUS_v2 register Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 14/15] i915: Enable LPE_PIPEA_Interrupt Pierre-Louis Bossart
2016-03-05 2:50 ` [RFC 15/15] i915: Fix typo in comment Pierre-Louis Bossart
2016-03-05 13:42 ` [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio Ville Syrjälä
2016-03-07 17:54 ` Pierre-Louis Bossart
2016-03-07 18:02 ` Ville Syrjälä
2016-03-07 18:12 ` Pierre-Louis Bossart
2016-03-07 18:29 ` Ville Syrjälä
2016-03-07 12:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2FB74.2060108@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=broonie@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox