From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Siluvery Subject: Re: [PATCH 2/7] drm/i915/guc: always reset GuC before loading firmware Date: Tue, 22 Mar 2016 13:32:37 +0000 Message-ID: <56F14975.20508@linux.intel.com> References: <1458555400-22859-1-git-send-email-david.s.gordon@intel.com> <1458555400-22859-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 626DB8902A for ; Tue, 22 Mar 2016 13:33:06 +0000 (UTC) In-Reply-To: <1458555400-22859-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjEvMDMvMjAxNiAxMDoxNiwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4gQWZ0ZXIgYSBzdXNwZW5k LXJlc3VtZSBjeWNsZSwgdGhlIHJlc3VtZWQga2VybmVsIGhhcyBubyBpZGVhIHdoYXQgdGhlCj4g Ym9vdGVkIGtlcm5lbCBtYXkgaGF2ZSBkb25lIHRvIHRoZSBHdUMgYmVmb3JlIHJlcGxhY2luZyBp dHNlbGYgd2l0aCB0aGUKPiByZXN1bWVkIGltYWdlLiBJbiBwYXJ0aWN1bGFyLCBpdCBtYXkgaGF2 ZSBhbHJlYWR5IGxvYWRlZCB0aGUgR3VDIHdpdGgKPiBmaXJtd2FyZSwgd2hpY2ggd2lsbCB0aGVu IGNhdXNlIHRoaXMga2VybmVsJ3MgYXR0ZW1wdCB0byAocmUpbG9hZCB0aGUKPiBmaXJtd2FyZSB0 byBmYWlsIChHdUMgcHJvZ3JhbSBtZW1vcnkgaXMgd3JpdGUtb25jZSEpLgo+Cj4gU28gaGVyZSB3 ZSBjaG9vc2UgdG8gYWx3YXlzIHJlc2V0IHRoZSBHdUMganVzdCBiZWZvcmUgKHJlKWxvYWRpbmcg dGhlCj4gZmlybXdhcmUsIHNvIHRoZSBoYXJkd2FyZSBzaG91bGQgdGhlbiBiZSBpbiBhIHdlbGwt a25vd24gc3RhdGUsIGFuZCB3ZQo+IG1heSBldmVuIGF2b2lkIHNvbWUgb2YgdGhlIGlzc3VlcyBh cmlzaW5nIGZyb20gdW5wcmVkaWN0YWJsZSB0aW1pbmcuCj4KPiBBbHNvIGFkZGVkIHNvbWUgbW9y ZSBmaWVsZHMgJiB2YWx1ZXMgdG8gdGhlIGRlZmluaXRpb24gb2YgdGhlIEdVQ19TVEFUVVMKPiBy ZWdpc3Rlciwgd2hpY2ggaXMgdGhlIGtleSBkaWFnbm9zdGljIGluZGljYXRvciBpZiB0aGUgR3VD IGxvYWQgZmFpbHMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jk b25AaW50ZWwuY29tPgo+IENjOiBBcnVuIFNpbHV2ZXJ5IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4KUGxlYXNlIGFkZCBi dWd6aWxsYSByZWZlcmVuY2UuCgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n dWNfcmVnLmggICAgIHwgMTIgKysrKysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2xvYWRlci5jIHwgNDAgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4g ICAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfcmVnLmgKPiBpbmRleCA5NGNlZWU1Li44MDc4NmQ5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfcmVnLmgKPiBAQCAtMjcsMTAgKzI3LDEyIEBA Cj4gICAvKiBEZWZpbml0aW9ucyBvZiBHdUMgSC9XIHJlZ2lzdGVycywgYml0cywgZXRjICovCj4K PiAgICNkZWZpbmUgR1VDX1NUQVRVUwkJCV9NTUlPKDB4YzAwMCkKPiAtI2RlZmluZSAgIEdTX01J QV9JTl9SRVNFVAkJKDEgPDwgMCkKPiArI2RlZmluZSAgIEdTX1JFU0VUX1NISUZUCQkwCj4gKyNk ZWZpbmUgICBHU19NSUFfSU5fUkVTRVQJCSAgKDB4MDEgPDwgR1NfUkVTRVRfU0hJRlQpCj4gICAj ZGVmaW5lICAgR1NfQk9PVFJPTV9TSElGVAkJMQo+ICAgI2RlZmluZSAgIEdTX0JPT1RST01fTUFT SwkJICAoMHg3RiA8PCBHU19CT09UUk9NX1NISUZUKQo+ICAgI2RlZmluZSAgIEdTX0JPT1RST01f UlNBX0ZBSUxFRAkJICAoMHg1MCA8PCBHU19CT09UUk9NX1NISUZUKQo+ICsjZGVmaW5lICAgR1Nf Qk9PVFJPTV9KVU1QX1BBU1NFRAkgICgweDc2IDw8IEdTX0JPT1RST01fU0hJRlQpCj4gICAjZGVm aW5lICAgR1NfVUtFUk5FTF9TSElGVAkJOAo+ICAgI2RlZmluZSAgIEdTX1VLRVJORUxfTUFTSwkJ ICAoMHhGRiA8PCBHU19VS0VSTkVMX1NISUZUKQo+ICAgI2RlZmluZSAgIEdTX1VLRVJORUxfTEFQ SUNfRE9ORQkJICAoMHgzMCA8PCBHU19VS0VSTkVMX1NISUZUKQo+IEBAIC0zOCw3ICs0MCwxMyBA QAo+ICAgI2RlZmluZSAgIEdTX1VLRVJORUxfUkVBRFkJCSAgKDB4RjAgPDwgR1NfVUtFUk5FTF9T SElGVCkKPiAgICNkZWZpbmUgICBHU19NSUFfU0hJRlQJCQkxNgo+ICAgI2RlZmluZSAgIEdTX01J QV9NQVNLCQkJICAoMHgwNyA8PCBHU19NSUFfU0hJRlQpCj4gLSNkZWZpbmUgICBHU19NSUFfQ09S RV9TVEFURQkJICAoMSA8PCBHU19NSUFfU0hJRlQpCj4gKyNkZWZpbmUgICBHU19NSUFfQ09SRV9T VEFURQkJICAoMHgwMSA8PCBHU19NSUFfU0hJRlQpCj4gKyNkZWZpbmUgICBHU19NSUFfSEFMVF9S RVFVRVNURUQJCSAgKDB4MDIgPDwgR1NfTUlBX1NISUZUKQo+ICsjZGVmaW5lICAgR1NfTUlBX0lT Ul9FTlRSWQkJICAoMHgwNCA8PCBHU19NSUFfU0hJRlQpCj4gKyNkZWZpbmUgICBHU19BVVRIX1NU QVRVU19TSElGVAkJMzAKPiArI2RlZmluZSAgIEdTX0FVVEhfU1RBVFVTX01BU0sJCSAgKDB4MDMg PDwgR1NfQVVUSF9TVEFUVVNfU0hJRlQpCj4gKyNkZWZpbmUgICBHU19BVVRIX1NUQVRVU19CQUQJ CSAgKDB4MDEgPDwgR1NfQVVUSF9TVEFUVVNfU0hJRlQpCj4gKyNkZWZpbmUgICBHU19BVVRIX1NU QVRVU19HT09ECQkgICgweDAyIDw8IEdTX0FVVEhfU1RBVFVTX1NISUZUKQo+Cj4gICAjZGVmaW5l IFNPRlRfU0NSQVRDSChuKQkJCV9NTUlPKDB4YzE4MCArIChuKSAqIDQpCj4gICAjZGVmaW5lIFNP RlRfU0NSQVRDSF9DT1VOVAkJMTYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX2xvYWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRl ci5jCj4gaW5kZXggYTA3YzIyOC4uYTg3NTkzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ndWNfbG9hZGVyLmMKPiBAQCAtMzg3LDcgKzM4Nyw3IEBAIGludCBpbnRlbF9ndWNfdWNv ZGVfbG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gICAJc3RydWN0IGludGVs X2d1Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMuZ3VjX2Z3Owo+IC0JaW50IGVyciA9IDA7 Cj4gKwlpbnQgcmV0cmllcywgZXJyID0gMDsKPgo+ICAgCWlmICghaTkxNS5lbmFibGVfZ3VjX3N1 Ym1pc3Npb24pCj4gICAJCXJldHVybiAwOwo+IEBAIC00NDEsMjkgKzQ0MSwyNiBAQCBpbnQgaW50 ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAkgKiBzdGVwcGlu Z3MgYWxzbyBzbyB0aGlzIGlzIGV4dGVuZGVkIGFzIHdlbGwuCj4gICAJICovCj4gICAJLyogV2FF bmFibGVHdUNCb290SGFzaENoZWNrTm90U2V0OnNrbCxieHQgKi8KPiAtCWVyciA9IGd1Y191Y29k ZV94ZmVyKGRldl9wcml2KTsKPiAtCWlmIChlcnIpIHsKPiAtCQlpbnQgcmV0cmllcyA9IDM7Cj4g LQo+IC0JCURSTV9FUlJPUigiR3VDIGZ3IGxvYWQgZmFpbGVkLCBlcnI9JWQsIGF0dGVtcHRpbmcg cmVzZXQgYW5kIHJldHJ5XG4iLCBlcnIpOwo+IC0KPiAtCQl3aGlsZSAocmV0cmllcy0tKSB7Cj4g LQkJCWVyciA9IGk5MTVfcmVzZXRfZ3VjKGRldl9wcml2KTsKPiAtCQkJaWYgKGVycikKPiAtCQkJ CWJyZWFrOwo+IC0KPiAtCQkJZXJyID0gZ3VjX3Vjb2RlX3hmZXIoZGV2X3ByaXYpOwo+IC0JCQlp ZiAoIWVycikgewo+IC0JCQkJRFJNX0RFQlVHX0RSSVZFUigiR3VDIGZ3IHJlbG9hZCBzdWNjZWVk ZWQgYWZ0ZXIgcmVzZXRcbiIpOwo+IC0JCQkJYnJlYWs7Cj4gLQkJCX0KPiAtCQkJRFJNX0RFQlVH X0RSSVZFUigiR3VDIGZ3IHJlbG9hZCByZXRyaWVzIGxlZnQ6ICVkXG4iLCByZXRyaWVzKTsKPiAt CQl9Cj4gLQo+ICsJZm9yIChyZXRyaWVzID0gMzsgOyApIHsKPiArCQkvKgo+ICsJCSAqIEFsd2F5 cyByZXNldCB0aGUgR3VDIGp1c3QgYmVmb3JlIChyZSlsb2FkaW5nLCBzbwo+ICsJCSAqIHRoYXQg dGhlIHN0YXRlIGFuZCB0aW1pbmcgYXJlIGZhaXJseSBwcmVkaWN0YWJsZQo+ICsJCSAqLwo+ICsJ CWVyciA9IGk5MTVfcmVzZXRfZ3VjKGRldl9wcml2KTsKPiAgIAkJaWYgKGVycikgewo+IC0JCQlE Uk1fRVJST1IoIkd1QyBmdyByZWxvYWQgYXR0ZW1wdCBmYWlsZWQsIHJldD0lZFxuIiwgZXJyKTsK PiArCQkJRFJNX0VSUk9SKCJHdUMgcmVzZXQgZmFpbGVkLCBlcnIgJWRcbiIsIGVycik7Cj4gICAJ CQlnb3RvIGZhaWw7Cj4gICAJCX0KPiArCj4gKwkJZXJyID0gZ3VjX3Vjb2RlX3hmZXIoZGV2X3By aXYpOwo+ICsJCWlmICghZXJyKQo+ICsJCQlicmVhazsKPiArCj4gKwkJaWYgKC0tcmV0cmllcyA9 PSAwKQo+ICsJCQlnb3RvIGZhaWw7Cj4gKwo+ICsJCURSTV9JTkZPKCJHdUMgZncgbG9hZCBmYWls ZWQsIGVyciAlZDsgd2lsbCByZXNldCBhbmQgIgo+ICsJCQkicmV0cnkgJWQgbW9yZSB0aW1lKHMp XG4iLCBlcnIsIHJldHJpZXMpOwo+ICAgCX0KPgo+ICAgCWd1Y19mdy0+Z3VjX2Z3X2xvYWRfc3Rh dHVzID0gR1VDX0ZJUk1XQVJFX1NVQ0NFU1M7Cj4gQEAgLTQ4NSw2ICs0ODIsNyBAQCBpbnQgaW50 ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAlyZXR1cm4gMDsK Pgo+ICAgZmFpbDoKPiArCURSTV9FUlJPUigiR3VDIGZpcm13YXJlIGxvYWQgZmFpbGVkLCBlcnIg JWRcbiIsIGVycik7Cj4gICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X2xvYWRfc3RhdHVzID09IEdVQ19G SVJNV0FSRV9QRU5ESU5HKQo+ICAgCQlndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cyA9IEdVQ19G SVJNV0FSRV9GQUlMOwo+Cj4KbG9va3MgZ29vZCB0byBtZSwKUmV2aWV3ZWQtYnk6IEFydW4gU2ls dXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXguaW50ZWwuY29tPgoKcmVnYXJkcwpBcnVuCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK