From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v7 6/7] drm/i915: refactor duplicate object
 vmap functions (the final rework?)
Date: Tue, 22 Mar 2016 15:25:59 +0000
Message-ID: <56F16407.9010803@intel.com>
References: <1456850039-25856-1-git-send-email-david.s.gordon@intel.com>
 <1456850039-25856-7-git-send-email-david.s.gordon@intel.com>
 <20160302120810.GB25660@nuc-i3427.alporthouse.com>
 <56D70961.6080806@intel.com> <56DE9EC4.2000007@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id AB6556E1CA
 for <intel-gfx@lists.freedesktop.org>; Tue, 22 Mar 2016 15:26:01 +0000 (UTC)
In-Reply-To: <56DE9EC4.2000007@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gMDgvMDMvMTYgMDk6NDMsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMDIvMDMvMTYg
MTU6NDAsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBPbiAwMi8wMy8xNiAxMjowOCwgQ2hyaXMgV2ls
c29uIHdyb3RlOgo+Pj4gT24gVHVlLCBNYXIgMDEsIDIwMTYgYXQgMDQ6MzM6NThQTSArMDAwMCwg
RGF2ZSBHb3Jkb24gd3JvdGU6Cj4+Pj4gVGhpcyBpcyBlc3NlbnRpYWxseSBDaHJpcyBXaWxzb24n
cyBwYXRjaCBvZiBhIHNpbWlsYXIgbmFtZSwgcmV3b3JrZWQgb24KPj4+PiB0b3Agb2YgQWxleCBE
YWkncyByZWNlbnQgcGF0Y2g6Cj4+Pj4gfCBkcm0vaTkxNTogQWRkIGk5MTVfZ2VtX29iamVjdF92
bWFwIHRvIG1hcCBHRU0gb2JqZWN0IHRvIHZpcnR1YWwgc3BhY2UKPj4+Pgo+Pj4+IENocmlzJyBv
cmlnaW5hbCBjb21tZW50YXJ5IHNhaWQ6Cj4+Pj4gfCBXZSBub3cgaGF2ZSB0d28gaW1wbGVtZW50
YXRpb25zIGZvciB2bWFwcGluZyBhIHdob2xlIG9iamVjdCwgb25lIGZvcgo+Pj4+IHwgZG1hLWJ1
ZiBhbmQgb25lIGZvciB0aGUgcmluZ2J1ZmZlci4gSWYgd2UgY291cGxlIHRoZSB2bWFwcGluZyBp
bnRvCj4+Pj4gfCB0aGUgb2JqLT5wYWdlcyBsaWZldGltZSwgdGhlbiB3ZSBjYW4gcmV1c2UgYW4g
b2JqLT52bWFwcGluZyBmb3IgYm90aAo+Pj4+IHwgYW5kIGF0IHRoZSBzYW1lIHRpbWUgY291cGxl
IGl0IGludG8gdGhlIHNocmlua2VyLgo+Pj4+IHwKPj4+PiB8IHYyOiBNYXJrIHRoZSBmYWlsYWJs
ZSBrbWFsbG9jKCkgYXMgX19HRlBfTk9XQVJOICh2c3lyamFsYSkKPj4+PiB8IHYzOiBDYWxsIHVu
cGluX3ZtYXAgZnJvbSB0aGUgcmlnaHQgZG1hYnVmIHVubWFwcGVyCj4+Pj4KPj4+PiB2NDogcmVp
bXBsZW1lbnRzIHRoZSBzYW1lIGZ1bmN0aW9uYWxpdHksIGJ1dCBub3cgYXMgd3JhcHBlcnMgcm91
bmQgdGhlCj4+Pj4gICAgICByZWNlbnRseS1pbnRyb2R1Y2VkIGk5MTVfZ2VtX29iamVjdF92bWFw
X3JhbmdlKCkgZnJvbSBBbGV4J3MgcGF0Y2gKPj4+PiAgICAgIG1lbnRpb25lZCBhYm92ZS4KPj4+
Pgo+Pj4+IHY1OiBzZXBhcmF0ZWQgZnJvbSB0d28gbWlub3IgYnV0IHVucmVsYXRlZCBjaGFuZ2Vz
IFtUdnJ0a28gVXJzdWxpbl07Cj4+Pj4gICAgICB0aGlzIGlzIHRoZSB0aGlyZCBhbmQgbW9zdCBz
dWJzdGFudGlhbCBwb3J0aW9uLgo+Pj4+Cj4+Pj4gICAgICBEZWNpZGVkIG5vdCB0byBob2xkIG9u
dG8gdm1hcHBpbmdzIGFmdGVyIHRoZSBwaW4gY291bnQgZ29lcyB0bwo+Pj4+IHplcm8uCj4+Pj4g
ICAgICBUaGlzIG1heSByZWR1Y2UgdGhlIGJlbmVmaXQgb2YgQ2hyaXMnIHNjaGVtZSBhIGJpdCwg
YnV0IGRvZXMgYXZvaWQKPj4+PiAgICAgIGFueSBpbmNyZWFzZWQgcmlzayBvZiBleGhhdXN0aW5n
IGtlcm5lbCB2bWFwIHNwYWNlIG9uIDMyLWJpdAo+Pj4+IGtlcm5lbHMKPj4+PiAgICAgIFtUdnJ0
a28gVXJzdWxpbl0uIFBvdGVudGlhbGx5LCB0aGUgdnVubWFwKCkgY291bGQgYmUgZGVmZXJyZWQK
Pj4+PiB1bnRpbAo+Pj4+ICAgICAgdGhlIHB1dF9wYWdlcygpIHN0YWdlIGlmIGEgc3VpdGFibGUg
bm90aWZpZXIgd2VyZSB3cml0dGVuLCBidXQKPj4+PiB3ZSdyZQo+Pj4+ICAgICAgbm90IGRvaW5n
IHRoYXQgaGVyZS4gTm9uZXRoZWxlc3MsIHRoZSBzaW1wbGlmaWNhdGlvbiBvZiBib3RoCj4+Pj4g
ZG1hYnVmCj4+Pj4gICAgICBhbmQgcmluZ2J1ZmZlciBjb2RlIG1ha2VzIGl0IHdvcnRod2hpbGUg
aW4gaXRzIG93biByaWdodC4KPj4+Pgo+Pj4+IHY2OiBjaGFuZ2UgQlVHX09OKCkgdG8gV0FSTl9P
TigpLiBbVHZydGtvIFVyc3VsaW5dCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRv
biA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+Pj4+IFJldmlld2VkLWJ5OiBUdnJ0a28gVXJz
dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4+IENjOiBDaHJpcyBXaWxzb24gPGNo
cmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+PiBDYzogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5j
b20+Cj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAg
ICAgfCAyMiArKysrKysrKysrKysrKy0tLS0tCj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2dlbS5jICAgICAgICAgfCAzOQo+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKwo+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZG1hYnVmLmMgIHwgMzYK
Pj4+PiArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiAgIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyB8ICA5ICsrKystLS0tCj4+Pj4gICA0IGZpbGVzIGNo
YW5nZWQsIDY1IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+PiBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+PiBpbmRleCBiM2FlMTkxLi5mMWFkM2IzIDEwMDY0NAo+
Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+PiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+Pj4gQEAgLTIxNzIsMTAgKzIxNzIsNyBAQCBz
dHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCB7Cj4+Pj4gICAgICAgICAgIHN0cnVjdCBzY2F0dGVy
bGlzdCAqc2c7Cj4+Pj4gICAgICAgICAgIGludCBsYXN0Owo+Pj4+ICAgICAgIH0gZ2V0X3BhZ2U7
Cj4+Pj4gLQo+Pj4+IC0gICAgLyogcHJpbWUgZG1hLWJ1ZiBzdXBwb3J0ICovCj4+Pj4gLSAgICB2
b2lkICpkbWFfYnVmX3ZtYXBwaW5nOwo+Pj4+IC0gICAgaW50IHZtYXBwaW5nX2NvdW50Owo+Pj4+
ICsgICAgdm9pZCAqdm1hcHBpbmc7Cj4+Pj4KPj4+PiAgICAgICAvKiogQnJlYWRjcnVtYiBvZiBs
YXN0IHJlbmRlcmluZyB0byB0aGUgYnVmZmVyLgo+Pj4+ICAgICAgICAqIFRoZXJlIGNhbiBvbmx5
IGJlIG9uZSB3cml0ZXIsIGJ1dCB3ZSBhbGxvdyBmb3IgbXVsdGlwbGUKPj4+PiByZWFkZXJzLgo+
Pj4+IEBAIC0yOTgwLDcgKzI5NzcsMjIgQEAgc3RhdGljIGlubGluZSB2b2lkCj4+Pj4gaTkxNV9n
ZW1fb2JqZWN0X3Bpbl9wYWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+Pj4+
ICAgc3RhdGljIGlubGluZSB2b2lkIGk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhzdHJ1Y3QK
Pj4+PiBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+Pj4gICB7Cj4+Pj4gICAgICAgQlVHX09O
KG9iai0+cGFnZXNfcGluX2NvdW50ID09IDApOwo+Pj4+IC0gICAgb2JqLT5wYWdlc19waW5fY291
bnQtLTsKPj4+PiArICAgIGlmICgtLW9iai0+cGFnZXNfcGluX2NvdW50ID09IDAgJiYgb2JqLT52
bWFwcGluZykgewo+Pj4+ICsgICAgICAgIC8qCj4+Pj4gKyAgICAgICAgICogUmVsZWFzaW5nIHRo
ZSB2bWFwcGluZyBoZXJlIG1heSB5aWVsZCBsZXNzIGJlbmVmaXQgdGhhbgo+Pj4+ICsgICAgICAg
ICAqIGlmIHdlIGtlcHQgaXQgdW50aWwgcHV0X3BhZ2VzKCksIGJ1dCBvbiB0aGUgb3RoZXIgaGFu
ZAo+Pj4KPj4+IFlpZWxkcyBubyBiZW5lZml0LiBNYWtlcyB0aGUgcGF0Y2ggcG9pbnRsZXNzLgo+
Pj4gUGx1cyB0aGVyZSBpcyBhbHNvIHByZXNzdXJlIHRvIGVuYWJsZSBXQyB2bWFwcy4KPj4+IC1D
aHJpcwo+Pgo+PiBUaGUgcGF0Y2ggaXMgbm90IHBvaW50bGVzcyAtLSBhdCB0aGUgdmVyeSBsZWFz
dCwgaXQ6Cj4+ICsgcmVkdWNlcyB0aGUgc2l6ZSBvZiAic3RydWN0IGRybV9pOTE1X2dlbV9vYmpl
Y3QiIChPSywgb25seSBieSA0IGJ5dGVzKQo+PiArIHJlcGxhY2VzIHNwZWNpYWwtZnVuY3Rpb24g
Y29kZSBmb3IgZG1hYnVmcyB3aXRoIG1vcmUgZ2VuZXJpYyBjb2RlIHRoYXQKPj4gY2FuIGJlIHJl
dXNlZCBmb3Igb3RoZXIgb2JqZWN0cyAoZm9yIG5vdywgcmluZ2J1ZmZlcnM7IG5leHQgR3VDLXNo
YXJlZAo+PiBvYmplY3RzIC0tIHNlZSBBbGV4J3MgcGF0Y2ggImRybS9pOTE1L2d1YzogU2ltcGxp
ZnkgY29kZSBieSBrZWVwaW5nIHZtYXAKPj4gb2YgZ3VjX2NsaWVudCBvYmplY3QiIHdoaWNoIHdp
bGwgZWxpbWluYXRlIGxvdCBvZiBzaG9ydC10ZXJtCj4+IGttYXBfYXRvbWljcyB3aXRoIHBlcnNp
c3RlbnQga21hcHMpLgo+PiArIHByb3ZpZGVzIGEgc2hvcnRoYW5kIGZvciB0aGUgc2VxdWVuY2Ug
b2YgeyBnZXRfcGFnZXMoKSwgcGluX3BhZ2VzKCksCj4+IHZtYXAoKSB9IHNvIHdlIGRvbid0IGhh
dmUgdG8gb3Blbi1jb2RlIGl0IChhbmQgZGVhbCB3aXRoIGFsbCB0aGUgZXJyb3IKPj4gcGF0aHMp
IGluIHNldmVyYWwgZGlmZmVyZW50IHBsYWNlcwo+Pgo+PiBUaHVzIHRoZXJlIGlzIGFuIGVuZ2lu
ZWVyaW5nIGJlbmVmaXQgZXZlbiBpZiB0aGlzIHZlcnNpb24gZG9lc24ndAo+PiBwcm92aWRlIGFu
eSBwZXJmb3JtYW5jZSBiZW5lZml0LiBBbmQgaWYsIGFzIHRoZSBuZXh0IHN0ZXAsIHlvdSB3YW50
IHRvCj4+IGV4dGVuZCB0aGUgdm1hcCBsaWZldGltZSwgeW91IGp1c3QgaGF2ZSB0byByZW1vdmUg
dGhvc2UgZmV3IGxpbmVzIGluCj4+IGk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcygpIGFuZCBp
bmNvcnBvcmF0ZSB0aGUgbm90aWZpZXIgdGhhdCB5b3UKPj4gcHJvdG90eXBlZCBlYXJsaWVyIC0t
IGlmIGl0IGFjdHVhbGx5IHByb3ZpZGVzIGFueSBwZXJmb3JtYW5jZSBib29zdC4KPgo+IFNvIENo
cmlzIGRvIHlvdSBhY2sgb24gdGhpcyBzZXJpZXMgb24gdGhlIGJhc2lzIG9mIHRoZSBhYm92ZSAt
IHRoYXQgaXQKPiBjb25zb2xpZGF0ZXMgdGhlIGN1cnJlbnQgY29kZSBhbmQgZm9sbG93aW5nIEd1
QyBwYXRjaCB3aWxsIGJlIGFub3RoZXIKPiB1c2VyIG9mIHRoZSBwaW5fdm1hcCBBUEk/Cj4KPiBS
ZWdhcmRzLAo+IFR2cnRrbwoKSSBzZWUgdGhhdCBDaHJpcyBoYXMgcG9zdGVkIGEgcGF0Y2ggdG8g
YWRkIGEgdm1hcCBub3RpZmllciwgYWx0aG91Z2ggaXQgCmhhc24ndCB5ZXQgZ290IGl0cyBSLUIu
IFNvIEkgc3VnZ2VzdCB3ZSBtZXJnZSB0aGlzIHBhdGNoIHNlcmllcyBub3csIGFuZCAKdGhlbiB1
cGRhdGUgaXQgYnkgbW92aW5nIHRoZSB2dW5tYXAoKSBpbnRvIHB1dF9wYWdlcygpIHdoZW4gQ2hy
aXMgaGFzIAp0aGUgbm90aWZpZXIgZmluYWxpc2VkLiBJSVJDIHlvdSB3YW50ZWQgRGFuaWVsIHRv
IG1lcmdlIHRoZSBuZXcgRFJNIGJpdHMgCihwYXRjaGVzIDMgYW5kIDcsIHdoaWNoIGFscmVhZHkg
aGF2ZSB0aGVpciBSLUJzKSA/CgpPciB3ZSBjYW4gbWVyZ2UgMS01KzcsIGFsbCBvZiB3aGljaCBh
bHJlYWR5IGhhdmUgUi1CcywgYW5kIEkgY2FuIHR1cm4KNiBpbnRvIGEgR3VDLXByaXZhdGUgdmVy
c2lvbiwgd2l0aG91dCB0aGUgYmVuZWZpdCBvZiBzaW1wbGlmeWluZyBhbmQgCnVuaWZ5aW5nIHRo
ZSBjb3JyZXNwb25kaW5nIG9iamVjdC1tYXBwaW5nIG1hbmFnZW1lbnQgaW4gdGhlIERNQWJ1ZiBh
bmQgCnJpbmdidWZmZXIgY29kZS4KCk9yIEkgY2FuIHJlcG9zdCBqdXN0IHRoZSBiaXRzIHRoYXQg
ZG9uJ3QgcmVseSBvbiBkcm1fbWFsbG9jX2dmcCgpIGFuZCAKZXhjbHVkZSB0aGUgZmluYWwgcGF0
Y2ggc28gdGhhdCB3ZSBjYW4gbW92ZSBhaGVhZCBvbiB0aGUgYml0cyB3ZSAKYWN0dWFsbHkgd2Fu
dCBmb3IgaW1wcm92aW5nIHRoZSBwZXJmb3JtYW5jZSBvZiB0aGUgR3VDIGludGVyZmFjZSBhbmQg
CnJlZHVjaW5nIHRoZSBudW1iZXIgb2Yga21hcF9hdG9taWMgY2FsbHMgZWxzZXdoZXJlLCBhbmQg
dGhlbiB0aGUgb21pdHRlZCAKYml0cyBjYW4gYmUgYWRkZWQgYmFjayBvbmNlIGRybV9tYWxsb2Nf
Z2ZwKCkgaGFzIGJlZW4gbWVyZ2VkIHVwc3RyZWFtIAphbmQgdGhlIG5vdGlmaWVyIGlzIHdvcmtp
bmcuCgouRGF2ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==