From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Siluvery Subject: Re: [PATCH 2/7] drm/i915/guc: always reset GuC before loading firmware Date: Tue, 22 Mar 2016 18:42:26 +0000 Message-ID: <56F19212.9000705@linux.intel.com> References: <1458555400-22859-1-git-send-email-david.s.gordon@intel.com> <1458555400-22859-3-git-send-email-david.s.gordon@intel.com> <56F14975.20508@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 357C36E0C7 for ; Tue, 22 Mar 2016 18:42:29 +0000 (UTC) In-Reply-To: <56F14975.20508@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjIvMDMvMjAxNiAxMzozMiwgQXJ1biBTaWx1dmVyeSB3cm90ZToKPiBPbiAyMS8wMy8yMDE2 IDEwOjE2LCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gQWZ0ZXIgYSBzdXNwZW5kLXJlc3VtZSBjeWNs ZSwgdGhlIHJlc3VtZWQga2VybmVsIGhhcyBubyBpZGVhIHdoYXQgdGhlCj4+IGJvb3RlZCBrZXJu ZWwgbWF5IGhhdmUgZG9uZSB0byB0aGUgR3VDIGJlZm9yZSByZXBsYWNpbmcgaXRzZWxmIHdpdGgg dGhlCj4+IHJlc3VtZWQgaW1hZ2UuIEluIHBhcnRpY3VsYXIsIGl0IG1heSBoYXZlIGFscmVhZHkg bG9hZGVkIHRoZSBHdUMgd2l0aAo+PiBmaXJtd2FyZSwgd2hpY2ggd2lsbCB0aGVuIGNhdXNlIHRo aXMga2VybmVsJ3MgYXR0ZW1wdCB0byAocmUpbG9hZCB0aGUKPj4gZmlybXdhcmUgdG8gZmFpbCAo R3VDIHByb2dyYW0gbWVtb3J5IGlzIHdyaXRlLW9uY2UhKS4KPj4KPj4gU28gaGVyZSB3ZSBjaG9v c2UgdG8gYWx3YXlzIHJlc2V0IHRoZSBHdUMganVzdCBiZWZvcmUgKHJlKWxvYWRpbmcgdGhlCj4+ IGZpcm13YXJlLCBzbyB0aGUgaGFyZHdhcmUgc2hvdWxkIHRoZW4gYmUgaW4gYSB3ZWxsLWtub3du IHN0YXRlLCBhbmQgd2UKPj4gbWF5IGV2ZW4gYXZvaWQgc29tZSBvZiB0aGUgaXNzdWVzIGFyaXNp bmcgZnJvbSB1bnByZWRpY3RhYmxlIHRpbWluZy4KPj4KPj4gQWxzbyBhZGRlZCBzb21lIG1vcmUg ZmllbGRzICYgdmFsdWVzIHRvIHRoZSBkZWZpbml0aW9uIG9mIHRoZSBHVUNfU1RBVFVTCj4+IHJl Z2lzdGVyLCB3aGljaCBpcyB0aGUga2V5IGRpYWdub3N0aWMgaW5kaWNhdG9yIGlmIHRoZSBHdUMg bG9hZCBmYWlscy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29y ZG9uQGludGVsLmNvbT4KPj4gQ2M6IEFydW4gU2lsdXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXgu aW50ZWwuY29tPgo+PiBDYzogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Cj4gUGxlYXNl IGFkZCBidWd6aWxsYSByZWZlcmVuY2UuCgpodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3No b3dfYnVnLmNnaT9pZD05NDM5MAoKcmVnYXJkcwpBcnVuCgo+Cj4+IC0tLQo+PiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oICAgICB8IDEyICsrKysrKysrLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCA0MAo+PiArKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMo KyksIDIzIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ndWNfcmVnLmgKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19yZWcu aAo+PiBpbmRleCA5NGNlZWU1Li44MDc4NmQ5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19yZWcuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2d1Y19yZWcuaAo+PiBAQCAtMjcsMTAgKzI3LDEyIEBACj4+ICAgLyogRGVmaW5pdGlvbnMgb2Yg R3VDIEgvVyByZWdpc3RlcnMsIGJpdHMsIGV0YyAqLwo+Pgo+PiAgICNkZWZpbmUgR1VDX1NUQVRV UyAgICAgICAgICAgIF9NTUlPKDB4YzAwMCkKPj4gLSNkZWZpbmUgICBHU19NSUFfSU5fUkVTRVQg ICAgICAgICgxIDw8IDApCj4+ICsjZGVmaW5lICAgR1NfUkVTRVRfU0hJRlQgICAgICAgIDAKPj4g KyNkZWZpbmUgICBHU19NSUFfSU5fUkVTRVQgICAgICAgICAgKDB4MDEgPDwgR1NfUkVTRVRfU0hJ RlQpCj4+ICAgI2RlZmluZSAgIEdTX0JPT1RST01fU0hJRlQgICAgICAgIDEKPj4gICAjZGVmaW5l ICAgR1NfQk9PVFJPTV9NQVNLICAgICAgICAgICgweDdGIDw8IEdTX0JPT1RST01fU0hJRlQpCj4+ ICAgI2RlZmluZSAgIEdTX0JPT1RST01fUlNBX0ZBSUxFRCAgICAgICAgICAoMHg1MCA8PCBHU19C T09UUk9NX1NISUZUKQo+PiArI2RlZmluZSAgIEdTX0JPT1RST01fSlVNUF9QQVNTRUQgICAgICAo MHg3NiA8PCBHU19CT09UUk9NX1NISUZUKQo+PiAgICNkZWZpbmUgICBHU19VS0VSTkVMX1NISUZU ICAgICAgICA4Cj4+ICAgI2RlZmluZSAgIEdTX1VLRVJORUxfTUFTSyAgICAgICAgICAoMHhGRiA8 PCBHU19VS0VSTkVMX1NISUZUKQo+PiAgICNkZWZpbmUgICBHU19VS0VSTkVMX0xBUElDX0RPTkUg ICAgICAgICAgKDB4MzAgPDwgR1NfVUtFUk5FTF9TSElGVCkKPj4gQEAgLTM4LDcgKzQwLDEzIEBA Cj4+ICAgI2RlZmluZSAgIEdTX1VLRVJORUxfUkVBRFkgICAgICAgICAgKDB4RjAgPDwgR1NfVUtF Uk5FTF9TSElGVCkKPj4gICAjZGVmaW5lICAgR1NfTUlBX1NISUZUICAgICAgICAgICAgMTYKPj4g ICAjZGVmaW5lICAgR1NfTUlBX01BU0sgICAgICAgICAgICAgICgweDA3IDw8IEdTX01JQV9TSElG VCkKPj4gLSNkZWZpbmUgICBHU19NSUFfQ09SRV9TVEFURSAgICAgICAgICAoMSA8PCBHU19NSUFf U0hJRlQpCj4+ICsjZGVmaW5lICAgR1NfTUlBX0NPUkVfU1RBVEUgICAgICAgICAgKDB4MDEgPDwg R1NfTUlBX1NISUZUKQo+PiArI2RlZmluZSAgIEdTX01JQV9IQUxUX1JFUVVFU1RFRCAgICAgICAg ICAoMHgwMiA8PCBHU19NSUFfU0hJRlQpCj4+ICsjZGVmaW5lICAgR1NfTUlBX0lTUl9FTlRSWSAg ICAgICAgICAoMHgwNCA8PCBHU19NSUFfU0hJRlQpCj4+ICsjZGVmaW5lICAgR1NfQVVUSF9TVEFU VVNfU0hJRlQgICAgICAgIDMwCj4+ICsjZGVmaW5lICAgR1NfQVVUSF9TVEFUVVNfTUFTSyAgICAg ICAgICAoMHgwMyA8PCBHU19BVVRIX1NUQVRVU19TSElGVCkKPj4gKyNkZWZpbmUgICBHU19BVVRI X1NUQVRVU19CQUQgICAgICAgICAgKDB4MDEgPDwgR1NfQVVUSF9TVEFUVVNfU0hJRlQpCj4+ICsj ZGVmaW5lICAgR1NfQVVUSF9TVEFUVVNfR09PRCAgICAgICAgICAoMHgwMiA8PCBHU19BVVRIX1NU QVRVU19TSElGVCkKPj4KPj4gICAjZGVmaW5lIFNPRlRfU0NSQVRDSChuKSAgICAgICAgICAgIF9N TUlPKDB4YzE4MCArIChuKSAqIDQpCj4+ICAgI2RlZmluZSBTT0ZUX1NDUkFUQ0hfQ09VTlQgICAg ICAgIDE2Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9h ZGVyLmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4gaW5k ZXggYTA3YzIyOC4uYTg3NTkzNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX2xvYWRlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2FkZXIuYwo+PiBAQCAtMzg3LDcgKzM4Nyw3IEBAIGludCBpbnRlbF9ndWNfdWNvZGVfbG9h ZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgIHsKPj4gICAgICAgc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gICAgICAgc3RydWN0IGlu dGVsX2d1Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMuZ3VjX2Z3Owo+PiAtICAgIGludCBl cnIgPSAwOwo+PiArICAgIGludCByZXRyaWVzLCBlcnIgPSAwOwo+Pgo+PiAgICAgICBpZiAoIWk5 MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKQo+PiAgICAgICAgICAgcmV0dXJuIDA7Cj4+IEBAIC00 NDEsMjkgKzQ0MSwyNiBAQCBpbnQgaW50ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPj4gICAgICAgICogc3RlcHBpbmdzIGFsc28gc28gdGhpcyBpcyBleHRlbmRlZCBh cyB3ZWxsLgo+PiAgICAgICAgKi8KPj4gICAgICAgLyogV2FFbmFibGVHdUNCb290SGFzaENoZWNr Tm90U2V0OnNrbCxieHQgKi8KPj4gLSAgICBlcnIgPSBndWNfdWNvZGVfeGZlcihkZXZfcHJpdik7 Cj4+IC0gICAgaWYgKGVycikgewo+PiAtICAgICAgICBpbnQgcmV0cmllcyA9IDM7Cj4+IC0KPj4g LSAgICAgICAgRFJNX0VSUk9SKCJHdUMgZncgbG9hZCBmYWlsZWQsIGVycj0lZCwgYXR0ZW1wdGlu ZyByZXNldCBhbmQKPj4gcmV0cnlcbiIsIGVycik7Cj4+IC0KPj4gLSAgICAgICAgd2hpbGUgKHJl dHJpZXMtLSkgewo+PiAtICAgICAgICAgICAgZXJyID0gaTkxNV9yZXNldF9ndWMoZGV2X3ByaXYp Owo+PiAtICAgICAgICAgICAgaWYgKGVycikKPj4gLSAgICAgICAgICAgICAgICBicmVhazsKPj4g LQo+PiAtICAgICAgICAgICAgZXJyID0gZ3VjX3Vjb2RlX3hmZXIoZGV2X3ByaXYpOwo+PiAtICAg ICAgICAgICAgaWYgKCFlcnIpIHsKPj4gLSAgICAgICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVS KCJHdUMgZncgcmVsb2FkIHN1Y2NlZWRlZCBhZnRlcgo+PiByZXNldFxuIik7Cj4+IC0gICAgICAg ICAgICAgICAgYnJlYWs7Cj4+IC0gICAgICAgICAgICB9Cj4+IC0gICAgICAgICAgICBEUk1fREVC VUdfRFJJVkVSKCJHdUMgZncgcmVsb2FkIHJldHJpZXMgbGVmdDogJWRcbiIsCj4+IHJldHJpZXMp Owo+PiAtICAgICAgICB9Cj4+IC0KPj4gKyAgICBmb3IgKHJldHJpZXMgPSAzOyA7ICkgewo+PiAr ICAgICAgICAvKgo+PiArICAgICAgICAgKiBBbHdheXMgcmVzZXQgdGhlIEd1QyBqdXN0IGJlZm9y ZSAocmUpbG9hZGluZywgc28KPj4gKyAgICAgICAgICogdGhhdCB0aGUgc3RhdGUgYW5kIHRpbWlu ZyBhcmUgZmFpcmx5IHByZWRpY3RhYmxlCj4+ICsgICAgICAgICAqLwo+PiArICAgICAgICBlcnIg PSBpOTE1X3Jlc2V0X2d1YyhkZXZfcHJpdik7Cj4+ICAgICAgICAgICBpZiAoZXJyKSB7Cj4+IC0g ICAgICAgICAgICBEUk1fRVJST1IoIkd1QyBmdyByZWxvYWQgYXR0ZW1wdCBmYWlsZWQsIHJldD0l ZFxuIiwgZXJyKTsKPj4gKyAgICAgICAgICAgIERSTV9FUlJPUigiR3VDIHJlc2V0IGZhaWxlZCwg ZXJyICVkXG4iLCBlcnIpOwo+PiAgICAgICAgICAgICAgIGdvdG8gZmFpbDsKPj4gICAgICAgICAg IH0KPj4gKwo+PiArICAgICAgICBlcnIgPSBndWNfdWNvZGVfeGZlcihkZXZfcHJpdik7Cj4+ICsg ICAgICAgIGlmICghZXJyKQo+PiArICAgICAgICAgICAgYnJlYWs7Cj4+ICsKPj4gKyAgICAgICAg aWYgKC0tcmV0cmllcyA9PSAwKQo+PiArICAgICAgICAgICAgZ290byBmYWlsOwo+PiArCj4+ICsg ICAgICAgIERSTV9JTkZPKCJHdUMgZncgbG9hZCBmYWlsZWQsIGVyciAlZDsgd2lsbCByZXNldCBh bmQgIgo+PiArICAgICAgICAgICAgInJldHJ5ICVkIG1vcmUgdGltZShzKVxuIiwgZXJyLCByZXRy aWVzKTsKPj4gICAgICAgfQo+Pgo+PiAgICAgICBndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cyA9 IEdVQ19GSVJNV0FSRV9TVUNDRVNTOwo+PiBAQCAtNDg1LDYgKzQ4Miw3IEBAIGludCBpbnRlbF9n dWNfdWNvZGVfbG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgICAgICByZXR1cm4gMDsK Pj4KPj4gICBmYWlsOgo+PiArICAgIERSTV9FUlJPUigiR3VDIGZpcm13YXJlIGxvYWQgZmFpbGVk LCBlcnIgJWRcbiIsIGVycik7Cj4+ICAgICAgIGlmIChndWNfZnctPmd1Y19md19sb2FkX3N0YXR1 cyA9PSBHVUNfRklSTVdBUkVfUEVORElORykKPj4gICAgICAgICAgIGd1Y19mdy0+Z3VjX2Z3X2xv YWRfc3RhdHVzID0gR1VDX0ZJUk1XQVJFX0ZBSUw7Cj4+Cj4+Cj4gbG9va3MgZ29vZCB0byBtZSwK PiBSZXZpZXdlZC1ieTogQXJ1biBTaWx1dmVyeSA8YXJ1bi5zaWx1dmVyeUBsaW51eC5pbnRlbC5j b20+Cj4KPiByZWdhcmRzCj4gQXJ1bgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK