From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v7 6/7] drm/i915: refactor duplicate object vmap functions (the final rework?) Date: Wed, 23 Mar 2016 12:23:44 +0000 Message-ID: <56F28AD0.4010807@linux.intel.com> References: <1456850039-25856-1-git-send-email-david.s.gordon@intel.com> <1456850039-25856-7-git-send-email-david.s.gordon@intel.com> <20160302120810.GB25660@nuc-i3427.alporthouse.com> <56D70961.6080806@intel.com> <56DE9EC4.2000007@linux.intel.com> <56F16407.9010803@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id B85246E3CA for ; Wed, 23 Mar 2016 12:23:46 +0000 (UTC) In-Reply-To: <56F16407.9010803@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , Chris Wilson , Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAzLzE2IDE1OjI1LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAwOC8wMy8xNiAwOTo0 MywgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uIDAyLzAzLzE2IDE1OjQwLCBEYXZlIEdv cmRvbiB3cm90ZToKPj4+IE9uIDAyLzAzLzE2IDEyOjA4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+ Pj4gT24gVHVlLCBNYXIgMDEsIDIwMTYgYXQgMDQ6MzM6NThQTSArMDAwMCwgRGF2ZSBHb3Jkb24g d3JvdGU6Cj4+Pj4+IFRoaXMgaXMgZXNzZW50aWFsbHkgQ2hyaXMgV2lsc29uJ3MgcGF0Y2ggb2Yg YSBzaW1pbGFyIG5hbWUsCj4+Pj4+IHJld29ya2VkIG9uCj4+Pj4+IHRvcCBvZiBBbGV4IERhaSdz IHJlY2VudCBwYXRjaDoKPj4+Pj4gfCBkcm0vaTkxNTogQWRkIGk5MTVfZ2VtX29iamVjdF92bWFw IHRvIG1hcCBHRU0gb2JqZWN0IHRvIHZpcnR1YWwKPj4+Pj4gc3BhY2UKPj4+Pj4KPj4+Pj4gQ2hy aXMnIG9yaWdpbmFsIGNvbW1lbnRhcnkgc2FpZDoKPj4+Pj4gfCBXZSBub3cgaGF2ZSB0d28gaW1w bGVtZW50YXRpb25zIGZvciB2bWFwcGluZyBhIHdob2xlIG9iamVjdCwgb25lIGZvcgo+Pj4+PiB8 IGRtYS1idWYgYW5kIG9uZSBmb3IgdGhlIHJpbmdidWZmZXIuIElmIHdlIGNvdXBsZSB0aGUgdm1h cHBpbmcgaW50bwo+Pj4+PiB8IHRoZSBvYmotPnBhZ2VzIGxpZmV0aW1lLCB0aGVuIHdlIGNhbiBy ZXVzZSBhbiBvYmotPnZtYXBwaW5nIGZvciBib3RoCj4+Pj4+IHwgYW5kIGF0IHRoZSBzYW1lIHRp bWUgY291cGxlIGl0IGludG8gdGhlIHNocmlua2VyLgo+Pj4+PiB8Cj4+Pj4+IHwgdjI6IE1hcmsg dGhlIGZhaWxhYmxlIGttYWxsb2MoKSBhcyBfX0dGUF9OT1dBUk4gKHZzeXJqYWxhKQo+Pj4+PiB8 IHYzOiBDYWxsIHVucGluX3ZtYXAgZnJvbSB0aGUgcmlnaHQgZG1hYnVmIHVubWFwcGVyCj4+Pj4+ Cj4+Pj4+IHY0OiByZWltcGxlbWVudHMgdGhlIHNhbWUgZnVuY3Rpb25hbGl0eSwgYnV0IG5vdyBh cyB3cmFwcGVycyByb3VuZCB0aGUKPj4+Pj4gICAgICByZWNlbnRseS1pbnRyb2R1Y2VkIGk5MTVf Z2VtX29iamVjdF92bWFwX3JhbmdlKCkgZnJvbSBBbGV4J3MKPj4+Pj4gcGF0Y2gKPj4+Pj4gICAg ICBtZW50aW9uZWQgYWJvdmUuCj4+Pj4+Cj4+Pj4+IHY1OiBzZXBhcmF0ZWQgZnJvbSB0d28gbWlu b3IgYnV0IHVucmVsYXRlZCBjaGFuZ2VzIFtUdnJ0a28gVXJzdWxpbl07Cj4+Pj4+ICAgICAgdGhp cyBpcyB0aGUgdGhpcmQgYW5kIG1vc3Qgc3Vic3RhbnRpYWwgcG9ydGlvbi4KPj4+Pj4KPj4+Pj4g ICAgICBEZWNpZGVkIG5vdCB0byBob2xkIG9udG8gdm1hcHBpbmdzIGFmdGVyIHRoZSBwaW4gY291 bnQgZ29lcyB0bwo+Pj4+PiB6ZXJvLgo+Pj4+PiAgICAgIFRoaXMgbWF5IHJlZHVjZSB0aGUgYmVu ZWZpdCBvZiBDaHJpcycgc2NoZW1lIGEgYml0LCBidXQgZG9lcwo+Pj4+PiBhdm9pZAo+Pj4+PiAg ICAgIGFueSBpbmNyZWFzZWQgcmlzayBvZiBleGhhdXN0aW5nIGtlcm5lbCB2bWFwIHNwYWNlIG9u IDMyLWJpdAo+Pj4+PiBrZXJuZWxzCj4+Pj4+ICAgICAgW1R2cnRrbyBVcnN1bGluXS4gUG90ZW50 aWFsbHksIHRoZSB2dW5tYXAoKSBjb3VsZCBiZSBkZWZlcnJlZAo+Pj4+PiB1bnRpbAo+Pj4+PiAg ICAgIHRoZSBwdXRfcGFnZXMoKSBzdGFnZSBpZiBhIHN1aXRhYmxlIG5vdGlmaWVyIHdlcmUgd3Jp dHRlbiwgYnV0Cj4+Pj4+IHdlJ3JlCj4+Pj4+ICAgICAgbm90IGRvaW5nIHRoYXQgaGVyZS4gTm9u ZXRoZWxlc3MsIHRoZSBzaW1wbGlmaWNhdGlvbiBvZiBib3RoCj4+Pj4+IGRtYWJ1Zgo+Pj4+PiAg ICAgIGFuZCByaW5nYnVmZmVyIGNvZGUgbWFrZXMgaXQgd29ydGh3aGlsZSBpbiBpdHMgb3duIHJp Z2h0Lgo+Pj4+Pgo+Pj4+PiB2NjogY2hhbmdlIEJVR19PTigpIHRvIFdBUk5fT04oKS4gW1R2cnRr byBVcnN1bGluXQo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQu cy5nb3Jkb25AaW50ZWwuY29tPgo+Pj4+PiBSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2 cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+Pj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+Pj4+PiBDYzogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+ Pj4+IC0tLQo+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICB8 IDIyICsrKysrKysrKysrKysrLS0tLS0KPj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jICAgICAgICAgfCAzOQo+Pj4+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9kbWFidWYuYyAgfCAzNgo+ Pj4+PiArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+Pj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAgOSArKysrLS0tLQo+Pj4+PiAgIDQgZmlsZXMg Y2hhbmdlZCwgNjUgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCj4+Pj4+Cj4+Pj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+Pj4+IGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4+PiBpbmRleCBiM2FlMTkxLi5mMWFkM2IzIDEw MDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+Pj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+Pj4gQEAgLTIxNzIsMTAgKzIx NzIsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCB7Cj4+Pj4+ICAgICAgICAgICBzdHJ1 Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+Pj4+PiAgICAgICAgICAgaW50IGxhc3Q7Cj4+Pj4+ICAgICAg IH0gZ2V0X3BhZ2U7Cj4+Pj4+IC0KPj4+Pj4gLSAgICAvKiBwcmltZSBkbWEtYnVmIHN1cHBvcnQg Ki8KPj4+Pj4gLSAgICB2b2lkICpkbWFfYnVmX3ZtYXBwaW5nOwo+Pj4+PiAtICAgIGludCB2bWFw cGluZ19jb3VudDsKPj4+Pj4gKyAgICB2b2lkICp2bWFwcGluZzsKPj4+Pj4KPj4+Pj4gICAgICAg LyoqIEJyZWFkY3J1bWIgb2YgbGFzdCByZW5kZXJpbmcgdG8gdGhlIGJ1ZmZlci4KPj4+Pj4gICAg ICAgICogVGhlcmUgY2FuIG9ubHkgYmUgb25lIHdyaXRlciwgYnV0IHdlIGFsbG93IGZvciBtdWx0 aXBsZQo+Pj4+PiByZWFkZXJzLgo+Pj4+PiBAQCAtMjk4MCw3ICsyOTc3LDIyIEBAIHN0YXRpYyBp bmxpbmUgdm9pZAo+Pj4+PiBpOTE1X2dlbV9vYmplY3RfcGluX3BhZ2VzKHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmopCj4+Pj4+ICAgc3RhdGljIGlubGluZSB2b2lkIGk5MTVfZ2VtX29i amVjdF91bnBpbl9wYWdlcyhzdHJ1Y3QKPj4+Pj4gZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ Pj4+PiAgIHsKPj4+Pj4gICAgICAgQlVHX09OKG9iai0+cGFnZXNfcGluX2NvdW50ID09IDApOwo+ Pj4+PiAtICAgIG9iai0+cGFnZXNfcGluX2NvdW50LS07Cj4+Pj4+ICsgICAgaWYgKC0tb2JqLT5w YWdlc19waW5fY291bnQgPT0gMCAmJiBvYmotPnZtYXBwaW5nKSB7Cj4+Pj4+ICsgICAgICAgIC8q Cj4+Pj4+ICsgICAgICAgICAqIFJlbGVhc2luZyB0aGUgdm1hcHBpbmcgaGVyZSBtYXkgeWllbGQg bGVzcyBiZW5lZml0IHRoYW4KPj4+Pj4gKyAgICAgICAgICogaWYgd2Uga2VwdCBpdCB1bnRpbCBw dXRfcGFnZXMoKSwgYnV0IG9uIHRoZSBvdGhlciBoYW5kCj4+Pj4KPj4+PiBZaWVsZHMgbm8gYmVu ZWZpdC4gTWFrZXMgdGhlIHBhdGNoIHBvaW50bGVzcy4KPj4+PiBQbHVzIHRoZXJlIGlzIGFsc28g cHJlc3N1cmUgdG8gZW5hYmxlIFdDIHZtYXBzLgo+Pj4+IC1DaHJpcwo+Pj4KPj4+IFRoZSBwYXRj aCBpcyBub3QgcG9pbnRsZXNzIC0tIGF0IHRoZSB2ZXJ5IGxlYXN0LCBpdDoKPj4+ICsgcmVkdWNl cyB0aGUgc2l6ZSBvZiAic3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QiIChPSywgb25seSBieSA0 IGJ5dGVzKQo+Pj4gKyByZXBsYWNlcyBzcGVjaWFsLWZ1bmN0aW9uIGNvZGUgZm9yIGRtYWJ1ZnMg d2l0aCBtb3JlIGdlbmVyaWMgY29kZSB0aGF0Cj4+PiBjYW4gYmUgcmV1c2VkIGZvciBvdGhlciBv YmplY3RzIChmb3Igbm93LCByaW5nYnVmZmVyczsgbmV4dCBHdUMtc2hhcmVkCj4+PiBvYmplY3Rz IC0tIHNlZSBBbGV4J3MgcGF0Y2ggImRybS9pOTE1L2d1YzogU2ltcGxpZnkgY29kZSBieSBrZWVw aW5nIHZtYXAKPj4+IG9mIGd1Y19jbGllbnQgb2JqZWN0IiB3aGljaCB3aWxsIGVsaW1pbmF0ZSBs b3Qgb2Ygc2hvcnQtdGVybQo+Pj4ga21hcF9hdG9taWNzIHdpdGggcGVyc2lzdGVudCBrbWFwcyku Cj4+PiArIHByb3ZpZGVzIGEgc2hvcnRoYW5kIGZvciB0aGUgc2VxdWVuY2Ugb2YgeyBnZXRfcGFn ZXMoKSwgcGluX3BhZ2VzKCksCj4+PiB2bWFwKCkgfSBzbyB3ZSBkb24ndCBoYXZlIHRvIG9wZW4t Y29kZSBpdCAoYW5kIGRlYWwgd2l0aCBhbGwgdGhlIGVycm9yCj4+PiBwYXRocykgaW4gc2V2ZXJh bCBkaWZmZXJlbnQgcGxhY2VzCj4+Pgo+Pj4gVGh1cyB0aGVyZSBpcyBhbiBlbmdpbmVlcmluZyBi ZW5lZml0IGV2ZW4gaWYgdGhpcyB2ZXJzaW9uIGRvZXNuJ3QKPj4+IHByb3ZpZGUgYW55IHBlcmZv cm1hbmNlIGJlbmVmaXQuIEFuZCBpZiwgYXMgdGhlIG5leHQgc3RlcCwgeW91IHdhbnQgdG8KPj4+ IGV4dGVuZCB0aGUgdm1hcCBsaWZldGltZSwgeW91IGp1c3QgaGF2ZSB0byByZW1vdmUgdGhvc2Ug ZmV3IGxpbmVzIGluCj4+PiBpOTE1X2dlbV9vYmplY3RfdW5waW5fcGFnZXMoKSBhbmQgaW5jb3Jw b3JhdGUgdGhlIG5vdGlmaWVyIHRoYXQgeW91Cj4+PiBwcm90b3R5cGVkIGVhcmxpZXIgLS0gaWYg aXQgYWN0dWFsbHkgcHJvdmlkZXMgYW55IHBlcmZvcm1hbmNlIGJvb3N0Lgo+Pgo+PiBTbyBDaHJp cyBkbyB5b3UgYWNrIG9uIHRoaXMgc2VyaWVzIG9uIHRoZSBiYXNpcyBvZiB0aGUgYWJvdmUgLSB0 aGF0IGl0Cj4+IGNvbnNvbGlkYXRlcyB0aGUgY3VycmVudCBjb2RlIGFuZCBmb2xsb3dpbmcgR3VD IHBhdGNoIHdpbGwgYmUgYW5vdGhlcgo+PiB1c2VyIG9mIHRoZSBwaW5fdm1hcCBBUEk/Cj4+Cj4+ IFJlZ2FyZHMsCj4+IFR2cnRrbwo+Cj4gSSBzZWUgdGhhdCBDaHJpcyBoYXMgcG9zdGVkIGEgcGF0 Y2ggdG8gYWRkIGEgdm1hcCBub3RpZmllciwgYWx0aG91Z2ggaXQKPiBoYXNuJ3QgeWV0IGdvdCBp dHMgUi1CLiBTbyBJIHN1Z2dlc3Qgd2UgbWVyZ2UgdGhpcyBwYXRjaCBzZXJpZXMgbm93LCBhbmQK PiB0aGVuIHVwZGF0ZSBpdCBieSBtb3ZpbmcgdGhlIHZ1bm1hcCgpIGludG8gcHV0X3BhZ2VzKCkg d2hlbiBDaHJpcyBoYXMKPiB0aGUgbm90aWZpZXIgZmluYWxpc2VkLiBJSVJDIHlvdSB3YW50ZWQg RGFuaWVsIHRvIG1lcmdlIHRoZSBuZXcgRFJNIGJpdHMKPiAocGF0Y2hlcyAzIGFuZCA3LCB3aGlj aCBhbHJlYWR5IGhhdmUgdGhlaXIgUi1CcykgPwo+Cj4gT3Igd2UgY2FuIG1lcmdlIDEtNSs3LCBh bGwgb2Ygd2hpY2ggYWxyZWFkeSBoYXZlIFItQnMsIGFuZCBJIGNhbiB0dXJuCj4gNiBpbnRvIGEg R3VDLXByaXZhdGUgdmVyc2lvbiwgd2l0aG91dCB0aGUgYmVuZWZpdCBvZiBzaW1wbGlmeWluZyBh bmQKPiB1bmlmeWluZyB0aGUgY29ycmVzcG9uZGluZyBvYmplY3QtbWFwcGluZyBtYW5hZ2VtZW50 IGluIHRoZSBETUFidWYgYW5kCj4gcmluZ2J1ZmZlciBjb2RlLgo+Cj4gT3IgSSBjYW4gcmVwb3N0 IGp1c3QgdGhlIGJpdHMgdGhhdCBkb24ndCByZWx5IG9uIGRybV9tYWxsb2NfZ2ZwKCkgYW5kCj4g ZXhjbHVkZSB0aGUgZmluYWwgcGF0Y2ggc28gdGhhdCB3ZSBjYW4gbW92ZSBhaGVhZCBvbiB0aGUg Yml0cyB3ZQo+IGFjdHVhbGx5IHdhbnQgZm9yIGltcHJvdmluZyB0aGUgcGVyZm9ybWFuY2Ugb2Yg dGhlIEd1QyBpbnRlcmZhY2UgYW5kCj4gcmVkdWNpbmcgdGhlIG51bWJlciBvZiBrbWFwX2F0b21p YyBjYWxscyBlbHNld2hlcmUsIGFuZCB0aGVuIHRoZSBvbWl0dGVkCj4gYml0cyBjYW4gYmUgYWRk ZWQgYmFjayBvbmNlIGRybV9tYWxsb2NfZ2ZwKCkgaGFzIGJlZW4gbWVyZ2VkIHVwc3RyZWFtCj4g YW5kIHRoZSBub3RpZmllciBpcyB3b3JraW5nLgoKSSd2ZSBjaGF0dGVkIHdpdGggQ2hyaXMgYW5k IERhbmllbCBvbiBJUkMgYW5kIGhlcmUgaXMgdGhlIHN1bW1hcnkgYW5kIAp3YXkgZm9yd2FyZCBJ IHRoaW5rLgoKMS4gRHJvcCA2LzcsIGFuZCBwcm9iYWJseSA3LzcgdW5sZXNzIHlvdSBjYW4gZ2V0 IGV0bmF2aXYgcGVvcGxlIHRvIHItYi9hY2suCgoyLiBBZGQgdGhlIHBhdGNoIHdoaWNoIGZpeGVz IHRoZSBhY3R1YWwgc2NoZWR1bGluZyB3aGlsZSBhdG9taWMgaW4gR3VDCnRvIHRoZSBlbmQgb2Yg dGhlIHNlcmllcyB3aXRoIGEgQnVnemlsYSAmIFRlc3RjYXNlIHRhZyBpbiB0aGF0IHBhdGNoLgoK KFRoaXMgc3RlcCBzaG91bGQgYWxsb3cgQ2hyaXMgdG8gcHJvdmlkZSBhbiBBY2tlZC1ieS4pCgoz LiBDYyBkcmktZGV2ZWwgb24gYWxsIHBhdGNoZXMgb2YgdGhlIHNlcmllcyBzaW5jZSBzb21lIHRv dWNoIERSTSBjb3JlLiAKKFRoaXMgaXMgc3RhbmRhcmQgcmVjb21tZW5kZWQgcHJhY3RpY2UpLgoK NC4gUmViYXNlICYgcmVzZW5kIGFzIG5ldyBzZXJpZXMuCgo1LiBSZXZpZXcgdGhlIG5ldyBwYXRj aCBpbiB0aGUgc2VyaWVzLgoKNi4gRXhwbGFpbiBDSSByZXN1bHRzLgoKNy4gTWVyZ2UuIDopCgpS ZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=