From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 4/6] drm/i915: Allow mmio updates on all platforms. Date: Thu, 24 Mar 2016 09:35:04 +0100 Message-ID: <56F3A6B8.2010807@linux.intel.com> References: <1458739472-6582-1-git-send-email-maarten.lankhorst@linux.intel.com> <1458739472-6582-5-git-send-email-maarten.lankhorst@linux.intel.com> <20160323150730.GV4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id A27A16E55D for ; Thu, 24 Mar 2016 08:35:07 +0000 (UTC) In-Reply-To: <20160323150730.GV4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjMtMDMtMTYgb20gMTY6MDcgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBN YXIgMjMsIDIwMTYgYXQgMDI6MjQ6MzBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFJlbmFtZSBpbnRlbF91bnBpbl93b3JrIHRvIGludGVsX2ZsaXBfd29yayBhbmQgdXNlIGl0 IGZvciBtbWlvIGZsaXBzCj4+IGFuZCB1bnBpbm5pbmcuIFVzZSBmbGlwX3F1ZXVlZF9yZXEgdG8g aG9sZCB0aGUgd2FpdCByZXF1ZXN0IGluIHRoZQo+PiBtbWlvIGNhc2UgYW5kIGFsbG93IHRoZSB2 YmxhbmsgaW50ZXJydXB0IHRvIGNvbXBsZXRlIG1taW8gd29yayB0bwo+PiBoYXZlIG1taW8gZmxp cHMgcnVuIGNvcnJlY3RseSBvbiBnNCBhbmQgZWFybGllci4KPiBCZWZvcmUgeW91IGFjdHVhbGx5 IGdvIGFuZCB0cnVzdCBkcm1fdmJsYW5rX2NvdW50KCkgeW91IHNob3VsZCBtYWtlIGl0Cj4gcmFj ZSBmcmVlLgoKSG93IGFib3V0IGFkZGluZyB0aGUgYmVsb3cgdG8gdGhlIHBhdGNoPwoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwppbmRleCBiZWZhYzY0OWFhOTYuLjA1ZWM4MzJlMDJk ZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCisrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwpAQCAtMTEyMjQsMTIgKzExMjI0 LDExIEBAIHN0YXRpYyB2b2lkIGludGVsX21taW9fZmxpcF93b3JrX2Z1bmMoc3RydWN0IHdvcmtf c3RydWN0ICp3KQogCQkJCQkJCSAgICBmYWxzZSwgZmFsc2UsCiAJCQkJCQkJICAgIE1BWF9TQ0hF RFVMRV9USU1FT1VUKSA8IDApOwogCi0JaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoY3J0Yyk7CisJ aW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoY3J0Yywgd29yayk7CiAJcHJpbWFyeS0+dXBkYXRlX3Bs YW5lKCZwcmltYXJ5LT5iYXNlLAogCQkJICAgICAgY3J0Yy0+Y29uZmlnLAogCQkJICAgICAgdG9f aW50ZWxfcGxhbmVfc3RhdGUocHJpbWFyeS0+YmFzZS5zdGF0ZSkpOwotCWF0b21pY19zZXQoJndv cmstPnBlbmRpbmcsIElOVEVMX0ZMSVBfUEVORElORyk7Ci0JaW50ZWxfcGlwZV91cGRhdGVfZW5k KGNydGMpOworCWludGVsX3BpcGVfdXBkYXRlX2VuZChjcnRjLCB3b3JrKTsKIH0KIAogc3RhdGlj IGludCBpbnRlbF9kZWZhdWx0X3F1ZXVlX2ZsaXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKQEAg LTEzODAwLDcgKzEzNzk5LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQo c3RydWN0IGRybV9jcnRjICpjcnRjLAogCWJvb2wgbW9kZXNldCA9IG5lZWRzX21vZGVzZXQoY3J0 Yy0+c3RhdGUpOwogCiAJLyogUGVyZm9ybSB2YmxhbmsgZXZhc2lvbiBhcm91bmQgY29tbWl0IG9w ZXJhdGlvbiAqLwotCWludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGludGVsX2NydGMpOworCWludGVs X3BpcGVfdXBkYXRlX3N0YXJ0KGludGVsX2NydGMsIE5VTEwpOwogCiAJaWYgKG1vZGVzZXQpCiAJ CXJldHVybjsKQEAgLTEzODE2LDcgKzEzODE1LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZmluaXNo X2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKIHsKIAlzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7CiAKLQlpbnRlbF9waXBlX3VwZGF0 ZV9lbmQoaW50ZWxfY3J0Yyk7CisJaW50ZWxfcGlwZV91cGRhdGVfZW5kKGludGVsX2NydGMsIE5V TEwpOwogfQogCiAvKioKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKaW5kZXggY2FjMzY4MTM4NzY0 Li44NmQ0ODZjZmQ3NzggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCkBAIC0xNjA0LDggKzE2 MDQsOCBAQCBib29sIGludGVsX3Nkdm9faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAogaW50 IGludGVsX3BsYW5lX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBpcGUs IGludCBwbGFuZSk7CiBpbnQgaW50ZWxfc3ByaXRlX3NldF9jb2xvcmtleShzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCB2b2lkICpkYXRhLAogCQkJICAgICAgc3RydWN0IGRybV9maWxlICpmaWxlX3By aXYpOwotdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 Yyk7Ci12b2lkIGludGVsX3BpcGVfdXBkYXRlX2VuZChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7 Cit2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBz dHJ1Y3QgaW50ZWxfZmxpcF93b3JrICp3b3JrKTsKK3ZvaWQgaW50ZWxfcGlwZV91cGRhdGVfZW5k KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBzdHJ1Y3QgaW50ZWxfZmxpcF93b3JrICp3b3JrKTsK IAogLyogaW50ZWxfdHYuYyAqLwogdm9pZCBpbnRlbF90dl9pbml0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwppbmRleCA4ODIxNTMzNTYxYjEu LjhkYTU5YTFlY2E1NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By aXRlLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKQEAgLTc4LDcg Kzc4LDggQEAgc3RhdGljIGludCB1c2Vjc190b19zY2FubGluZXMoY29uc3Qgc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUsCiAgKiBhdm9pZCByYW5kb20gZGVsYXlzLiBUaGUg dmFsdWUgd3JpdHRlbiB0byBAc3RhcnRfdmJsX2NvdW50IHNob3VsZCBiZQogICogc3VwcGxpZWQg dG8gaW50ZWxfcGlwZV91cGRhdGVfZW5kKCkgZm9yIGVycm9yIGNoZWNraW5nLgogICovCi12b2lk IGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQordm9pZCBp bnRlbF9waXBlX3VwZGF0ZV9zdGFydChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKKwkJCSAgICAg c3RydWN0IGludGVsX2ZsaXBfd29yayAqd29yaykKIHsKIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+YmFzZS5kZXY7CiAJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVz dGVkX21vZGUgPSAmY3J0Yy0+Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7CkBAIC0xNDIsNiAr MTQzLDkgQEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YykKIAljcnRjLT5kZWJ1Zy5zdGFydF92YmxfY291bnQgPQogCQlkZXYtPmRyaXZlci0+Z2V0 X3ZibGFua19jb3VudGVyKGRldiwgcGlwZSk7CiAKKwlpZiAod29yaykKKwkJd29yay0+ZmxpcF9x dWV1ZWRfdmJsYW5rID0gY3J0Yy0+ZGVidWcuc3RhcnRfdmJsX2NvdW50OworCiAJdHJhY2VfaTkx NV9waXBlX3VwZGF0ZV92YmxhbmtfZXZhZGVkKGNydGMpOwogfQogCkBAIC0xNTQsNyArMTU4LDcg QEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykK ICAqIHJlLWVuYWJsZXMgaW50ZXJydXB0cyBhbmQgdmVyaWZpZXMgdGhlIHVwZGF0ZSB3YXMgYWN0 dWFsbHkgY29tcGxldGVkCiAgKiBiZWZvcmUgYSB2YmxhbmsgdXNpbmcgdGhlIHZhbHVlIG9mIEBz dGFydF92YmxfY291bnQuCiAgKi8KLXZvaWQgaW50ZWxfcGlwZV91cGRhdGVfZW5kKHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjKQordm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9lbmQoc3RydWN0IGludGVs X2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9mbGlwX3dvcmsgKndvcmspCiB7CiAJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2OwogCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+ cGlwZTsKQEAgLTE2Miw2ICsxNjYsMTIgQEAgdm9pZCBpbnRlbF9waXBlX3VwZGF0ZV9lbmQoc3Ry dWN0IGludGVsX2NydGMgKmNydGMpCiAJdTMyIGVuZF92YmxfY291bnQgPSBkZXYtPmRyaXZlci0+ Z2V0X3ZibGFua19jb3VudGVyKGRldiwgcGlwZSk7CiAJa3RpbWVfdCBlbmRfdmJsX3RpbWUgPSBr dGltZV9nZXQoKTsKIAorCWlmICh3b3JrKSB7CisJCXdvcmstPmZsaXBfcXVldWVkX3ZibGFuayA9 IGVuZF92YmxfY291bnQ7CisJCXNtcF9tYl9fYmVmb3JlX2F0b21pYygpOworCQlhdG9taWNfc2V0 KCZ3b3JrLT5wZW5kaW5nLCBJTlRFTF9GTElQX1BFTkRJTkcpOworCX0KKwogCXRyYWNlX2k5MTVf cGlwZV91cGRhdGVfZW5kKGNydGMsIGVuZF92YmxfY291bnQsIHNjYW5saW5lX2VuZCk7CiAKIAls b2NhbF9pcnFfZW5hYmxlKCk7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK