From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel Feceoru Subject: Re: [PATCH v3] drm/i915: Protect fbdev across slow or failed initialisation Date: Thu, 31 Mar 2016 15:00:17 +0300 Message-ID: <56FD1151.5050303@intel.com> References: <1459360634-25516-1-git-send-email-chris@chris-wilson.co.uk> <1459364165-16031-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 319F16E0CA for ; Thu, 31 Mar 2016 12:00:40 +0000 (UTC) In-Reply-To: <1459364165-16031-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org VGhpcyBhbG1vc3QgZml4ZXMgdGhlIHByb2JsZW0gLCBidXQgd2l0aCB0aGlzOgoKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgCmIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZmJkZXYuYwppbmRleCA1MDI5ZjkyLi5hNmQzYzU4IDEwMDY0NAotLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2ZiZGV2LmMKQEAgLTEyMyw4ICsxMjMsOSBAQCBzdGF0aWMgc3RydWN0IGludGVs X2ZiZGV2IAoqaW50ZWxfZmJkZXZfZ2V0X2lmX2FjdGl2ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQogICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwoKICAgICAgICAgaW5mbyA9IGRldl9wcml2 LT5mYmRldi0+aGVscGVyLmZiZGV2OwotICAgICAgIGlmIChpbmZvLT5zY3JlZW5fYmFzZSA9PSBO VUxMKQorICAgICAgIGlmIChpbmZvID09IE5VTEwgfHwgaW5mby0+c2NyZWVuX2Jhc2UgPT0gTlVM TCkKICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKCiAgICAgICAgIGlmIChpbmZvLT5zdGF0 ZSAhPSBGQklORk9fU1RBVEVfUlVOTklORykKICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsK CgpJIGdvdCBpbml0aWFsbHkgYSBwYWdlIGZhdWx0IGR1cmluZyBpbml0LCBidXQgd2l0aCB0aGlz IGZpeCwgdGhlIHN1c3BlbmQgCnRlc3QgcGFzc2VzLgoKVGhhbmsgeW91LCBwbGVhc2UgY29uc2lk ZXIgdGhpcy4KClJlZ2FyZHMsCkdhYnJpZWwKCgoKT24gMzAuMDMuMjAxNiAyMTo1NiwgQ2hyaXMg V2lsc29uIHdyb3RlOgo+IElmIHRoZSBpbml0aWFsaXNhdGlvbiBmYWlscywgd2UgbWF5IGJlIGxl ZnQgd2l0aCBhIGRhbmdsaW5nIHBvaW50ZXIgd2l0aAo+IGFuIGluY29tcGxldGUgZmJkZXYgc3Ry dWN0dXJlLiBIZXJlIHdlIHdhbnQgdG8gZGlzYWJsZSBpbnRlcm5hbCBjYWxscwo+IGludG8gZmJk ZXYuIFNpbWlsYXJseSwgdGhlIGluaXRpYWxpc2F0aW9uIG1heSBiZSBzbG93IGFuZCB3ZSBoYXZl bid0IHlldAo+IGVuYWJsZWQgdGhlIGZiZGV2IChlLmcuIHF1aWNrIHN1c3BlbmQgb3IgbGFzdC1j bG9zZSBiZWZvcmUgdGhlIGFzeW5jIGluaXQKPiBjb21wbGV0ZXMpLgo+Cj4gdjM6IFRvIGNyZWF0 ZSBhIHR5cG8gaW50cm9kdWNlZCB3aGVuIHJldHlwaW5nCj4KPiBCdWd6aWxsYTogaHR0cHM6Ly9i dWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM1ODAKPiBSZXBvcnRlZC1ieTog IkxpLCBXZWluYW4gWiIgPHdlaW5hbi56LmxpQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgfCA0OCArKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDE4IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zi ZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXggMTUzZWE3 YTNmY2Y2Li41MDI5ZjkyN2ZlMGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZmJkZXYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMK PiBAQCAtMTE0LDYgKzExNCwyNCBAQCBzdGF0aWMgc3RydWN0IGZiX29wcyBpbnRlbGZiX29wcyA9 IHsKPiAgIAkuZmJfZGVidWdfbGVhdmUgPSBkcm1fZmJfaGVscGVyX2RlYnVnX2xlYXZlLAo+ICAg fTsKPgo+ICtzdGF0aWMgc3RydWN0IGludGVsX2ZiZGV2ICppbnRlbF9mYmRldl9nZXRfaWZfYWN0 aXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBmYl9pbmZvICppbmZvOwo+ ICsKPiArCWlmIChkZXZfcHJpdi0+ZmJkZXYgPT0gTlVMTCkKPiArCQlyZXR1cm4gTlVMTDsKPiAr Cj4gKwlpbmZvID0gZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIuZmJkZXY7Cj4gKwlpZiAoaW5mby0+ c2NyZWVuX2Jhc2UgPT0gTlVMTCkKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwlpZiAoaW5mby0+ c3RhdGUgIT0gRkJJTkZPX1NUQVRFX1JVTk5JTkcpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJ cmV0dXJuIGRldl9wcml2LT5mYmRldjsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQgaW50ZWxmYl9h bGxvYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAgCQkJIHN0cnVjdCBkcm1fZmJf aGVscGVyX3N1cmZhY2Vfc2l6ZSAqc2l6ZXMpCj4gICB7Cj4gQEAgLTc2Niw2ICs3ODQsOCBAQCB2 b2lkIGludGVsX2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBz dGF0ZSwgYm9vbCBzeW5jaHJvbm91cwo+ICAgCQlyZXR1cm47Cj4KPiAgIAlpbmZvID0gaWZiZGV2 LT5oZWxwZXIuZmJkZXY7Cj4gKwlpZiAoaW5mby0+c2NyZWVuX2Jhc2UgPT0gTlVMTCkKPiArCQly ZXR1cm47Cj4KPiAgIAlpZiAoc3luY2hyb25vdXMpIHsKPiAgIAkJLyogRmx1c2ggYW55IHBlbmRp bmcgd29yayB0byB0dXJuIHRoZSBjb25zb2xlIG9uLCBhbmQgdGhlbgo+IEBAIC04MDcsMzIgKzgy NywyNCBAQCB2b2lkIGludGVsX2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIGludCBzdGF0ZSwgYm9vbCBzeW5jaHJvbm91cwo+Cj4gICB2b2lkIGludGVsX2ZiZGV2X291 dHB1dF9wb2xsX2NoYW5nZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIHsKPiAtCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlzdHJ1 Y3QgaW50ZWxfZmJkZXYgKmlmYmRldiA9IGludGVsX2ZiZGV2X2dldF9pZl9hY3RpdmUoZGV2KTsK PiArCj4gKwlpZiAoaWZiZGV2ID09IE5VTEwpCj4gKwkJcmV0dXJuOwo+Cj4gLQlhc3luY19zeW5j aHJvbml6ZV9mdWxsKCk7Cj4gLQlpZiAoZGV2X3ByaXYtPmZiZGV2KQo+IC0JCWRybV9mYl9oZWxw ZXJfaG90cGx1Z19ldmVudCgmZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIpOwo+ICsJZHJtX2ZiX2hl bHBlcl9ob3RwbHVnX2V2ZW50KCZpZmJkZXYtPmhlbHBlcik7Cj4gICB9Cj4KPiAgIHZvaWQgaW50 ZWxfZmJkZXZfcmVzdG9yZV9tb2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICB7Cj4gLQlp bnQgcmV0Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf cHJpdmF0ZTsKPiAtCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gZGV2X3ByaXYtPmZiZGV2 Owo+IC0Jc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcjsKPiArCXN0cnVjdCBpbnRlbF9m YmRldiAqaWZiZGV2ID0gaW50ZWxfZmJkZXZfZ2V0X2lmX2FjdGl2ZShkZXYpOwo+Cj4gLQlhc3lu Y19zeW5jaHJvbml6ZV9mdWxsKCk7Cj4gLQlpZiAoIWlmYmRldikKPiArCWlmIChpZmJkZXYgPT0g TlVMTCkKPiAgIAkJcmV0dXJuOwo+Cj4gLQlmYl9oZWxwZXIgPSAmaWZiZGV2LT5oZWxwZXI7Cj4g LQo+IC0JcmV0ID0gZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQoZmJf aGVscGVyKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlEUk1fREVCVUcoImZhaWxlZCB0byByZXN0b3Jl IGNydGMgbW9kZVxuIik7Cj4gLQl9IGVsc2Ugewo+IC0JCW11dGV4X2xvY2soJmZiX2hlbHBlci0+ ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJaWYgKGRybV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRldl9t b2RlX3VubG9ja2VkKCZpZmJkZXYtPmhlbHBlcikgPT0gMCkgewo+ICsJCW11dGV4X2xvY2soJmRl di0+c3RydWN0X211dGV4KTsKPiAgIAkJaW50ZWxfZmJfb2JqX2ludmFsaWRhdGUoaWZiZGV2LT5m Yi0+b2JqLCBPUklHSU5fR1RUKTsKPiAtCQltdXRleF91bmxvY2soJmZiX2hlbHBlci0+ZGV2LT5z dHJ1Y3RfbXV0ZXgpOwo+ICsJCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAg CX0KPiAgIH0KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK