From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Sort DEV_INFO_FOR_EACH_FLAG
Date: Thu, 6 Oct 2016 11:10:51 +0100 [thread overview]
Message-ID: <56d42d98-112b-cfcb-e070-c0e80027936f@linux.intel.com> (raw)
In-Reply-To: <20161004133203.GB9653@nuc-i3427.alporthouse.com>
On 04/10/2016 14:32, Chris Wilson wrote:
> On Tue, Oct 04, 2016 at 03:42:58PM +0300, Joonas Lahtinen wrote:
>> Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*).
>>
>> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Ok. Looks like it should be easier to read.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Could you add something like:
>
> /* Keep is_* in chronological order */
> ....
> /* Keep has_* in alphabetical order */
> ...
You could also push is_mobile and is_preliminary to the end of the is_
block which would be a micro-opt for the "IS_SKYLAKE || IS_KABYLAKE"
code and similar for the checks for the earlier hardware. If flags for
things of similar age end up in the same byte then checking for compound
conditions is shorter. :) As it stands they are just split across byte
boundaries. :))
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-06 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 12:42 [PATCH 1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG Joonas Lahtinen
2016-10-04 12:42 ` [PATCH 2/2] drm/i915: Sort DEV_INFO_FOR_EACH_FLAG Joonas Lahtinen
2016-10-04 13:32 ` Chris Wilson
2016-10-06 10:10 ` Tvrtko Ursulin [this message]
2016-10-04 13:23 ` [PATCH 1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG Chris Wilson
2016-10-04 13:49 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
2016-10-04 14:19 ` [PATCH 1/2] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d42d98-112b-cfcb-e070-c0e80027936f@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox