From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yu Dai <yu.dai@intel.com>
Subject: Re: [PATCH v4 2/6] drm/i915/guc: move
 guc_ring_doorbell() nearer to callsite
Date: Wed, 13 Apr 2016 10:52:13 -0700
Message-ID: <570E874D.7000504@intel.com>
References: <1460049678-21918-1-git-send-email-david.s.gordon@intel.com>
 <1460049678-21918-3-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id CB98A6E931
 for <intel-gfx@lists.freedesktop.org>; Wed, 13 Apr 2016 17:53:43 +0000 (UTC)
In-Reply-To: <1460049678-21918-3-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

TEdUTS4KClJldmlld2VkLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KCk9uIDA0LzA3
LzIwMTYgMTA6MjEgQU0sIERhdmUgR29yZG9uIHdyb3RlOgo+IEp1c3QgY29kZSBtb3ZlbWVudCwg
bm8gYWN0dWFsIGNoYW5nZSB0byB0aGUgZnVuY3Rpb24uIFRoaXMgaXMgaW4KPiBwcmVwYXJhdGlv
biBmb3IgdGhlIG5leHQgcGF0Y2gsIHdoaWNoIHdpbGwgcmVvcmdhbmlzZSBhbGwgdGhlIG90aGVy
Cj4gZG9vcmJlbGwgY29kZSwgYnV0IGRvZXNuJ3QgY2hhbmdlIHRoaXMgZnVuY3Rpb24uIFNvIGxl
dCdzIHNodWZmbGUgaXQKPiBkb3duIG5lYXIgaXRzIGNhbGxlciByYXRoZXIgdGhhbiBsZWF2aW5n
IGl0IG1peGVkIGluIHdpdGggdGhlIHNldHVwCj4gY29kZS4gVW5saWtlIHRoZSBkb29yYmVsbCBt
YW5hZ2VtZW50IGNvZGUsIHRoaXMgZnVuY3Rpb24gaXMgc29tZXdoYXQKPiB0aW1lLWNyaXRpY2Fs
LCBzbyBwdXR0aW5nIGl0IG5lYXIgaXRzIGNhbGxlciBtYXkgZXZlbiB5aWVsZCBhIHRpbnkKPiBw
ZXJmb3JtYW5jZSBpbXByb3ZlbWVudC4KPgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxk
YXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2d1Y19zdWJtaXNzaW9uLmMgfCAxMjggKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0K
PiAgIDEgZmlsZSBjaGFuZ2VkLCA2NyBpbnNlcnRpb25zKCspLCA2MSBkZWxldGlvbnMoLSkKPgo+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCBkYTg2
YmRiLi4yMTcxNzU5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj
X3N1Ym1pc3Npb24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1p
c3Npb24uYwo+IEBAIC0xOTAsNjcgKzE5MCw2IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X2Rvb3Ji
ZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiAgIAlrdW5tYXBfYXRvbWljKGJhc2UpOwo+ICAg
fQo+ICAgCj4gLXN0YXRpYyBpbnQgZ3VjX3JpbmdfZG9vcmJlbGwoc3RydWN0IGk5MTVfZ3VjX2Ns
aWVudCAqZ2MpCj4gLXsKPiAtCXN0cnVjdCBndWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+IC0JdW5p
b24gZ3VjX2Rvb3JiZWxsX3F3IGRiX2NtcCwgZGJfZXhjLCBkYl9yZXQ7Cj4gLQl1bmlvbiBndWNf
ZG9vcmJlbGxfcXcgKmRiOwo+IC0Jdm9pZCAqYmFzZTsKPiAtCWludCBhdHRlbXB0ID0gMiwgcmV0
ID0gLUVBR0FJTjsKPiAtCj4gLQliYXNlID0ga21hcF9hdG9taWMoaTkxNV9nZW1fb2JqZWN0X2dl
dF9wYWdlKGdjLT5jbGllbnRfb2JqLCAwKSk7Cj4gLQlkZXNjID0gYmFzZSArIGdjLT5wcm9jX2Rl
c2Nfb2Zmc2V0Owo+IC0KPiAtCS8qIFVwZGF0ZSB0aGUgdGFpbCBzbyBpdCBpcyB2aXNpYmxlIHRv
IEd1QyAqLwo+IC0JZGVzYy0+dGFpbCA9IGdjLT53cV90YWlsOwo+IC0KPiAtCS8qIGN1cnJlbnQg
Y29va2llICovCj4gLQlkYl9jbXAuZGJfc3RhdHVzID0gR1VDX0RPT1JCRUxMX0VOQUJMRUQ7Cj4g
LQlkYl9jbXAuY29va2llID0gZ2MtPmNvb2tpZTsKPiAtCj4gLQkvKiBjb29raWUgdG8gYmUgdXBk
YXRlZCAqLwo+IC0JZGJfZXhjLmRiX3N0YXR1cyA9IEdVQ19ET09SQkVMTF9FTkFCTEVEOwo+IC0J
ZGJfZXhjLmNvb2tpZSA9IGdjLT5jb29raWUgKyAxOwo+IC0JaWYgKGRiX2V4Yy5jb29raWUgPT0g
MCkKPiAtCQlkYl9leGMuY29va2llID0gMTsKPiAtCj4gLQkvKiBwb2ludGVyIG9mIGN1cnJlbnQg
ZG9vcmJlbGwgY2FjaGVsaW5lICovCj4gLQlkYiA9IGJhc2UgKyBnYy0+ZG9vcmJlbGxfb2Zmc2V0
Owo+IC0KPiAtCXdoaWxlIChhdHRlbXB0LS0pIHsKPiAtCQkvKiBsZXRzIHJpbmcgdGhlIGRvb3Ji
ZWxsICovCj4gLQkJZGJfcmV0LnZhbHVlX3F3ID0gYXRvbWljNjRfY21weGNoZygoYXRvbWljNjRf
dCAqKWRiLAo+IC0JCQlkYl9jbXAudmFsdWVfcXcsIGRiX2V4Yy52YWx1ZV9xdyk7Cj4gLQo+IC0J
CS8qIGlmIHRoZSBleGNoYW5nZSB3YXMgc3VjY2Vzc2Z1bGx5IGV4ZWN1dGVkICovCj4gLQkJaWYg
KGRiX3JldC52YWx1ZV9xdyA9PSBkYl9jbXAudmFsdWVfcXcpIHsKPiAtCQkJLyogZGIgd2FzIHN1
Y2Nlc3NmdWxseSBydW5nICovCj4gLQkJCWdjLT5jb29raWUgPSBkYl9leGMuY29va2llOwo+IC0J
CQlyZXQgPSAwOwo+IC0JCQlicmVhazsKPiAtCQl9Cj4gLQo+IC0JCS8qIFhYWDogZG9vcmJlbGwg
d2FzIGxvc3QgYW5kIG5lZWQgdG8gYWNxdWlyZSBpdCBhZ2FpbiAqLwo+IC0JCWlmIChkYl9yZXQu
ZGJfc3RhdHVzID09IEdVQ19ET09SQkVMTF9ESVNBQkxFRCkKPiAtCQkJYnJlYWs7Cj4gLQo+IC0J
CURSTV9FUlJPUigiQ29va2llIG1pc21hdGNoLiBFeHBlY3RlZCAlZCwgcmV0dXJuZWQgJWRcbiIs
Cj4gLQkJCSAgZGJfY21wLmNvb2tpZSwgZGJfcmV0LmNvb2tpZSk7Cj4gLQo+IC0JCS8qIHVwZGF0
ZSB0aGUgY29va2llIHRvIG5ld2x5IHJlYWQgY29va2llIGZyb20gR3VDICovCj4gLQkJZGJfY21w
LmNvb2tpZSA9IGRiX3JldC5jb29raWU7Cj4gLQkJZGJfZXhjLmNvb2tpZSA9IGRiX3JldC5jb29r
aWUgKyAxOwo+IC0JCWlmIChkYl9leGMuY29va2llID09IDApCj4gLQkJCWRiX2V4Yy5jb29raWUg
PSAxOwo+IC0JfQo+IC0KPiAtCS8qIEZpbmFsbHksIHVwZGF0ZSB0aGUgY2FjaGVkIGNvcHkgb2Yg
dGhlIEd1QydzIFdRIGhlYWQgKi8KPiAtCWdjLT53cV9oZWFkID0gZGVzYy0+aGVhZDsKPiAtCj4g
LQlrdW5tYXBfYXRvbWljKGJhc2UpOwo+IC0JcmV0dXJuIHJldDsKPiAtfQo+IC0KPiAgIHN0YXRp
YyB2b2lkIGd1Y19kaXNhYmxlX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiAgIAkJ
CQkgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50KQo+ICAgewo+IEBAIC00NzEsNiArNDEw
LDEyIEBAIHN0YXRpYyB2b2lkIGd1Y19maW5pX2N0eF9kZXNjKHN0cnVjdCBpbnRlbF9ndWMgKmd1
YywKPiAgIAkJCSAgICAgc2l6ZW9mKGRlc2MpICogY2xpZW50LT5jdHhfaW5kZXgpOwo+ICAgfQo+
ICAgCj4gKy8qCj4gKyAqIEV2ZXJ5dGhpbmcgYWJvdmUgaGVyZSBpcyBjb25jZXJuZWQgd2l0aCBz
ZXR1cCAmIHRlYXJkb3duLCBhbmQgaXMKPiArICogdGhlcmVmb3JlIG5vdCBwYXJ0IG9mIHRoZSBz
b21ld2hhdCB0aW1lLWNyaXRpY2FsIGJhdGNoLXN1Ym1pc3Npb24KPiArICogcGF0aCBvZiBpOTE1
X2d1Y19zdWJtaXQoKSBiZWxvdy4KPiArICovCj4gKwo+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNr
X3NwYWNlKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ICAgewo+ICAgCXN0cnVjdCBndWNf
cHJvY2Vzc19kZXNjICpkZXNjOwo+IEBAIC01NTksNiArNTA0LDY3IEBAIHN0YXRpYyBpbnQgZ3Vj
X2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYywKPiAgIAlyZXR1
cm4gMDsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgaW50IGd1Y19yaW5nX2Rvb3JiZWxsKHN0cnVjdCBp
OTE1X2d1Y19jbGllbnQgKmdjKQo+ICt7Cj4gKwlzdHJ1Y3QgZ3VjX3Byb2Nlc3NfZGVzYyAqZGVz
YzsKPiArCXVuaW9uIGd1Y19kb29yYmVsbF9xdyBkYl9jbXAsIGRiX2V4YywgZGJfcmV0Owo+ICsJ
dW5pb24gZ3VjX2Rvb3JiZWxsX3F3ICpkYjsKPiArCXZvaWQgKmJhc2U7Cj4gKwlpbnQgYXR0ZW1w
dCA9IDIsIHJldCA9IC1FQUdBSU47Cj4gKwo+ICsJYmFzZSA9IGttYXBfYXRvbWljKGk5MTVfZ2Vt
X29iamVjdF9nZXRfcGFnZShnYy0+Y2xpZW50X29iaiwgMCkpOwo+ICsJZGVzYyA9IGJhc2UgKyBn
Yy0+cHJvY19kZXNjX29mZnNldDsKPiArCj4gKwkvKiBVcGRhdGUgdGhlIHRhaWwgc28gaXQgaXMg
dmlzaWJsZSB0byBHdUMgKi8KPiArCWRlc2MtPnRhaWwgPSBnYy0+d3FfdGFpbDsKPiArCj4gKwkv
KiBjdXJyZW50IGNvb2tpZSAqLwo+ICsJZGJfY21wLmRiX3N0YXR1cyA9IEdVQ19ET09SQkVMTF9F
TkFCTEVEOwo+ICsJZGJfY21wLmNvb2tpZSA9IGdjLT5jb29raWU7Cj4gKwo+ICsJLyogY29va2ll
IHRvIGJlIHVwZGF0ZWQgKi8KPiArCWRiX2V4Yy5kYl9zdGF0dXMgPSBHVUNfRE9PUkJFTExfRU5B
QkxFRDsKPiArCWRiX2V4Yy5jb29raWUgPSBnYy0+Y29va2llICsgMTsKPiArCWlmIChkYl9leGMu
Y29va2llID09IDApCj4gKwkJZGJfZXhjLmNvb2tpZSA9IDE7Cj4gKwo+ICsJLyogcG9pbnRlciBv
ZiBjdXJyZW50IGRvb3JiZWxsIGNhY2hlbGluZSAqLwo+ICsJZGIgPSBiYXNlICsgZ2MtPmRvb3Ji
ZWxsX29mZnNldDsKPiArCj4gKwl3aGlsZSAoYXR0ZW1wdC0tKSB7Cj4gKwkJLyogbGV0cyByaW5n
IHRoZSBkb29yYmVsbCAqLwo+ICsJCWRiX3JldC52YWx1ZV9xdyA9IGF0b21pYzY0X2NtcHhjaGco
KGF0b21pYzY0X3QgKilkYiwKPiArCQkJZGJfY21wLnZhbHVlX3F3LCBkYl9leGMudmFsdWVfcXcp
Owo+ICsKPiArCQkvKiBpZiB0aGUgZXhjaGFuZ2Ugd2FzIHN1Y2Nlc3NmdWxseSBleGVjdXRlZCAq
Lwo+ICsJCWlmIChkYl9yZXQudmFsdWVfcXcgPT0gZGJfY21wLnZhbHVlX3F3KSB7Cj4gKwkJCS8q
IGRiIHdhcyBzdWNjZXNzZnVsbHkgcnVuZyAqLwo+ICsJCQlnYy0+Y29va2llID0gZGJfZXhjLmNv
b2tpZTsKPiArCQkJcmV0ID0gMDsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsKPiArCQkvKiBYWFg6
IGRvb3JiZWxsIHdhcyBsb3N0IGFuZCBuZWVkIHRvIGFjcXVpcmUgaXQgYWdhaW4gKi8KPiArCQlp
ZiAoZGJfcmV0LmRiX3N0YXR1cyA9PSBHVUNfRE9PUkJFTExfRElTQUJMRUQpCj4gKwkJCWJyZWFr
Owo+ICsKPiArCQlEUk1fRVJST1IoIkNvb2tpZSBtaXNtYXRjaC4gRXhwZWN0ZWQgJWQsIHJldHVy
bmVkICVkXG4iLAo+ICsJCQkgIGRiX2NtcC5jb29raWUsIGRiX3JldC5jb29raWUpOwo+ICsKPiAr
CQkvKiB1cGRhdGUgdGhlIGNvb2tpZSB0byBuZXdseSByZWFkIGNvb2tpZSBmcm9tIEd1QyAqLwo+
ICsJCWRiX2NtcC5jb29raWUgPSBkYl9yZXQuY29va2llOwo+ICsJCWRiX2V4Yy5jb29raWUgPSBk
Yl9yZXQuY29va2llICsgMTsKPiArCQlpZiAoZGJfZXhjLmNvb2tpZSA9PSAwKQo+ICsJCQlkYl9l
eGMuY29va2llID0gMTsKPiArCX0KPiArCj4gKwkvKiBGaW5hbGx5LCB1cGRhdGUgdGhlIGNhY2hl
ZCBjb3B5IG9mIHRoZSBHdUMncyBXUSBoZWFkICovCj4gKwlnYy0+d3FfaGVhZCA9IGRlc2MtPmhl
YWQ7Cj4gKwo+ICsJa3VubWFwX2F0b21pYyhiYXNlKTsKPiArCXJldHVybiByZXQ7Cj4gK30KPiAr
Cj4gICAvKioKPiAgICAqIGk5MTVfZ3VjX3N1Ym1pdCgpIC0gU3VibWl0IGNvbW1hbmRzIHRocm91
Z2ggR3VDCj4gICAgKiBAY2xpZW50Ogl0aGUgZ3VjIGNsaWVudCB3aGVyZSBjb21tYW5kcyB3aWxs
IGdvIHRocm91Z2gKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eAo=