From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v4 4/6] drm/i915/guc: (re)initialise
 doorbell h/w when enabling GuC submission
Date: Wed, 13 Apr 2016 20:46:58 +0100
Message-ID: <570EA232.4080608@intel.com>
References: <1460049678-21918-1-git-send-email-david.s.gordon@intel.com>
 <1460049678-21918-5-git-send-email-david.s.gordon@intel.com>
 <570E86DF.2050909@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8CEFD6E023
 for <intel-gfx@lists.freedesktop.org>; Wed, 13 Apr 2016 19:47:01 +0000 (UTC)
In-Reply-To: <570E86DF.2050909@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Yu Dai <yu.dai@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMTMvMDQvMTYgMTg6NTAsIFl1IERhaSB3cm90ZToKPgo+Cj4gT24gMDQvMDcvMjAxNiAxMDoy
MSBBTSwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IER1cmluZyBhIGhpYmVybmF0ZS9yZXN1bWUgY3lj
bGUsIHRoZSB3aG9sZSBzeXN0ZW0gaXMgcmVzZXQsIGluY2x1ZGluZwo+PiB0aGUgR3VDIGFuZCB0
aGUgZG9vcmJlbGwgaGFyZHdhcmUuIFRoZW4gdGhlIHN5c3RlbSBpcyBib290ZWQgdXAsIGRyaXZl
cnMKPj4gYXJlIGxvYWRlZCwgZXRjIC0tIHRoZSBHdUMgZmlybXdhcmUgbWF5IGJlIGxvYWRlZCBh
bmQgc2V0IHJ1bm5pbmcgYXQgdGhpcwo+PiBwb2ludC4gQnV0IHRoZW4sIHRoZSBib290ZWQga2Vy
bmVsIGlzIHJlcGxhY2VkIGJ5IHRoZSBoaWJlcm5hdGVkIGltYWdlLAo+PiBhbmQgdGhpcyByZXN1
bWVkIGtlcm5lbCB3aWxsIGFsc28gdHJ5IHRvIHJlbG9hZCB0aGUgR3VDIGZpcm13YXJlICh3aGlj
aAo+PiB3aWxsIGZhaWwpLiBUbyByZWNvdmVyLCB3ZSByZXNldCB0aGUgR3VDIGFuZCB0cnkgYWdh
aW4gKHdoaWNoIHNob3VsZAo+PiB3b3JrKS4gQnV0IHRoaXMgR3VDIHJlc2V0IGRvZXNuJ3QgYWxz
byByZXNldCB0aGUgZG9vcmJlbGwgaGFyZHdhcmUsIHNvCj4+IGl0IGNhbiBiZSBsZWZ0IGluIGEg
c3RhdGUgaW5jb25zaXN0ZW50IHdpdGggdGhhdCBhc3N1bWVkIGJ5IHRoZSBkcml2ZXIKPj4gYW5k
IHRoZSBHdUMuCj4+Cj4+IEl0IHdvdWxkIGJlIGJldHRlciBpZiB0aGUgR3VDIHJlc2V0IGFsc28g
Y2xlYXJlZCBhbGwgZG9vcmJlbGwgc3RhdGUsCj4+IGJ1dCB0aGF0J3Mgbm90IGhvdyB0aGUgaGFy
ZHdhcmUgY3VycmVudGx5IHdvcmtzOyBhbHNvLCB0aGUgZHJpdmVyIGNhbm5vdAo+PiBkaXJlY3Rs
eSByZXByb2dyYW0gdGhlIGRvb3JiZWxsIGhhcmR3YXJlIChvbmx5IHRoZSBHdUMgY2FuIGRvIHRo
YXQpLgo+Pgo+PiBTbyB0aGlzIHBhdGNoIGN5Y2xlcyB0aHJvdWdoIGFsbCBkb29yYmVsbHMsIGFz
c2lnbmluZyBhbmQgcmVsZWFzaW5nIGVhY2gKPj4gaW4gdHVybiwgc28gdGhhdCBhbGwgdGhlIGRv
b3JiZWxsIGhhcmR3YXJlIGlzIGxlZnQgaW4gYSBjb25zaXN0ZW50IHN0YXRlLAo+PiBubyBtYXR0
ZXIgaG93IGl0IHdhcyBwcm9ncmFtbWVkIGJ5IHRoZSBwcmV2aW91c2x5LXJ1bm5pbmcga2VybmVs
IGFuZC9vcgo+PiBHdUMgZmlybXdhcmUuCj4+Cj4+IFRoaXMgcGF0Y2ggY2FuIGJlIHJlbW92ZWQg
aWYvd2hlbiB0aGUgR3VDIGZpcm13YXJlIGlzIHVwZGF0ZWQgc28gdGhhdCBpdAo+PiAocmUpaW5p
dGlhbGlzZXMgdGhlIGRvb3JiZWxsIGhhcmR3YXJlIGFmdGVyIGV2ZXJ5IGZpcm13YXJlIChyZSls
b2FkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50
ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz
aW9uLmMgfCA0Ngo+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4gICAxIGZpbGUg
Y2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGluZGV4IDJmYzY5ZjEuLmY0
NjZlYWIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1p
c3Npb24uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9u
LmMKPj4gQEAgLTcwNyw2ICs3MDcsNTAgQEAgc3RhdGljIHZvaWQgZ3VjX2NsaWVudF9mcmVlKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAgICAgIGtmcmVlKGNsaWVudCk7Cj4+ICAgfQo+PiAr
LyoKPj4gKyAqIEJvcnJvdyB0aGUgZmlyc3QgY2xpZW50IHRvIHNldCB1cCAmIHRlYXIgZG93biBl
dmVyeSBkb29yYmVsbAo+PiArICogaW4gdHVybiwgdG8gZW5zdXJlIHRoYXQgYWxsIGRvb3JiZWxs
IGgvdyBpcyAocmUpaW5pdGlhbGlzZWQuCj4+ICsgKi8KPj4gK3N0YXRpYyB2b2lkIGd1Y19pbml0
X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4gK3sKPj4gKyAgICBzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+PiArICAgIHN0
cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY2J1Zl9jbGllbnQ7Cj4+ICsg
ICAgc3RydWN0IGd1Y19kb29yYmVsbF9pbmZvICpkb29yYmVsbDsKPj4gKyAgICB1aW50MTZfdCBk
Yl9pZCwgaTsKPj4gKyAgICB2b2lkICpiYXNlOwo+PiArICAgIGludCByZXQ7Cj4+ICsKPj4gKyAg
ICBiYXNlID0ga21hcF9hdG9taWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGNsaWVudC0+Y2xp
ZW50X29iaiwgMCkpOwo+PiArICAgIGRvb3JiZWxsID0gYmFzZSArIGNsaWVudC0+ZG9vcmJlbGxf
b2Zmc2V0Owo+PiArICAgIGRiX2lkID0gY2xpZW50LT5kb29yYmVsbF9pZDsKPj4gKwo+PiArICAg
IGZvciAoaSA9IDA7IGkgPCBHVUNfTUFYX0RPT1JCRUxMUzsgKytpKSB7Cj4+ICsgICAgICAgIGk5
MTVfcmVnX3QgZHJicmVnID0gR0VOOF9EUkJSRUdMKGkpOwo+PiArICAgICAgICB1MzIgdmFsdWUg
PSBJOTE1X1JFQUQoZHJicmVnKTsKPj4gKwo+PiArICAgICAgICByZXQgPSBndWNfdXBkYXRlX2Rv
b3JiZWxsX2lkKGNsaWVudCwgZG9vcmJlbGwsIGkpOwo+PiArCj4+ICsgICAgICAgIGlmICgoKHZh
bHVlICYgR1VDX0RPT1JCRUxMX0VOQUJMRUQpICYmIChpICE9IGRiX2lkKSkgfHwgcmV0KQo+PiAr
ICAgICAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiRG9vcmJlbGwgcmVnIDB4JXggd2FzIDB4JXgs
IHJldCAlZFxuIiwKPj4gKyAgICAgICAgICAgICAgICBkcmJyZWcucmVnLCB2YWx1ZSwgcmV0KTsK
Pj4gKyAgICB9Cj4+ICsKPj4gKyAgICAvKiBSZXN0b3JlIHRvIG9yaWdpbmFsIHZhbHVlICovCj4+
ICsgICAgZ3VjX3VwZGF0ZV9kb29yYmVsbF9pZChjbGllbnQsIGRvb3JiZWxsLCBkYl9pZCk7Cj4+
ICsKPj4gKyAgICBmb3IgKGkgPSAwOyBpIDwgR1VDX01BWF9ET09SQkVMTFM7ICsraSkgewo+PiAr
ICAgICAgICBpOTE1X3JlZ190IGRyYnJlZyA9IEdFTjhfRFJCUkVHTChpKTsKPj4gKyAgICAgICAg
dTMyIHZhbHVlID0gSTkxNV9SRUFEKGRyYnJlZyk7Cj4+ICsKPj4gKyAgICAgICAgaWYgKCh2YWx1
ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSAmJiAoaSAhPSBkYl9pZCkpCj4+ICsgICAgICAgICAg
ICBEUk1fREVCVUdfRFJJVkVSKCJEb29yYmVsbCByZWcgMHgleCBmaW5hbGx5IDB4JXhcbiIsCj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICBkcmJyZWcucmVnLCB2YWx1ZSk7Cj4+ICsKPj4gKyAg
ICB9Cj4+ICsKPgo+IFRoZSBmb3IgbG9vcCBhYm92ZSBpcyBub3QgbmVlZGVkLiBJdCBjYW4gYmUg
bWVyZ2VkIGludG8gcHJldmlvdXMgbG9vcCBieQo+IHByaW50IG91dCBuZXcgZHJicmVnIHZhbHVl
IChyZWFkIGl0IGFnYWluIGFmdGVyIHVwZGF0ZV9kb29yYmVsbF9pZCkuCj4KPiBBdCB0aGlzIHBv
aW50LCBvbmx5IG5lZWQgdG8gY2hlY2sgaWYgZGJfaWQgaXMgY29ycmVjdGx5IGVuYWJsZWQgb3Ig
bm90Cj4gYnkgcHJpbnQgb3V0IEk5MTVfUkVBRChHRU44X0RSQlJFR0woZGJfaWQpKS4KPgo+IEFs
ZXgKCk5vLCB0aGUgaWRlYSBpcyBub3QgdG8gY2hlY2sgdGhhdCB0aGUgR3VDIGNhbGwgaGFzICpl
bmFibGVkKiBlYWNoIApzZWxlY3RlZCBkb29yYmVsbCwgYnV0IHRvIGNoZWNrIHRoYXQgYWZ0ZXIg
dGhlIGVuZCBvZiB0aGUgZmlyc3QgbG9vcCwgCmFuZCB0aGUgc3Vic2VxdWVudCByZXN0b3JlLCBh
bGwgKm90aGVyKiBkb29yYmVsbHMgaGF2ZSBiZWVuICpkaXNhYmxlZCouIApXZSdyZSBvbmx5ICpz
ZWxlY3RpbmcqIGVhY2ggZG9vcmJlbGwgc28gdGhhdCB3ZSBjYW4gdGhlbiAqZGVzZWxlY3QqIGl0
IAphcyBhIHNpZGUgZWZmZWN0IG9mIHNlbGVjdGluZyB0aGUgbmV4dCBvbmUhCgpIZW5jZSBzZXBh
cmF0ZSBsb29wIHJlcXVpcmVkIC4uLgoKLkRhdmUuCgo+PiArICAgIGt1bm1hcF9hdG9taWMoYmFz
ZSk7Cj4+ICt9Cj4+ICsKPj4gICAvKioKPj4gICAgKiBndWNfY2xpZW50X2FsbG9jKCkgLSBBbGxv
Y2F0ZSBhbiBpOTE1X2d1Y19jbGllbnQKPj4gICAgKiBAZGV2OiAgICBkcm0gZGV2aWNlCj4+IEBA
IC05NzEsOCArMTAxNSw4IEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3Qg
ZHJtX2RldmljZQo+PiAqZGV2KQo+PiAgICAgICB9Cj4+ICAgICAgIGd1Yy0+ZXhlY2J1Zl9jbGll
bnQgPSBjbGllbnQ7Cj4+IC0KPj4gICAgICAgaG9zdDJndWNfc2FtcGxlX2ZvcmNld2FrZShndWMs
IGNsaWVudCk7Cj4+ICsgICAgZ3VjX2luaXRfZG9vcmJlbGxfaHcoZ3VjKTsKPj4gICAgICAgcmV0
dXJuIDA7Cj4+ICAgfQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK