From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Dai Subject: Re: [PATCH v4 4/6] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission Date: Wed, 13 Apr 2016 13:13:51 -0700 Message-ID: <570EA87F.3070600@intel.com> References: <1460049678-21918-1-git-send-email-david.s.gordon@intel.com> <1460049678-21918-5-git-send-email-david.s.gordon@intel.com> <570E86DF.2050909@intel.com> <570EA232.4080608@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 206DB6E991 for ; Wed, 13 Apr 2016 20:15:01 +0000 (UTC) In-Reply-To: <570EA232.4080608@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwNC8xMy8yMDE2IDEyOjQ2IFBNLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAxMy8wNC8x NiAxODo1MCwgWXUgRGFpIHdyb3RlOgo+ID4KPiA+Cj4gPiBPbiAwNC8wNy8yMDE2IDEwOjIxIEFN LCBEYXZlIEdvcmRvbiB3cm90ZToKPiA+PiBEdXJpbmcgYSBoaWJlcm5hdGUvcmVzdW1lIGN5Y2xl LCB0aGUgd2hvbGUgc3lzdGVtIGlzIHJlc2V0LCBpbmNsdWRpbmcKPiA+PiB0aGUgR3VDIGFuZCB0 aGUgZG9vcmJlbGwgaGFyZHdhcmUuIFRoZW4gdGhlIHN5c3RlbSBpcyBib290ZWQgdXAsIGRyaXZl cnMKPiA+PiBhcmUgbG9hZGVkLCBldGMgLS0gdGhlIEd1QyBmaXJtd2FyZSBtYXkgYmUgbG9hZGVk IGFuZCBzZXQgcnVubmluZyBhdCB0aGlzCj4gPj4gcG9pbnQuIEJ1dCB0aGVuLCB0aGUgYm9vdGVk IGtlcm5lbCBpcyByZXBsYWNlZCBieSB0aGUgaGliZXJuYXRlZCBpbWFnZSwKPiA+PiBhbmQgdGhp cyByZXN1bWVkIGtlcm5lbCB3aWxsIGFsc28gdHJ5IHRvIHJlbG9hZCB0aGUgR3VDIGZpcm13YXJl ICh3aGljaAo+ID4+IHdpbGwgZmFpbCkuIFRvIHJlY292ZXIsIHdlIHJlc2V0IHRoZSBHdUMgYW5k IHRyeSBhZ2FpbiAod2hpY2ggc2hvdWxkCj4gPj4gd29yaykuIEJ1dCB0aGlzIEd1QyByZXNldCBk b2Vzbid0IGFsc28gcmVzZXQgdGhlIGRvb3JiZWxsIGhhcmR3YXJlLCBzbwo+ID4+IGl0IGNhbiBi ZSBsZWZ0IGluIGEgc3RhdGUgaW5jb25zaXN0ZW50IHdpdGggdGhhdCBhc3N1bWVkIGJ5IHRoZSBk cml2ZXIKPiA+PiBhbmQgdGhlIEd1Qy4KPiA+Pgo+ID4+IEl0IHdvdWxkIGJlIGJldHRlciBpZiB0 aGUgR3VDIHJlc2V0IGFsc28gY2xlYXJlZCBhbGwgZG9vcmJlbGwgc3RhdGUsCj4gPj4gYnV0IHRo YXQncyBub3QgaG93IHRoZSBoYXJkd2FyZSBjdXJyZW50bHkgd29ya3M7IGFsc28sIHRoZSBkcml2 ZXIgY2Fubm90Cj4gPj4gZGlyZWN0bHkgcmVwcm9ncmFtIHRoZSBkb29yYmVsbCBoYXJkd2FyZSAo b25seSB0aGUgR3VDIGNhbiBkbyB0aGF0KS4KPiA+Pgo+ID4+IFNvIHRoaXMgcGF0Y2ggY3ljbGVz IHRocm91Z2ggYWxsIGRvb3JiZWxscywgYXNzaWduaW5nIGFuZCByZWxlYXNpbmcgZWFjaAo+ID4+ IGluIHR1cm4sIHNvIHRoYXQgYWxsIHRoZSBkb29yYmVsbCBoYXJkd2FyZSBpcyBsZWZ0IGluIGEg Y29uc2lzdGVudCBzdGF0ZSwKPiA+PiBubyBtYXR0ZXIgaG93IGl0IHdhcyBwcm9ncmFtbWVkIGJ5 IHRoZSBwcmV2aW91c2x5LXJ1bm5pbmcga2VybmVsIGFuZC9vcgo+ID4+IEd1QyBmaXJtd2FyZS4K PiA+Pgo+ID4+IFRoaXMgcGF0Y2ggY2FuIGJlIHJlbW92ZWQgaWYvd2hlbiB0aGUgR3VDIGZpcm13 YXJlIGlzIHVwZGF0ZWQgc28gdGhhdCBpdAo+ID4+IChyZSlpbml0aWFsaXNlcyB0aGUgZG9vcmJl bGwgaGFyZHdhcmUgYWZ0ZXIgZXZlcnkgZmlybXdhcmUgKHJlKWxvYWQuCj4gPj4KPiA+PiBTaWdu ZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+ID4+IC0t LQo+ID4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgNDYK PiA+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+PiAgIDEgZmlsZSBjaGFuZ2Vk LCA0NSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPj4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiA+PiBpbmRleCAyZmM2OWYxLi5m NDY2ZWFiIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1 Ym1pc3Npb24uYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1p c3Npb24uYwo+ID4+IEBAIC03MDcsNiArNzA3LDUwIEBAIHN0YXRpYyB2b2lkIGd1Y19jbGllbnRf ZnJlZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAgICAgIGtmcmVlKGNsaWVudCk7Cj4g Pj4gICB9Cj4gPj4gKy8qCj4gPj4gKyAqIEJvcnJvdyB0aGUgZmlyc3QgY2xpZW50IHRvIHNldCB1 cCAmIHRlYXIgZG93biBldmVyeSBkb29yYmVsbAo+ID4+ICsgKiBpbiB0dXJuLCB0byBlbnN1cmUg dGhhdCBhbGwgZG9vcmJlbGwgaC93IGlzIChyZSlpbml0aWFsaXNlZC4KPiA+PiArICovCj4gPj4g K3N0YXRpYyB2b2lkIGd1Y19pbml0X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykK PiA+PiArewo+ID4+ICsgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3Vj X3RvX2k5MTUoZ3VjKTsKPiA+PiArICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9 IGd1Yy0+ZXhlY2J1Zl9jbGllbnQ7Cj4gPj4gKyAgICBzdHJ1Y3QgZ3VjX2Rvb3JiZWxsX2luZm8g KmRvb3JiZWxsOwo+ID4+ICsgICAgdWludDE2X3QgZGJfaWQsIGk7Cj4gPj4gKyAgICB2b2lkICpi YXNlOwo+ID4+ICsgICAgaW50IHJldDsKPiA+PiArCj4gPj4gKyAgICBiYXNlID0ga21hcF9hdG9t aWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGNsaWVudC0+Y2xpZW50X29iaiwgMCkpOwo+ID4+ ICsgICAgZG9vcmJlbGwgPSBiYXNlICsgY2xpZW50LT5kb29yYmVsbF9vZmZzZXQ7Cj4gPj4gKyAg ICBkYl9pZCA9IGNsaWVudC0+ZG9vcmJlbGxfaWQ7Cj4gPj4gKwo+ID4+ICsgICAgZm9yIChpID0g MDsgaSA8IEdVQ19NQVhfRE9PUkJFTExTOyArK2kpIHsKPiA+PiArICAgICAgICBpOTE1X3JlZ190 IGRyYnJlZyA9IEdFTjhfRFJCUkVHTChpKTsKPiA+PiArICAgICAgICB1MzIgdmFsdWUgPSBJOTE1 X1JFQUQoZHJicmVnKTsKPiA+PiArCj4gPj4gKyAgICAgICAgcmV0ID0gZ3VjX3VwZGF0ZV9kb29y YmVsbF9pZChjbGllbnQsIGRvb3JiZWxsLCBpKTsKPiA+PiArCj4gPj4gKyAgICAgICAgaWYgKCgo dmFsdWUgJiBHVUNfRE9PUkJFTExfRU5BQkxFRCkgJiYgKGkgIT0gZGJfaWQpKSB8fCByZXQpCj4g Pj4gKyAgICAgICAgICAgIERSTV9ERUJVR19EUklWRVIoIkRvb3JiZWxsIHJlZyAweCV4IHdhcyAw eCV4LCByZXQgJWRcbiIsCj4gPj4gKyAgICAgICAgICAgICAgICBkcmJyZWcucmVnLCB2YWx1ZSwg cmV0KTsKPiA+PiArICAgIH0KPiA+PiArCj4gPj4gKyAgICAvKiBSZXN0b3JlIHRvIG9yaWdpbmFs IHZhbHVlICovCj4gPj4gKyAgICBndWNfdXBkYXRlX2Rvb3JiZWxsX2lkKGNsaWVudCwgZG9vcmJl bGwsIGRiX2lkKTsKPiA+PiArCj4gPj4gKyAgICBmb3IgKGkgPSAwOyBpIDwgR1VDX01BWF9ET09S QkVMTFM7ICsraSkgewo+ID4+ICsgICAgICAgIGk5MTVfcmVnX3QgZHJicmVnID0gR0VOOF9EUkJS RUdMKGkpOwo+ID4+ICsgICAgICAgIHUzMiB2YWx1ZSA9IEk5MTVfUkVBRChkcmJyZWcpOwo+ID4+ ICsKPiA+PiArICAgICAgICBpZiAoKHZhbHVlICYgR1VDX0RPT1JCRUxMX0VOQUJMRUQpICYmIChp ICE9IGRiX2lkKSkKPiA+PiArICAgICAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiRG9vcmJlbGwg cmVnIDB4JXggZmluYWxseSAweCV4XG4iLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICBk cmJyZWcucmVnLCB2YWx1ZSk7Cj4gPj4gKwo+ID4+ICsgICAgfQo+ID4+ICsKPiA+Cj4gPiBUaGUg Zm9yIGxvb3AgYWJvdmUgaXMgbm90IG5lZWRlZC4gSXQgY2FuIGJlIG1lcmdlZCBpbnRvIHByZXZp b3VzIGxvb3AgYnkKPiA+IHByaW50IG91dCBuZXcgZHJicmVnIHZhbHVlIChyZWFkIGl0IGFnYWlu IGFmdGVyIHVwZGF0ZV9kb29yYmVsbF9pZCkuCj4gPgo+ID4gQXQgdGhpcyBwb2ludCwgb25seSBu ZWVkIHRvIGNoZWNrIGlmIGRiX2lkIGlzIGNvcnJlY3RseSBlbmFibGVkIG9yIG5vdAo+ID4gYnkg cHJpbnQgb3V0IEk5MTVfUkVBRChHRU44X0RSQlJFR0woZGJfaWQpKS4KPiA+Cj4gPiBBbGV4Cj4K PiBObywgdGhlIGlkZWEgaXMgbm90IHRvIGNoZWNrIHRoYXQgdGhlIEd1QyBjYWxsIGhhcyAqZW5h YmxlZCogZWFjaAo+IHNlbGVjdGVkIGRvb3JiZWxsLCBidXQgdG8gY2hlY2sgdGhhdCBhZnRlciB0 aGUgZW5kIG9mIHRoZSBmaXJzdCBsb29wLAo+IGFuZCB0aGUgc3Vic2VxdWVudCByZXN0b3JlLCBh bGwgKm90aGVyKiBkb29yYmVsbHMgaGF2ZSBiZWVuICpkaXNhYmxlZCouCj4gV2UncmUgb25seSAq c2VsZWN0aW5nKiBlYWNoIGRvb3JiZWxsIHNvIHRoYXQgd2UgY2FuIHRoZW4gKmRlc2VsZWN0KiBp dAo+IGFzIGEgc2lkZSBlZmZlY3Qgb2Ygc2VsZWN0aW5nIHRoZSBuZXh0IG9uZSEKPgo+IEhlbmNl IHNlcGFyYXRlIGxvb3AgcmVxdWlyZWQgLi4uCj4KPiAuRGF2ZS4KClRoaXMgc3RpbGwgY2FuIGJl IGRvbmUgYnkgYmFja3VwIG9mIHByZXZpb3VzIGNsaWVudC0+ZG9vcmJlbGxfaWQuIElmIGl0IApp cyBub3Qgc2FtZSBhcyB0aGUgZGVzaXJlZCBkYl9pZCwgdGhlbiBtYWtlIHN1cmUgaXQgaXMgKmRp c2FibGVkKiBhZnRlciAKdGhlIHVwZGF0ZS4KClRoZSByZWFsIHByb2JsZW0gaGVyZSwgYXQgbGVh c3Qgbm90IGZvciBub3csIGlzIHRoYXQgaXQgYXNzdW1lcyB0aGVyZSBpcyAKb25seSBvbmUgZ3Vj X2NsaWVudC4gSW4gZnV0dXJlLCBpZiB0aGVyZSBpcyB1c2VyIGNyZWF0ZWQgZ3VjX2NsaWVudCwg dGhlIApjb2RlIGRvZXNuJ3QgcmVzdG9yZSBkb29yYmVsbCBmb3IgaXQuCgpBbGV4Cgo+ID4+ICsg ICAga3VubWFwX2F0b21pYyhiYXNlKTsKPiA+PiArfQo+ID4+ICsKPiA+PiAgIC8qKgo+ID4+ICAg ICogZ3VjX2NsaWVudF9hbGxvYygpIC0gQWxsb2NhdGUgYW4gaTkxNV9ndWNfY2xpZW50Cj4gPj4g ICAgKiBAZGV2OiAgICBkcm0gZGV2aWNlCj4gPj4gQEAgLTk3MSw4ICsxMDE1LDggQEAgaW50IGk5 MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlCj4gPj4gKmRldikKPiA+ PiAgICAgICB9Cj4gPj4gICAgICAgZ3VjLT5leGVjYnVmX2NsaWVudCA9IGNsaWVudDsKPiA+PiAt Cj4gPj4gICAgICAgaG9zdDJndWNfc2FtcGxlX2ZvcmNld2FrZShndWMsIGNsaWVudCk7Cj4gPj4g KyAgICBndWNfaW5pdF9kb29yYmVsbF9odyhndWMpOwo+ID4+ICAgICAgIHJldHVybiAwOwo+ID4+ ICAgfQo+ID4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==