From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Use readl/writel for ring buffer access
Date: Thu, 14 Apr 2016 12:24:20 +0100 [thread overview]
Message-ID: <570F7DE4.7020700@linux.intel.com> (raw)
In-Reply-To: <20160414111657.GH5683@nuc-i3427.alporthouse.com>
On 14/04/16 12:16, Chris Wilson wrote:
> On Thu, Apr 14, 2016 at 11:59:29AM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> We know ringbuffers are memory and not ports so if we use readl
>> and writel instead of ioread32 and iowrite32 (which dispatch to
>> the very same functions after checking the address range) we
>> avoid generating functions calls and branching on every access.
>
> We don't need to use readl/write at all, since they are normal memory
> on llc, and on x86 we can pretend that iomaps (!llc/stolen) are as well.
It is fine to use readl/writel since it translates to a single mov
instruction anyway on x86.
> This patch is in the queue along with killing the incorrect spare iomem
> annotation.
Ok did not spot them. Don't mind either way, thought this is quick, easy
and obvious improvement when I spotted the ugly code generated for ring
buffer writing.
Mind you it is still not completely pretty with this patch since it is
full of reloads and adds for ringbuf->virtual_start and tail which I
can't figure how to help GCC optimize. Unless we make being, emit and
advance functions return the current tail pointer and also accept it. In
that case it all shrinks by half.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-14 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 10:59 [PATCH 1/3] drm/i915: Use readl/writel for ring buffer access Tvrtko Ursulin
2016-04-14 10:59 ` [PATCH 2/3] drm/i915: Use writel instead of iowrite32 when doing GTT relocations Tvrtko Ursulin
2016-04-14 11:17 ` Chris Wilson
2016-04-14 10:59 ` [PATCH 3/3] drm/i915: Use writel instead of iowrite32 when programming page table entries Tvrtko Ursulin
2016-04-14 11:16 ` [PATCH 1/3] drm/i915: Use readl/writel for ring buffer access Chris Wilson
2016-04-14 11:24 ` Tvrtko Ursulin [this message]
2016-04-14 11:30 ` Chris Wilson
2016-04-14 11:58 ` Tvrtko Ursulin
2016-04-14 15:07 ` Dave Gordon
2016-04-14 15:55 ` Chris Wilson
2016-04-14 16:37 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2016-04-15 8:54 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F7DE4.7020700@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox