[PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest

[PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest

[Tomeu Vizoso]

When moving the call to gem_set_tiling into the subtests, the one needed
by addfb25-framebuffer-vs-set-tiling was left out.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 tests/kms_addfb_basic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 30f312291fe7..64047303dea7 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -385,6 +385,7 @@ static void addfb25_tests(int fd)
 	}
 
 	igt_subtest("addfb25-framebuffer-vs-set-tiling") {
+		gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
 		igt_require_fb_modifiers(fd);
 
 		f.modifier[0] = LOCAL_I915_FORMAT_MOD_X_TILED;
-- 
2.5.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest

[Tvrtko Ursulin]

On 15/04/16 10:50, Tomeu Vizoso wrote:
> When moving the call to gem_set_tiling into the subtests, the one needed
> by addfb25-framebuffer-vs-set-tiling was left out.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>   tests/kms_addfb_basic.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 30f312291fe7..64047303dea7 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -385,6 +385,7 @@ static void addfb25_tests(int fd)
>   	}
>
>   	igt_subtest("addfb25-framebuffer-vs-set-tiling") {
> +		gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
>   		igt_require_fb_modifiers(fd);
>
>   		f.modifier[0] = LOCAL_I915_FORMAT_MOD_X_TILED;
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks for fixing it! I'll push it shortly.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx