From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: Polymorphic to_i915() Date: Mon, 18 Apr 2016 12:11:07 +0100 Message-ID: <5714C0CB.8030401@intel.com> References: <1460742365-3646-1-git-send-email-chris@chris-wilson.co.uk> <87r3e3p95s.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 721426E58D for ; Mon, 18 Apr 2016 11:11:10 +0000 (UTC) In-Reply-To: <87r3e3p95s.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMDQvMTYgMTA6MTgsIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIEZyaSwgMTUgQXByIDIw MTYsIENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cm90ZToKPj4gRmlu YWwgY2FudmFzIGZvciBvcGluaW9ucyBmb3IgdXNpbmcgYSBtYWdpYyBtYWNybyB0byByZWR1Y2Ug dHlwaW5nIGluCj4+IHRoZSBjb21tb24gb3BlcmF0aW9uIG9mIGdldHRpbmcgb3VyIGRybV9pOTE1 X3ByaXZhdGUgZnJvbSB0aGUgb2JqZWN0Lgo+Pgo+PiAJMjEgZmlsZXMgY2hhbmdlZCwgMzMzIGlu c2VydGlvbnMoKyksIDM5MiBkZWxldGlvbnMoLSkKPj4KPj4gTm90IHRvIG1lbnRpb24gdGhlIGVh c2UgaXQgbWFrZXMgZm9yIGxhdGVyIHBhdGNoZXMgdG8gcmVkdWNlIHRoZSBwb2ludGVyCj4+IGRh bmNlLgo+Cj4gSSd2ZSBleHByZXNzZWQgbXkgcmVzZXJ2YXRpb25zIGFib3V0IHRoaXMgdGhlIGxh c3QgdGltZS4KPgo+IE15IGNvbXByb21pc2UgcHJvcG9zYWwgaXMgdGhpczogbGV0J3MgYWRkIHRo ZSB0b19pOTE1KCkKPiAic3VwZXJjb252ZW5pZW5jZSBtYWNybyIsIGJ1dCBsZXQncyBub3QgZW1i ZWQgdGhhdCBpbnRvIG90aGVyCj4gbWFjcm9zLiBJbnN0ZWFkLCBtb3ZlIGF3YXkgZnJvbSBjb252 ZW5pZW5jZSBtYWNyb3MgaW4gdGhlbSwgZXhwbGljaXRseQo+IHJlcXVpcmluZyBkZXZfcHJpdi4K Pgo+IFRoaXMgd291bGQgbWFrZSBqdXN0IG9uZSBtYWNybyBzcGVjaWFsLCBhbmQgd291bGQga2Vl cCB0aGUgcmVzdCBsZXNzCj4gc3VycHJpc2luZyBhbmQgIkMtbGlrZSIuIFdlIGFscmVhZHkgbmVl ZCBkZXZfcHJpdiBhbGwgb3ZlciB0aGUgcGxhY2UsIHNvCj4gSSBkb24ndCB0aGluayBoYXZpbmcg YSBsb2NhbCB2YXJpYWJsZSBvciBhbiBleHBsaWNpdCB0b19pOTE1KCkgaXMgYSBiaWcKPiBidXJk ZW4uCj4KPiBCUiwKPiBKYW5pLgoKSSdtIHF1aXRlIGhhcHB5IHdpdGggdGhlIGZpcnN0IHBhdGNo IG9mIHRoaXMgc2VyaWVzICh2YXJpb3VzIHJlbmFtZXMpLCAKYnV0IG5vdCBzbyBrZWVuIG9uIHRo ZSBzZWNvbmQgKHBhc3MgYW55dGhpbmcgdG8gZm9yX2VhY2hfZW5naW5lKCkuIFRoZSAKcmVhc29u IGZvciB0aGlzIGlzIHRoYXQgdGhlIGRldl9wcml2IHBhcmFtZXRlciB0byB0aGlzIG1hY3JvIGlz IHVzZWQgCnJlcGVhdGVkbHkgaW4gdGhlIHJlc3VsdGluZyBsb29wLCBzbyB0aGUgY2FsbGVyIHNo b3VsZCBiZSBlbmNvdXJhZ2VkIHRvIApzdXBwbHkgYXMgYW4gYWN0dWFsIHBhcmFtZXRlciB0aGUg ZXhwcmVzc2lvbiB0aGF0IG5lZWRzIHRoZSBsZWFzdCAKZXZhbHVhdGlvbiBvbiBlYWNoIGl0ZXJh dGlvbiBpLmUuIGEgbG9jYWwgdmFyaWFibGUuIEFsbG93aW5nIHN1Y2ggdGhpbmdzIAphcyB0b19p OTE1KGRldikgb3IsIHdvcnNlLCB0b19pOTE1KGVuZ2luZSkgbWF5IGVuY291cmFnZSB1c2VzIHdo aWNoIGVuZCAKdXAgZ2VuZXJhdGluZyBmb3VyIGxldmVscyBvZiBtZW1vcnkgaW5kaXJlY3Rpb24g OigKZS5nLiBlbmdpbmUtPmRldi0+ZGV2X3ByaXYtPmVuZ2luZSghKQoKU28gSSB0aGluayBpdCBz aG91bGQgYmUgcmVnYXJkZWQgYXMgYmV0dGVyIChtb3JlIGVmZmljaWVudCkgc3R5bGUgdG8gd3Jp dGUKCglzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IHRvX2k5MTUoLi4uKTsKCS4uLgoJ Zm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgaTkxNSkgewoJCS4uLgoJfQoKcmF0aGVyIHRoYW4KCglm b3JfZWFjaF9lbmdpbmUoZW5naW5lLCB0b19pOTE1KC4uLikpIHsKCQkuLi4KCX0KCk9UT0ggSSBo YXZlIG5vIG9iamVjdGlvbiB0bwoKCWlmIChVU0VTX0ZVTExfUFBHVFQodG9faTkxNShvYmopKSAu Li4KCihub3QgYSBsb29wKSBidXQgSSdtIG5vdCBzbyBrZWVuIG9uCgoJaWYgKFVTRVNfRlVMTF9Q UEdUVChvYmopKQoKYXMgdGhpcyBzdWdnZXN0cyB0aGF0IGl0J3MgYSBwcm9wZXJ0eSBvZiB0aGUg b2JqZWN0LCBhbmQgZGlmZmVyZW50IApvYmplY3RzIG1pZ2h0IHRoZXJlZm9yZSByZXR1cm4gZGlm ZmVyZW50IHZhbHVlcy4KClRoZSBHdUMgY2hhbmdlcyBhcmUgT0ssIGFuZCB3ZSBtaWdodCBhcyB3 ZWxsIGNvbnZlcnQgImRldl9wcml2IiB0byAKImk5MTUiIGF0IHRoZSBzYW1lIHRpbWUsIGlmIHRo YXQncyBub3cgdGhlIHByZWZlcnJlZCBuYW1lLgoKSW4gdGhlIGVuZCwgSSB0aGluayBJIGFncmVl IHdpdGggSmFuaTogbGV0J3MgaGF2ZSBhIHRob3JvdWdobHkgCnBvbHltb3JwaGljIHRvX2k5MTUo KSB0aGF0IHdvcmtzIG9uIGFueXRoaW5nLCBhbmQgdGhlbiBoYXZlIGV2ZXJ5dGhpbmcgCmVsc2Ug cmVxdWlyZSB0aGF0LgoKUmVnYXJkcywKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=