From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: refactor
	i915_gem_object_pin_map()
Date: Wed, 20 Apr 2016 10:39:36 +0100
Message-ID: <57174E58.7070701@intel.com>
References: <1461087608-34346-1-git-send-email-david.s.gordon@intel.com>
 <20160419195015.GC14602@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTP id B56606E93D
 for <intel-gfx@lists.freedesktop.org>; Wed, 20 Apr 2016 09:39:38 +0000 (UTC)
In-Reply-To: <20160419195015.GC14602@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gMTkvMDQvMTYgMjA6NTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIEFwciAxOSwg
MjAxNiBhdCAwNjo0MDowN1BNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gRnJvbTogQWxl
eCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Cj4+IFRoZSByZWNlbnRseS1hZGRlZCBpOTE1X2dl
bV9vYmplY3RfcGluX21hcCgpIGNhbiBiZSBmdXJ0aGVyIG9wdGltaXNlZAo+PiBmb3IgInNtYWxs
IiBvYmplY3RzLiBUbyBmYWNpbGl0YXRlIHRoaXMsIGFuZCBzaW1wbGlmeSB0aGUgZXJyb3IgcGF0
aHMKPj4gYmVmb3JlIGFkZGluZyB0aGUgbmV3IGNvZGUsIHRoaXMgcGF0Y2ggcHVsbHMgb3V0IHRo
ZSAibWFwcGluZyIgcGFydCBvZgo+PiB0aGUgb3BlcmF0aW9uIChpbnZvbHZpbmcgbG9jYWwgYWxs
b2NhdGlvbnMgd2hpY2ggbXVzdCBiZSB1bmRvbmUgYmVmb3JlCj4+IHJldHVybikgaW50byBpdHMg
b3duIHN1YmZ1bmN0aW9uLgo+Pgo+PiBUaGUgbmV4dCBwYXRjaCB3aWxsIHRoZW4gaW5zZXJ0IHRo
ZSBuZXcgb3B0aW1pc2F0aW9uIGludG8gdGhlIG1pZGRsZSBvZgo+PiB0aGUgbm93LXNlcGFyYXRl
ZCBzdWJmdW5jdGlvbi4KPj4KPj4gVGhpcyByZW9yZ2FuaXNhdGlvbiB3aWxsIHByb2JhYmx5IG5v
dCBhZmZlY3QgdGhlIGdlbmVyYXRlZCBjb2RlLCBhcyB0aGUKPj4gY29tcGlsZXIgd2lsbCBtb3N0
IGxpa2VseSBpbmxpbmUgaXQgYW55d2F5LCBidXQgaXQgbWFrZXMgdGhlIGxvZ2ljYWwKPj4gc3Ry
dWN0dXJlIGEgYml0IGNsZWFyZXIgYW5kIGVhc2llciB0byBtb2RpZnkuCj4+Cj4+IFNpZ25lZC1v
ZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+IENjOiBUdnJ0
a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29u
IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ2VtLmMgfCA2MSArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t
LS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMo
LSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+IGluZGV4IDZjZTJjMzEuLmZjNDJiZTAg
MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBAQCAtMjM5Niw2ICsyMzk2LDQ1IEBA
IHN0YXRpYyB2b2lkIGk5MTVfZ2VtX29iamVjdF9mcmVlX21tYXBfb2Zmc2V0KHN0cnVjdCBkcm1f
aTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+ICAgCXJldHVybiAwOwo+PiAgIH0KPj4KPj4gKy8qIFRo
ZSAnbWFwcGluZycgcGFydCBvZiBpOTE1X2dlbV9vYmplY3RfcGluX21hcCgpIGJlbG93ICovCj4+
ICtzdGF0aWMgdm9pZCAqaTkxNV9nZW1fb2JqZWN0X21hcChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVf
Z2VtX29iamVjdCAqb2JqKQo+PiArewo+PiArCXVuc2lnbmVkIGxvbmcgbl9wYWdlcyA9IG9iai0+
YmFzZS5zaXplID4+IFBBR0VfU0hJRlQ7Cj4+ICsJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZyA9IG9i
ai0+cGFnZXMtPnNnbDsKPj4gKwlzdHJ1Y3Qgc2dfcGFnZV9pdGVyIHNnX2l0ZXI7Cj4+ICsJc3Ry
dWN0IHBhZ2UgKipwYWdlczsKPj4gKwl1bnNpZ25lZCBsb25nIGkgPSAwOwo+PiArCXZvaWQgKmFk
ZHIgPSBOVUxMOwo+PiArCj4+ICsJLyogQSBzaW5nbGUgcGFnZSBjYW4gYWx3YXlzIGJlIGttYXBw
ZWQgKi8KPj4gKwlpZiAobl9wYWdlcyA9PSAxKQo+PiArCQlyZXR1cm4ga21hcChzZ19wYWdlKHNn
KSk7Cj4+ICsKPj4gKwlwYWdlcyA9IGRybV9tYWxsb2NfZ2ZwKG5fcGFnZXMsIHNpemVvZigqcGFn
ZXMpLCBHRlBfVEVNUE9SQVJZKTsKPj4gKwlpZiAocGFnZXMgPT0gTlVMTCkgewo+PiArCQlEUk1f
REVCVUdfRFJJVkVSKCJGYWlsZWQgdG8gZ2V0IHNwYWNlIGZvciBwYWdlc1xuIik7Cj4+ICsJCXJl
dHVybiBOVUxMOwo+PiArCX0KPj4gKwo+PiArCWZvcl9lYWNoX3NnX3BhZ2Uoc2csICZzZ19pdGVy
LCBuX3BhZ2VzLCAwKSB7Cj4+ICsJCXBhZ2VzW2ldID0gc2dfcGFnZV9pdGVyX3BhZ2UoJnNnX2l0
ZXIpOwo+Cj4gSnVzdCBwYWdlc1tpKytdID0gc2dfcGFnZV9pdGVyX3BhZ2UoJnNnX2l0ZXIpOwo+
Cj4+ICsJCWlmICgrK2kgPT0gbl9wYWdlcykgewo+PiArCQkJYWRkciA9IHZtYXAocGFnZXMsIG5f
cGFnZXMsIDAsIFBBR0VfS0VSTkVMKTsKPj4gKwkJCWJyZWFrOwo+PiArCQl9Cj4+ICsJfQo+PiAr
Cj4+ICsJLyogV2Ugc2hvdWxkIGhhdmUgZ290IGhlcmUgdmlhIHRoZSAnYnJlYWsnIGFib3ZlICov
Cj4+ICsJV0FSTl9PTihpICE9IG5fcGFnZXMpOwo+PiArCWlmIChhZGRyID09IE5VTEwpCj4+ICsJ
CURSTV9ERUJVR19EUklWRVIoIkZhaWxlZCB0byB2bWFwIHBhZ2VzXG4iKTsKPgo+IEFzIHRoaXMg
aXMgYSB2ZXJ5LCB2ZXJ5IGNvbmZ1c2VkIGxvb3AuCj4gLUNocmlzCgpJIHRyaWVkIHRoYXQgYXBw
cm9hY2ggYmVmb3JlLCBidXQgaXQgd2FzIGFjdHVhbGx5IG1vcmUgZGlmZmljdWx0IHRvIGhhdmUg
CnRpZHkgZXJyb3ItY2hlY2tpbmcgdGhhdCB3YXkgKHJlbWVtYmVyaW5nIHRoYXQgd2UgbXVzdCBh
bHdheXMgZnJlZSB0aGUgCnBhZ2VzIGFycmF5LCBzbyBkb24ndCByZWFsbHkgd2FudCBhbiBlYXJs
eSByZXR1cm4pLgoKSGVyZSwgcHV0dGluZyB0aGUgdm1hcCgpIGluc2lkZSB0aGUgZmluYWwgaXRl
cmF0aW9uIG9mIHRoZSBsb29wIG1lYW5zIAp0aGF0IHdlIGF1dG9tYXRpY2FsbHkgbGVhdmUgImFk
ZHIiIGFzIE5VTEwgaWYgd2UgZG9uJ3QgcmVhY2ggdGhlIApleHBlY3RlZCBjb3VudC4gVGhlIHN1
YnNlcXVlbnQgV0FSTl9PTigpIHRlbGxzIHVzIHRoYXQgdGhpcyBoYXMgCmhhcHBlbmVkLCBidXQg
d2UgZG9uJ3QgdGhlbiBoYXZlIHRvIGJhc2UgYW55IGZ1cnRoZXIgYnJhbmNoaW5nIG9uIHRoaXMg
CmNvbmRpdGlvbiAoaSAhPSBuX3BhZ2VzKSBhcyAiYWRkciIgaXMgYWxyZWFkeSByaWdodC4gKE9i
dmlvdXNseSwgd2UgCmRvbid0IHdhbnQgdG8gZG8gdGhlIHZtYXAoKSBpZiB3ZSBoYXZlIGV4aXRl
ZCB0aGUgbG9vcCB3aXRoIHRoZSB3cm9uZyAKcGFnZSBjb3VudCkuCgpJJ2xsIHBvc3QgdGhlIG90
aGVyIHZlcnNpb24sIGJ1dCBJIHRoaW5rIHRoZSBwb3N0LWxvb3AgY2hlY2tpbmcgaXMgCm1lc3Np
ZXIsIHRvIHN1Y2ggYW4gZXh0ZW50IHRoYXQgdGhpcyB3YXkgcm91bmQgaXMgc2ltcGxlciBvdmVy
YWxsLgoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eAo=