From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Move releasing of the GEM request from free to retire/cancel Date: Wed, 20 Apr 2016 14:55:50 +0100 Message-ID: <57178A66.6090400@linux.intel.com> References: <1461066053-30072-1-git-send-email-chris@chris-wilson.co.uk> <1461070748-767-1-git-send-email-chris@chris-wilson.co.uk> <1461070748-767-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B6956E9E3 for ; Wed, 20 Apr 2016 13:56:08 +0000 (UTC) In-Reply-To: <1461070748-767-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA0LzE2IDEzOjU5LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSWYgd2UgbW92ZSB0aGUg cmVsZWFzZSBvZiB0aGUgR0VNIHJlcXVlc3QgKGkuZS4gZGVjb3VwbGluZyBpdCBmcm9tIHRoZQo+ IHZhcmlvdXMgbGlzdHMgdXNlZCBmb3IgY2xpZW50IGFuZCBjb250ZXh0IHRyYWNraW5nKSBhZnRl ciBpdCBpcyBjb21wbGV0ZQo+IChlaXRoZXIgYnkgdGhlIEdQVSByZXRpcmluZyB0aGUgcmVxdWVz dCwgb3IgYnkgdGhlIGNhbGxlciBjYW5jZWxsaW5nIHRoZQo+IHJlcXVlc3QpLCB3ZSBjYW4gcmVt b3ZlIHRoZSByZXF1aXJlbWVudCB0aGF0IHRoZSBmaW5hbCB1bnJlZmVyZW5jZSBvZgo+IHRoZSBH RU0gcmVxdWVzdCBuZWVkIHRvIGJlIHVuZGVyIHRoZSBzdHJ1Y3RfbXV0ZXguCj4KPiB2Mix2Mzog UmViYWxhbmNlIGV4ZWNsaXN0cyBieSBtb3ZpbmcgdGhlIGNvbnRleHQgdW5waW5uaW5nLgo+IHY0 OiBSZWJhc2Ugb250byAtbmlnaHRseQo+IHY1OiBBdm9pZCB0cnlpbmcgdG8gcmViYWxhbmNlIGV4 ZWNsaXN0L0d1QyBjb250ZXh0IHBpbm5pbmcsIGxlYXZlIHRoYXQKPiB0byB0aGUgbmV4dCBzdGVw Cj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8IDE0IC0t LS0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgfCAy MyArKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgIDIgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAg ICB8ICAyICstCj4gICA0IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDMwIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggYzBhNmZiZmY0Njc4Li5j NTliMjY3MGNjMzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjM3MCwyMyAr MjM3MCw5IEBAIGk5MTVfZ2VtX3JlcXVlc3RfcmVmZXJlbmNlKHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxKQo+ICAgc3RhdGljIGlubGluZSB2b2lkCj4gICBpOTE1X2dlbV9yZXF1ZXN0 X3VucmVmZXJlbmNlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+ICAgewo+IC0J V0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZyZXEtPmVuZ2luZS0+ZGV2LT5zdHJ1Y3RfbXV0ZXgp KTsKPiAgIAlrcmVmX3B1dCgmcmVxLT5yZWYsIGk5MTVfZ2VtX3JlcXVlc3RfZnJlZSk7Cj4gICB9 Cj4KPiAtc3RhdGljIGlubGluZSB2b2lkCj4gLWk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2Vf X3VubG9ja2VkKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+IC17Cj4gLQlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2Owo+IC0KPiAtCWlmICghcmVxKQo+IC0JCXJldHVybjsKPiAtCj4g LQlkZXYgPSByZXEtPmVuZ2luZS0+ZGV2Owo+IC0JaWYgKGtyZWZfcHV0X211dGV4KCZyZXEtPnJl ZiwgaTkxNV9nZW1fcmVxdWVzdF9mcmVlLCAmZGV2LT5zdHJ1Y3RfbXV0ZXgpKQo+IC0JCW11dGV4 X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC19Cj4gLQo+ICAgc3RhdGljIGlubGluZSB2 b2lkIGk5MTVfZ2VtX3JlcXVlc3RfYXNzaWduKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq KnBkc3QsCj4gICAJCQkJCSAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc3JjKQo+ICAg ewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDI2MTE4NTI4MWU3OC4uOWI0ODU0YTE3 MjY0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTE0MTMsNiArMTQxMywxMyBA QCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9yZXF1ZXN0X3JldGlyZShzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJbGlzdF9kZWxfaW5pdCgmcmVxdWVzdC0+bGlzdCk7Cj4g ICAJaTkxNV9nZW1fcmVxdWVzdF9yZW1vdmVfZnJvbV9jbGllbnQocmVxdWVzdCk7Cj4KPiArCWlm IChyZXF1ZXN0LT5jdHgpIHsKPiArCQlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKQo+ICsJCQlp bnRlbF9scl9jb250ZXh0X3VucGluKHJlcXVlc3QtPmN0eCwgcmVxdWVzdC0+ZW5naW5lKTsKPiAr Cj4gKwkJaTkxNV9nZW1fY29udGV4dF91bnJlZmVyZW5jZShyZXF1ZXN0LT5jdHgpOwo+ICsJfQo+ ICsKPiAgIAlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHJlcXVlc3QpOwo+ICAgfQo+Cj4g QEAgLTI3MTMsMTggKzI3MjAsNiBAQCB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfZnJlZShzdHJ1Y3Qg a3JlZiAqcmVxX3JlZikKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl cSA9IGNvbnRhaW5lcl9vZihyZXFfcmVmLAo+ICAgCQkJCQkJIHR5cGVvZigqcmVxKSwgcmVmKTsK PiAtCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHggPSByZXEtPmN0eDsKPiAtCj4gLQlpZiAocmVx LT5maWxlX3ByaXYpCj4gLQkJaTkxNV9nZW1fcmVxdWVzdF9yZW1vdmVfZnJvbV9jbGllbnQocmVx KTsKPiAtCj4gLQlpZiAoY3R4KSB7Cj4gLQkJaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKPiAt CQkJaW50ZWxfbHJfY29udGV4dF91bnBpbihjdHgsIHJlcS0+ZW5naW5lKTsKPiAtCj4gLQkJaTkx NV9nZW1fY29udGV4dF91bnJlZmVyZW5jZShjdHgpOwo+IC0JfQo+IC0KPiAgIAlrbWVtX2NhY2hl X2ZyZWUocmVxLT5pOTE1LT5yZXF1ZXN0cywgcmVxKTsKPiAgIH0KPgo+IEBAIC0zMTg2LDcgKzMx ODEsNyBAQCBpOTE1X2dlbV93YWl0X2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQg KmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiAgIAkJCXJldCA9IF9faTkxNV93YWl0X3Jl cXVlc3QocmVxW2ldLCB0cnVlLAo+ICAgCQkJCQkJICBhcmdzLT50aW1lb3V0X25zID4gMCA/ICZh cmdzLT50aW1lb3V0X25zIDogTlVMTCwKPiAgIAkJCQkJCSAgdG9fcnBzX2NsaWVudChmaWxlKSk7 Cj4gLQkJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZV9fdW5sb2NrZWQocmVxW2ldKTsKPiAr CQlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHJlcVtpXSk7Cj4gICAJfQo+ICAgCXJldHVy biByZXQ7Cj4KPiBAQCAtNDE5OSw3ICs0MTk0LDcgQEAgaTkxNV9nZW1fcmluZ190aHJvdHRsZShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gICAJaWYgKHJl dCA9PSAwKQo+ICAgCQlxdWV1ZV9kZWxheWVkX3dvcmsoZGV2X3ByaXYtPndxLCAmZGV2X3ByaXYt Pm1tLnJldGlyZV93b3JrLCAwKTsKPgo+IC0JaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZV9f dW5sb2NrZWQodGFyZ2V0KTsKPiArCWk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2UodGFyZ2V0 KTsKPgo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IGluZGV4IGZmNjAyNDFiMWY3Ni4uZjViZjQ2Zjk5Y2MyIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMTM5OSw3ICsxMTM5OSw3IEBAIHN0YXRpYyB2 b2lkIGludGVsX21taW9fZmxpcF93b3JrX2Z1bmMoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ ICAgCQlXQVJOX09OKF9faTkxNV93YWl0X3JlcXVlc3QobW1pb19mbGlwLT5yZXEsCj4gICAJCQkJ CSAgICBmYWxzZSwgTlVMTCwKPiAgIAkJCQkJICAgICZtbWlvX2ZsaXAtPmk5MTUtPnJwcy5tbWlv ZmxpcHMpKTsKPiAtCQlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlX191bmxvY2tlZChtbWlv X2ZsaXAtPnJlcSk7Cj4gKwkJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShtbWlvX2ZsaXAt PnJlcSk7Cj4gICAJfQo+Cj4gICAJLyogRm9yIGZyYW1lYnVmZmVyIGJhY2tlZCBieSBkbWFidWYs IHdhaXQgZm9yIGZlbmNlICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXggYjdjMjE4 NjAyYzZlLi5lZDM3OTdiZjQxYWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAt NzM2Niw3ICs3MzY2LDcgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9ycHNfYm9vc3Rfd29yayhzdHJ1 Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gICAJCWdlbjZfcnBzX2Jvb3N0KHRvX2k5MTUocmVxLT5l bmdpbmUtPmRldiksIE5VTEwsCj4gICAJCQkgICAgICAgcmVxLT5lbWl0dGVkX2ppZmZpZXMpOwo+ Cj4gLQlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlX191bmxvY2tlZChyZXEpOwo+ICsJaTkx NV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShyZXEpOwo+ICAgCWtmcmVlKGJvb3N0KTsKPiAgIH0K Pgo+CgpJZiBJIGFtIG5vdCB0b28gY2xvc2UgdG8gdGhpczoKClJldmlld2VkLWJ5OiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK