Re: Polymorphic to_i915()

Jani Nikula
2016-04-18T11:49:28Z

On Mon, 18 Apr 2016, Dave Gordon <david.s.gordon@intel.com> wrote:
> The GuC changes are OK, and we might as well convert "dev_priv" to
> "i915" at the same time, if that's now the preferred name.

Hmph, I see that "struct drm_i915_private *i915" is already being used
in a few places. This is more than a little confusing since "struct
i915_params i915" in i915_params.c is also the struct we currently use
to hold the module parameters. Rather annoyingly, there are no warnings
about the module wide i915 being shadowed.

I oppose to having both around. Please figure this out before adding a
single new "struct drm_i915_private *i915".

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center