From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v4 4/6] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission Date: Wed, 20 Apr 2016 16:19:22 +0100 Message-ID: <57179DFA.1060903@intel.com> References: <1460049678-21918-1-git-send-email-david.s.gordon@intel.com> <1460049678-21918-5-git-send-email-david.s.gordon@intel.com> <570E86DF.2050909@intel.com> <570EA232.4080608@intel.com> <570EA87F.3070600@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F1C86EA34 for ; Wed, 20 Apr 2016 15:19:56 +0000 (UTC) In-Reply-To: <570EA87F.3070600@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yu Dai , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDQvMTYgMjE6MTMsIFl1IERhaSB3cm90ZToKPiBPbiAwNC8xMy8yMDE2IDEyOjQ2IFBN LCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gT24gMTMvMDQvMTYgMTg6NTAsIFl1IERhaSB3cm90ZToK Pj4gPgo+PiA+IE9uIDA0LzA3LzIwMTYgMTA6MjEgQU0sIERhdmUgR29yZG9uIHdyb3RlOgo+PiA+ PiBEdXJpbmcgYSBoaWJlcm5hdGUvcmVzdW1lIGN5Y2xlLCB0aGUgd2hvbGUgc3lzdGVtIGlzIHJl c2V0LCBpbmNsdWRpbmcKPj4gPj4gdGhlIEd1QyBhbmQgdGhlIGRvb3JiZWxsIGhhcmR3YXJlLiBU aGVuIHRoZSBzeXN0ZW0gaXMgYm9vdGVkIHVwLAo+PiBkcml2ZXJzCj4+ID4+IGFyZSBsb2FkZWQs IGV0YyAtLSB0aGUgR3VDIGZpcm13YXJlIG1heSBiZSBsb2FkZWQgYW5kIHNldCBydW5uaW5nCj4+ IGF0IHRoaXMKPj4gPj4gcG9pbnQuIEJ1dCB0aGVuLCB0aGUgYm9vdGVkIGtlcm5lbCBpcyByZXBs YWNlZCBieSB0aGUgaGliZXJuYXRlZAo+PiBpbWFnZSwKPj4gPj4gYW5kIHRoaXMgcmVzdW1lZCBr ZXJuZWwgd2lsbCBhbHNvIHRyeSB0byByZWxvYWQgdGhlIEd1QyBmaXJtd2FyZQo+PiAod2hpY2gK Pj4gPj4gd2lsbCBmYWlsKS4gVG8gcmVjb3Zlciwgd2UgcmVzZXQgdGhlIEd1QyBhbmQgdHJ5IGFn YWluICh3aGljaCBzaG91bGQKPj4gPj4gd29yaykuIEJ1dCB0aGlzIEd1QyByZXNldCBkb2Vzbid0 IGFsc28gcmVzZXQgdGhlIGRvb3JiZWxsIGhhcmR3YXJlLCBzbwo+PiA+PiBpdCBjYW4gYmUgbGVm dCBpbiBhIHN0YXRlIGluY29uc2lzdGVudCB3aXRoIHRoYXQgYXNzdW1lZCBieSB0aGUgZHJpdmVy Cj4+ID4+IGFuZCB0aGUgR3VDLgo+PiA+Pgo+PiA+PiBJdCB3b3VsZCBiZSBiZXR0ZXIgaWYgdGhl IEd1QyByZXNldCBhbHNvIGNsZWFyZWQgYWxsIGRvb3JiZWxsIHN0YXRlLAo+PiA+PiBidXQgdGhh dCdzIG5vdCBob3cgdGhlIGhhcmR3YXJlIGN1cnJlbnRseSB3b3JrczsgYWxzbywgdGhlIGRyaXZl cgo+PiBjYW5ub3QKPj4gPj4gZGlyZWN0bHkgcmVwcm9ncmFtIHRoZSBkb29yYmVsbCBoYXJkd2Fy ZSAob25seSB0aGUgR3VDIGNhbiBkbyB0aGF0KS4KPj4gPj4KPj4gPj4gU28gdGhpcyBwYXRjaCBj eWNsZXMgdGhyb3VnaCBhbGwgZG9vcmJlbGxzLCBhc3NpZ25pbmcgYW5kIHJlbGVhc2luZwo+PiBl YWNoCj4+ID4+IGluIHR1cm4sIHNvIHRoYXQgYWxsIHRoZSBkb29yYmVsbCBoYXJkd2FyZSBpcyBs ZWZ0IGluIGEgY29uc2lzdGVudAo+PiBzdGF0ZSwKPj4gPj4gbm8gbWF0dGVyIGhvdyBpdCB3YXMg cHJvZ3JhbW1lZCBieSB0aGUgcHJldmlvdXNseS1ydW5uaW5nIGtlcm5lbAo+PiBhbmQvb3IKPj4g Pj4gR3VDIGZpcm13YXJlLgo+PiA+Pgo+PiA+PiBUaGlzIHBhdGNoIGNhbiBiZSByZW1vdmVkIGlm L3doZW4gdGhlIEd1QyBmaXJtd2FyZSBpcyB1cGRhdGVkIHNvCj4+IHRoYXQgaXQKPj4gPj4gKHJl KWluaXRpYWxpc2VzIHRoZSBkb29yYmVsbCBoYXJkd2FyZSBhZnRlciBldmVyeSBmaXJtd2FyZSAo cmUpbG9hZC4KPj4gPj4KPj4gPj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMu Z29yZG9uQGludGVsLmNvbT4KPj4gPj4gLS0tCj4+ID4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgNDYKPj4gPj4gKysrKysrKysrKysrKysrKysrKysrKysr KysrKystCj4+ID4+ICAgMSBmaWxlIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKPj4gPj4KPj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z3VjX3N1Ym1pc3Npb24uYwo+PiA+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1 Ym1pc3Npb24uYwo+PiA+PiBpbmRleCAyZmM2OWYxLi5mNDY2ZWFiIDEwMDY0NAo+PiA+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+ID4+IEBAIC03MDcs NiArNzA3LDUwIEBAIHN0YXRpYyB2b2lkIGd1Y19jbGllbnRfZnJlZShzdHJ1Y3QgZHJtX2Rldmlj ZQo+PiAqZGV2LAo+PiA+PiAgICAgICBrZnJlZShjbGllbnQpOwo+PiA+PiAgIH0KPj4gPj4gKy8q Cj4+ID4+ICsgKiBCb3Jyb3cgdGhlIGZpcnN0IGNsaWVudCB0byBzZXQgdXAgJiB0ZWFyIGRvd24g ZXZlcnkgZG9vcmJlbGwKPj4gPj4gKyAqIGluIHR1cm4sIHRvIGVuc3VyZSB0aGF0IGFsbCBkb29y YmVsbCBoL3cgaXMgKHJlKWluaXRpYWxpc2VkLgo+PiA+PiArICovCj4+ID4+ICtzdGF0aWMgdm9p ZCBndWNfaW5pdF9kb29yYmVsbF9odyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4+ID4+ICt7Cj4+ ID4+ICsgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUo Z3VjKTsKPj4gPj4gKyAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQgPSBndWMtPmV4 ZWNidWZfY2xpZW50Owo+PiA+PiArICAgIHN0cnVjdCBndWNfZG9vcmJlbGxfaW5mbyAqZG9vcmJl bGw7Cj4+ID4+ICsgICAgdWludDE2X3QgZGJfaWQsIGk7Cj4+ID4+ICsgICAgdm9pZCAqYmFzZTsK Pj4gPj4gKyAgICBpbnQgcmV0Owo+PiA+PiArCj4+ID4+ICsgICAgYmFzZSA9Cj4+IGttYXBfYXRv bWljKGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZShjbGllbnQtPmNsaWVudF9vYmosIDApKTsKPj4g Pj4gKyAgICBkb29yYmVsbCA9IGJhc2UgKyBjbGllbnQtPmRvb3JiZWxsX29mZnNldDsKPj4gPj4g KyAgICBkYl9pZCA9IGNsaWVudC0+ZG9vcmJlbGxfaWQ7Cj4+ID4+ICsKPj4gPj4gKyAgICBmb3Ig KGkgPSAwOyBpIDwgR1VDX01BWF9ET09SQkVMTFM7ICsraSkgewo+PiA+PiArICAgICAgICBpOTE1 X3JlZ190IGRyYnJlZyA9IEdFTjhfRFJCUkVHTChpKTsKPj4gPj4gKyAgICAgICAgdTMyIHZhbHVl ID0gSTkxNV9SRUFEKGRyYnJlZyk7Cj4+ID4+ICsKPj4gPj4gKyAgICAgICAgcmV0ID0gZ3VjX3Vw ZGF0ZV9kb29yYmVsbF9pZChjbGllbnQsIGRvb3JiZWxsLCBpKTsKPj4gPj4gKwo+PiA+PiArICAg ICAgICBpZiAoKCh2YWx1ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSAmJiAoaSAhPSBkYl9pZCkp IHx8IHJldCkKPj4gPj4gKyAgICAgICAgICAgIERSTV9ERUJVR19EUklWRVIoIkRvb3JiZWxsIHJl ZyAweCV4IHdhcyAweCV4LCByZXQgJWRcbiIsCj4+ID4+ICsgICAgICAgICAgICAgICAgZHJicmVn LnJlZywgdmFsdWUsIHJldCk7Cj4+ID4+ICsgICAgfQo+PiA+PiArCj4+ID4+ICsgICAgLyogUmVz dG9yZSB0byBvcmlnaW5hbCB2YWx1ZSAqLwo+PiA+PiArICAgIGd1Y191cGRhdGVfZG9vcmJlbGxf aWQoY2xpZW50LCBkb29yYmVsbCwgZGJfaWQpOwo+PiA+PiArCj4+ID4+ICsgICAgZm9yIChpID0g MDsgaSA8IEdVQ19NQVhfRE9PUkJFTExTOyArK2kpIHsKPj4gPj4gKyAgICAgICAgaTkxNV9yZWdf dCBkcmJyZWcgPSBHRU44X0RSQlJFR0woaSk7Cj4+ID4+ICsgICAgICAgIHUzMiB2YWx1ZSA9IEk5 MTVfUkVBRChkcmJyZWcpOwo+PiA+PiArCj4+ID4+ICsgICAgICAgIGlmICgodmFsdWUgJiBHVUNf RE9PUkJFTExfRU5BQkxFRCkgJiYgKGkgIT0gZGJfaWQpKQo+PiA+PiArICAgICAgICAgICAgRFJN X0RFQlVHX0RSSVZFUigiRG9vcmJlbGwgcmVnIDB4JXggZmluYWxseSAweCV4XG4iLAo+PiA+PiAr ICAgICAgICAgICAgICAgICAgICAgICAgZHJicmVnLnJlZywgdmFsdWUpOwo+PiA+PiArCj4+ID4+ ICsgICAgfQo+PiA+PiArCj4+ID4KPj4gPiBUaGUgZm9yIGxvb3AgYWJvdmUgaXMgbm90IG5lZWRl ZC4gSXQgY2FuIGJlIG1lcmdlZCBpbnRvIHByZXZpb3VzCj4+IGxvb3AgYnkKPj4gPiBwcmludCBv dXQgbmV3IGRyYnJlZyB2YWx1ZSAocmVhZCBpdCBhZ2FpbiBhZnRlciB1cGRhdGVfZG9vcmJlbGxf aWQpLgo+PiA+Cj4+ID4gQXQgdGhpcyBwb2ludCwgb25seSBuZWVkIHRvIGNoZWNrIGlmIGRiX2lk IGlzIGNvcnJlY3RseSBlbmFibGVkIG9yIG5vdAo+PiA+IGJ5IHByaW50IG91dCBJOTE1X1JFQUQo R0VOOF9EUkJSRUdMKGRiX2lkKSkuCj4+ID4KPj4gPiBBbGV4Cj4+Cj4+IE5vLCB0aGUgaWRlYSBp cyBub3QgdG8gY2hlY2sgdGhhdCB0aGUgR3VDIGNhbGwgaGFzICplbmFibGVkKiBlYWNoCj4+IHNl bGVjdGVkIGRvb3JiZWxsLCBidXQgdG8gY2hlY2sgdGhhdCBhZnRlciB0aGUgZW5kIG9mIHRoZSBm aXJzdCBsb29wLAo+PiBhbmQgdGhlIHN1YnNlcXVlbnQgcmVzdG9yZSwgYWxsICpvdGhlciogZG9v cmJlbGxzIGhhdmUgYmVlbiAqZGlzYWJsZWQqLgo+PiBXZSdyZSBvbmx5ICpzZWxlY3RpbmcqIGVh Y2ggZG9vcmJlbGwgc28gdGhhdCB3ZSBjYW4gdGhlbiAqZGVzZWxlY3QqIGl0Cj4+IGFzIGEgc2lk ZSBlZmZlY3Qgb2Ygc2VsZWN0aW5nIHRoZSBuZXh0IG9uZSEKPj4KPj4gSGVuY2Ugc2VwYXJhdGUg bG9vcCByZXF1aXJlZCAuLi4KPj4KPj4gLkRhdmUuCj4KPiBUaGlzIHN0aWxsIGNhbiBiZSBkb25l IGJ5IGJhY2t1cCBvZiBwcmV2aW91cyBjbGllbnQtPmRvb3JiZWxsX2lkLiBJZiBpdAo+IGlzIG5v dCBzYW1lIGFzIHRoZSBkZXNpcmVkIGRiX2lkLCB0aGVuIG1ha2Ugc3VyZSBpdCBpcyAqZGlzYWJs ZWQqIGFmdGVyCj4gdGhlIHVwZGF0ZS4KCk5vLCBJIGFsc28gd2FudCB0byBjaGVjayB0aGF0IHRo ZXJlJ3Mgbm8gY3Jvc3N0YWxrLCBzbyB0aGF0IGFmdGVyIGhhdmluZyAKc3dlcHQgdGhlIGVudGly ZSBzcGFjZSwgdGhlcmUncyBleGFjdGx5IE9ORSBkb29yYmVsbCBlbmFibGVkLCBhbmQgaXQncyAK dGhlIG9uZSB3ZSBtb3N0IHJlY2VudGx5IGFzc29jaWF0ZWQgd2l0aCB0aGUgY2xpZW50LgoKPiBU aGUgcmVhbCBwcm9ibGVtIGhlcmUsIGF0IGxlYXN0IG5vdCBmb3Igbm93LCBpcyB0aGF0IGl0IGFz c3VtZXMgdGhlcmUgaXMKPiBvbmx5IG9uZSBndWNfY2xpZW50LiBJbiBmdXR1cmUsIGlmIHRoZXJl IGlzIHVzZXIgY3JlYXRlZCBndWNfY2xpZW50LCB0aGUKPiBjb2RlIGRvZXNuJ3QgcmVzdG9yZSBk b29yYmVsbCBmb3IgaXQuCj4KPiBBbGV4CgpCeSBkZWZpbml0aW9uIHRoZXJlIGlzIG9ubHkgb25l IChuZXdseS1jcmVhdGVkKSBjbGllbnQgYXQgdGhlIHBvaW50IAp3aGVyZSB0aGlzIGlzIGNhbGxl ZC4gSSdkIGhhdmUgZG9uZSB0aGlzIGZpcnN0LCBidXQgd2UgbmVlZCBhIGNsaWVudCBmb3IgCnRh bGtpbmcgdG8gdGhlIEd1QyEgQW55IGFkZGl0aW9uYWwgY2xpZW50cyAoZS5nLiBmb3IgcHJlZW1w dGlvbikgd2lsbCBiZSAKY3JlYXRlZCBhZnRlcndhcmRzLgoKVGhpcyBlbnRpcmUgZnVuY3Rpb24g d291bGRuJ3QgYmUgbmVjZXNzYXJ5IGlmIHRoZSBHdUMgd291bGQgZ3VhcmFudGVlIHRvIApjbGVh ciBhbGwgZG9vcmJlbGxzIGF0IHN0YXJ0dXAsIG9yIGlmIHRoZSBoYXJkd2FyZSBwcm92aWRlIGEg UkVTRVQgCnNpZ25hbCBmb3IgdGhlIGRvb3JiZWxsIGJsb2NrIDooCgpCVFcgdGhlIHBlcnNpc3Rl bnQta21hcCBwYXRjaCBzaG91bGQgYmUgbWVyZ2VkIHRvZGF5LCBzbyBJJ2xsIGhhdmUgdG8gCnVw ZGF0ZSB0aGUgYWJvdmUgdG8gZ2V0IHJpZCBvZiB0aGUga21hcF9hdG9taWMoKSBhYm92ZS4KCi5E YXZlLgoKPj4gPj4gKyAgICBrdW5tYXBfYXRvbWljKGJhc2UpOwo+PiA+PiArfQo+PiA+PiArCj4+ ID4+ICAgLyoqCj4+ID4+ICAgICogZ3VjX2NsaWVudF9hbGxvYygpIC0gQWxsb2NhdGUgYW4gaTkx NV9ndWNfY2xpZW50Cj4+ID4+ICAgICogQGRldjogICAgZHJtIGRldmljZQo+PiA+PiBAQCAtOTcx LDggKzEwMTUsOCBAQCBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9lbmFibGUoc3RydWN0IGRybV9k ZXZpY2UKPj4gPj4gKmRldikKPj4gPj4gICAgICAgfQo+PiA+PiAgICAgICBndWMtPmV4ZWNidWZf Y2xpZW50ID0gY2xpZW50Owo+PiA+PiAtCj4+ID4+ICAgICAgIGhvc3QyZ3VjX3NhbXBsZV9mb3Jj ZXdha2UoZ3VjLCBjbGllbnQpOwo+PiA+PiArICAgIGd1Y19pbml0X2Rvb3JiZWxsX2h3KGd1Yyk7 Cj4+ID4+ICAgICAgIHJldHVybiAwOwo+PiA+PiAgIH0KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=