From: John Harrison <John.C.Harrison@Intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [PATCH v7 2/8] drm/i915: Removed now redudant parameter to i915_gem_request_completed()
Date: Thu, 21 Apr 2016 11:18:26 +0100 [thread overview]
Message-ID: <5718A8F2.5090304@Intel.com> (raw)
In-Reply-To: <57187F12.4050101@linux.intel.com>
On 21/04/2016 08:19, Maarten Lankhorst wrote:
> Typo in subject (redundant). ^
>
> Op 20-04-16 om 19:09 schreef John.C.Harrison@Intel.com:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The change to the implementation of i915_gem_request_completed() means
>> that the lazy coherency flag is no longer used. This can now be
>> removed to simplify the interface.
>>
>> v6: Updated to newer nightly and resolved conflicts.
>>
>> v7: Updated to newer nightly (lots of ring -> engine renaming).
>>
> I think it would be more readable to put this patch as preparation for patch 1.
>
> ~Maarten
I can't be prep for patch one. It is a result of patch one that the
parameter is redundant and can be removed. It can't be removed before
the patch that makes it redundant! It could be squashed into that patch
but earlier comments have been that it is best to not do too much in a
single patch.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-21 10:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 17:09 [PATCH v7 0/8] Convert requests to use struct fence John.C.Harrison
2016-04-20 17:09 ` [PATCH v7 1/8] drm/i915: " John.C.Harrison
2016-04-21 7:06 ` Maarten Lankhorst
2016-04-21 10:26 ` John Harrison
2016-04-21 11:12 ` Maarten Lankhorst
2016-04-21 7:09 ` Maarten Lankhorst
2016-04-20 17:09 ` [PATCH v7 2/8] drm/i915: Removed now redudant parameter to i915_gem_request_completed() John.C.Harrison
2016-04-21 7:19 ` Maarten Lankhorst
2016-04-21 10:18 ` John Harrison [this message]
2016-04-20 17:09 ` [PATCH v7 3/8] drm/i915: Add per context timelines to fence object John.C.Harrison
2016-04-20 17:44 ` Chris Wilson
2016-04-21 11:37 ` John Harrison
2016-04-20 17:09 ` [PATCH v7 4/8] drm/i915: Fix clean up of file client list on execbuff failure John.C.Harrison
2016-04-21 7:20 ` Maarten Lankhorst
2016-04-21 10:15 ` John Harrison
2016-04-20 17:09 ` [PATCH v7 5/8] drm/i915: Delay the freeing of requests until retire time John.C.Harrison
2016-04-21 7:41 ` Maarten Lankhorst
2016-04-20 17:09 ` [PATCH v7 6/8] drm/i915: Interrupt driven fences John.C.Harrison
2016-04-21 7:38 ` Maarten Lankhorst
2016-04-20 17:09 ` [PATCH v7 7/8] drm/i915: Updated request structure tracing John.C.Harrison
2016-04-20 17:09 ` [PATCH v7 8/8] drm/i915: Cache last IRQ seqno to reduce IRQ overhead John.C.Harrison
2016-04-22 15:37 ` [PATCH v7 0/8] Convert requests to use struct fence John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5718A8F2.5090304@Intel.com \
--to=john.c.harrison@intel.com \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).