From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 4/4] drm/i915: Simplify i915_gem_obj_ggtt_bound_view Date: Fri, 22 Apr 2016 11:54:33 +0100 Message-ID: <571A02E9.1020108@intel.com> References: <1461240286-25968-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1461240286-25968-4-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id D2E0A6E2C8 for ; Fri, 22 Apr 2016 10:54:43 +0000 (UTC) In-Reply-To: <1461240286-25968-4-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-Id: intel-gfx@lists.freedesktop.org T24gMjEvMDQvMTYgMTM6MDQsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBDYW4gdXNlIHRoZSBuZXcgdm1h LT5pc19ndHQgdG8gc2ltcGxpZnkgdGhlIGNoZWNrIGFuZAo+IGdldCByaWQgb2YgdGhlIGxvY2Fs IHZhcmlhYmxlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz dWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j IHwgNCArLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25z KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCAxMzVlMWU5YzQwYzIuLmM1Y2E1 M2QyZTM1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC01Mjc1LDEyICs1Mjc1 LDEwIEBAIGJvb2wgaTkxNV9nZW1fb2JqX2JvdW5kKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvLAo+ICAgYm9vbCBpOTE1X2dlbV9vYmpfZ2d0dF9ib3VuZF92aWV3KHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvLAo+ICAgCQkJCSAgY29uc3Qgc3RydWN0IGk5MTVfZ2d0dF92aWV3ICp2 aWV3KQo+ICAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShvLT5iYXNlLmRldik7Cj4gLQlzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0ID0gJmRldl9wcml2LT5n Z3R0Owo+ICAgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+Cj4gICAJbGlzdF9mb3JfZWFjaF9lbnRy eSh2bWEsICZvLT52bWFfbGlzdCwgb2JqX2xpbmspCj4gLQkJaWYgKHZtYS0+dm0gPT0gJmdndHQt PmJhc2UgJiYKPiArCQlpZiAodm1hLT5pc19nZ3R0ICYmCj4gICAJCSAgICBpOTE1X2dndHRfdmll d19lcXVhbCgmdm1hLT5nZ3R0X3ZpZXcsIHZpZXcpICYmCj4gICAJCSAgICBkcm1fbW1fbm9kZV9h bGxvY2F0ZWQoJnZtYS0+bm9kZSkpCj4gICAJCQlyZXR1cm4gdHJ1ZTsKPgoKRm9yIHBhdGNoZXMg Mi00LApSZXZpZXdlZC1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4K CkFzIHRoZXNlIHRocmVlIGFsbCBub3cgY29udGFpbgoJaWYgKHZtYS0+aXNfZ2d0dCAmJgoJICAg IGk5MTVfZ2d0dF92aWV3X2VxdWFsKCZ2bWEtPmdndHRfdmlldywgdmlldykKCSAgICAuLi4KYW5k IHRoZXNlIGFyZSB0aGUgT05MWSB0aHJlZSB1c2VzIG9mIGk5MTVfZ2d0dF92aWV3X2VxdWFsKCks IHBlcmhhcHMKdGhlIGxhdHRlciBjb3VsZCBiZSBkZWxldGVkIGZyb20gdGhlIGhlYWRlciBmaWxl IGFuZCByZXBsYWNlZCBieSBhIGxvY2FsIAooc3RhdGljKSBpbmxpbmUgdGhhdCBlbmNhcHN1bGF0 ZXMgdGhlIGlzX2dndHQgdGVzdCBhcyB3ZWxsPwoKVGhlIENvY2NpIHNjcmlwdCBiZWxvdyBmb3Vu ZCBvbmUgbW9yZSBjYW5kaWRhdGUgZm9yIHVwZGF0aW5nOgoKLS0tIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5jCisrKyBjb2NjaS1vdXRwdXQtMjQ2ODEtMmYyZTNiLWk5MTVfZ2Vt X2d0dC5jCkBAIC0zMjU1LDcgKzMyNTUsNyBAQCB2b2lkIGk5MTVfZ2VtX3Jlc3RvcmVfZ3R0X21h cHBpbmdzKHN0cnVjCiAgCWxpc3RfZm9yX2VhY2hfZW50cnkob2JqLCAmZGV2X3ByaXYtPm1tLmJv dW5kX2xpc3QsIGdsb2JhbF9saXN0KSB7CiAgCQlmbHVzaCA9IGZhbHNlOwogIAkJbGlzdF9mb3Jf ZWFjaF9lbnRyeSh2bWEsICZvYmotPnZtYV9saXN0LCBvYmpfbGluaykgewotCQkJaWYgKHZtYS0+ dm0gIT0gJmdndHQtPmJhc2UpCisJCQlpZiAoIXZtYS0+aXNfZ2d0dCkKICAJCQkJY29udGludWU7 CgpDb2NjaToKQGlzX2dndHRACiAgIGlkZXhwcmVzc2lvbiBzdHJ1Y3QgaTkxNV9nZ3R0ICpHR1RU OwogICBpZGV4cHJlc3Npb24gc3RydWN0IGk5MTVfdm1hICpWTUE7CkBACiAgIHsKICAgICA8Li4u Ci0gICAgIFZNQS0+dm0gPT0gJkdHVFQtPmJhc2UKKyAgICAgVk1BLT5pc19nZ3R0CiAgICAgLi4u PgogICB9CgpAbm90X2dndHRACiAgIGlkZXhwcmVzc2lvbiBzdHJ1Y3QgaTkxNV9nZ3R0ICpHR1RU OwogICBpZGV4cHJlc3Npb24gc3RydWN0IGk5MTVfdm1hICpWTUE7CkBACiAgIHsKICAgICA8Li4u Ci0gICAgIFZNQS0+dm0gIT0gJkdHVFQtPmJhc2UKKyAgICAgIVZNQS0+aXNfZ2d0dAogICAgIC4u Lj4KICAgfQoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=