From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Propagate error from drm_gem_object_init() Date: Fri, 22 Apr 2016 12:59:43 +0100 Message-ID: <571A122F.7000109@intel.com> References: <1461322677-20728-1-git-send-email-matthew.auld@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id DB1E86EEB3 for ; Fri, 22 Apr 2016 11:59:44 +0000 (UTC) In-Reply-To: <1461322677-20728-1-git-send-email-matthew.auld@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Chris Wilson List-Id: intel-gfx@lists.freedesktop.org T24gMjIvMDQvMTYgMTE6NTcsIE1hdHRoZXcgQXVsZCB3cm90ZToKPiBGcm9tOiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPgo+IFByb3BhZ2F0ZSB0aGUgcmVhbCBlcnJv ciBmcm9tIGRybV9nZW1fb2JqZWN0X2luaXQoKS4gTm90ZSB0aGlzIGFsc28KPiBmaXhlcyBzb21l IGNvbmZ1c2lvbiBpbiB0aGUgZXJyb3IgcmV0dXJuIGZyb20gaTkxNV9nZW1fYWxsb2Nfb2JqZWN0 Li4uCj4KPiB2MjoKPiAoTWF0dGhldyBBdWxkKQo+ICAgIC0gdXBkYXRlZCBuZXcgdXNlcnMgb2Yg Z2VtX2FsbG9jX29iamVjdCBmcm9tIGxhdGVzdCBkcm0tbmlnaHRseQo+ICAgIC0gcmVwbGFjZWQg b2NjdXJyZW5jZXMgb2YgSVNfRVJSX09SX05VTEwoKSB3aXRoIElTX0VSUigpCj4gdjM6Cj4gKEpv b25hcyBMYWh0aW5lbikKPiAgICAtIGZpeCBkb3VibGUgIkZyb206IiBpbiBjb21taXQgbWVzc2Fn ZQo+ICAgIC0gYWRkIGdvdG8gdGVhcmRvd24gcGF0aAo+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dGhl dyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFJldmlld2VkLWJ5OiBKb29uYXMgTGFo dGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgICAgICB8IDIxICsrKysrKysrKysrKyst LS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fYmF0Y2hfcG9vbC5jICAg fCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgICAg ICB8ICA0ICsrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlbmRlcl9zdGF0 ZS5jIHwgIDcgKysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlz c2lvbi5jICAgfCAgMiArLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j ICAgICAgICAgfCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5j ICAgICAgICAgICB8ICA0ICsrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j ICAgICAgICAgICAgIHwgMTAgKysrKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfb3ZlcmxheS5jICAgICAgICAgfCAgMiArLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcmluZ2J1ZmZlci5jICAgICAgfCAxOSArKysrKysrKysrLS0tLS0tLS0tCj4gICAxMCBmaWxl cyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+IGluZGV4IDI2MWEzZWYuLmM2YzE3ZGQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPiBAQCAtMzgyLDggKzM4Miw4IEBAIGk5MTVfZ2VtX2NyZWF0ZShzdHJ1Y3Qg ZHJtX2ZpbGUgKmZpbGUsCj4KPiAgIAkvKiBBbGxvY2F0ZSB0aGUgbmV3IG9iamVjdCAqLwo+ICAg CW9iaiA9IGk5MTVfZ2VtX2FsbG9jX29iamVjdChkZXYsIHNpemUpOwo+IC0JaWYgKG9iaiA9PSBO VUxMKQo+IC0JCXJldHVybiAtRU5PTUVNOwo+ICsJaWYgKElTX0VSUihvYmopKQo+ICsJCXJldHVy biBQVFJfRVJSKG9iaik7Cj4KPiAgIAlyZXQgPSBkcm1fZ2VtX2hhbmRsZV9jcmVhdGUoZmlsZSwg Jm9iai0+YmFzZSwgJmhhbmRsZSk7Cj4gICAJLyogZHJvcCByZWZlcmVuY2UgZnJvbSBhbGxvY2F0 ZSAtIGhhbmRsZSBob2xkcyBpdCBub3cgKi8KPiBAQCAtNDQ5OCwxNSArNDQ5OCwxNSBAQCBzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqaTkxNV9nZW1fYWxsb2Nfb2JqZWN0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAgIAlz dHJ1Y3QgYWRkcmVzc19zcGFjZSAqbWFwcGluZzsKPiAgIAlnZnBfdCBtYXNrOwo+ICsJaW50IHJl dDsKPgo+ICAgCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9hbGxvYyhkZXYpOwo+ICAgCWlmIChvYmog PT0gTlVMTCkKPiAtCQlyZXR1cm4gTlVMTDsKPiArCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsK ClRoZSB0d28gY2hhbmdlcyBhYm92ZSBsb29rZWQgcmVhbGx5IHJlYWxseSBjb25mdXNpbmcsIHdo ZXJlIG9uZSB0ZXN0cyAKdGhlIHJldHVybmVkIHBvaW50ZXIgYW5kIHJldHVybnMgaXQgaWYgaXQn cyBhbiBFUlJfUFRSLCBhbmQgdGhlIG90aGVyIAp0ZXN0cyBmb3IgTlVMTCBhbmQgcmV0dXJucyBF UlJfUFRSKC1FTk9NRU0pLgoKVGhlbiBJIHJlYWxpc2VkIG9uZSB3YXMgaTkxNV9nZW1fYWxsb2Nf b2JqZWN0KCkgYW5kIHRoZSBvdGhlciB3YXMgCmk5MTVfZ2VtX29iamVjdF9hbGxvYygpIQoKQ2Fu IHdlIHBsZWFzZSBnZXQgcmlkIG9mIG9uZSBvciB0aGUgb3RoZXI/IFNpbmNlIHdlIGdlbmVyYWxs eSB1c2UgCnN1YnN5c3RlbV9jbGFzc19hY3Rpb24gbmFtaW5nLCBJJ2Qgc3VnZ2VzdCBrZWVwaW5n ICh0aGUgbG93LWxldmVsIAptZW1vcnktYWxsb2NhdG9yKSBpOTE1X2dlbV9vYmplY3RfYWxsb2Mo KSwgYW5kIHJlbmFtaW5nIHRoZSBoaWdoLWxldmVsIAppOTE1X2dlbV9hbGxvY19vYmplY3QoKSB0 byBpOTE1X2dlbV9vYmplY3RfY3JlYXRlKCkgb3Igc2ltaWxhci4KCj4gLQlpZiAoZHJtX2dlbV9v YmplY3RfaW5pdChkZXYsICZvYmotPmJhc2UsIHNpemUpICE9IDApIHsKPiAtCQlpOTE1X2dlbV9v YmplY3RfZnJlZShvYmopOwo+IC0JCXJldHVybiBOVUxMOwo+IC0JfQo+ICsJcmV0ID0gZHJtX2dl bV9vYmplY3RfaW5pdChkZXYsICZvYmotPmJhc2UsIHNpemUpOwo+ICsJaWYgKHJldCkKPiArCQln b3RvIGZhaWw7Cj4KPiAgIAltYXNrID0gR0ZQX0hJR0hVU0VSIHwgX19HRlBfUkVDTEFJTUFCTEU7 Cj4gICAJaWYgKElTX0NSRVNUTElORShkZXYpIHx8IElTX0JST0FEV0FURVIoZGV2KSkgewo+IEBA IC00NTQzLDYgKzQ1NDMsMTEgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmk5MTVfZ2Vt X2FsbG9jX29iamVjdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAgCXRyYWNlX2k5MTVfZ2Vt X29iamVjdF9jcmVhdGUob2JqKTsKCk9oIGFuZCBCVFcgaTkxNV9nZW1fYWxsb2Nfb2JqZWN0KCkg YWxyZWFkeSBjYWxscyBpdHNlbGYgCmk5MTVfZ2VtX29iamVjdF9jcmVhdGUoKSBpbiB0cmFjZSBt ZXNzYWdlcyEKCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK