* [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
@ 2016-04-22 8:46 tim.gore
2016-04-22 10:53 ` ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: tim.gore @ 2016-04-22 8:46 UTC (permalink / raw)
To: intel-gfx
From: Tim Gore <tim.gore@intel.com>
This patch applies a performance enhancement workaround
based on analysis of DX and OCL S-Curve workloads. We
increase the General Priority Credits for L3SQ from the
hardware default of 56 to the max value 62, and decrease
the High Priority credits from 8 to 2.
v2: Only apply to B0 onwards
v3: Move w/a to per engine init, ie bxt_init_workarounds
Signed-off-by: Tim Gore <tim.gore@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index c21b71c..efd36c3 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6074,6 +6074,7 @@ enum skl_disp_power_wells {
#define GEN8_L3SQCREG1 _MMIO(0xB100)
#define BDW_WA_L3SQCREG1_DEFAULT 0x784000
+#define BXT_WA_L3SQCREG1_DEFAULT 0xF84000
#define GEN7_L3CNTLREG1 _MMIO(0xB01C)
#define GEN7_WA_FOR_GEN7_L3_CONTROL 0x3C47FF8C
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 245386e..f6e8e7e 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1180,6 +1180,10 @@ static int bxt_init_workarounds(struct intel_engine_cs *engine)
return ret;
}
+ /* WaProgramL3SqcReg1DefaultForPerf:bxt */
+ if (IS_BXT_REVID(dev, BXT_REVID_B0, REVID_FOREVER))
+ I915_WRITE(GEN8_L3SQCREG1, BXT_WA_L3SQCREG1_DEFAULT);
+
return 0;
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
2016-04-22 8:46 [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf tim.gore
@ 2016-04-22 10:53 ` Patchwork
2016-04-22 11:55 ` Patchwork
2016-04-24 6:23 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-04-22 10:53 UTC (permalink / raw)
To: tim.gore; +Cc: intel-gfx
== Series Details ==
Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
URL : https://patchwork.freedesktop.org/series/5990/
State : warning
== Summary ==
Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
http://patchwork.freedesktop.org/api/1.0/series/5990/revisions/4/mbox/
Test gem_busy:
Subgroup basic-blt:
skip -> PASS (bsw-nuc-2)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ilk-hp8440p) UNSTABLE
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-b:
pass -> DMESG-WARN (snb-dellxps)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (hsw-gt2)
pass -> SKIP (bdw-nuci7)
bdw-nuci7 total:193 pass:180 dwarn:0 dfail:0 fail:0 skip:13
bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
hsw-brixbox total:193 pass:169 dwarn:0 dfail:0 fail:0 skip:24
hsw-gt2 total:193 pass:173 dwarn:1 dfail:0 fail:0 skip:19
ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57
ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:193 pass:154 dwarn:1 dfail:0 fail:0 skip:38
snb-x220t total:193 pass:155 dwarn:0 dfail:0 fail:1 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_1989/
d5b5101bd09a7b7e48b1cd78fe8f8a40b21d4deb drm-intel-nightly: 2016y-04m-21d-16h-37m-06s UTC integration manifest
441386e drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
2016-04-22 8:46 [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf tim.gore
2016-04-22 10:53 ` ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) Patchwork
@ 2016-04-22 11:55 ` Patchwork
2016-04-24 6:23 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-04-22 11:55 UTC (permalink / raw)
To: tim.gore; +Cc: intel-gfx
== Series Details ==
Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
URL : https://patchwork.freedesktop.org/series/5990/
State : warning
== Summary ==
Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
http://patchwork.freedesktop.org/api/1.0/series/5990/revisions/4/mbox/
Test gem_busy:
Subgroup basic-blt:
skip -> PASS (bsw-nuc-2)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ilk-hp8440p) UNSTABLE
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-b:
pass -> DMESG-WARN (snb-dellxps)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (hsw-gt2)
pass -> SKIP (bdw-nuci7)
bdw-nuci7 total:193 pass:180 dwarn:0 dfail:0 fail:0 skip:13
bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
hsw-brixbox total:193 pass:169 dwarn:0 dfail:0 fail:0 skip:24
hsw-gt2 total:193 pass:173 dwarn:1 dfail:0 fail:0 skip:19
ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57
ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:193 pass:154 dwarn:1 dfail:0 fail:0 skip:38
snb-x220t total:193 pass:155 dwarn:0 dfail:0 fail:1 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_1989/
d5b5101bd09a7b7e48b1cd78fe8f8a40b21d4deb drm-intel-nightly: 2016y-04m-21d-16h-37m-06s UTC integration manifest
441386e drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
2016-04-22 8:46 [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf tim.gore
2016-04-22 10:53 ` ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) Patchwork
2016-04-22 11:55 ` Patchwork
@ 2016-04-24 6:23 ` Patchwork
2016-04-25 9:09 ` Tvrtko Ursulin
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-04-24 6:23 UTC (permalink / raw)
To: tim.gore; +Cc: intel-gfx
== Series Details ==
Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
URL : https://patchwork.freedesktop.org/series/5990/
State : success
== Summary ==
Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
http://patchwork.freedesktop.org/api/1.0/series/5990/revisions/4/mbox/
bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57
ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:193 pass:155 dwarn:0 dfail:0 fail:0 skip:38
Results at /archive/results/CI_IGT_test/Patchwork_2028/
340c485ad98d0ec0369a3b18d4a09938f3f5537d drm-intel-nightly: 2016y-04m-22d-17h-32m-25s UTC integration manifest
22517b8 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
2016-04-24 6:23 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2016-04-25 9:09 ` Tvrtko Ursulin
0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2016-04-25 9:09 UTC (permalink / raw)
To: intel-gfx, tim.gore
On 24/04/16 07:23, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)
> URL : https://patchwork.freedesktop.org/series/5990/
> State : success
>
> == Summary ==
>
> Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
> http://patchwork.freedesktop.org/api/1.0/series/5990/revisions/4/mbox/
>
>
> bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
> bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
> byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
> ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57
> ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
> skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
> skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
> snb-dellxps total:193 pass:155 dwarn:0 dfail:0 fail:0 skip:38
>
> Results at /archive/results/CI_IGT_test/Patchwork_2028/
>
> 340c485ad98d0ec0369a3b18d4a09938f3f5537d drm-intel-nightly: 2016y-04m-22d-17h-32m-25s UTC integration manifest
> 22517b8 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Merged, thanks for the patch and review.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-25 9:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-22 8:46 [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf tim.gore
2016-04-22 10:53 ` ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) Patchwork
2016-04-22 11:55 ` Patchwork
2016-04-24 6:23 ` ✓ Fi.CI.BAT: success " Patchwork
2016-04-25 9:09 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).