public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	marius.vlad@intel.com
Subject: Re: [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors.
Date: Mon, 25 Apr 2016 11:38:06 -0400	[thread overview]
Message-ID: <571E39DE.5080405@collabora.com> (raw)
In-Reply-To: <20160425151029.GC4329@intel.com>



On 04/25/2016 11:10 AM, Ville Syrjälä wrote:
> On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>> connectors.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>>   tests/kms_panel_fitting.c | 13 ++++++++++---
>>   1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 272a531..f59d042 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -140,9 +140,16 @@ static void test_panel_fitting(data_t *d)
>>   	for_each_connected_output(display, output) {
>>   		drmModeModeInfo *mode, native_mode;
>>   
>> -		if (output->config.connector->connector_type !=
>> -		    DRM_MODE_CONNECTOR_eDP)
>> -			continue;
>> +		/* Ignore over incompatible connectors. */
>> +		switch (output->config.connector->connector_type)
>> +		{
>> +			case DRM_MODE_CONNECTOR_LVDS:
>> +			case DRM_MODE_CONNECTOR_eDP:
>> +			case DRM_MODE_CONNECTOR_DSI:
>> +				break;
>> +			default:
>> +				continue;
>> +		}
> What happened to looking for the property?
The "scaling mode" property? I was intentionally leaving it out.
If desired, I could look into adding that too.

I've looked for and not found the "scaling mode" property id, but I 
still haven't found it.
Do you know what it is?
>
>>   
>>   		pipe = output->config.pipe;
>>   		igt_output_set_pipe(output, pipe);
>> -- 
>> 2.5.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-04-25 15:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 14:35 [PATCH i-g-t v2 0/6] Improve kms_panel_fitting robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 1/6] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 2/6] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 3/6] kms_panel_fitting: Remove un-used variable robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 5/6] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-25 15:10   ` Ville Syrjälä
2016-04-25 15:38     ` Robert Foss [this message]
2016-04-25 16:43       ` Ville Syrjälä
2016-04-26 11:51 ` [PATCH i-g-t v2 0/6] Improve kms_panel_fitting Tomeu Vizoso
2016-04-26 15:47   ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571E39DE.5080405@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.vlad@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox