Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

[Robert Foss <robert.foss@collabora.com>]

On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>> connectors.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>>   tests/kms_panel_fitting.c | 12 +++++++++---
>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 60a22b0..933776c 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>>   	for_each_connected_output(display, output) {
>>   		drmModeModeInfo *mode, native_mode;
>>
>> -		if (output->config.connector->connector_type !=
>> -			DRM_MODE_CONNECTOR_eDP)
>> -			continue;
>> +		switch (output->config.connector->connector_type)
>> +		{
>> +		    case DRM_MODE_CONNECTOR_LVDS:
>> +		    case DRM_MODE_CONNECTOR_eDP:
>> +		    case DRM_MODE_CONNECTOR_DSI:
>> +			    break;
>> +		    default:
>> +			    continue;
>> +		}
>
> I think ville commented that we should instead check for "scaling mode",
> and we discussed this on irc. Am I accidentally looking at an old patch
> series?
> -Daniel
>
No, this isn't an old patch, I misunderstood where our conversation ended.

"scaling mode" is an intel specific extension as far as I understand it,
which is somewhat the opposite of generalizing i-g-t tests.

Is there an architecture independent way forward?
>>
>>   		pipe = output->config.pipe;
>>   		igt_output_set_pipe(output, pipe);
>> --
>> 2.5.0
>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx