From: Dave Gordon <david.s.gordon@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter
Date: Wed, 27 Apr 2016 10:43:59 +0100 [thread overview]
Message-ID: <572089DF.7080705@intel.com> (raw)
In-Reply-To: <20160426141811.GQ8291@phenom.ffwll.local>
On 26/04/16 15:18, Daniel Vetter wrote:
> On Mon, Apr 25, 2016 at 03:37:11PM +0100, Dave Gordon wrote:
>> Split the function of "enable_guc_submission" into two separate
>> options. The new one ("enable_guc_loading") controls only the
>> *fetching and loading* of the GuC firmware image. The existing
>> one is redefined to control only the *use* of the GuC for batch
>> submission once the firmware is loaded.
>>
>> In addition, the degree of control has been refined from a simple
>> bool to an integer key, allowing several options:
>> -1 (default) whatever the platform default is
>> 0 DISABLE don't load/use the GuC
>> 1 BEST EFFORT try to load/use the GuC, fallback if not available
>> 2 REQUIRE must load/use the GuC, else leave the GPU wedged
>>
>> The new platform default (as coded here) will be to attempt to
>> load the GuC iff the device has a GuC that requires firmware,
>> but not yet to use it for submission. A later patch will change
>> to enable it if appropriate.
>>
>> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
>
> intel-gfx-trybot@fd.o is your CI_only patchwork and CI instance:
>
> https://patchwork.freedesktop.org/project/intel-gfx-trybot/series/?ordering=-last_updated
>
> Cheers, Daniel
Yes, I tried sending this to trybot several times before this, but it
wasn't working well, with many tests giving spurious "INCOMPLETE"
results, especially on the Romanian machines. So this was still the only
was to get a good test run.
Hopefully trybot will be back in working order soon, but that link shows
there has not been a single successful submission by anybody since 1st
April!
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-27 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 14:37 [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter Dave Gordon
2016-04-25 14:37 ` [PATCH 2/4] CI_ONLY: change default to using GuC submission if possible Dave Gordon
2016-04-25 14:37 ` [PATCH 3/4] CI_ONLY: pass request (not client) to i915_guc_wq_check_space() Dave Gordon
2016-04-25 14:37 ` [PATCH 4/4] CI_ONLY: DO NOT MERGE: WARN on GuC WQ full Dave Gordon
2016-04-25 15:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] CI_ONLY: add enable_guc_loading parameter Patchwork
2016-04-26 14:18 ` [PATCH 1/4] " Daniel Vetter
2016-04-27 9:43 ` Dave Gordon [this message]
2016-04-28 8:04 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572089DF.7080705@intel.com \
--to=david.s.gordon@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox