From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo Date: Thu, 28 Apr 2016 12:14:44 +0100 Message-ID: <5721F0A4.1090505@intel.com> References: <1448032264-31086-1-git-send-email-chris@chris-wilson.co.uk> <20151120153825.GS4437@intel.com> <878tzyi09k.fsf@intel.com> <8760v2i05v.fsf@intel.com> <20160428090226.GL27856@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 847D86E38B for ; Thu, 28 Apr 2016 11:14:46 +0000 (UTC) In-Reply-To: <20160428090226.GL27856@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Chris Wilson List-Id: intel-gfx@lists.freedesktop.org T24gMjgvMDQvMTYgMTA6MDIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUaHUsIEFwciAyOCwg MjAxNiBhdCAxMTo1NDowNEFNICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gT24gVGh1LCAy OCBBcHIgMjAxNiwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4gd3Jv dGU6Cj4+PiBPbiBGcmksIDIwIE5vdiAyMDE1LCBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4+PiBPbiBGcmksIE5vdiAyMCwgMjAxNSBhdCAw MzoxMTowNFBNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+Pj4+IFRoZSBvZmZzZXQgd2l0 aGluIGFuZCB0aGUgbGVuZ3RoIG9mIHRoZSBjb21tYW5kIHNlcXVlbmNlIHRvIGV4ZWN1dGUgYXJl Cj4+Pj4+IHN1cHBsaWVkIGJ5IHRoZSB1c2VyIHdpdGggcmVzcGVjdCB0byB0aGUgYmF0Y2ggYnVm ZmVyLiBXZSBzaG91bGQgYmUKPj4+Pj4gdmFsaWRhdGluZyB0aGF0IHJlZ2lvbiBpcyB3aG9sbHkg Y29udGFpbmVkIHdpdGhpbiB0aGUgYmF0Y2ggYnVmZmVyOwo+Pj4+PiBtYWtlIGl0IHNvLgo+Pj4+ Pgo+Pj4+PiBSZXBvcnRlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4+Pj4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4+Pj4+IC0t LQo+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDcg KysrKysrKwo+Pj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPj4+Pj4KPj4+ Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+Pj4+PiBpbmRl eCBhNGMyNDNjZWM0YWEuLmUzODI4NGMxYjg5ZiAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+Pj4+PiBAQCAtMTQ2Miw2ICsxNDYyLDEz IEBAIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAq ZGF0YSwKPj4+Pj4gICAJLyogdGFrZSBub3RlIG9mIHRoZSBiYXRjaCBidWZmZXIgYmVmb3JlIHdl IG1pZ2h0IHJlb3JkZXIgdGhlIGxpc3RzICovCj4+Pj4+ICAgCWJhdGNoX29iaiA9IGViX2dldF9i YXRjaChlYik7Cj4+Pj4+Cj4+Pj4+ICsJaWYgKGFyZ3MtPmJhdGNoX2xlbiA+IGJhdGNoX29iai0+ YmFzZS5zaXplIHx8Cj4+Pj4+ICsJICAgIGFyZ3MtPmJhdGNoX3N0YXJ0X29mZnNldCA+IGJhdGNo X29iai0+YmFzZS5zaXplIC0gYXJncy0+YmF0Y2hfbGVuKSB7Cj4+Pj4KPj4+PiBsZ3RtLiBObyBw b3NzaWJpbGl0eSBvZiBvdmVyZmxvdyBkb2luZyBpdCB0aGF0IHdheS4KPj4+Pgo+Pj4+IFJldmll d2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ Pgo+PiBJIGRvbid0IGtub3cgd2hhdCBJIGZhdCBmaW5nZXJlZCB3aXRoIHRoZSBwcmV2aW91cyBt YWlsLCBidXQgSSBqdXN0Cj4+IHN0dW1ibGVkIHVwb24gdGhpcyBwYXRjaCBhbmQgbm90aWNlZCBp dCBuZXZlciBtYWRlIGl0LiBJcyB0aGlzIHN0aWxsCj4+IHZhbGlkPwo+Cj4gWXVwLCBJJ2QgY29t cGxldGVseSBmb3Jnb3R0ZW4gYWJvdXQgdGhpcyBwYXRjaCBhbmQgaXQgd2UgZG9uJ3QgaGF2ZSB0 aGUKPiBzYWZlZ3VhcmQgaW4gdGhlIGtlcm5lbCB5ZXQuCj4gLUNocmlzCj4KCkhtbSAuLiB0aGlz IHdpbGwgYWxsb3cgKGxlbiA9PSAwKSBhcyBsb25nIGFzIHN0YXJ0IGlzIGluIHRoZSByYW5nZSAK WzAuLnNpemUpLiBCdXQgbGF0ZXIsIGk5MTVfZ2VtX3JpbmdidWZmZXJfc3VibWlzc2lvbigpIHdp bGwgaW50ZXJwcmV0IApsZW5ndGggMCBhcyBtZWFuaW5nICJzaXplb2YgYmF0Y2hfYm8iLCB3aGlj aCB3b3VsZCBiZSBvdXQtb2YtYm91bmRzIGlmIApzdGFydCAhPSAwLiBSZWxldmFudCBjb2RlIGlz OgoKICAgICAgICAgZXhlY19sZW4gICA9IGFyZ3MtPmJhdGNoX2xlbjsKICAgICAgICAgZXhlY19z dGFydCA9IHBhcmFtcy0+YmF0Y2hfb2JqX3ZtX29mZnNldCArCiAgICAgICAgICAgICAgICAgICAg ICBwYXJhbXMtPmFyZ3NfYmF0Y2hfc3RhcnRfb2Zmc2V0OwoKICAgICAgICAgaWYgKGV4ZWNfbGVu ID09IDApCiAgICAgICAgICAgICAgICAgZXhlY19sZW4gPSBwYXJhbXMtPmJhdGNoX29iai0+YmFz ZS5zaXplOwoKU2hvdWxkIHdlIHBlcm1pdCBsZW4gPT0gMCBpZmYgc3RhcnQgPT0gMD8gT3IgdGFr ZSBpdCB0byBtZWFuICJmcm9tIHN0YXJ0IAp0byBzaXplb2YgYm8iLCBhbmQgbWF5YmUgcHV0IHRo ZSByZXBsYWNlbWVudCBpbiB0aGUgbmV3IGNoZWNrIGNvZGUgCnJhdGhlciB0aGFuIGxhdGVyLCBp biBzdWJtaXNzaW9uKCk/CgpPZiBjb3Vyc2UgYmF0Y2ggbGVuZ3RoIGlzIG5vdCBhY3R1YWxseSB1 c2VkIG9uIGxhdGVyIGhhcmR3YXJlLCBhbmQgc28gCnRoZSBleGVjbGlzdHMgdmVyc2lvbiBkb2Vz bid0IG1ha2UgdGhpcyBzdWJzdGl0dXRpb24sIHNpbmNlIGFueSBoYXJkd2FyZSAKdGhhdCBjYW4g ZG8gZXhlY2xpc3RzIG9ubHkgdXNlcyB0aGUgQkItU1RBUlQgZm9ybSB3aXRob3V0IGEgbGVuZ3Ro LiAKTm9uZXRoZWxlc3Mgd2UgbWlnaHQgc3RpbGwgd2FudCB0byB2YWxpZGF0ZSBhbmQgaW50ZXJw cmV0IHRoaXMgaW4gYSAKdW5pZm9ybSBtYW5uZXIgLi4uCgouRGF2ZS4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=