From: Dave Gordon <david.s.gordon@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty()
Date: Thu, 28 Apr 2016 18:20:30 +0100 [thread overview]
Message-ID: <5722465E.1060501@intel.com> (raw)
In-Reply-To: <20160428163633.GD29549@nuc-i3427.alporthouse.com>
On 28/04/16 17:36, Chris Wilson wrote:
> On Thu, Apr 28, 2016 at 05:26:21PM +0100, Dave Gordon wrote:
>> intel_pin_and_map_ringbuffer_obj() should have been setting the dirty
>> flag, but wasn't; and the LRC code in intel_lr_context_do_pin() is also
>> updated to use the new function.
>
> Technically it doesn't need to. Whilst there is any valid content in the
> ringbuffer, it is pinned for use by requests and the hadware. Unlike the
> context object whose content does need to persist when inactive.
> -Chris
What about across suspend and/or hibernate? Any chance of there being
valid (new) content in a ringbuffer that gets thrown away? Though
presumably we insist that all pending work is completed before allowing
hibernation/suspend anyway?
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-28 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 16:26 [PATCH 1/2] drm/i915: introduce & use i915_gem_object_mark_dirty() Dave Gordon
2016-04-28 16:26 ` [PATCH 2/2] drm/i915: a couple more uses for i915_gem_object_mark_dirty() Dave Gordon
2016-04-28 16:36 ` Chris Wilson
2016-04-28 17:20 ` Dave Gordon [this message]
2016-04-28 17:27 ` Chris Wilson
2016-04-28 16:34 ` [PATCH 1/2] drm/i915: introduce & use i915_gem_object_mark_dirty() Chris Wilson
2016-04-28 17:32 ` Dave Gordon
2016-04-28 17:48 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
2016-04-28 18:36 ` Dave Gordon
2016-05-02 8:58 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5722465E.1060501@intel.com \
--to=david.s.gordon@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox