From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/execlists: Refactor common engine setup Date: Fri, 29 Apr 2016 10:25:41 +0100 Message-ID: <57232895.3020204@linux.intel.com> References: <1461851222-20557-1-git-send-email-chris@chris-wilson.co.uk> <1461864932-26230-1-git-send-email-chris@chris-wilson.co.uk> <572323A3.2000902@linux.intel.com> <20160429091504.GE30680@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 554016EE7E for ; Fri, 29 Apr 2016 09:25:55 +0000 (UTC) In-Reply-To: <20160429091504.GE30680@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Dave Gordon List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA0LzE2IDEwOjE1LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBBcHIgMjks IDIwMTYgYXQgMTA6MDQ6MzVBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9u IDI4LzA0LzE2IDE4OjM1LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBNb3ZlIGFsbCBvZiB0aGUg Y29uc3RhbnQgYXNzaWdubWVudHMgdXAgZnJvbnQgYW5kIGludG8gYSBjb21tb24KPj4+IGZ1bmN0 aW9uLiBUaGlzIGlzIHByaW1hcmlseSB0byBlbnN1cmUgdGhlIGJhY2twb2ludGVycyBhcmUgc2V0 IGFzIGVhcmx5Cj4+PiBhcyBwb3NzaWJsZSBmb3IgbGF0ZXIgdXNlIGR1cmluZyBpbml0aWFsaXNh dGlvbi4KPj4+Cj4+PiB2MjogVXNlIGEgY29uc3RhbnQgc3RydWN0IHNvIHRoYXQgYWxsIHRoZSBz aW1pbGFyIHZhbHVlcyBhcmUgc2V0Cj4+PiB0b2dldGhlci4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5 OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENjOiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+Pj4gQ2M6IERhdmUgR29y ZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAxNzYgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA5MyBpbnNlcnRpb25zKCspLCA4MyBkZWxl dGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4gaW5kZXggODc0YzI1 MTVmOWQ0Li4yZTBlYWE5ZmEyNDAgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK Pj4+IEBAIC0xOTIxLDggKzE5MjEsNyBAQCB2b2lkIGludGVsX2xvZ2ljYWxfcmluZ19jbGVhbnVw KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICAgfQo+Pj4KPj4+ICAgc3RhdGlj IHZvaWQKPj4+IC1sb2dpY2FsX3JpbmdfZGVmYXVsdF92ZnVuY3Moc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPj4+IC0JCQkgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4gK2xv Z2ljYWxfcmluZ19kZWZhdWx0X3ZmdW5jcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4+PiAgIHsKPj4+ICAgCS8qIERlZmF1bHQgdmZ1bmNzIHdoaWNoIGNhbiBiZSBvdmVycmlkZW4g YnkgZWFjaCBlbmdpbmUuICovCj4+PiAgIAllbmdpbmUtPmluaXRfaHcgPSBnZW44X2luaXRfY29t bW9uX3Jpbmc7Cj4+PiBAQCAtMTkzMyw3ICsxOTMyLDcgQEAgbG9naWNhbF9yaW5nX2RlZmF1bHRf dmZ1bmNzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+PiAgIAllbmdpbmUtPmVtaXRfYmJfc3Rh cnQgPSBnZW44X2VtaXRfYmJfc3RhcnQ7Cj4+PiAgIAllbmdpbmUtPmdldF9zZXFubyA9IGdlbjhf Z2V0X3NlcW5vOwo+Pj4gICAJZW5naW5lLT5zZXRfc2Vxbm8gPSBnZW44X3NldF9zZXFubzsKPj4+ IC0JaWYgKElTX0JYVF9SRVZJRChkZXYsIDAsIEJYVF9SRVZJRF9BMSkpIHsKPj4+ICsJaWYgKElT X0JYVF9SRVZJRChlbmdpbmUtPmRldiwgMCwgQlhUX1JFVklEX0ExKSkgewo+Pj4gICAJCWVuZ2lu ZS0+aXJxX3NlcW5vX2JhcnJpZXIgPSBieHRfYV9zZXFub19iYXJyaWVyOwo+Pj4gICAJCWVuZ2lu ZS0+c2V0X3NlcW5vID0gYnh0X2Ffc2V0X3NlcW5vOwo+Pj4gICAJfQo+Pj4gQEAgLTE5NDQsNiAr MTk0Myw3IEBAIGxvZ2ljYWxfcmluZ19kZWZhdWx0X2lycXMoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lLCB1bnNpZ25lZCBzaGlmdCkKPj4+ICAgewo+Pj4gICAJZW5naW5lLT5pcnFfZW5h YmxlX21hc2sgPSBHVF9SRU5ERVJfVVNFUl9JTlRFUlJVUFQgPDwgc2hpZnQ7Cj4+PiAgIAllbmdp bmUtPmlycV9rZWVwX21hc2sgPSBHVF9DT05URVhUX1NXSVRDSF9JTlRFUlJVUFQgPDwgc2hpZnQ7 Cj4+PiArCWluaXRfd2FpdHF1ZXVlX2hlYWQoJmVuZ2luZS0+aXJxX3F1ZXVlKTsKPj4+ICAgfQo+ Pj4KPj4+ICAgc3RhdGljIGludAo+Pj4gQEAgLTE5NjQsMzEgKzE5NjQsNjggQEAgbHJjX3NldHVw X2h3cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4+PiAgIAlyZXR1cm4gMDsKPj4+ ICAgfQo+Pj4KPj4+IC1zdGF0aWMgaW50Cj4+PiAtbG9naWNhbF9yaW5nX2luaXQoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgbG9naWNhbF9yaW5nX2luZm8gewo+Pj4gKwljb25zdCBjaGFyICpuYW1l Owo+Pj4gKwl1bnNpZ25lZCBleGVjX2lkOwo+Pj4gKwl1bnNpZ25lZCBndWNfaWQ7Cj4+PiArCXUz MiBtbWlvX2Jhc2U7Cj4+PiArCXVuc2lnbmVkIGlycV9zaGlmdDsKPj4+ICt9IGxvZ2ljYWxfcmlu Z3NbXSA9IHsKPj4+ICsJW1JDU10gPSB7Cj4+PiArCQkubmFtZSA9ICJyZW5kZXIgcmluZyIsCj4+ PiArCQkuZXhlY19pZCA9IEk5MTVfRVhFQ19SRU5ERVIsCj4+PiArCQkuZ3VjX2lkID0gR1VDX1JF TkRFUl9FTkdJTkUsCj4+PiArCQkubW1pb19iYXNlID0gUkVOREVSX1JJTkdfQkFTRSwKPj4+ICsJ CS5pcnFfc2hpZnQgPSBHRU44X1JDU19JUlFfU0hJRlQsCj4+PiArCX0sCj4+PiArCVtCQ1NdID0g ewo+Pj4gKwkJLm5hbWUgPSAiYmxpdHRlciByaW5nIiwKPj4+ICsJCS5leGVjX2lkID0gSTkxNV9F WEVDX0JMVCwKPj4+ICsJCS5ndWNfaWQgPSBHVUNfQkxJVFRFUl9FTkdJTkUsCj4+PiArCQkubW1p b19iYXNlID0gQkxUX1JJTkdfQkFTRSwKPj4+ICsJCS5pcnFfc2hpZnQgPSBHRU44X0JDU19JUlFf U0hJRlQsCj4+PiArCX0sCj4+PiArCVtWQ1NdID0gewo+Pj4gKwkJLm5hbWUgPSAiYnNkIHJpbmci LAo+Pj4gKwkJLmV4ZWNfaWQgPSBJOTE1X0VYRUNfQlNELAo+Pj4gKwkJLmd1Y19pZCA9IEdVQ19W SURFT19FTkdJTkUsCj4+PiArCQkubW1pb19iYXNlID0gR0VONl9CU0RfUklOR19CQVNFLAo+Pj4g KwkJLmlycV9zaGlmdCA9IEdFTjhfVkNTMV9JUlFfU0hJRlQsCj4+PiArCX0sCj4+PiArCVtWQ1My XSA9IHsKPj4+ICsJCS5uYW1lID0gImJzZDIgcmluZyIsCj4+PiArCQkuZXhlY19pZCA9IEk5MTVf RVhFQ19CU0QsCj4+PiArCQkuZ3VjX2lkID0gR1VDX1ZJREVPX0VOR0lORTIsCj4+PiArCQkubW1p b19iYXNlID0gR0VOOF9CU0QyX1JJTkdfQkFTRSwKPj4+ICsJCS5pcnFfc2hpZnQgPSBHRU44X1ZD UzJfSVJRX1NISUZULAo+Pj4gKwl9LAo+Pj4gKwlbVkVDU10gPSB7Cj4+PiArCQkubmFtZSA9ICJ2 aWRlbyBlbmhhbmNlbWVudCByaW5nIiwKPj4+ICsJCS5leGVjX2lkID0gSTkxNV9FWEVDX1ZFQk9Y LAo+Pj4gKwkJLmd1Y19pZCA9IEdVQ19WSURFT0VOSEFOQ0VfRU5HSU5FLAo+Pj4gKwkJLm1taW9f YmFzZSA9IFZFQk9YX1JJTkdfQkFTRSwKPj4+ICsJCS5pcnFfc2hpZnQgPSBHRU44X1ZFQ1NfSVJR X1NISUZULAo+Pj4gKwl9LAo+Pj4gK307Cj4+PiArCj4+PiArc3RhdGljIHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKgo+Pj4gK2xvZ2ljYWxfcmluZ19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCBlbnVtIGludGVsX2VuZ2luZV9pZCBpZCkKPj4+ICAgewo+Pgo+PiBXb3VsZCBkZXZfcHJpdiBi ZSBiZXR0ZXI/IEp1c3QgdG8gZ3JhZHVhbGx5IG1vdmUgdG93YXJkcyB0aGUgY29ycmVjdAo+PiBz dGF0ZSBvZiB0aGluZ3MuCj4KPiBJIGhhdmUgYSBwYXRjaCBxdWV1ZWQgdXAgdG8gZG8gZW5naW5l LT5pOTE1ICgxIEtpQiBpbiBvYmplY3QgY29kZQo+IHJlZHVjdGlvbikgbmV4dC4KPgo+Pj4gKwlj b25zdCBzdHJ1Y3QgbG9naWNhbF9yaW5nX2luZm8gKmluZm8gPSAmbG9naWNhbF9yaW5nc1tpZF07 Cj4+PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7 Cj4+PiAtCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpkY3R4ID0gZGV2X3ByaXYtPmtlcm5lbF9jb250 ZXh0Owo+Pj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPSAmZGV2X3ByaXYtPmVu Z2luZVtpZF07Cj4+PiAgIAllbnVtIGZvcmNld2FrZV9kb21haW5zIGZ3X2RvbWFpbnM7Cj4+PiAt CWludCByZXQ7Cj4+PiAtCj4+PiAtCS8qIEludGVudGlvbmFsbHkgbGVmdCBibGFuay4gKi8KPj4+ IC0JZW5naW5lLT5idWZmZXIgPSBOVUxMOwo+Pj4KPj4+ICAgCWVuZ2luZS0+ZGV2ID0gZGV2Owo+ Pgo+PiBMb29raW5nIGF0IHVzYWdlcyBvZiBpbnRlbF9lbmdpbmVfaW5pdGlhbGl6ZWQuLi4gb25l IHBvdGVudGlhbAo+PiBkYW5nZXIgc2NlbmFyaW8gd291bGQgYmUgaW50ZXJydXB0IG5vaXNlIGR1 cmluZyBkcml2ZXIgbG9hZCBlbmQgaW4KPj4gbm90aWZ5IHJpbmcgYW5kIGV4cGxvZGVzLiBTb3Vu ZHMgdmVyeSB1bmxpa2VseSBidXQgdGhlb3JldGljYWxseSBpdAo+PiBpcyBhIHJlZ3Jlc3Npb24g Y29tcGFyZWQgdG8gd2hlcmUgZW5naW5lLT5kZXYgaW5pdGlhbGl6YXRpb24gd2FzCj4+IGJlZm9y ZS4KPj4KPj4gV2Ugc2hvdWxkIHJlYWxseSBtb3ZlIGF3YXkgZnJvbSBlbmdpbmUtPmRldiBmb3Ig dGhpcyBhbmQganVzdCBhZGQgYW4KPj4gZXhwbGljaXQgZmxhZy4KPgo+IEhtbS4gbm90IHRoYXQg YnV0IEkgdGhpbmsgd2UgcmVhbGx5IHNob3VsZCBiZSBzYW5pdGl6aW5nIHRoZSBpcnEgaGVyZQo+ IGFuZCBlbmFibGluZyB0aGVtIGxhc3QuCj4KPiBMaWtlOgo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMKPiBpbmRleCAyZTBlYWE5ZmEyNDAuLjJjOTQwNzJhYjA4NSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jCj4gQEAgLTIwMTYsMTQgKzIwMTYsMTcgQEAgbG9naWNhbF9yaW5nX3Nl dHVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gaW50ZWxfZW5naW5lX2lkIGlkKQo+ICAg ICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9ICZkZXZfcHJpdi0+ZW5naW5l W2lkXTsKPiAgICAgICAgICBlbnVtIGZvcmNld2FrZV9kb21haW5zIGZ3X2RvbWFpbnM7Cj4KPiAt ICAgICAgIGVuZ2luZS0+ZGV2ID0gZGV2Owo+IC0KPiAgICAgICAgICBlbmdpbmUtPmlkID0gaWQ7 Cj4gICAgICAgICAgZW5naW5lLT5uYW1lID0gaW5mby0+bmFtZTsKPiAgICAgICAgICBlbmdpbmUt PmV4ZWNfaWQgPSBpbmZvLT5leGVjX2lkOwo+ICAgICAgICAgIGVuZ2luZS0+Z3VjX2lkID0gaW5m by0+Z3VjX2lkOwo+ICAgICAgICAgIGVuZ2luZS0+bW1pb19iYXNlID0gaW5mby0+bW1pb19iYXNl Owo+Cj4gKyAgICAgICAvKiBkaXNhYmxlIGludGVycnVwdHMgdG8gdGhpcyBlbmdpbmUgYmVmb3Jl IHdlIGluc3RhbGwgb3Vyc2VsdmVzKi8KPiArICAgICAgIEk5MTVfV1JJVEVfSU1SKGVuZ2luZSwg fjApOwo+ICsKPiArICAgICAgIGVuZ2luZS0+ZGV2ID0gZGV2Owo+ICsKPiAgICAgICAgICAvKiBJ bnRlbnRpb25hbGx5IGxlZnQgYmxhbmsuICovCj4gICAgICAgICAgZW5naW5lLT5idWZmZXIgPSBO VUxMOwo+Cj4gTWFrZSBzZW5zZT8KCk5vdCB0aGUgbW9zdCBlbGVnYW50IGJlY2F1c2UgYWxsIHRo ZSBodyBhY2Nlc3Mgd2UgaGF2ZSBzbyBmYXIgaXMgaW4gCmVuZ2luZS0+aW5pdF9ody4gV2h5IGNh bid0IHdlIGp1c3QgbWFrZSBpbnRlbF9lbmdpbmVfaW5pdGlhbGl6ZWQgcmV0dXJuIApmYWxzZSB1 bnRpbCB0aGUgdmVyeSBsYXN0IHRoaW5nIGluIGVuZ2luZSBjb25zdHJ1Y3RvcnM/CgpSZWdhcmRz LAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=