From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 2/5] drm/i915/guc: pass request (not client) to i915_guc_{wq_check_space, submit}() Date: Fri, 29 Apr 2016 16:08:55 +0100 Message-ID: <57237907.4020808@linux.intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-2-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 71C476EFB9 for ; Fri, 29 Apr 2016 15:08:58 +0000 (UTC) In-Reply-To: <1461780195-17434-2-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI3LzA0LzE2IDE5OjAzLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaGUga25vd2xlZGdlIG9m IGhvdyB0byBkZXJpdmUgdGhlIHJlbGV2YW50IGNsaWVudCBmcm9tIHRoZSByZXF1ZXN0Cj4gc2hv dWxkIGJlIGxvY2FsaXNlZCB3aXRoaW4gaTkxNV9ndWNfc3VibWlzc2lvbi5jOyB0aGUgTFJDIGNv ZGUgc2hvdWxkbid0Cj4gaGF2ZSB0byBrbm93IGFib3V0IHRoZSBpbnRlcm5hbCBkZXRhaWxzIG9m IHRoZSBHdUMgc3VibWlzc2lvbiBwcm9jZXNzLgo+IEFuZCBhbGwgdGhlIGluZm9ybWF0aW9uIHRo ZSBHdUMgY29kZSBuZWVkcyBzaG91bGQgYmUgZW5jYXBzdWxhdGVkIGluIChvcgo+IHJlYWNoYWJs ZSBmcm9tKSB0aGUgcmVxdWVzdC4KPgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZp ZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2d1Y19zdWJtaXNzaW9uLmMgfCAxMSArKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjLmggICAgICAgICAgIHwgIDUgKystLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jICAgICAgICAgICB8ICA5ICsrKy0tLS0tLQo+ICAgMyBmaWxlcyBjaGFu Z2VkLCAxMSBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA0MmQyZWZhLi42NmFmNWNlIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC00 NTEsMTAgKzQ1MSwxMSBAQCBzdGF0aWMgdm9pZCBndWNfZmluaV9jdHhfZGVzYyhzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMsCj4gICAJCQkgICAgIHNpemVvZihkZXNjKSAqIGNsaWVudC0+Y3R4X2luZGV4 KTsKPiAgIH0KPgo+IC1pbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uoc3RydWN0IGk5MTVfZ3Vj X2NsaWVudCAqZ2MpCj4gK2ludCBpOTE1X2d1Y193cV9jaGVja19zcGFjZShzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gICB7Cj4gKwljb25zdCBzaXplX3Qgc2l6ZSA9IHNp emVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwoKQWxsIHRoZSBvdGhlciB2YXJpYWJsZXMgcGFzc2Vk IHRvIENJUkNfU1BBQ0UgYXJlIHUzMiBzbyB0aGlzIGlzIGZvciB0aGUgCndvcnNlIEkgdGhpbmsu Cgo+ICsJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MgPSByZXF1ZXN0LT5pOTE1LT5ndWMuZXhl Y2J1Zl9jbGllbnQ7Cj4gICAJc3RydWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4gLQl1MzIg c2l6ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+ICAgCWludCByZXQgPSAtRVRJTUVE T1VULCB0aW1lb3V0X2NvdW50ZXIgPSAyMDA7Cj4KPiAgIAlpZiAoIWdjKQo+IEBAIC01MzcsMTEg KzUzOCwxMSBAQCBzdGF0aWMgaW50IGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVf Z3VjX2NsaWVudCAqZ2MsCj4gICAgKgo+ICAgICogUmV0dXJuOgkwIGlmIHN1Y2NlZWQKPiAgICAq Lwo+IC1pbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCwK PiAtCQkgICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSkKPiAraW50IGk5MTVfZ3Vj X3N1Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKQo+ICAgewo+IC0Jc3RydWN0 IGludGVsX2d1YyAqZ3VjID0gY2xpZW50LT5ndWM7Cj4gICAJdW5zaWduZWQgaW50IGVuZ2luZV9p ZCA9IHJxLT5lbmdpbmUtPmd1Y19pZDsKPiArCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZycS0+ aTkxNS0+Z3VjOwo+ICsJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50ID0gZ3VjLT5leGVj YnVmX2NsaWVudDsKPiAgIAlpbnQgcV9yZXQsIGJfcmV0Owo+Cj4gICAJcV9yZXQgPSBndWNfYWRk X3dvcmtxdWV1ZV9pdGVtKGNsaWVudCwgcnEpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4g aW5kZXggOWQ3OWM0Yy4uYjM3YzczMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4g QEAgLTE0OCwxMCArMTQ4LDkgQEAgZXh0ZXJuIGludCBpbnRlbF9ndWNfcmVzdW1lKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpOwo+ICAgLyogaTkxNV9ndWNfc3VibWlzc2lvbi5jICovCj4gICBpbnQg aTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgaW50 IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+IC1p bnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCwKPiAtCQkg ICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4gK2ludCBpOTE1X2d1Y193cV9j aGVja19zcGFjZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPiAraW50IGk5MTVf Z3VjX3N1Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPiAgIHZvaWQgaTkx NV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgdm9p ZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gLWlu dCBpOTE1X2d1Y193cV9jaGVja19zcGFjZShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQp Owo+Cj4gICAjZW5kaWYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDJiN2U2YmIu LmI4ZWM4YzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC03MDgsOSArNzA4 LDcgQEAgaW50IGludGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QKPiAgIAkJICogZ29pbmcgYW55IGZ1cnRoZXIs IGFzIHRoZSBpOTE1X2FkZF9yZXF1ZXN0KCkgY2FsbAo+ICAgCQkgKiBsYXRlciBvbiBtdXN0bid0 IGZhaWwgLi4uCj4gICAJCSAqLwo+IC0JCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZyZXF1ZXN0 LT5pOTE1LT5ndWM7Cj4gLQo+IC0JCXJldCA9IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKGd1Yy0+ ZXhlY2J1Zl9jbGllbnQpOwo+ICsJCXJldCA9IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHJlcXVl c3QpOwo+ICAgCQlpZiAocmV0KQo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAl9Cj4gQEAgLTc3Niw3 ICs3NzQsNiBAQCBzdGF0aWMgaW50IGxvZ2ljYWxfcmluZ193YWl0X2Zvcl9zcGFjZShzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgIGludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNl X2FuZF9zdWJtaXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgewo+ ICAgCXN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcmVxdWVzdC0+cmluZ2J1ZjsK PiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcXVlc3QtPmk5MTU7Cj4g ICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcmVxdWVzdC0+ZW5naW5lOwo+Cj4g ICAJaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gQEAgLTgwNiw4ICs4MDMs OCBAQCBzdGF0aWMgaW50IGxvZ2ljYWxfcmluZ193YWl0X2Zvcl9zcGFjZShzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgIAkJfQo+ICAgCX0KPgo+IC0JaWYgKGRldl9wcml2LT5n dWMuZXhlY2J1Zl9jbGllbnQpCj4gLQkJaTkxNV9ndWNfc3VibWl0KGRldl9wcml2LT5ndWMuZXhl Y2J1Zl9jbGllbnQsIHJlcXVlc3QpOwo+ICsJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u KQo+ICsJCWk5MTVfZ3VjX3N1Ym1pdChyZXF1ZXN0KTsKPiAgIAllbHNlCj4gICAJCWV4ZWNsaXN0 c19jb250ZXh0X3F1ZXVlKHJlcXVlc3QpOwo+Cj4KCldpdGggdGhlIGRhdGF0eXBlIGZpeCAocmV2 ZXJ0KSBpbiBpOTE1X2d1Y193cV9jaGVja19zcGFjZToKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK