From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 3/5] drm/i915/guc: don't spinwait if the GuC's workqueue is full Date: Fri, 29 Apr 2016 16:17:00 +0100 Message-ID: <57237AEC.5080308@linux.intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id A32386E3DB for ; Fri, 29 Apr 2016 15:17:02 +0000 (UTC) In-Reply-To: <1461780195-17434-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI3LzA0LzE2IDE5OjAzLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBSYXRoZXIgdGhhbiB3YWl0 IHRvIHNlZSB3aGV0aGVyIG1vcmUgc3BhY2UgYmVjb21lcyBhdmFpbGFibGUgaW4gdGhlIEd1Qwo+ IHN1Ym1pc3Npb24gd29ya3F1ZXVlLCB3ZSBjYW4ganVzdCByZXR1cm4gLUVBR0FJTiBhbmQgbGV0 IHRoZSBjYWxsZXIgdHJ5Cj4gYWdhaW4gaW4gYSBsaXR0bGUgd2hpbGUuIFRoaXMgZ2V0cyByaWQg b2YgYW4gdW5pbnRlcnJ1cHRhYmxlIHNsZWVwIGluCj4gdGhlIHBvbGxpbmcgY29kZSA6KQo+Cj4g V2UnbGwgYWxzbyBhZGQgYSBjb3VudGVyIHRvIHRoZSBHdUMgY2xpZW50IHN0YXRpc3RpY3MsIHRv IHNlZSBob3cgb2Z0ZW4KPiB3ZSBmaW5kIHRoZSBXUSBmdWxsLgo+Cj4gU2lnbmVkLW9mZi1ieTog RGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICB8ICAxICsKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDE2ICsrKysrLS0tLS0tLS0tLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oICAgICAgICAgICB8ICA4ICsrKystLS0t Cj4gICAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCA4YjhkNmYwLi4xMDI0OTQ3 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjUwOSw2ICsyNTA5 LDcgQEAgc3RhdGljIHZvaWQgaTkxNV9ndWNfY2xpZW50X2luZm8oc3RydWN0IHNlcV9maWxlICpt LAo+ICAgCXNlcV9wcmludGYobSwgIlx0V1Egc2l6ZSAlZCwgb2Zmc2V0OiAweCV4LCB0YWlsICVk XG4iLAo+ICAgCQljbGllbnQtPndxX3NpemUsIGNsaWVudC0+d3Ffb2Zmc2V0LCBjbGllbnQtPndx X3RhaWwpOwo+Cj4gKwlzZXFfcHJpbnRmKG0sICJcdFdvcmsgcXVldWUgZnVsbDogJXVcbiIsIGNs aWVudC0+bm9fd3Ffc3BhY2UpOwo+ICAgCXNlcV9wcmludGYobSwgIlx0RmFpbGVkIHRvIHF1ZXVl OiAldVxuIiwgY2xpZW50LT5xX2ZhaWwpOwo+ICAgCXNlcV9wcmludGYobSwgIlx0RmFpbGVkIGRv b3JiZWxsOiAldVxuIiwgY2xpZW50LT5iX2ZhaWwpOwo+ICAgCXNlcV9wcmludGYobSwgIlx0TGFz dCBzdWJtaXNzaW9uIHJlc3VsdDogJWRcbiIsIGNsaWVudC0+cmV0Y29kZSk7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IDY2YWY1Y2UuLjY2MjZl ZmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4g QEAgLTQ1MywyNyArNDUzLDIxIEBAIHN0YXRpYyB2b2lkIGd1Y19maW5pX2N0eF9kZXNjKHN0cnVj dCBpbnRlbF9ndWMgKmd1YywKPgo+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgIHsKPiAtCWNvbnN0IHNpemVfdCBz aXplID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4gKwljb25zdCBzaXplX3Qgd3FpX3Np emUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPiAgIAlzdHJ1Y3QgaTkxNV9ndWNfY2xp ZW50ICpnYyA9IHJlcXVlc3QtPmk5MTUtPmd1Yy5leGVjYnVmX2NsaWVudDsKPiAgIAlzdHJ1Y3Qg Z3VjX3Byb2Nlc3NfZGVzYyAqZGVzYzsKPiAtCWludCByZXQgPSAtRVRJTUVET1VULCB0aW1lb3V0 X2NvdW50ZXIgPSAyMDA7Cj4KPiAgIAlpZiAoIWdjKQo+ICAgCQlyZXR1cm4gMDsKCk5vdCBwYXJ0 IG9mIHRoaXMgcGF0Y2ggYnV0IHNwb3R0ZWQgaXQgLSBjYW4gdGhpcyByZWFsbHkgaGFwcGVuLCBh bmQgaWYgCnNvLCBkb2VzIGl0IHdhcnJhbnQgYSBXQVJOX09OQ0UsIEdFTV9CVUdfT04gb3Igc29t ZXRoaW5nPwoKPgo+ICAgCWRlc2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNjX29m ZnNldDsKPgo+IC0Jd2hpbGUgKHRpbWVvdXRfY291bnRlci0tID4gMCkgewo+IC0JCWlmIChDSVJD X1NQQUNFKGdjLT53cV90YWlsLCBkZXNjLT5oZWFkLCBnYy0+d3Ffc2l6ZSkgPj0gc2l6ZSkgewo+ IC0JCQlyZXQgPSAwOwo+IC0JCQlicmVhazsKPiAtCQl9Cj4gKwlpZiAoQ0lSQ19TUEFDRShnYy0+ d3FfdGFpbCwgZGVzYy0+aGVhZCwgZ2MtPndxX3NpemUpID49IHdxaV9zaXplKQo+ICsJCXJldHVy biAwOwoKQ291bGQgc3RpY2sgYSBsaWtlbHkgaGVyZSB0byBsYXkgb3V0IHRoZSBjb2RlIGZvciB0 aGUgZXhwZWN0ZWQgY2FzZSBidXQgCml0IGNvdWxkIGJlIGp1c3QgT0NELiA6KQoKPgo+IC0JCWlm ICh0aW1lb3V0X2NvdW50ZXIpCj4gLQkJCXVzbGVlcF9yYW5nZSgxMDAwLCAyMDAwKTsKPiAtCX07 Cj4gKwlnYy0+bm9fd3Ffc3BhY2UgKz0gMTsKPgo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiAt RUFHQUlOOwoKSSBzdXBwb3NlIGl0IGlzIE9LIHRvIG1ha2UgdXNlcnNwYWNlIHBheSB0aGUgY29z dCBzaW5jZSB0aGlzIHNob3VsZCBiZSAKZXh0cmVtZWx5IHJhcmUsIGNvcnJlY3Q/Cgo+ICAgfQo+ Cj4gICBzdGF0aWMgaW50IGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2Ns aWVudCAqZ2MsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBpbmRleCBiMzdjNzMxLi40MzZm MmQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBAQCAtNzMsMTAgKzczLDEwIEBA IHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgewo+Cj4gICAJLyogR3VDIHN1Ym1pc3Npb24gc3RhdGlz dGljcyAmIHN0YXR1cyAqLwo+ICAgCXVpbnQ2NF90IHN1Ym1pc3Npb25zW0dVQ19NQVhfRU5HSU5F U19OVU1dOwo+IC0JdWludDMyX3QgcV9mYWlsOwo+IC0JdWludDMyX3QgYl9mYWlsOwo+IC0JaW50 IHJldGNvZGU7Cj4gLQlpbnQgc3BhcmU7CQkJLyogcGFkIHRvIDMyIERXb3JkcwkJKi8KPiArCXVp bnQzMl90IG5vX3dxX3NwYWNlOwkJLyogU3BhY2UgcHJlLWNoZWNrIGZhaWxlZAkqLwo+ICsJdWlu dDMyX3QgcV9mYWlsOwkJLyogRmFpbGVkIHRvIHF1ZXVlIChNQlopCSovCj4gKwl1aW50MzJfdCBi X2ZhaWw7CQkvKiBEb29yYmVsbCBmYWlsdXJlIChNQlopCSovCj4gKwlpbnQgcmV0Y29kZTsJCQkv KiBSZXN1bHQgb2YgbGFzdCBndWNfc3VibWl0KCkJKi8KPiAgIH07Cj4KPiAgIGVudW0gaW50ZWxf Z3VjX2Z3X3N0YXR1cyB7Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK