From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 4/5] drm/i915/guc: rework guc_add_workqueue_item() Date: Tue, 3 May 2016 11:26:34 +0100 Message-ID: <57287CDA.8010005@linux.intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-4-git-send-email-david.s.gordon@intel.com> <57238158.6090903@linux.intel.com> <20160429161019.GN30680@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id A03B26E18F for ; Tue, 3 May 2016 10:26:36 +0000 (UTC) In-Reply-To: <20160429161019.GN30680@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA0LzE2IDE3OjEwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBBcHIgMjks IDIwMTYgYXQgMDQ6NDQ6MjRQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9u IDI3LzA0LzE2IDE5OjAzLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+IE1vc3RseSBsaXR0bGUgb3B0 aW1pc2F0aW9uczsgZm9yIGluc3RhbmNlLCBpZiB0aGUgZHJpdmVyIGlzIGNvcnJlY3RseQo+Pj4g Zm9sbG93aW5nIHRoZSBzdWJtaXNzaW9uIHByb3RvY29sLCB0aGUgIm91dCBvZiBzcGFjZSIgY29u ZGl0aW9uIGlzCj4+PiBpbXBvc3NpYmxlLCBzbyB0aGUgcHJldmlvdXMgcnVudGltZSBXQVJOX09O KCkgaXMgcHJvbW90ZWQgdG8gYQo+Pj4gR0VNX0JVR19PTigpIGZvciBhIG1vcmUgZHJhbWF0aWMg ZWZmZWN0IGluIGRldmVsb3BtZW50IGFuZCBsZXNzIGltcGFjdAo+Pj4gaW4gZW5kLXVzZXIgc3lz dGVtcy4KPj4+Cj4+PiBTaW1pbGFybHkgd2UgY2FuIHJlcGxhY2Ugb3RoZXIgV0FSTl9PTigpIGNv bmRpdGlvbnMgdGhhdCBkb24ndCByZWxhdGUgdG8KPj4+IHRoZSBoYXJkd2FyZSBzdGF0ZSB3aXRo IGVpdGhlciBCVUlMRF9CVUdfT04oKSBmb3IgY29tcGlsZS10aW1lLQo+Pj4gZGV0ZWN0YWJsZSBp c3N1ZXMsIG9yIEdFTV9CVUdfT04oKSBmb3IgbG9naWNhbCAiY2FuJ3QgaGFwcGVuIiBlcnJvcnMu Cj4+Pgo+Pj4gV2l0aCB0aG9zZSBjaGFuZ2VzLCB3ZSBjYW4gY29udmVydCBpdCB0byB2b2lkLCBh cyBzdWdnZXN0ZWQgYnkgQ2hyaXMKPj4+IFdpbHNvbiwgYW5kIHVwZGF0ZSB0aGUgY2FsbGluZyBj b2RlIGFwcHJvcHJpYXRlbHkuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRh dmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPj4+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9ndWNfc3VibWlzc2lvbi5jIHwgNjkgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oICAgICAgICAgICB8ICAyICstCj4+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19md2lmLmggICAgICB8ICAzICstCj4+ PiAgIDMgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMzcgZGVsZXRpb25zKC0pCj4+ Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Np b24uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+Pj4gaW5k ZXggNjYyNmVmZi4uNGQyZWE4NCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9ndWNfc3VibWlzc2lvbi5jCj4+PiBAQCAtNDcwLDIzICs0NzAsMjggQEAgaW50IGk5MTVfZ3Vj X3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPj4+ ICAgCXJldHVybiAtRUFHQUlOOwo+Pj4gICB9Cj4+Pgo+Pj4gLXN0YXRpYyBpbnQgZ3VjX2FkZF93 b3JrcXVldWVfaXRlbShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYywKPj4+IC0JCQkJICBzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKQo+Pj4gK3N0YXRpYyB2b2lkIGd1Y19hZGRfd29y a3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MsCj4+PiArCQkJCSAgIHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4+PiAgIHsKPj4+ICsJLyogd3FpX2xlbiBpcyBp biBEV29yZHMsIGFuZCBkb2VzIG5vdCBpbmNsdWRlIHRoZSBvbmUtd29yZCBoZWFkZXIgKi8KPj4+ ICsJY29uc3Qgc2l6ZV90IHdxaV9zaXplID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4+ Cj4+IEFnYWluLCB1MzIgaXMgY29ycmVjdCBJIHRoaW5rLgo+Pgo+Pj4gKwljb25zdCB1MzIgd3Fp X2xlbiA9IHdxaV9zaXplL3NpemVvZih1MzIpIC0gMTsKPj4+ICAgCXN0cnVjdCBndWNfcHJvY2Vz c19kZXNjICpkZXNjOwo+Pj4gICAJc3RydWN0IGd1Y193cV9pdGVtICp3cWk7Cj4+PiAgIAl2b2lk ICpiYXNlOwo+Pj4gLQl1MzIgdGFpbCwgd3FfbGVuLCB3cV9vZmYsIHNwYWNlOwo+Pj4gKwl1MzIg c3BhY2UsIHRhaWwsIHdxX29mZiwgd3FfcGFnZTsKPj4+Cj4+PiAgIAlkZXNjID0gZ2MtPmNsaWVu dF9iYXNlICsgZ2MtPnByb2NfZGVzY19vZmZzZXQ7Cj4+PiArCj4+PiArCS8qIFNwYWNlIHdhcyBj aGVja2VkIGVhcmxpZXIsIGluIGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKCkgYWJvdmUgKi8KPj4K Pj4gSXQgbWF5IGJlIGFib3ZlIGluIHRoZSBmaWxlLCBidXQgdGhlIHR3byBkbyBub3QgY2FsbCBv bmUgYW5vdGhlciBzbwo+PiBJIHJlY29tbWVuZCBzYXlpbmcgZXhhY3RseSB3aG8gY2FsbGVkIGl0 Lgo+Pgo+Pj4gICAJc3BhY2UgPSBDSVJDX1NQQUNFKGdjLT53cV90YWlsLCBkZXNjLT5oZWFkLCBn Yy0+d3Ffc2l6ZSk7Cj4+PiAtCWlmIChXQVJOX09OKHNwYWNlIDwgc2l6ZW9mKHN0cnVjdCBndWNf d3FfaXRlbSkpKQo+Pj4gLQkJcmV0dXJuIC1FTk9TUEM7IC8qIHNob3VsZG4ndCBoYXBwZW4gKi8K Pj4+ICsJR0VNX0JVR19PTihzcGFjZSA8IHdxaV9zaXplKTsKPj4KPj4gSXQgaXMgaW1wb3NzaWJs ZSB0byBoaXQgdGhpcyBvbmx5IGJlY2F1c2Ugb2YgdGhlIHN0cnVjdF9tdXRleAo+PiBndWFyZGlu ZyB0aGUgd2hvbGUgdGltZSB3aW5kb3cgZnJvbSByZXF1ZXN0IGNyZWF0aW9uIHRvIHN1Ym1pc3Np b24uCj4+IElmIGluIHRoZSBmdXR1cmUsIG5lYXIgb3IgZmFyLCB0aGF0IGdldHMgZml4ZWQsIHRo ZW4gdGhpcyB3aWxsIG5lZWQKPj4gcmV3b3JraW5nLgo+Cj4gUmVxdWVzdCBzdWJtaXNzaW9uIHdp bGwgc3RpbGwgaGF2ZSB0byBzZXJpYWxpc2VkIGJ5IGEgInJpbmciIG11dGV4LAo+IGZyb20gdGhl IHRpbWUgd2UgYWxsb2NhdGUgdGhlIHJlcXVlc3QgdG8gdGhlIHRpbWUgd2UgYWRkIGl0IHRvIHdo YXRldmVyCj4gc3VibWlzc2lvbiBxdWV1ZS4gSXQgc2hvdWxkIHN0aWxsIGhvbGQgdGhhdCB3ZSBj YW4gcGluIGFsbCB0aGUgcmVxdWlyZWQKPiByZXNvdXJjZXMgKHJpbmdidWZmZXIsIGNvbnRleHQg c3RhdGUsIHZtIHBhZ2UgdGFibGVzLCB3b3JrcXVldWVzKSB1cAo+IGZyb250IGFuZCB0YWtlIGFu eSBlcnJvcnMgZWFybHkgYW5kIHRoZW4gcmVseSBvbiBvdXIgcHJlYWxsb2NhdGlvbiB3aGVuCj4g c3VibWl0dGluZyB0aGUgcmVxdWVzdC4KPgo+PiBJIGRvbid0IGhhdmUgYW55IGJldHRlciBpZGVh cyB0aG91Z2guCj4+Cj4+IEJ1dCBhIFdBUk5fT04gYW5kIHJldHVybiB3b3VsZCBiZSBhbG1vc3Qg YXMgZ29vZC4gRXZlcnl0aGluZyBpcwo+PiBiZXR0ZXIgdGhhbiBhIGRlYWQgbWFjaGluZSBvbmUg Y2FuJ3Qgc3NoIGludG8uLi4KPj4KPj4gU28gSSBhcHBlYWwgdG8gbWFrZSB0aGlzIGEgV0FSTl9P TiBhbmQgcmV0dXJuLiBOb3RoaW5nIGJhZCB3b3VsZAo+PiBoYXBwZW4gYXBhcnQgZnJvbSBzb2Z0 d2FyZSB0aGlua2luZyBHUFUgaGFzIGh1bmcuCj4KPiBIZW5jZSB3aHkgbm90IG1ha2UgaXQgYSBi dWc/IElmIHlvdSBjYW4ndCBzc2ggaW4gYmVjYXVzZSB0aGUgZHJpdmVyIGRpZWQKPiBpbnNpZGUg R0VNLCBzb21ldGhpbmcgaXMgdmVyeSB3cm9uZy4KCkkgd2FzIHN1cmUgYnVncyBhcmUga2VybmVs IHBhbmljcywgbG9va3MgbGlrZSBJJ3ZlIGJlZW4gcnVubmluZyB3aXRoIApwYW5pYyBvbiBvb3Bz IGZvciB0b28gbG9uZy4gOigKCkdFTV9CVUdfT04gaXMgb2sgdGhlbi4KClJlZ2FyZHMsCgpUdnJ0 a28KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK