From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com,
daniel.vetter@intel.com, paulo.r.zanoni@intel.com,
sonika.jindal@intel.com, sivakumar.thulasimani@intel.com
Subject: Re: [PATCH 06/12] drm/i915: Add new lspcon file
Date: Tue, 03 May 2016 21:23:53 +0530 [thread overview]
Message-ID: <5728C991.8060405@intel.com> (raw)
In-Reply-To: <87oa8ofrz9.fsf@intel.com>
Regards
Shashank
On 5/2/2016 8:05 PM, Jani Nikula wrote:
> On Mon, 04 Apr 2016, Shashank Sharma <shashank.sharma@intel.com> wrote:
>> This patch adds a new file for lspcon with
>> some basic stuff like:
>> - Some read/wrire addresses for lspcon device
>> - Basic read/write functions, using i2c over aux channel
>> - Utility functions to get lspcon/encoder/connector
>>
>> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
>> Signed-off-by: Akashdeep Sharma <akashdeep.sharma@intel.com>
>> ---
>> drivers/gpu/drm/i915/Makefile | 3 +-
>> drivers/gpu/drm/i915/intel_lspcon.c | 56 +++++++++++++++++++++++++++++++++++++
>> 2 files changed, 58 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/gpu/drm/i915/intel_lspcon.c
>>
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index 5558a03..00a531a 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -90,7 +90,8 @@ i915-y += dvo_ch7017.o \
>> intel_lvds.o \
>> intel_panel.o \
>> intel_sdvo.o \
>> - intel_tv.o
>> + intel_tv.o \
>> + intel_lspcon.o
>
> At the top of the Makefile:
>
> # Please keep these build lists sorted!
>
Ah, dint notice the sorting :), will do that.
>
> BR,
> Jani.
>
>
>
>>
>> # virtual gpu code
>> i915-y += i915_vgpu.o
>> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
>> new file mode 100644
>> index 0000000..5a1993b
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
>> @@ -0,0 +1,56 @@
>> +/*
>> + * Copyright © 2016 Intel Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the "Software"),
>> + * to deal in the Software without restriction, including without limitation
>> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> + * and/or sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the next
>> + * paragraph) shall be included in all copies or substantial portions of the
>> + * Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Authors:
>> + * Shashank Sharma <shashank.sharma@intel.com>
>> + * Akashdeep Sharma <akashdeep.sharma@intel.com>
>> + *
>> + */
>> +#include <drm/drm_edid.h>
>> +#include <drm/drm_atomic_helper.h>
>> +#include <drm/drm_dp_dual_mode_helper.h>
>> +#include "intel_drv.h"
>> +
>> +#define LSPCON_I2C_ADDRESS 0x80
>> +#define LSPCON_MODE_CHANGE_OFFSET 0x40
>> +#define LSPCON_MODE_CHECK_OFFSET 0x41
>> +#define LSPCON_ADAPTER_SIGN_OFFSET 0x00
>> +#define LSPCON_IDENTIFIER_OFFSET 0x10
>> +#define LSPCON_IDENTIFIER_LENGTH 0x10
>> +#define LSPCON_MODE_MASK 0x1
>> +
>> +struct intel_digital_port *lspcon_to_dig_port(struct intel_lspcon *lspcon)
>> +{
>> + return container_of(lspcon, struct intel_digital_port, lspcon);
>> +}
>> +
>> +struct intel_hdmi *lspcon_to_hdmi(struct intel_lspcon *lspcon)
>> +{
>> + return &lspcon_to_dig_port(lspcon)->hdmi;
>> +}
>> +
>> +struct intel_lspcon *enc_to_lspcon(struct drm_encoder *encoder)
>> +{
>> + struct intel_digital_port *intel_dig_port =
>> + container_of(encoder, struct intel_digital_port, base.base);
>> + return &intel_dig_port->lspcon;
>> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-03 15:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 12:01 [PATCH 01/12] drm: Add helper for DP++ adaptors Shashank Sharma
2016-04-04 12:01 ` [PATCH 02/12] drm/i915: Respect DP++ adaptor TMDS clock limit Shashank Sharma
2016-04-04 12:01 ` [PATCH 03/12] drm/i915: Enable/disable TMDS output buffers in DP++ adaptor as needed Shashank Sharma
2016-04-04 12:01 ` [PATCH 04/12] drm/i915: Determine DP++ type 1 DVI adaptor presence based on VBT Shashank Sharma
2016-05-02 14:33 ` Jani Nikula
2016-05-02 14:39 ` Ville Syrjälä
2016-05-03 15:52 ` Sharma, Shashank
2016-04-04 12:01 ` [PATCH 05/12] drm/i915: Add lspcon data structures Shashank Sharma
2016-04-04 12:01 ` [PATCH 06/12] drm/i915: Add new lspcon file Shashank Sharma
2016-05-02 13:37 ` Ville Syrjälä
2016-05-03 15:39 ` Sharma, Shashank
2016-05-02 14:35 ` Jani Nikula
2016-05-03 15:53 ` Sharma, Shashank [this message]
2016-04-04 12:01 ` [PATCH 07/12] drm/i915: Add and initialize lspcon connector Shashank Sharma
2016-04-25 21:34 ` Zanoni, Paulo R
2016-04-04 12:01 ` [PATCH 08/12] drm: Add lspcon (custom type2 dp->hdmi) support Shashank Sharma
2016-05-02 13:49 ` Ville Syrjälä
2016-05-03 15:45 ` Sharma, Shashank
2016-05-03 15:59 ` Ville Syrjälä
2016-05-03 16:09 ` Sharma, Shashank
2016-05-03 17:19 ` Ville Syrjälä
2016-04-04 12:01 ` [PATCH 09/12] drm/i915: Add and register lspcon connector functions Shashank Sharma
2016-04-04 12:01 ` [PATCH 10/12] drm/i915: Add lspcon core functions Shashank Sharma
2016-05-02 13:51 ` Ville Syrjälä
2016-05-03 15:48 ` Sharma, Shashank
2016-05-03 16:09 ` Ville Syrjälä
2016-05-03 16:14 ` Sharma, Shashank
2016-05-04 21:09 ` Zanoni, Paulo R
2016-05-06 10:16 ` Ville Syrjälä
2016-04-04 12:01 ` [PATCH 11/12] drm/i915: Add lspcon hpd handler Shashank Sharma
2016-04-04 12:01 ` [PATCH 12/12] DO_NOT_MERGE: drm/i915: Hack to enable lspcon initialization Shashank Sharma
2016-04-06 12:18 ` Jani Nikula
2016-04-06 13:02 ` Sharma, Shashank
2016-04-04 13:33 ` ✗ Fi.CI.BAT: failure for series starting with [01/12] drm: Add helper for DP++ adaptors Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728C991.8060405@intel.com \
--to=shashank.sharma@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=sivakumar.thulasimani@intel.com \
--cc=sonika.jindal@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox