From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 2/5] drm/i915/guc: pass request (not client) to i915_guc_{wq_check_space, submit}() Date: Tue, 3 May 2016 20:22:05 +0100 Message-ID: <5728FA5D.4050907@intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-2-git-send-email-david.s.gordon@intel.com> <57237907.4020808@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D20C6E3A5 for ; Tue, 3 May 2016 19:22:07 +0000 (UTC) In-Reply-To: <57237907.4020808@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjkvMDQvMTYgMTY6MDgsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMjcvMDQvMTYg MTk6MDMsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBUaGUga25vd2xlZGdlIG9mIGhvdyB0byBkZXJp dmUgdGhlIHJlbGV2YW50IGNsaWVudCBmcm9tIHRoZSByZXF1ZXN0Cj4+IHNob3VsZCBiZSBsb2Nh bGlzZWQgd2l0aGluIGk5MTVfZ3VjX3N1Ym1pc3Npb24uYzsgdGhlIExSQyBjb2RlIHNob3VsZG4n dAo+PiBoYXZlIHRvIGtub3cgYWJvdXQgdGhlIGludGVybmFsIGRldGFpbHMgb2YgdGhlIEd1QyBz dWJtaXNzaW9uIHByb2Nlc3MuCj4+IEFuZCBhbGwgdGhlIGluZm9ybWF0aW9uIHRoZSBHdUMgY29k ZSBuZWVkcyBzaG91bGQgYmUgZW5jYXBzdWxhdGVkIGluIChvcgo+PiByZWFjaGFibGUgZnJvbSkg dGhlIHJlcXVlc3QuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdv cmRvbkBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj X3N1Ym1pc3Npb24uYyB8IDExICsrKysrKy0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjLmggICAgICAgICAgIHwgIDUgKystLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYyAgICAgICAgICAgfCAgOSArKystLS0tLS0KPj4gICAzIGZpbGVzIGNoYW5n ZWQsIDExIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGluZGV4IDQyZDJlZmEuLjY2YWY1 Y2UgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Np b24uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMK Pj4gQEAgLTQ1MSwxMCArNDUxLDExIEBAIHN0YXRpYyB2b2lkIGd1Y19maW5pX2N0eF9kZXNjKHN0 cnVjdCBpbnRlbF9ndWMKPj4gKmd1YywKPj4gICAgICAgICAgICAgICAgICAgIHNpemVvZihkZXNj KSAqIGNsaWVudC0+Y3R4X2luZGV4KTsKPj4gICB9Cj4+Cj4+IC1pbnQgaTkxNV9ndWNfd3FfY2hl Y2tfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MpCj4+ICtpbnQgaTkxNV9ndWNfd3Ff Y2hlY2tfc3BhY2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+PiAgIHsK Pj4gKyAgICBjb25zdCBzaXplX3Qgc2l6ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+ Cj4gQWxsIHRoZSBvdGhlciB2YXJpYWJsZXMgcGFzc2VkIHRvIENJUkNfU1BBQ0UgYXJlIHUzMiBz byB0aGlzIGlzIGZvciB0aGUKPiB3b3JzZSBJIHRoaW5rLgoKVGhpcyBpc24ndCBwYXNzZWQgdG8g Q0lSQ19TUEFDRTsgdGhpcyBpcyB3aGF0IHRoZSByZXN1bHQgb2YgQ0lSQ19TUEFDRSAKaXMgY29t cGFyZWQgYWdhaW5zdC4gQXMgaXQncyBhIGNvbnN0YW50LCBnY2Mga25vd3MgaG93IGJpZyBpdCBu ZWVkcyB0byAKYmUgdG8gY29ycmVjdGx5IHJlcHJlc2VudCBpdHMgYWN0dWFsIHZhbHVlLCBzbyB3 aGV0aGVyIHRoaXMgaXMgdGhlIApsb2dpY2FsbHkgY29ycmVjdCAic2l6ZV90IiAoYXMgaXQgcmVw cmVzZW50cyBhIHNpemUpIG9yIHRoZSBwcmFjdGljYWwgCiJ1MzIiIG9yIGV2ZW4gInU4IiAoYXMg d2Uga25vdyBpdCB3aWxsIGZpdCksIHRoZSBnZW5lcmF0ZWQgY29kZSBpcyAKaWRlbnRpY2FsIChh bmQgSSdkIGhvcGUgdGhlIGNvbXBpbGVyIHdvdWxkIHdhcm4gdXMgaWYgaXQgbWFkZSBhIApkaWZm ZXJlbmNlLCBlLmcuIHVzaW5nIHU4IGZvciBhIHNpemVvZigpIGV4cHJlc3Npb24gZ3JlYXRlciB0 aGFuIDI1NikuCgpJbnRlcmVzdGluZ2x5LCB0aGUgZXhwZWN0ZWQgdmFsdWUgInNpemVvZihzdHJ1 Y3Qgd29ya19xdWV1ZV9pdGVtKSIgaXMgCjE2LCBidXQgdGhhdCBkb2Vzbid0IGFwcGVhciBpbiB0 aGUgY29kZSBhdCBhbGwgLS0gaW5zdGVhZCBnY2MgY29tcGFyZXMgCmFnYWluc3QgMTUgc28gaXQg Y2FuIHVzZSAiamJlIiAoSnVtcCBpZiBCZWxvdyBvciBFcXVhbCkgdG8gZ2V0IAp1bnNpZ25lZC1j b21wYXJpc29uIHNlbWFudGljcy4KCi5EYXZlLgoKPj4gKyAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xp ZW50ICpnYyA9IHJlcXVlc3QtPmk5MTUtPmd1Yy5leGVjYnVmX2NsaWVudDsKPj4gICAgICAgc3Ry dWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4+IC0gICAgdTMyIHNpemUgPSBzaXplb2Yoc3Ry dWN0IGd1Y193cV9pdGVtKTsKPj4gICAgICAgaW50IHJldCA9IC1FVElNRURPVVQsIHRpbWVvdXRf Y291bnRlciA9IDIwMDsKPj4KPj4gICAgICAgaWYgKCFnYykKPj4gQEAgLTUzNywxMSArNTM4LDEx IEBAIHN0YXRpYyBpbnQgZ3VjX2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QKPj4gaTkxNV9ndWNf Y2xpZW50ICpnYywKPj4gICAgKgo+PiAgICAqIFJldHVybjogICAgMCBpZiBzdWNjZWVkCj4+ICAg ICovCj4+IC1pbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVu dCwKPj4gLSAgICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4+ICtp bnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4+ICAg ewo+PiAtICAgIHN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGNsaWVudC0+Z3VjOwo+PiAgICAgICB1 bnNpZ25lZCBpbnQgZW5naW5lX2lkID0gcnEtPmVuZ2luZS0+Z3VjX2lkOwo+PiArICAgIHN0cnVj dCBpbnRlbF9ndWMgKmd1YyA9ICZycS0+aTkxNS0+Z3VjOwo+PiArICAgIHN0cnVjdCBpOTE1X2d1 Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY2J1Zl9jbGllbnQ7Cj4+ICAgICAgIGludCBxX3Jl dCwgYl9yZXQ7Cj4+Cj4+ICAgICAgIHFfcmV0ID0gZ3VjX2FkZF93b3JrcXVldWVfaXRlbShjbGll bnQsIHJxKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5o Cj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gaW5kZXggOWQ3OWM0Yy4u YjM3YzczMSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gQEAgLTE0OCwxMCAr MTQ4LDkgQEAgZXh0ZXJuIGludCBpbnRlbF9ndWNfcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpOwo+PiAgIC8qIGk5MTVfZ3VjX3N1Ym1pc3Npb24uYyAqLwo+PiAgIGludCBpOTE1X2d1Y19z dWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+ICAgaW50IGk5MTVfZ3Vj X3N1Ym1pc3Npb25fZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+PiAtaW50IGk5MTVf Z3VjX3N1Ym1pdChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQsCj4+IC0gICAgICAgICAg ICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPj4gK2ludCBpOTE1X2d1Y193cV9j aGVja19zcGFjZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPj4gK2ludCBpOTE1 X2d1Y19zdWJtaXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4+ICAgdm9pZCBp OTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+ICAg dm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+ IC1pbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xp ZW50KTsKPj4KPj4gICAjZW5kaWYKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5k ZXggMmI3ZTZiYi4uYjhlYzhjNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4g QEAgLTcwOCw5ICs3MDgsNyBAQCBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3Rf ZXh0cmFzKHN0cnVjdAo+PiBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdAo+PiAgICAgICAg ICAgICogZ29pbmcgYW55IGZ1cnRoZXIsIGFzIHRoZSBpOTE1X2FkZF9yZXF1ZXN0KCkgY2FsbAo+ PiAgICAgICAgICAgICogbGF0ZXIgb24gbXVzdG4ndCBmYWlsIC4uLgo+PiAgICAgICAgICAgICov Cj4+IC0gICAgICAgIHN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZyZXF1ZXN0LT5pOTE1LT5ndWM7 Cj4+IC0KPj4gLSAgICAgICAgcmV0ID0gaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2UoZ3VjLT5leGVj YnVmX2NsaWVudCk7Cj4+ICsgICAgICAgIHJldCA9IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHJl cXVlc3QpOwo+PiAgICAgICAgICAgaWYgKHJldCkKPj4gICAgICAgICAgICAgICByZXR1cm4gcmV0 Owo+PiAgICAgICB9Cj4+IEBAIC03NzYsNyArNzc0LDYgQEAgc3RhdGljIGludCBsb2dpY2FsX3Jp bmdfd2FpdF9mb3Jfc3BhY2Uoc3RydWN0Cj4+IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4+ ICAgaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2VfYW5kX3N1Ym1pdChzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QKPj4gKnJlcXVlc3QpCj4+ICAgewo+PiAgICAgICBzdHJ1Y3QgaW50ZWxfcmlu Z2J1ZmZlciAqcmluZ2J1ZiA9IHJlcXVlc3QtPnJpbmdidWY7Cj4+IC0gICAgc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcmVxdWVzdC0+aTkxNTsKPj4gICAgICAgc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcmVxdWVzdC0+ZW5naW5lOwo+Pgo+PiAgICAgICBpbnRl bF9sb2dpY2FsX3JpbmdfYWR2YW5jZShyaW5nYnVmKTsKPj4gQEAgLTgwNiw4ICs4MDMsOCBAQCBz dGF0aWMgaW50IGxvZ2ljYWxfcmluZ193YWl0X2Zvcl9zcGFjZShzdHJ1Y3QKPj4gZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnJlcSwKPj4gICAgICAgICAgIH0KPj4gICAgICAgfQo+Pgo+PiAtICAgIGlm IChkZXZfcHJpdi0+Z3VjLmV4ZWNidWZfY2xpZW50KQo+PiAtICAgICAgICBpOTE1X2d1Y19zdWJt aXQoZGV2X3ByaXYtPmd1Yy5leGVjYnVmX2NsaWVudCwgcmVxdWVzdCk7Cj4+ICsgICAgaWYgKGk5 MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKQo+PiArICAgICAgICBpOTE1X2d1Y19zdWJtaXQocmVx dWVzdCk7Cj4+ICAgICAgIGVsc2UKPj4gICAgICAgICAgIGV4ZWNsaXN0c19jb250ZXh0X3F1ZXVl KHJlcXVlc3QpOwo+Pgo+Pgo+Cj4gV2l0aCB0aGUgZGF0YXR5cGUgZml4IChyZXZlcnQpIGluIGk5 MTVfZ3VjX3dxX2NoZWNrX3NwYWNlOgo+Cj4gUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBSZWdhcmRzLAo+Cj4gVHZydGtvCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK