From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode Date: Wed, 4 May 2016 12:35:09 +0100 Message-ID: <5729DE6D.7080209@intel.com> References: <1461860672-12623-1-git-send-email-chris@chris-wilson.co.uk> <1461860672-12623-3-git-send-email-chris@chris-wilson.co.uk> <57231D15.10503@linux.intel.com> <20160429084935.GD30680@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0172164259==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 14D1D6E7C0 for ; Wed, 4 May 2016 11:35:16 +0000 (UTC) In-Reply-To: <20160429084935.GD30680@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0172164259== Content-Type: multipart/alternative; boundary="------------000302000801090404000605" This is a multi-part message in MIME format. --------------000302000801090404000605 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 29/04/2016 09:49, Chris Wilson wrote: > On Fri, Apr 29, 2016 at 09:36:37AM +0100, Tvrtko Ursulin wrote: >> On 28/04/16 17:24, Chris Wilson wrote: >>> With the introduction of a distinct engine->id vs the hardware id, we need >>> to fix up the value we use for selecting the target engine when signaling >>> a semaphore. Note that these values can be merged with engine->guc_id. >> So I broke something more with the decoupling, did not realize. I >> suppose it was still worth it. This at least wasn't being used. > A consolation prize: wean the guc over to a common hw_id :) > -Chris As in, use the GuC's concept of the engine ID for other purposes too? .Dave. --------------000302000801090404000605 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 29/04/2016 09:49, Chris Wilson wrote:
On Fri, Apr 29, 2016 at 09:36:37AM +0100, Tvrtko Ursulin wrote:

On 28/04/16 17:24, Chris Wilson wrote:

With the introduction of a distinct engine->id vs the hardware id, we need
to fix up the value we use for selecting the target engine when signaling
a semaphore. Note that these values can be merged with engine->guc_id.

So I broke something more with the decoupling, did not realize. I
suppose it was still worth it. This at least wasn't being used.

A consolation prize: wean the guc over to a common hw_id :)
-Chris
As in, use the GuC's concept of the engine ID for other purposes too?

.Dave.
--------------000302000801090404000605-- --===============0172164259== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0172164259==--