From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/core: Do not preserve framebuffer on rmfb, v4. Date: Thu, 5 May 2016 10:07:57 +0100 Message-ID: <572B0D6D.4020802@linux.intel.com> References: <1458640720-2526-1-git-send-email-maarten.lankhorst@linux.intel.com> <1459423563-27558-1-git-send-email-maarten.lankhorst@linux.intel.com> <5728932D.90003@vmware.com> <6c63ca37-0e7e-ac7f-a6d2-c7822e3d611f@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6c63ca37-0e7e-ac7f-a6d2-c7822e3d611f@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , Thomas Hellstrom , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, David Herrmann List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzA1LzE2IDEzOjM4LCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiBJdCB0dXJucyBv dXQgdGhhdCBwcmVzZXJ2aW5nIGZyYW1lYnVmZmVycyBhZnRlciB0aGUgcm1mYiBjYWxsIGJyZWFr cwo+IHZtd2dmeCB1c2Vyc3BhY2UuIFRoaXMgd2FzIG9yaWdpbmFsbHkgaW50cm9kdWNlZCBiZWNh dXNlIGl0IHdhcyB0aG91Z2h0Cj4gbm9ib2R5IHJlbGllZCBvbiB0aGUgYmVoYXZpb3IsIGJ1dCB1 bmZvcnR1bmF0ZWx5IGl0IHNlZW1zIHRoZXJlIGFyZQo+IGV4Y2VwdGlvbnMuCj4KPiBkcm1fZnJh bWVidWZmZXJfcmVtb3ZlIG1heSBmYWlsIHdpdGggLUVJTlRSIG5vdywgc28gYSBzdHJhaWdodCBy ZXZlcnQKPiBpcyBpbXBvc3NpYmxlLiBUaGVyZSBpcyBubyB3YXkgdG8gcmVtb3ZlIHRoZSBmcmFt ZWJ1ZmZlciBmcm9tIHRoZSBsaXN0cwo+IGFuZCBhY3RpdmUgcGxhbmVzIHdpdGhvdXQgaW50cm9k dWNpbmcgYSByYWNlIGJlY2F1c2Ugb2YgdGhlIGRpZmZlcmVudAo+IGxvY2tpbmcgcmVxdWlyZW1l bnRzLiBJbnN0ZWFkIGNhbGwgZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSBmcm9tIGEKPiB3b3JrcXVl dWUsIHdoaWNoIGlzIHVuYWZmZWN0ZWQgYnkgc2lnbmFscy4KPgo+IENoYW5nZXMgc2luY2UgdjE6 Cj4gLSBBZGQgY29tbWVudC4KPiBDaGFuZ2VzIHNpbmNlIHYyOgo+IC0gQWRkIGZhc3RwYXRoIGZv ciByZWZjb3VudCA9IDEuIChkYW52ZXQpCj4gQ2hhbmdlcyBzaW5jZSB2MzoKPiAtIFJlYmFzZWQu Cj4gLSBSZXN0b3JlIGxhc3RjbG9zZSBmcmFtZWJ1ZmZlciByZW1vdmFsIHRvby4KPgo+IENjOiBz dGFibGVAdmdlci5rZXJuZWwub3JnICN2NC40Kwo+IEZpeGVzOiAxMzgwMzEzMjgxOGMgKCJkcm0v Y29yZTogUHJlc2VydmUgdGhlIGZyYW1lYnVmZmVyIGFmdGVyIHJlbW92aW5nIGl0LiIpCj4gVGVz dGNhc2U6IGttc19ybWZiX2Jhc2ljCj4gUmVmZXJlbmNlczogaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTYtTWFyY2gvMTAyODc2Lmh0bWwKPiBDYzog VGhvbWFzIEhlbGxzdHJvbSA8dGhlbGxzdHJvbUB2bXdhcmUuY29tPgo+IENjOiBEYXZpZCBIZXJy bWFubiA8ZGguaGVycm1hbm5AZ21haWwuY29tPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFRlc3RlZC1ieTogVGhvbWFzIEhlbGxzdHJvbSA8 dGhlbGxzdHJvbUB2bXdhcmUuY29tPiAjdjMKCkNhbid0IGJlIDEwMCUgc2luY2UgYXBwYXJlbnRs eSBlRFAgcmVncmVzc2VkIGEgbG90IHJlY2VudGx5IGZvciBtZSwgYnV0IApzZWVtcyB0byBiZSBl ZmZlY3RpdmUgaW4gZ2V0dGluZyByaWQgb2Ygc3RhbGUgcGxhbmVzIGluIG15IHRlc3QgY2FzZXMu CgpUZXN0ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpS ZWdhcmRzLAoKVHZydGtvCgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCA2 MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gICAxIGZp bGUgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0 Yy5jCj4gaW5kZXggOTYyNmEwY2MwNTBhLi45YTNkMTdiNzAwOTEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMu Ywo+IEBAIC0zNDQwLDYgKzM0NDAsMjQgQEAgaW50IGRybV9tb2RlX2FkZGZiMihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+ICAgCXJldHVybiAwOwo+ICAgfQo+Cj4gK3N0cnVjdCBkcm1fbW9kZV9y bWZiX3dvcmsgewo+ICsJc3RydWN0IHdvcmtfc3RydWN0IHdvcms7Cj4gKwlzdHJ1Y3QgbGlzdF9o ZWFkIGZiczsKPiArfTsKPiArCj4gK3N0YXRpYyB2b2lkIGRybV9tb2RlX3JtZmJfd29ya19mbihz dHJ1Y3Qgd29ya19zdHJ1Y3QgKncpCj4gK3sKPiArCXN0cnVjdCBkcm1fbW9kZV9ybWZiX3dvcmsg KmFyZyA9IGNvbnRhaW5lcl9vZih3LCB0eXBlb2YoKmFyZyksIHdvcmspOwo+ICsKPiArCXdoaWxl ICghbGlzdF9lbXB0eSgmYXJnLT5mYnMpKSB7Cj4gKwkJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAq ZmIgPQo+ICsJCQlsaXN0X2ZpcnN0X2VudHJ5KCZhcmctPmZicywgdHlwZW9mKCpmYiksIGZpbHBf aGVhZCk7Cj4gKwo+ICsJCWxpc3RfZGVsX2luaXQoJmZiLT5maWxwX2hlYWQpOwo+ICsJCWRybV9m cmFtZWJ1ZmZlcl9yZW1vdmUoZmIpOwo+ICsJfQo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBkcm1f bW9kZV9ybWZiIC0gcmVtb3ZlIGFuIEZCIGZyb20gdGhlIGNvbmZpZ3VyYXRpb24KPiAgICAqIEBk ZXY6IGRybSBkZXZpY2UgZm9yIHRoZSBpb2N0bAo+IEBAIC0zNDgwLDEyICszNDk4LDI5IEBAIGlu dCBkcm1fbW9kZV9ybWZiKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAJbGlzdF9kZWxfaW5p dCgmZmItPmZpbHBfaGVhZCk7Cj4gICAJbXV0ZXhfdW5sb2NrKCZmaWxlX3ByaXYtPmZic19sb2Nr KTsKPgo+IC0JLyogd2Ugbm93IG93biB0aGUgcmVmZXJlbmNlIHRoYXQgd2FzIHN0b3JlZCBpbiB0 aGUgZmJzIGxpc3QgKi8KPiAtCWRybV9mcmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShmYik7Cj4gLQo+ ICAgCS8qIGRyb3AgdGhlIHJlZmVyZW5jZSB3ZSBwaWNrZWQgdXAgaW4gZnJhbWVidWZmZXIgbG9v a3VwICovCj4gICAJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPgo+ICsJLyoKPiAr CSAqIHdlIG5vdyBvd24gdGhlIHJlZmVyZW5jZSB0aGF0IHdhcyBzdG9yZWQgaW4gdGhlIGZicyBs aXN0Cj4gKwkgKgo+ICsJICogZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSBtYXkgZmFpbCB3aXRoIC1F SU5UUiBvbiBwZW5kaW5nIHNpZ25hbHMsCj4gKwkgKiBzbyBydW4gdGhpcyBpbiBhIHNlcGFyYXRl IHN0YWNrIGFzIHRoZXJlJ3Mgbm8gd2F5IHRvIGNvcnJlY3RseQo+ICsJICogaGFuZGxlIHRoaXMg YWZ0ZXIgdGhlIGZiIGlzIGFscmVhZHkgcmVtb3ZlZCBmcm9tIHRoZSBsb29rdXAgdGFibGUuCj4g KwkgKi8KPiArCWlmIChkcm1fZnJhbWVidWZmZXJfcmVhZF9yZWZjb3VudChmYikgPiAxKSB7Cj4g KwkJc3RydWN0IGRybV9tb2RlX3JtZmJfd29yayBhcmc7Cj4gKwo+ICsJCUlOSVRfV09SS19PTlNU QUNLKCZhcmcud29yaywgZHJtX21vZGVfcm1mYl93b3JrX2ZuKTsKPiArCQlJTklUX0xJU1RfSEVB RCgmYXJnLmZicyk7Cj4gKwkJbGlzdF9hZGRfdGFpbCgmZmItPmZpbHBfaGVhZCwgJmFyZy5mYnMp Owo+ICsKPiArCQlzY2hlZHVsZV93b3JrKCZhcmcud29yayk7Cj4gKwkJZmx1c2hfd29yaygmYXJn LndvcmspOwo+ICsJCWRlc3Ryb3lfd29ya19vbl9zdGFjaygmYXJnLndvcmspOwo+ICsJfSBlbHNl Cj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPiArCj4gICAJcmV0dXJuIDA7 Cj4KPiAgIGZhaWxfdW5yZWY6Cj4gQEAgLTM2MzUsNyArMzY3MCw2IEBAIG91dF9lcnIxOgo+ICAg CXJldHVybiByZXQ7Cj4gICB9Cj4KPiAtCj4gICAvKioKPiAgICAqIGRybV9mYl9yZWxlYXNlIC0g cmVtb3ZlIGFuZCBmcmVlIHRoZSBGQnMgb24gdGhpcyBmaWxlCj4gICAgKiBAcHJpdjogZHJtIGZp bGUgZm9yIHRoZSBpb2N0bAo+IEBAIC0zNjUwLDYgKzM2ODQsOSBAQCBvdXRfZXJyMToKPiAgIHZv aWQgZHJtX2ZiX3JlbGVhc2Uoc3RydWN0IGRybV9maWxlICpwcml2KQo+ICAgewo+ICAgCXN0cnVj dCBkcm1fZnJhbWVidWZmZXIgKmZiLCAqdGZiOwo+ICsJc3RydWN0IGRybV9tb2RlX3JtZmJfd29y ayBhcmc7Cj4gKwo+ICsJSU5JVF9MSVNUX0hFQUQoJmFyZy5mYnMpOwo+Cj4gICAJLyoKPiAgIAkg KiBXaGVuIHRoZSBmaWxlIGdldHMgcmVsZWFzZWQgdGhhdCBtZWFucyBubyBvbmUgZWxzZSBjYW4g YWNjZXNzIHRoZSBmYgo+IEBAIC0zNjYyLDEwICszNjk5LDIyIEBAIHZvaWQgZHJtX2ZiX3JlbGVh c2Uoc3RydWN0IGRybV9maWxlICpwcml2KQo+ICAgCSAqIGF0IGl0IGFueSBtb3JlLgo+ICAgCSAq Lwo+ICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShmYiwgdGZiLCAmcHJpdi0+ZmJzLCBmaWxw X2hlYWQpIHsKPiAtCQlsaXN0X2RlbF9pbml0KCZmYi0+ZmlscF9oZWFkKTsKPiArCQlpZiAoZHJt X2ZyYW1lYnVmZmVyX3JlYWRfcmVmY291bnQoZmIpID4gMSkgewo+ICsJCQlsaXN0X21vdmVfdGFp bCgmZmItPmZpbHBfaGVhZCwgJmFyZy5mYnMpOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCWxpc3RfZGVs X2luaXQoJmZiLT5maWxwX2hlYWQpOwo+Cj4gLQkJLyogVGhpcyBkcm9wcyB0aGUgZnByaXYtPmZi cyByZWZlcmVuY2UuICovCj4gLQkJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPiAr CQkJLyogVGhpcyBkcm9wcyB0aGUgZnByaXYtPmZicyByZWZlcmVuY2UuICovCj4gKwkJCWRybV9m cmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShmYik7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlmICghbGlz dF9lbXB0eSgmYXJnLmZicykpIHsKPiArCQlJTklUX1dPUktfT05TVEFDSygmYXJnLndvcmssIGRy bV9tb2RlX3JtZmJfd29ya19mbik7Cj4gKwo+ICsJCXNjaGVkdWxlX3dvcmsoJmFyZy53b3JrKTsK PiArCQlmbHVzaF93b3JrKCZhcmcud29yayk7Cj4gKwkJZGVzdHJveV93b3JrX29uX3N0YWNrKCZh cmcud29yayk7Cj4gICAJfQo+ICAgfQo+Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==