From: Nick Hoath <nicholas.hoath@intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
"Antoine, Peter" <peter.antoine@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v3] drm/i915: resize the GuC WOPCM for rc6
Date: Fri, 6 May 2016 10:37:33 +0100 [thread overview]
Message-ID: <572C65DD.1080500@intel.com> (raw)
In-Reply-To: <572B6119.8010105@intel.com>
On 05/05/2016 16:04, Dave Gordon wrote:
> On 05/05/2016 15:02, Antoine, Peter wrote:
>> The attached version still does not explain that the WOPCM_TOP is to tell the GuC not to use that space.
>
> That's NOT what WOPCM_TOP means. The GuC is allowed to use the space up
> to the value stored in the GUC_WOPCM_SIZE register (as the comment above
> the #define says). Architecturally, this is allowed to be any value
> greater than (16K+sizeof internal SRAM (64, 128, or 256K)) and less than
> or equal to GUC_WOPCM_TOP (which is a platform-independent constant), so
> we normally choose the maximm allowed. Howver on BXT, we need to leave
> some space at the top for the RC6 image, hence the logic (and comments!)
> in guc_wopcm_size().
>
>> The extra information does not aid anybody as the information is used internally within the GuC.
> It may help the next person who has to figure out what's gone wrong on
> some future chip that needs more than 64K for RC6!
>
> .Dave.
>>
>> But, I have not actual objection to the patch.
>>
>> Peter.
>>
>
Unfortunately Dave's patch locked my test system on bootup, so I've t-b
& r-b'd Peter's.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-06 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 9:11 [PATCH v3] drm/i915: resize the GuC WOPCM for rc6 Peter Antoine
2016-04-26 10:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-26 10:38 ` Peter Antoine
2016-04-26 14:20 ` Daniel Vetter
2016-05-12 16:29 ` Antoine, Peter
2016-05-05 13:41 ` [PATCH v3] " Dave Gordon
2016-05-05 14:02 ` Antoine, Peter
2016-05-05 15:04 ` Dave Gordon
2016-05-06 7:01 ` Peter Antoine
2016-05-06 9:36 ` Nick Hoath
2016-05-06 9:37 ` Nick Hoath [this message]
2016-05-06 12:18 ` Dave Gordon
2016-05-16 14:12 ` Nick Hoath
2016-05-10 15:59 ` Bob Paauwe
2016-05-10 18:46 ` Antoine, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572C65DD.1080500@intel.com \
--to=nicholas.hoath@intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peter.antoine@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox