From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 3/5] drm/i915/guc: don't spinwait if the GuC's workqueue is full Date: Fri, 6 May 2016 16:17:59 +0100 Message-ID: <572CB5A7.3080400@intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-3-git-send-email-david.s.gordon@intel.com> <57238190.9030304@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id E09CE6EB03 for ; Fri, 6 May 2016 15:18:00 +0000 (UTC) In-Reply-To: <57238190.9030304@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjkvMDQvMTYgMTY6NDUsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT25lIGxhdGUgY29t bWVudDoKPgo+IE9uIDI3LzA0LzE2IDE5OjAzLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gUmF0aGVy IHRoYW4gd2FpdCB0byBzZWUgd2hldGhlciBtb3JlIHNwYWNlIGJlY29tZXMgYXZhaWxhYmxlIGlu IHRoZSBHdUMKPj4gc3VibWlzc2lvbiB3b3JrcXVldWUsIHdlIGNhbiBqdXN0IHJldHVybiAtRUFH QUlOIGFuZCBsZXQgdGhlIGNhbGxlciB0cnkKPj4gYWdhaW4gaW4gYSBsaXR0bGUgd2hpbGUuIFRo aXMgZ2V0cyByaWQgb2YgYW4gdW5pbnRlcnJ1cHRhYmxlIHNsZWVwIGluCj4+IHRoZSBwb2xsaW5n IGNvZGUgOikKPj4KPj4gV2UnbGwgYWxzbyBhZGQgYSBjb3VudGVyIHRvIHRoZSBHdUMgY2xpZW50 IHN0YXRpc3RpY3MsIHRvIHNlZSBob3cgb2Z0ZW4KPj4gd2UgZmluZCB0aGUgV1EgZnVsbC4KPj4K Pj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4K Pj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAgIHwg IDEgKwo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDE2 ICsrKysrLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCAg ICAgICAgICAgfCAgOCArKysrLS0tLQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9u cygrKSwgMTUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RlYnVnZnMuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jCj4+IGluZGV4IDhiOGQ2ZjAuLjEwMjQ5NDcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jCj4+IEBAIC0yNTA5LDYgKzI1MDksNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2d1 Y19jbGllbnRfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUKPj4gKm0sCj4+ICAgICAgIHNlcV9wcmludGYo bSwgIlx0V1Egc2l6ZSAlZCwgb2Zmc2V0OiAweCV4LCB0YWlsICVkXG4iLAo+PiAgICAgICAgICAg Y2xpZW50LT53cV9zaXplLCBjbGllbnQtPndxX29mZnNldCwgY2xpZW50LT53cV90YWlsKTsKPj4K Pj4gKyAgICBzZXFfcHJpbnRmKG0sICJcdFdvcmsgcXVldWUgZnVsbDogJXVcbiIsIGNsaWVudC0+ bm9fd3Ffc3BhY2UpOwo+PiAgICAgICBzZXFfcHJpbnRmKG0sICJcdEZhaWxlZCB0byBxdWV1ZTog JXVcbiIsIGNsaWVudC0+cV9mYWlsKTsKPj4gICAgICAgc2VxX3ByaW50ZihtLCAiXHRGYWlsZWQg ZG9vcmJlbGw6ICV1XG4iLCBjbGllbnQtPmJfZmFpbCk7Cj4+ICAgICAgIHNlcV9wcmludGYobSwg Ilx0TGFzdCBzdWJtaXNzaW9uIHJlc3VsdDogJWRcbiIsIGNsaWVudC0+cmV0Y29kZSk7Cj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4g Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gaW5kZXggNjZh ZjVjZS4uNjYyNmVmZiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n dWNfc3VibWlzc2lvbi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1 Ym1pc3Npb24uYwo+PiBAQCAtNDUzLDI3ICs0NTMsMjEgQEAgc3RhdGljIHZvaWQgZ3VjX2Zpbmlf Y3R4X2Rlc2Moc3RydWN0IGludGVsX2d1Ywo+PiAqZ3VjLAo+Pgo+PiAgIGludCBpOTE1X2d1Y193 cV9jaGVja19zcGFjZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4+ICAg ewo+PiAtICAgIGNvbnN0IHNpemVfdCBzaXplID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7 Cj4+ICsgICAgY29uc3Qgc2l6ZV90IHdxaV9zaXplID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRl bSk7Cj4+ICAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjID0gcmVxdWVzdC0+aTkxNS0+ Z3VjLmV4ZWNidWZfY2xpZW50Owo+PiAgICAgICBzdHJ1Y3QgZ3VjX3Byb2Nlc3NfZGVzYyAqZGVz YzsKPj4gLSAgICBpbnQgcmV0ID0gLUVUSU1FRE9VVCwgdGltZW91dF9jb3VudGVyID0gMjAwOwo+ Pgo+PiAgICAgICBpZiAoIWdjKQo+PiAgICAgICAgICAgcmV0dXJuIDA7Cj4+Cj4+ICAgICAgIGRl c2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNjX29mZnNldDsKPj4KPj4gLSAgICB3 aGlsZSAodGltZW91dF9jb3VudGVyLS0gPiAwKSB7Cj4+IC0gICAgICAgIGlmIChDSVJDX1NQQUNF KGdjLT53cV90YWlsLCBkZXNjLT5oZWFkLCBnYy0+d3Ffc2l6ZSkgPj0gc2l6ZSkgewo+PiAtICAg ICAgICAgICAgcmV0ID0gMDsKPj4gLSAgICAgICAgICAgIGJyZWFrOwo+PiAtICAgICAgICB9Cj4+ ICsgICAgaWYgKENJUkNfU1BBQ0UoZ2MtPndxX3RhaWwsIGRlc2MtPmhlYWQsIGdjLT53cV9zaXpl KSA+PSB3cWlfc2l6ZSkKPj4gKyAgICAgICAgcmV0dXJuIDA7Cj4+Cj4+IC0gICAgICAgIGlmICh0 aW1lb3V0X2NvdW50ZXIpCj4+IC0gICAgICAgICAgICB1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7 Cj4+IC0gICAgfTsKPj4gKyAgICBnYy0+bm9fd3Ffc3BhY2UgKz0gMTsKPj4KPj4gLSAgICByZXR1 cm4gcmV0Owo+PiArICAgIHJldHVybiAtRUFHQUlOOwo+PiAgIH0KPj4KPj4gICBzdGF0aWMgaW50 IGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MsCj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+PiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+IGluZGV4IGIzN2M3MzEuLjQzNmYyZDYgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+IEBAIC03MywxMCArNzMsMTAgQEAgc3RydWN0 IGk5MTVfZ3VjX2NsaWVudCB7Cj4+Cj4+ICAgICAgIC8qIEd1QyBzdWJtaXNzaW9uIHN0YXRpc3Rp Y3MgJiBzdGF0dXMgKi8KPj4gICAgICAgdWludDY0X3Qgc3VibWlzc2lvbnNbR1VDX01BWF9FTkdJ TkVTX05VTV07Cj4+IC0gICAgdWludDMyX3QgcV9mYWlsOwo+PiAtICAgIHVpbnQzMl90IGJfZmFp bDsKPj4gLSAgICBpbnQgcmV0Y29kZTsKPj4gLSAgICBpbnQgc3BhcmU7ICAgICAgICAgICAgLyog cGFkIHRvIDMyIERXb3JkcyAgICAgICAgKi8KPj4gKyAgICB1aW50MzJfdCBub193cV9zcGFjZTsg ICAgICAgIC8qIFNwYWNlIHByZS1jaGVjayBmYWlsZWQgICAgKi8KPj4gKyAgICB1aW50MzJfdCBx X2ZhaWw7ICAgICAgICAvKiBGYWlsZWQgdG8gcXVldWUgKE1CWikgICAgKi8KPj4gKyAgICB1aW50 MzJfdCBiX2ZhaWw7ICAgICAgICAvKiBEb29yYmVsbCBmYWlsdXJlIChNQlopICAgICovCj4KPiBX aHkgTUJaPyBJdCBpcyBub3QgYWxsIHVzZWQgaW4gdGhpcyBjb250ZXh0IHNvIHRoaXMgd2lsbCBq dXN0IGNvbmZ1c2UKPiBwZW9wbGUuCgpNQlogPT4gTXVzdCBCZSBaZXJvLiBBcyBpbiwgd2UgY2Fu J3QgcmVhbGx5IGRlYWwgd2l0aCB0aGUgZXZlbnRzIHRoYXQgCmNhdXNlIHRoZXNlIGNvdW50ZXJz IHRvIGJlIGluY3JlbWVudGVkLCBzbyBpZiB0aGV5J3JlIG5vbnplcm8sIHNvbWV0aGluZyAKaXMg YnJva2VuIGFuZCB0aGUgZHJpdmVyIG1heSBvciBtYXkgbm90IHJlY292ZXIgOigKCklmIHRoZSBj YWxsIHByb3RvY29sIGlzIGNoYW5nZWQsIHRoZSBNQlogdmFyaWFibGVzIG1heSBnbyBhd2F5IGVu dGlyZWx5LgoKLkRhdmUuCgo+PiArICAgIGludCByZXRjb2RlOyAgICAgICAgICAgIC8qIFJlc3Vs dCBvZiBsYXN0IGd1Y19zdWJtaXQoKSAgICAqLwo+PiAgIH07Cj4+Cj4+ICAgZW51bSBpbnRlbF9n dWNfZndfc3RhdHVzIHsKPgo+Cj4gUmVnYXJkcywKPgo+IFR2cnRrbwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==