From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v2 3/5] drm/i915/guc: don't spinwait if the
 GuC's workqueue is full
Date: Fri, 6 May 2016 18:12:40 +0100
Message-ID: <572CD088.5010306@intel.com>
References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com>
 <1461780195-17434-3-git-send-email-david.s.gordon@intel.com>
 <57237AEC.5080308@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id BD9DE6E06B
 for <intel-gfx@lists.freedesktop.org>; Fri,  6 May 2016 17:12:42 +0000 (UTC)
In-Reply-To: <57237AEC.5080308@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMjkvMDQvMTYgMTY6MTcsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMjcvMDQvMTYg
MTk6MDMsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBSYXRoZXIgdGhhbiB3YWl0IHRvIHNlZSB3aGV0
aGVyIG1vcmUgc3BhY2UgYmVjb21lcyBhdmFpbGFibGUgaW4gdGhlIEd1Qwo+PiBzdWJtaXNzaW9u
IHdvcmtxdWV1ZSwgd2UgY2FuIGp1c3QgcmV0dXJuIC1FQUdBSU4gYW5kIGxldCB0aGUgY2FsbGVy
IHRyeQo+PiBhZ2FpbiBpbiBhIGxpdHRsZSB3aGlsZS4gVGhpcyBnZXRzIHJpZCBvZiBhbiB1bmlu
dGVycnVwdGFibGUgc2xlZXAgaW4KPj4gdGhlIHBvbGxpbmcgY29kZSA6KQo+Pgo+PiBXZSdsbCBh
bHNvIGFkZCBhIGNvdW50ZXIgdG8gdGhlIEd1QyBjbGllbnQgc3RhdGlzdGljcywgdG8gc2VlIGhv
dyBvZnRlbgo+PiB3ZSBmaW5kIHRoZSBXUSBmdWxsLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBEYXZl
IEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgICAgfCAgMSArCj4+ICAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgMTYgKysrKystLS0tLS0tLS0tLQo+PiAg
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oICAgICAgICAgICB8ICA4ICsrKystLS0t
Cj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkK
Pj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gaW5kZXggOGI4ZDZmMC4u
MTAyNDk0NyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2Zz
LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gQEAgLTI1
MDksNiArMjUwOSw3IEBAIHN0YXRpYyB2b2lkIGk5MTVfZ3VjX2NsaWVudF9pbmZvKHN0cnVjdCBz
ZXFfZmlsZQo+PiAqbSwKPj4gICAgICAgc2VxX3ByaW50ZihtLCAiXHRXUSBzaXplICVkLCBvZmZz
ZXQ6IDB4JXgsIHRhaWwgJWRcbiIsCj4+ICAgICAgICAgICBjbGllbnQtPndxX3NpemUsIGNsaWVu
dC0+d3Ffb2Zmc2V0LCBjbGllbnQtPndxX3RhaWwpOwo+Pgo+PiArICAgIHNlcV9wcmludGYobSwg
Ilx0V29yayBxdWV1ZSBmdWxsOiAldVxuIiwgY2xpZW50LT5ub193cV9zcGFjZSk7Cj4+ICAgICAg
IHNlcV9wcmludGYobSwgIlx0RmFpbGVkIHRvIHF1ZXVlOiAldVxuIiwgY2xpZW50LT5xX2ZhaWwp
Owo+PiAgICAgICBzZXFfcHJpbnRmKG0sICJcdEZhaWxlZCBkb29yYmVsbDogJXVcbiIsIGNsaWVu
dC0+Yl9mYWlsKTsKPj4gICAgICAgc2VxX3ByaW50ZihtLCAiXHRMYXN0IHN1Ym1pc3Npb24gcmVz
dWx0OiAlZFxuIiwgY2xpZW50LT5yZXRjb2RlKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBpbmRleCA2NmFmNWNlLi42NjI2ZWZmIDEwMDY0NAo+
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IEBAIC00NTMs
MjcgKzQ1MywyMSBAQCBzdGF0aWMgdm9pZCBndWNfZmluaV9jdHhfZGVzYyhzdHJ1Y3QgaW50ZWxf
Z3VjCj4+ICpndWMsCj4+Cj4+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBk
cm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPj4gICB7Cj4+IC0gICAgY29uc3Qgc2l6ZV90
IHNpemUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPj4gKyAgICBjb25zdCBzaXplX3Qg
d3FpX3NpemUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPj4gICAgICAgc3RydWN0IGk5
MTVfZ3VjX2NsaWVudCAqZ2MgPSByZXF1ZXN0LT5pOTE1LT5ndWMuZXhlY2J1Zl9jbGllbnQ7Cj4+
ICAgICAgIHN0cnVjdCBndWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+PiAtICAgIGludCByZXQgPSAt
RVRJTUVET1VULCB0aW1lb3V0X2NvdW50ZXIgPSAyMDA7Cj4+Cj4+ICAgICAgIGlmICghZ2MpCj4+
ICAgICAgICAgICByZXR1cm4gMDsKPgo+IE5vdCBwYXJ0IG9mIHRoaXMgcGF0Y2ggYnV0IHNwb3R0
ZWQgaXQgLSBjYW4gdGhpcyByZWFsbHkgaGFwcGVuLCBhbmQgaWYKPiBzbywgZG9lcyBpdCB3YXJy
YW50IGEgV0FSTl9PTkNFLCBHRU1fQlVHX09OIG9yIHNvbWV0aGluZz8KCkl0IGNlcnRhaW5seSBz
aG91bGRuJ3QsIGFzIHRoaXMgZnVuY3Rpb24gc2hvdWxkbid0IGJlIGNhbGxlZCB1bmxlc3MgCmVu
YWJsZV9ndWNfc3VibWlzc2lvbiBpcyBub256ZXJvLCBhbmQgaXQncyBzZXQgdG8gemVybyBpZiBj
bGllbnQgCmFsbG9jYXRpb24gZmFpbHMuIFNvIGl0IGNvdWxkIGJlIGEgR0VNX0JVR19PTigpLCBh
bmQgaXQgc2hvdWxkIGJlIHBhcnQgCm9mIHRoZSBwcmV2aW91cyBwYXRjaCwgd2hpY2ggY2hhbmdl
ZCB0aGlzIGZyb20gYSBwYXJhbWV0ZXIgdG8gZ2V0dGluZyBpdCAKb3V0IG9mIHRoZSBkZXZfcHJp
dmF0ZS4KCj4+ICAgICAgIGRlc2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNjX29m
ZnNldDsKPj4KPj4gLSAgICB3aGlsZSAodGltZW91dF9jb3VudGVyLS0gPiAwKSB7Cj4+IC0gICAg
ICAgIGlmIChDSVJDX1NQQUNFKGdjLT53cV90YWlsLCBkZXNjLT5oZWFkLCBnYy0+d3Ffc2l6ZSkg
Pj0gc2l6ZSkgewo+PiAtICAgICAgICAgICAgcmV0ID0gMDsKPj4gLSAgICAgICAgICAgIGJyZWFr
Owo+PiAtICAgICAgICB9Cj4+ICsgICAgaWYgKENJUkNfU1BBQ0UoZ2MtPndxX3RhaWwsIGRlc2Mt
PmhlYWQsIGdjLT53cV9zaXplKSA+PSB3cWlfc2l6ZSkKPj4gKyAgICAgICAgcmV0dXJuIDA7Cj4K
PiBDb3VsZCBzdGljayBhIGxpa2VseSBoZXJlIHRvIGxheSBvdXQgdGhlIGNvZGUgZm9yIHRoZSBl
eHBlY3RlZCBjYXNlIGJ1dAo+IGl0IGNvdWxkIGJlIGp1c3QgT0NELiA6KQoKT0ssIHRob3VnaCBp
dCBtYWtlcyB0aGUgbGluZSB0b28gbG9uZy4gOi0vCkknbGwganVzdCBjYWxjdWxhdGUgdGhlIGZy
ZWVzcGFjZSwgdGhlbiBjb21wYXJlIHNlcGFyYXRlbHkuCgo+PiAtICAgICAgICBpZiAodGltZW91
dF9jb3VudGVyKQo+PiAtICAgICAgICAgICAgdXNsZWVwX3JhbmdlKDEwMDAsIDIwMDApOwo+PiAt
ICAgIH07Cj4+ICsgICAgZ2MtPm5vX3dxX3NwYWNlICs9IDE7Cj4+Cj4+IC0gICAgcmV0dXJuIHJl
dDsKPj4gKyAgICByZXR1cm4gLUVBR0FJTjsKPgo+IEkgc3VwcG9zZSBpdCBpcyBPSyB0byBtYWtl
IHVzZXJzcGFjZSBwYXkgdGhlIGNvc3Qgc2luY2UgdGhpcyBzaG91bGQgYmUKPiBleHRyZW1lbHkg
cmFyZSwgY29ycmVjdD8KCkl0ICpzaG91bGQqIGJlIHJhcmUuIEl0IGNvdWxkIG1lYW4gdGhlIEd1
QyBoYXMgaHVuZywgb3IgdGhlIEdQVSBoYXMgaHVuZyAKc28gdGhlIEd1QyBjYW4ndCBkZXF1ZXVl
IGFueXRoaW5nLiBXaGF0ZXZlciBpdCBtZWFucywgc29tZW9uZSBuZWVkcyB0byAKYmFjayBvZmYu
IFRoZW4gbWF5YmUgVERSIHdpbGwgY3V0IGluIC0tIG9yIG1heWJlIHN0dWZmIHdpbGwgY29tcGxl
dGUgCmFmdGVyIGFsbC4KCklmIHRoZSBlcnJubyBnZXRzIGJhY2sgdG8gdXNlcmxhbmQsIGl0IGNh
biBqdXN0IHJldHJ5LCBvciB3YWl0IGZvciBzb21lIApvdGhlciByZXF1ZXN0IHRvIGNvbXBsZXRl
IGZpcnN0LiBJdCBkb2Vzbid0IGhhdmUgdG8gYmUgdXNlcmxhbmQsIHRob3VnaDsgCnRoZSBzY2hl
ZHVsZXIgd2lsbCBhbHNvIGJhY2sgb2ZmIGFuZCB0cnkgYWdhaW4gbGF0ZXIgaW4gdGhpcyBzaXR1
YXRpb24uCgpFaXRoZXIgd2F5LCBhbnl0aGluZyBpcyBiZXR0ZXIgdGhhbiBzbGVlcGluZyAodW5p
bnRlcnJ1cHRpYmx5KSBpbiB0aGUgCmRyaXZlciEKCj4+ICAgfQo+Pgo+PiAgIHN0YXRpYyBpbnQg
Z3VjX2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYywKPj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+IGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gaW5kZXggYjM3YzczMS4uNDM2ZjJkNiAxMDA2NDQK
Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gQEAgLTczLDEwICs3MywxMCBAQCBzdHJ1Y3Qg
aTkxNV9ndWNfY2xpZW50IHsKPj4KPj4gICAgICAgLyogR3VDIHN1Ym1pc3Npb24gc3RhdGlzdGlj
cyAmIHN0YXR1cyAqLwo+PiAgICAgICB1aW50NjRfdCBzdWJtaXNzaW9uc1tHVUNfTUFYX0VOR0lO
RVNfTlVNXTsKPj4gLSAgICB1aW50MzJfdCBxX2ZhaWw7Cj4+IC0gICAgdWludDMyX3QgYl9mYWls
Owo+PiAtICAgIGludCByZXRjb2RlOwo+PiAtICAgIGludCBzcGFyZTsgICAgICAgICAgICAvKiBw
YWQgdG8gMzIgRFdvcmRzICAgICAgICAqLwo+PiArICAgIHVpbnQzMl90IG5vX3dxX3NwYWNlOyAg
ICAgICAgLyogU3BhY2UgcHJlLWNoZWNrIGZhaWxlZCAgICAqLwo+PiArICAgIHVpbnQzMl90IHFf
ZmFpbDsgICAgICAgIC8qIEZhaWxlZCB0byBxdWV1ZSAoTUJaKSAgICAqLwo+PiArICAgIHVpbnQz
Ml90IGJfZmFpbDsgICAgICAgIC8qIERvb3JiZWxsIGZhaWx1cmUgKE1CWikgICAgKi8KPj4gKyAg
ICBpbnQgcmV0Y29kZTsgICAgICAgICAgICAvKiBSZXN1bHQgb2YgbGFzdCBndWNfc3VibWl0KCkg
ICAgKi8KPj4gICB9Owo+Pgo+PiAgIGVudW0gaW50ZWxfZ3VjX2Z3X3N0YXR1cyB7Cj4+Cj4KPiBS
ZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPgo+
IFJlZ2FyZHMsCj4gVHZydGtvCgpUaGFua3MsCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZngK