From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Use bitmask for IS_REVID checking Date: Tue, 10 May 2016 14:59:01 +0100 Message-ID: <5731E925.9010007@linux.intel.com> References: <1462885341-30380-1-git-send-email-tvrtko.ursulin@linux.intel.com> <87shxq6nru.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 629676E085 for ; Tue, 10 May 2016 13:59:03 +0000 (UTC) In-Reply-To: <87shxq6nru.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMTAvMDUvMTYgMTQ6MzMsIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIFR1ZSwgMTAg TWF5IDIwMTYsIFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+ IHdyb3RlOgo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29t Pgo+Pgo+PiBXaXRoIHRoaXMgc2NoZW1lIGFsbCBjYWxsIHNpdGVzIG9mIElTX1NLTF9SRVZJRCBh bmQgSVNfQlhUX1JFVklECj4+IHJlc3VsdCBpbiBhIG1heGltdW0gb2Ygb25lIGNvbmRpdGlvbmFs IGp1bXAgaW5zdHJ1Y3Rpb24gKHdhcwo+PiB0aHJlZSBiZWZvcmUpIGFuZCBvdmVyYWxsIHJlZHVj dGlvbiBpbiBjb2RlIHNpemUuCj4KPiBJTU8gd2UgcmVhbGx5IHNob3VsZG4ndCBib3RoZXIgd2l0 aCB0aGlzLiBUaGUgZW5kIGdvYWwgaXMgdGhhdCB3ZSByZW1vdmUKPiBhbGwgb2YgdGhlc2Ugd2hl biB3ZSBkZWNpZGUgd2Ugbm8gbG9uZ2VyIGNhcmUgYWJvdXQgZWFybHkKPiAobm9uLXByb2R1Y3Rp b24pIHJldmlzaW9ucyBmb3IgYSBwbGF0Zm9ybS4gRm9yIFNreWxha2UgSSdkIGFyZ3VlIHdlIGFy ZQo+IGJleW9uZCB0aGlzIHBvaW50LgoKVGhvdWdodCB0aGF0IHNpbXBseSByZW1vdmluZyBldmVy eXRoaW5nIGd1YXJkZWQgYnkgSVNfU0tMX1JFVklEIG1pZ2h0IGJlIApwb3NzaWJsZSBuZXZlciBj cm9zc2VkIG15IG1pbmQuIDopIFdoaWNoIG9uZSBpcyB0aGUgZmlyc3QgcHJvZHVjdGlvbiAKc3Rl cHBpbmcgdGhlbj8KClJlZ2FyZHMsCgpUdnJ0a28uCgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5j IHwgMTEgKysrKysrKysrKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwg MjQgKysrKysrKysrKysrKysrKysrKy0tLS0tCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kbWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPj4g aW5kZXggNDZhYzFkYTY0YTA5Li4xYWU4MTI0MzY4MjcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kbWEuYwo+PiBAQCAtMTA3Miw2ICsxMDcyLDE3IEBAIHN0YXRpYyBpbnQgaTkxNV9kcml2ZXJf aW5pdF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgCW1lbWNw eShkZXZpY2VfaW5mbywgaW5mbywgc2l6ZW9mKGRldl9wcml2LT5pbmZvKSk7Cj4+ICAgCWRldmlj ZV9pbmZvLT5kZXZpY2VfaWQgPSBkZXYtPnBkZXYtPmRldmljZTsKPj4KPj4gKwkvKiBGb3IgdW5r bm93biByZXZpc2lvbnMgbWFzayBzdGF5cyBhdCB6ZXJvIHdoaWNoIGlzIGNvcnJlY3QuICovCj4+ ICsJaWYgKGRldi0+cGRldi0+cmV2aXNpb24gPAo+PiArCSAgICBzaXplb2YoZGV2aWNlX2luZm8t PnJldmlzaW9uX21hc2spICogQklUU19QRVJfQllURSkKPj4gKwkJZGV2aWNlX2luZm8tPnJldmlz aW9uX21hc2sgPSBCSVQoZGV2LT5wZGV2LT5yZXZpc2lvbik7Cj4+ICsKPj4gKwlpZiAoSVNfU0tZ TEFLRShkZXZfcHJpdikpCj4+ICsJCWRldmljZV9pbmZvLT5za2xfcmV2X21hc2sgPSB+MDsKPj4g Kwo+PiArCWlmIChJU19CUk9YVE9OKGRldl9wcml2KSkKPj4gKwkJZGV2aWNlX2luZm8tPmJ4dF9y ZXZfbWFzayA9IH4wOwo+PiArCj4+ICAgCXNwaW5fbG9ja19pbml0KCZkZXZfcHJpdi0+aXJxX2xv Y2spOwo+PiAgIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPmdwdV9lcnJvci5sb2NrKTsKPj4g ICAJbXV0ZXhfaW5pdCgmZGV2X3ByaXYtPmJhY2tsaWdodF9sb2NrKTsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4+IGluZGV4IDI2ZTdkZTQxNTk2Ni4uZmJlYjY4ZTllYzk2IDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gQEAgLTc1Nyw2ICs3NTcsOSBAQCBzdHJ1Y3QgaW50ZWxf Y3NyIHsKPj4gICBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gewo+PiAgIAl1MzIgZGlzcGxheV9t bWlvX29mZnNldDsKPj4gICAJdTE2IGRldmljZV9pZDsKPj4gKwl1OCByZXZpc2lvbl9tYXNrOwo+ PiArCXU4IHNrbF9yZXZfbWFzazsKPj4gKwl1OCBieHRfcmV2X21hc2s7Cj4+ICAgCXU4IG51bV9w aXBlczozOwo+PiAgIAl1OCBudW1fc3ByaXRlc1tJOTE1X01BWF9QSVBFU107Cj4+ICAgCXU4IGdl bjsKPj4gQEAgLTI1MTksMTQgKzI1MjIsMjMgQEAgc3RydWN0IGRybV9pOTE1X2NtZF90YWJsZSB7 Cj4+ICAgI2RlZmluZSBJTlRFTF9ERVZJRChwKQkoSU5URUxfSU5GTyhwKS0+ZGV2aWNlX2lkKQo+ PiAgICNkZWZpbmUgSU5URUxfUkVWSUQocCkJKF9fSTkxNV9fKHApLT5kZXYtPnBkZXYtPnJldmlz aW9uKQo+Pgo+PiAtI2RlZmluZSBSRVZJRF9GT1JFVkVSCQkweGZmCj4+ICsjZGVmaW5lIFJFVklE X0ZPUkVWRVIJCTAKPj4gKwo+PiAgIC8qCj4+ICAgICogUmV0dXJuIHRydWUgaWYgcmV2aXNpb24g aXMgaW4gcmFuZ2UgW3NpbmNlLHVudGlsXSBpbmNsdXNpdmUuCj4+ICAgICoKPj4gICAgKiBVc2Ug MCBmb3Igb3Blbi1lbmRlZCBzaW5jZSwgYW5kIFJFVklEX0ZPUkVWRVIgZm9yIG9wZW4tZW5kZWQg dW50aWwuCj4+ICAgICovCj4+IC0jZGVmaW5lIElTX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkgXAo+ PiAtCShJTlRFTF9SRVZJRChwKSA+PSAoc2luY2UpICYmIElOVEVMX1JFVklEKHApIDw9ICh1bnRp bCkpCj4+ICsjZGVmaW5lIElTX1JFVklEKHAsIG1hc2ssIHNpbmNlLCB1bnRpbCkgKHtcCj4+ICsJ dW5zaWduZWQgaW50IF9fcyA9IChzaW5jZSksIF9fZSA9ICh1bnRpbCk7IFwKPj4gKwlCVUlMRF9C VUdfT04oIV9fYnVpbHRpbl9jb25zdGFudF9wKHNpbmNlKSk7IFwKPj4gKwlCVUlMRF9CVUdfT04o IV9fYnVpbHRpbl9jb25zdGFudF9wKHVudGlsKSk7IFwKPj4gKwlCVUlMRF9CVUdfT04oc2luY2Ug Pj0gc2l6ZW9mKElOVEVMX0lORk8ocCktPnJldmlzaW9uX21hc2spICogQklUU19QRVJfQllURSk7 IFwKPj4gKwlCVUlMRF9CVUdfT04odW50aWwgPj0gc2l6ZW9mKElOVEVMX0lORk8ocCktPnJldmlz aW9uX21hc2spICogQklUU19QRVJfQllURSk7IFwKPj4gKwlpZiAoKF9fZSkgPT0gUkVWSURfRk9S RVZFUikgXAo+PiArCQlfX2UgPSBCSVRTX1BFUl9MT05HIC0gMTsgXAo+PiArCSEhKElOVEVMX0lO Rk8ocCktPnJldmlzaW9uX21hc2sgJiAobWFzaykgJiBHRU5NQVNLKChfX2UpLCAoX19zKSkpOyBc Cj4+ICt9KQo+Pgo+PiAgICNkZWZpbmUgSVNfSTgzMChkZXYpCQkoSU5URUxfREVWSUQoZGV2KSA9 PSAweDM1NzcpCj4+ICAgI2RlZmluZSBJU184NDVHKGRldikJCShJTlRFTF9ERVZJRChkZXYpID09 IDB4MjU2MikKPj4gQEAgLTI2MDUsMTQgKzI2MTcsMTYgQEAgc3RydWN0IGRybV9pOTE1X2NtZF90 YWJsZSB7Cj4+ICAgI2RlZmluZSBTS0xfUkVWSURfRTAJCTB4NAo+PiAgICNkZWZpbmUgU0tMX1JF VklEX0YwCQkweDUKPj4KPj4gLSNkZWZpbmUgSVNfU0tMX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkg KElTX1NLWUxBS0UocCkgJiYgSVNfUkVWSUQocCwgc2luY2UsIHVudGlsKSkKPj4gKyNkZWZpbmUg SVNfU0tMX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkgSVNfUkVWSUQocCwgSU5URUxfSU5GTyhwKS0+ c2tsX3Jldl9tYXNrLCBcCj4+ICsJCQkJICAgICAgICAgICAgICAgc2luY2UsIHVudGlsKQo+Pgo+ PiAgICNkZWZpbmUgQlhUX1JFVklEX0EwCQkweDAKPj4gICAjZGVmaW5lIEJYVF9SRVZJRF9BMQkJ MHgxCj4+ICAgI2RlZmluZSBCWFRfUkVWSURfQjAJCTB4Mwo+PiAgICNkZWZpbmUgQlhUX1JFVklE X0MwCQkweDkKPj4KPj4gLSNkZWZpbmUgSVNfQlhUX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkgKElT X0JST1hUT04ocCkgJiYgSVNfUkVWSUQocCwgc2luY2UsIHVudGlsKSkKPj4gKyNkZWZpbmUgSVNf QlhUX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkgSVNfUkVWSUQocCwgSU5URUxfSU5GTyhwKS0+Ynh0 X3Jldl9tYXNrLCBcCj4+ICsJCQkJICAgICAgICAgICAgICAgc2luY2UsIHVudGlsKQo+Pgo+PiAg IC8qCj4+ICAgICogVGhlIGdlblggZGVzaWduYXRpb24gdHlwaWNhbGx5IHJlZmVycyB0byB0aGUg cmVuZGVyIGVuZ2luZSwgc28gcmVuZGVyCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==