From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Use bitmask for IS_REVID checking Date: Tue, 10 May 2016 15:06:16 +0100 Message-ID: <5731EAD8.30208@linux.intel.com> References: <1462885341-30380-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1462888436-10475-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D136E3E6 for ; Tue, 10 May 2016 14:06:17 +0000 (UTC) In-Reply-To: <1462888436-10475-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMC8wNS8xNiAxNDo1MywgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4gRnJvbTogVHZydGtv IFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPgo+IFdpdGggdGhpcyBzY2hlbWUg YWxsIGNhbGwgc2l0ZXMgb2YgSVNfU0tMX1JFVklEIGFuZCBJU19CWFRfUkVWSUQKPiByZXN1bHQg aW4gYSBtYXhpbXVtIG9mIG9uZSBjb25kaXRpb25hbCBqdW1wIGluc3RydWN0aW9uICh3YXMKPiB0 aHJlZSBiZWZvcmUpIGFuZCBvdmVyYWxsIHJlZHVjdGlvbiBpbiBjb2RlIHNpemUuCj4KPiB2Mjog U2ltcGxpZmllZCwgbm93IHNhdmVzIH44ODAgYnl0ZXMgb2YgdGV4dC4KPgo+IFNpZ25lZC1vZmYt Ynk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k bWEuYyB8ICA4ICsrKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwg MjEgKysrKysrKysrKysrKysrKy0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kbWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPiBpbmRleCA0 NmFjMWRhNjRhMDkuLmYyYWQ3OGQ4Mjk2ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+ IEBAIC0xMDcyLDYgKzEwNzIsMTQgQEAgc3RhdGljIGludCBpOTE1X2RyaXZlcl9pbml0X2Vhcmx5 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAltZW1jcHkoZGV2aWNlX2lu Zm8sIGluZm8sIHNpemVvZihkZXZfcHJpdi0+aW5mbykpOwo+ICAgCWRldmljZV9pbmZvLT5kZXZp Y2VfaWQgPSBkZXYtPnBkZXYtPmRldmljZTsKPgo+ICsJLyogRm9yIHVua25vd24gcmV2aXNpb25z IG1hc2sgc3RheXMgYXQgemVybyB3aGljaCBpcyBjb3JyZWN0LiAqLwo+ICsJaWYgKElTX1NLWUxB S0UoZGV2X3ByaXYpICYmIGRldi0+cGRldi0+cmV2aXNpb24gPAo+ICsJICAgIHNpemVvZihkZXZp Y2VfaW5mby0+c2tsX3Jldl9tYXNrKSAqIEJJVFNfUEVSX0JZVEUpCj4gKwkJZGV2aWNlX2luZm8t PnNrbF9yZXZfbWFzayA9IEJJVChkZXYtPnBkZXYtPnJldmlzaW9uKTsKPiArCWVsc2UgaWYgKElT X0JST1hUT04oZGV2X3ByaXYpICYmIGRldi0+cGRldi0+cmV2aXNpb24gPAo+ICsJICAgICAgICAg c2l6ZW9mKGRldmljZV9pbmZvLT5ieHRfcmV2X21hc2spICogQklUU19QRVJfQllURSkKPiArCQlk ZXZpY2VfaW5mby0+Ynh0X3Jldl9tYXNrID0gQklUKGRldi0+cGRldi0+cmV2aXNpb24pOwo+ICsK Ck5vIHRoaXMgaXMgd3JvbmcsID4gL2Rldi9udWxsIHBsZWFzZSwgc29ycnkgZm9yIHRoZSBub2lz ZS4gOikKClR2cnRrbwoKPiAgIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPmlycV9sb2NrKTsK PiAgIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPmdwdV9lcnJvci5sb2NrKTsKPiAgIAltdXRl eF9pbml0KCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+IGluZGV4IDI2ZTdkZTQxNTk2Ni4uMThlZWU1NzViOWFlIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTc1Nyw2ICs3NTcsOCBAQCBzdHJ1Y3QgaW50ZWxfY3NyIHsKPiAgIHN0 cnVjdCBpbnRlbF9kZXZpY2VfaW5mbyB7Cj4gICAJdTMyIGRpc3BsYXlfbW1pb19vZmZzZXQ7Cj4g ICAJdTE2IGRldmljZV9pZDsKPiArCXU4IHNrbF9yZXZfbWFzazsKPiArCXU4IGJ4dF9yZXZfbWFz azsKPiAgIAl1OCBudW1fcGlwZXM6MzsKPiAgIAl1OCBudW1fc3ByaXRlc1tJOTE1X01BWF9QSVBF U107Cj4gICAJdTggZ2VuOwo+IEBAIC0yNTE5LDE0ICsyNTIxLDIzIEBAIHN0cnVjdCBkcm1faTkx NV9jbWRfdGFibGUgewo+ICAgI2RlZmluZSBJTlRFTF9ERVZJRChwKQkoSU5URUxfSU5GTyhwKS0+ ZGV2aWNlX2lkKQo+ICAgI2RlZmluZSBJTlRFTF9SRVZJRChwKQkoX19JOTE1X18ocCktPmRldi0+ cGRldi0+cmV2aXNpb24pCj4KPiAtI2RlZmluZSBSRVZJRF9GT1JFVkVSCQkweGZmCj4gKyNkZWZp bmUgUkVWSURfRk9SRVZFUgkJMAo+ICsKPiAgIC8qCj4gICAgKiBSZXR1cm4gdHJ1ZSBpZiByZXZp c2lvbiBpcyBpbiByYW5nZSBbc2luY2UsdW50aWxdIGluY2x1c2l2ZS4KPiAgICAqCj4gICAgKiBV c2UgMCBmb3Igb3Blbi1lbmRlZCBzaW5jZSwgYW5kIFJFVklEX0ZPUkVWRVIgZm9yIG9wZW4tZW5k ZWQgdW50aWwuCj4gICAgKi8KPiAtI2RlZmluZSBJU19SRVZJRChwLCBzaW5jZSwgdW50aWwpIFwK PiAtCShJTlRFTF9SRVZJRChwKSA+PSAoc2luY2UpICYmIElOVEVMX1JFVklEKHApIDw9ICh1bnRp bCkpCj4gKyNkZWZpbmUgSVNfUkVWSUQocCwgbWFzaywgc2luY2UsIHVudGlsKSAoe1wKPiArCXVu c2lnbmVkIGludCBfX3MgPSAoc2luY2UpLCBfX2UgPSAodW50aWwpOyBcCj4gKwlCVUlMRF9CVUdf T04oIV9fYnVpbHRpbl9jb25zdGFudF9wKHNpbmNlKSk7IFwKPiArCUJVSUxEX0JVR19PTighX19i dWlsdGluX2NvbnN0YW50X3AodW50aWwpKTsgXAo+ICsJQlVJTERfQlVHX09OKHNpbmNlID49IHNp emVvZihJTlRFTF9JTkZPKHApLT5tYXNrKSAqIEJJVFNfUEVSX0JZVEUpOyBcCj4gKwlCVUlMRF9C VUdfT04odW50aWwgPj0gc2l6ZW9mKElOVEVMX0lORk8ocCktPm1hc2spICogQklUU19QRVJfQllU RSk7IFwKPiArCWlmICgoX19lKSA9PSBSRVZJRF9GT1JFVkVSKSBcCj4gKwkJX19lID0gQklUU19Q RVJfTE9ORyAtIDE7IFwKPiArCSEhKElOVEVMX0lORk8ocCktPm1hc2sgJiBHRU5NQVNLKChfX2Up LCAoX19zKSkpOyBcCj4gK30pCj4KPiAgICNkZWZpbmUgSVNfSTgzMChkZXYpCQkoSU5URUxfREVW SUQoZGV2KSA9PSAweDM1NzcpCj4gICAjZGVmaW5lIElTXzg0NUcoZGV2KQkJKElOVEVMX0RFVklE KGRldikgPT0gMHgyNTYyKQo+IEBAIC0yNjA1LDE0ICsyNjE2LDE0IEBAIHN0cnVjdCBkcm1faTkx NV9jbWRfdGFibGUgewo+ICAgI2RlZmluZSBTS0xfUkVWSURfRTAJCTB4NAo+ICAgI2RlZmluZSBT S0xfUkVWSURfRjAJCTB4NQo+Cj4gLSNkZWZpbmUgSVNfU0tMX1JFVklEKHAsIHNpbmNlLCB1bnRp bCkgKElTX1NLWUxBS0UocCkgJiYgSVNfUkVWSUQocCwgc2luY2UsIHVudGlsKSkKPiArI2RlZmlu ZSBJU19TS0xfUkVWSUQocCwgc2luY2UsIHVudGlsKSBJU19SRVZJRChwLCBza2xfcmV2X21hc2ss IHNpbmNlLCB1bnRpbCkKPgo+ICAgI2RlZmluZSBCWFRfUkVWSURfQTAJCTB4MAo+ICAgI2RlZmlu ZSBCWFRfUkVWSURfQTEJCTB4MQo+ICAgI2RlZmluZSBCWFRfUkVWSURfQjAJCTB4Mwo+ICAgI2Rl ZmluZSBCWFRfUkVWSURfQzAJCTB4OQo+Cj4gLSNkZWZpbmUgSVNfQlhUX1JFVklEKHAsIHNpbmNl LCB1bnRpbCkgKElTX0JST1hUT04ocCkgJiYgSVNfUkVWSUQocCwgc2luY2UsIHVudGlsKSkKPiAr I2RlZmluZSBJU19CWFRfUkVWSUQocCwgc2luY2UsIHVudGlsKSBJU19SRVZJRChwLCBieHRfcmV2 X21hc2ssIHNpbmNlLCB1bnRpbCkKPgo+ICAgLyoKPiAgICAqIFRoZSBnZW5YIGRlc2lnbmF0aW9u IHR5cGljYWxseSByZWZlcnMgdG8gdGhlIHJlbmRlciBlbmdpbmUsIHNvIHJlbmRlcgo+Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=