From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 3/5] drm/i915/guc: don't spinwait if the GuC's workqueue is full Date: Tue, 10 May 2016 15:44:48 +0100 Message-ID: <5731F3E0.3010507@linux.intel.com> References: <1461780195-17434-1-git-send-email-david.s.gordon@intel.com> <1461780195-17434-3-git-send-email-david.s.gordon@intel.com> <57238190.9030304@linux.intel.com> <572CB5A7.3080400@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 9929B6E678 for ; Tue, 10 May 2016 14:44:50 +0000 (UTC) In-Reply-To: <572CB5A7.3080400@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA1LzE2IDE2OjE3LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAyOS8wNC8xNiAxNjo0 NSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uZSBsYXRlIGNvbW1lbnQ6Cj4+Cj4+IE9u IDI3LzA0LzE2IDE5OjAzLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+IFJhdGhlciB0aGFuIHdhaXQg dG8gc2VlIHdoZXRoZXIgbW9yZSBzcGFjZSBiZWNvbWVzIGF2YWlsYWJsZSBpbiB0aGUgR3VDCj4+ PiBzdWJtaXNzaW9uIHdvcmtxdWV1ZSwgd2UgY2FuIGp1c3QgcmV0dXJuIC1FQUdBSU4gYW5kIGxl dCB0aGUgY2FsbGVyIHRyeQo+Pj4gYWdhaW4gaW4gYSBsaXR0bGUgd2hpbGUuIFRoaXMgZ2V0cyBy aWQgb2YgYW4gdW5pbnRlcnJ1cHRhYmxlIHNsZWVwIGluCj4+PiB0aGUgcG9sbGluZyBjb2RlIDop Cj4+Pgo+Pj4gV2UnbGwgYWxzbyBhZGQgYSBjb3VudGVyIHRvIHRoZSBHdUMgY2xpZW50IHN0YXRp c3RpY3MsIHRvIHNlZSBob3cgb2Z0ZW4KPj4+IHdlIGZpbmQgdGhlIFdRIGZ1bGwuCj4+Pgo+Pj4g U2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4+ IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgICAgfCAg MSArCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDE2 ICsrKysrLS0tLS0tLS0tLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgg ICAgICAgICAgIHwgIDggKysrKy0tLS0KPj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRp b25zKCspLCAxNSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k ZWJ1Z2ZzLmMKPj4+IGluZGV4IDhiOGQ2ZjAuLjEwMjQ5NDcgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4+IEBAIC0yNTA5LDYgKzI1MDksNyBAQCBzdGF0aWMgdm9p ZCBpOTE1X2d1Y19jbGllbnRfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUKPj4+ICptLAo+Pj4gICAgICAg c2VxX3ByaW50ZihtLCAiXHRXUSBzaXplICVkLCBvZmZzZXQ6IDB4JXgsIHRhaWwgJWRcbiIsCj4+ PiAgICAgICAgICAgY2xpZW50LT53cV9zaXplLCBjbGllbnQtPndxX29mZnNldCwgY2xpZW50LT53 cV90YWlsKTsKPj4+Cj4+PiArICAgIHNlcV9wcmludGYobSwgIlx0V29yayBxdWV1ZSBmdWxsOiAl dVxuIiwgY2xpZW50LT5ub193cV9zcGFjZSk7Cj4+PiAgICAgICBzZXFfcHJpbnRmKG0sICJcdEZh aWxlZCB0byBxdWV1ZTogJXVcbiIsIGNsaWVudC0+cV9mYWlsKTsKPj4+ICAgICAgIHNlcV9wcmlu dGYobSwgIlx0RmFpbGVkIGRvb3JiZWxsOiAldVxuIiwgY2xpZW50LT5iX2ZhaWwpOwo+Pj4gICAg ICAgc2VxX3ByaW50ZihtLCAiXHRMYXN0IHN1Ym1pc3Npb24gcmVzdWx0OiAlZFxuIiwgY2xpZW50 LT5yZXRjb2RlKTsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1 Y19zdWJtaXNzaW9uLmMKPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlz c2lvbi5jCj4+PiBpbmRleCA2NmFmNWNlLi42NjI2ZWZmIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4+IEBAIC00NTMsMjcgKzQ1MywyMSBA QCBzdGF0aWMgdm9pZCBndWNfZmluaV9jdHhfZGVzYyhzdHJ1Y3QgaW50ZWxfZ3VjCj4+PiAqZ3Vj LAo+Pj4KPj4+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqcmVxdWVzdCkKPj4+ICAgewo+Pj4gLSAgICBjb25zdCBzaXplX3Qgc2l6ZSA9 IHNpemVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+Pj4gKyAgICBjb25zdCBzaXplX3Qgd3FpX3Np emUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPj4+ICAgICAgIHN0cnVjdCBpOTE1X2d1 Y19jbGllbnQgKmdjID0gcmVxdWVzdC0+aTkxNS0+Z3VjLmV4ZWNidWZfY2xpZW50Owo+Pj4gICAg ICAgc3RydWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4+PiAtICAgIGludCByZXQgPSAtRVRJ TUVET1VULCB0aW1lb3V0X2NvdW50ZXIgPSAyMDA7Cj4+Pgo+Pj4gICAgICAgaWYgKCFnYykKPj4+ ICAgICAgICAgICByZXR1cm4gMDsKPj4+Cj4+PiAgICAgICBkZXNjID0gZ2MtPmNsaWVudF9iYXNl ICsgZ2MtPnByb2NfZGVzY19vZmZzZXQ7Cj4+Pgo+Pj4gLSAgICB3aGlsZSAodGltZW91dF9jb3Vu dGVyLS0gPiAwKSB7Cj4+PiAtICAgICAgICBpZiAoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwgZGVz Yy0+aGVhZCwgZ2MtPndxX3NpemUpID49IHNpemUpIHsKPj4+IC0gICAgICAgICAgICByZXQgPSAw Owo+Pj4gLSAgICAgICAgICAgIGJyZWFrOwo+Pj4gLSAgICAgICAgfQo+Pj4gKyAgICBpZiAoQ0lS Q19TUEFDRShnYy0+d3FfdGFpbCwgZGVzYy0+aGVhZCwgZ2MtPndxX3NpemUpID49IHdxaV9zaXpl KQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7Cj4+Pgo+Pj4gLSAgICAgICAgaWYgKHRpbWVvdXRfY291 bnRlcikKPj4+IC0gICAgICAgICAgICB1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4+PiAtICAg IH07Cj4+PiArICAgIGdjLT5ub193cV9zcGFjZSArPSAxOwo+Pj4KPj4+IC0gICAgcmV0dXJuIHJl dDsKPj4+ICsgICAgcmV0dXJuIC1FQUdBSU47Cj4+PiAgIH0KPj4+Cj4+PiAgIHN0YXRpYyBpbnQg Z3VjX2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYywKPj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+Pj4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+Pj4gaW5kZXggYjM3YzczMS4uNDM2ZjJkNiAxMDA2 NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+Pj4gQEAgLTczLDEwICs3MywxMCBAQCBz dHJ1Y3QgaTkxNV9ndWNfY2xpZW50IHsKPj4+Cj4+PiAgICAgICAvKiBHdUMgc3VibWlzc2lvbiBz dGF0aXN0aWNzICYgc3RhdHVzICovCj4+PiAgICAgICB1aW50NjRfdCBzdWJtaXNzaW9uc1tHVUNf TUFYX0VOR0lORVNfTlVNXTsKPj4+IC0gICAgdWludDMyX3QgcV9mYWlsOwo+Pj4gLSAgICB1aW50 MzJfdCBiX2ZhaWw7Cj4+PiAtICAgIGludCByZXRjb2RlOwo+Pj4gLSAgICBpbnQgc3BhcmU7ICAg ICAgICAgICAgLyogcGFkIHRvIDMyIERXb3JkcyAgICAgICAgKi8KPj4+ICsgICAgdWludDMyX3Qg bm9fd3Ffc3BhY2U7ICAgICAgICAvKiBTcGFjZSBwcmUtY2hlY2sgZmFpbGVkICAgICovCj4+PiAr ICAgIHVpbnQzMl90IHFfZmFpbDsgICAgICAgIC8qIEZhaWxlZCB0byBxdWV1ZSAoTUJaKSAgICAq Lwo+Pj4gKyAgICB1aW50MzJfdCBiX2ZhaWw7ICAgICAgICAvKiBEb29yYmVsbCBmYWlsdXJlIChN QlopICAgICovCj4+Cj4+IFdoeSBNQlo/IEl0IGlzIG5vdCBhbGwgdXNlZCBpbiB0aGlzIGNvbnRl eHQgc28gdGhpcyB3aWxsIGp1c3QgY29uZnVzZQo+PiBwZW9wbGUuCj4KPiBNQlogPT4gTXVzdCBC ZSBaZXJvLiBBcyBpbiwgd2UgY2FuJ3QgcmVhbGx5IGRlYWwgd2l0aCB0aGUgZXZlbnRzIHRoYXQK PiBjYXVzZSB0aGVzZSBjb3VudGVycyB0byBiZSBpbmNyZW1lbnRlZCwgc28gaWYgdGhleSdyZSBu b256ZXJvLCBzb21ldGhpbmcKPiBpcyBicm9rZW4gYW5kIHRoZSBkcml2ZXIgbWF5IG9yIG1heSBu b3QgcmVjb3ZlciA6KAo+Cj4gSWYgdGhlIGNhbGwgcHJvdG9jb2wgaXMgY2hhbmdlZCwgdGhlIE1C WiB2YXJpYWJsZXMgbWF5IGdvIGF3YXkgZW50aXJlbHkuCgpNeSBvYmplY3Rpb24gaXMgdGhhdCB3 aGVuIHNvbWVvbmUgc2VlcyBNQlogdGhleSdsbCB3cm9uZ2x5IHRoaW5rIHRoaXMgCnN0cnVjdHVy ZSBpcyBzaGFyZWQgd2l0aCB0aGUgaGFyZHdhcmUuIFNpbmNlIGl0IGlzIGp1c3QgYSBzb2Z0d2Fy ZSAKY291bnRlciBNQlogaXMgYSBjb25mdXNpbmcgbWFya2VyIHRvIHVzZS4KCkluc3RlYWQgdGhl c2UgZmllbGRzIHNob3VsZCBwcm9iYWJseSBqdXN0IGJlIHVuc2lnbmVkIGludHMgd2l0aCBjb21t ZW50cyAKc2F5aW5nIHNvbWV0aGluZyB0byB0aGUgZWZmZWN0IG9mIHdoYXQgeW91IHdyb3RlIGFi b3ZlLgoKUmVnYXJkcywKClR2cnRrbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK