From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4 5/7] drm/i915/guc: don't spinwait if the GuC's workqueue is full Date: Fri, 13 May 2016 16:32:43 +0100 Message-ID: <5735F39B.7000008@linux.intel.com> References: <1463150195-28805-1-git-send-email-david.s.gordon@intel.com> <1463150195-28805-6-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 150D96EAC3 for ; Fri, 13 May 2016 15:32:45 +0000 (UTC) In-Reply-To: <1463150195-28805-6-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzA1LzE2IDE1OjM2LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBSYXRoZXIgdGhhbiB3YWl0 IHRvIHNlZSB3aGV0aGVyIG1vcmUgc3BhY2UgYmVjb21lcyBhdmFpbGFibGUgaW4gdGhlIEd1Qwo+ IHN1Ym1pc3Npb24gd29ya3F1ZXVlLCB3ZSBjYW4ganVzdCByZXR1cm4gLUVBR0FJTiBhbmQgbGV0 IHRoZSBjYWxsZXIgdHJ5Cj4gYWdhaW4gaW4gYSBsaXR0bGUgd2hpbGUuIFRoaXMgZ2V0cyByaWQg b2YgYW4gdW5pbnRlcnJ1cHRhYmxlIHNsZWVwIGluCj4gdGhlIHBvbGxpbmcgY29kZSA6KQo+Cj4g V2UnbGwgYWxzbyBhZGQgYSBjb3VudGVyIHRvIHRoZSBHdUMgY2xpZW50IHN0YXRpc3RpY3MsIHRv IHNlZSBob3cgb2Z0ZW4KPiB3ZSBmaW5kIHRoZSBXUSBmdWxsLgo+Cj4gdjI6Cj4gICAgICBGbGFn IHRoZSBsaWtlbHkoKSBjb2RlIHBhdGggKFR2dHJrbyBVcnN1bGluKS4KPgo+IHY0Ogo+ICAgICAg QWRkL3VwZGF0ZSBjb21tZW50cyBhYm91dCBmYWlsdXJlIGNvdW50ZXJzIChUdnRya28gVXJzdWxp bikuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwu Y29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAg IHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwg MTggKysrKysrKy0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMu aCAgICAgICAgICAgfCAyMiArKysrKysrKysrKysrKysrLS0tLS0tCj4gICAzIGZpbGVzIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCAyNGY0MTA1Li5kZTA1ODQxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjUwNiw2ICsyNTA2LDcgQEAgc3RhdGljIHZvaWQg aTkxNV9ndWNfY2xpZW50X2luZm8oc3RydWN0IHNlcV9maWxlICptLAo+ICAgCXNlcV9wcmludGYo bSwgIlx0V1Egc2l6ZSAlZCwgb2Zmc2V0OiAweCV4LCB0YWlsICVkXG4iLAo+ICAgCQljbGllbnQt PndxX3NpemUsIGNsaWVudC0+d3Ffb2Zmc2V0LCBjbGllbnQtPndxX3RhaWwpOwo+Cj4gKwlzZXFf cHJpbnRmKG0sICJcdFdvcmsgcXVldWUgZnVsbDogJXVcbiIsIGNsaWVudC0+bm9fd3Ffc3BhY2Up Owo+ICAgCXNlcV9wcmludGYobSwgIlx0RmFpbGVkIHRvIHF1ZXVlOiAldVxuIiwgY2xpZW50LT5x X2ZhaWwpOwo+ICAgCXNlcV9wcmludGYobSwgIlx0RmFpbGVkIGRvb3JiZWxsOiAldVxuIiwgY2xp ZW50LT5iX2ZhaWwpOwo+ICAgCXNlcV9wcmludGYobSwgIlx0TGFzdCBzdWJtaXNzaW9uIHJlc3Vs dDogJWRcbiIsIGNsaWVudC0+cmV0Y29kZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IDg3Y2I3MzkuLjg1YjJiODkgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gQEAgLTQ2OCwyNiArNDY4LDIy IEBAIHN0YXRpYyB2b2lkIGd1Y19maW5pX2N0eF9kZXNjKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywK PiAgICAqLwo+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgIHsKPiAtCWNvbnN0IHNpemVfdCBzaXplID0gc2l6ZW9m KHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4gKwljb25zdCBzaXplX3Qgd3FpX3NpemUgPSBzaXplb2Yo c3RydWN0IGd1Y193cV9pdGVtKTsKPiAgIAlzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYyA9IHJl cXVlc3QtPmk5MTUtPmd1Yy5leGVjYnVmX2NsaWVudDsKPiAgIAlzdHJ1Y3QgZ3VjX3Byb2Nlc3Nf ZGVzYyAqZGVzYzsKPiAtCWludCByZXQgPSAtRVRJTUVET1VULCB0aW1lb3V0X2NvdW50ZXIgPSAy MDA7Cj4gKwl1MzIgZnJlZXNwYWNlOwo+Cj4gICAJR0VNX0JVR19PTihnYyA9PSBOVUxMKTsKPgo+ ICAgCWRlc2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNjX29mZnNldDsKPgo+IC0J d2hpbGUgKHRpbWVvdXRfY291bnRlci0tID4gMCkgewo+IC0JCWlmIChDSVJDX1NQQUNFKGdjLT53 cV90YWlsLCBkZXNjLT5oZWFkLCBnYy0+d3Ffc2l6ZSkgPj0gc2l6ZSkgewo+IC0JCQlyZXQgPSAw Owo+IC0JCQlicmVhazsKPiAtCQl9Cj4gKwlmcmVlc3BhY2UgPSBDSVJDX1NQQUNFKGdjLT53cV90 YWlsLCBkZXNjLT5oZWFkLCBnYy0+d3Ffc2l6ZSk7Cj4gKwlpZiAobGlrZWx5KGZyZWVzcGFjZSA+ PSB3cWlfc2l6ZSkpCj4gKwkJcmV0dXJuIDA7Cj4KPiAtCQlpZiAodGltZW91dF9jb3VudGVyKQo+ IC0JCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4gLQl9Owo+ICsJZ2MtPm5vX3dxX3NwYWNl ICs9IDE7Cj4KPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gLUVBR0FJTjsKPiAgIH0KPgo+ICAg c3RhdGljIGludCBndWNfYWRkX3dvcmtxdWV1ZV9pdGVtKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQg KmdjLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gaW5kZXggOTFmMzE1Yy4uMzgwYTc0MyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gQEAgLTQ4LDkgKzQ4LDE4IEBAIHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdDsKPiAgICAqIHF1ZXVlIChhIGNpcmN1bGFyIGFycmF5IG9m IHdvcmsgaXRlbXMpLCBhZ2FpbiBkZXNjcmliZWQgaW4gdGhlIHByb2Nlc3MKPiAgICAqIGRlc2Ny aXB0b3IuIFdvcmsgcXVldWUgcGFnZXMgYXJlIG1hcHBlZCBtb21lbnRhcmlseSBhcyByZXF1aXJl ZC4KPiAgICAqCj4gLSAqIEZpbmFsbHksIHdlIGFsc28ga2VlcCBhIGZldyBzdGF0aXN0aWNzIGhl cmUsIGluY2x1ZGluZyB0aGUgbnVtYmVyIG9mCj4gLSAqIHN1Ym1pc3Npb25zIHRvIGVhY2ggZW5n aW5lLCBhbmQgYSByZWNvcmQgb2YgdGhlIGxhc3Qgc3VibWlzc2lvbiBmYWlsdXJlCj4gLSAqIChp ZiBhbnkpLgo+ICsgKiBXZSBhbHNvIGtlZXAgYSBmZXcgc3RhdGlzdGljcyBvbiBmYWlsdXJlcy4g SWRlYWxseSwgdGhlc2Ugc2hvdWxkIGFsbAo+ICsgKiBiZSB6ZXJvIQo+ICsgKiAgIG5vX3dxX3Nw YWNlOiB0aW1lcyB0aGF0IHRoZSBzdWJtaXNzaW9uIHByZS1jaGVjayBmb3VuZCBubyBzcGFjZSB3 YXMKPiArICogICAgICAgICAgICAgICAgYXZhaWxhYmxlIGluIHRoZSB3b3JrIHF1ZXVlIChub3Rl LCB0aGUgcXVldWUgaXMgc2hhcmVkLAo+ICsgKiAgICAgICAgICAgICAgICBub3QgcGVyLWVuZ2lu ZSkuIEl0IGlzIE9LIGZvciB0aGlzIHRvIGJlIG5vbnplcm8sIGJ1dAo+ICsgKiAgICAgICAgICAg ICAgICBpdCBzaG91bGQgbm90IGJlIGh1Z2UhCj4gKyAqICAgcV9mYWlsOiBmYWlsZWQgdG8gZW5x dWV1ZSBhIHdvcmsgaXRlbS4gVGhpcyBzaG91bGQgbmV2ZXIgaGFwcGVuLAo+ICsgKiAgICAgICAg ICAgYmVjYXVzZSB3ZSBjaGVjayBmb3Igc3BhY2UgYmVmb3JlaGFuZC4KPiArICogICBiX2ZhaWw6 IGZhaWxlZCB0byByaW5nIHRoZSBkb29yYmVsbC4gVGhpcyBzaG91bGQgbmV2ZXIgaGFwcGVuLCB1 bmxlc3MKPiArICogICAgICAgICAgIHNvbWVob3cgdGhlIGhhcmR3YXJlIG1pc2JlaGF2ZXMsIG9y IG1heWJlIGlmIHRoZSBHdUMgZmlybXdhcmUKPiArICogICAgICAgICAgIGNyYXNoZXM/IFdlIHBy b2JhYmx5IG5lZWQgdG8gcmVzZXQgdGhlIEdQVSB0byByZWNvdmVyLgo+ICsgKiAgIHJldGNvZGU6 IGVycm5vIGZyb20gbGFzdCBndWNfc3VibWl0KCkKPiAgICAqLwo+ICAgc3RydWN0IGk5MTVfZ3Vj X2NsaWVudCB7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmNsaWVudF9vYmo7Cj4g QEAgLTcxLDEyICs4MCwxMyBAQCBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50IHsKPiAgIAl1aW50MzJf dCB3cV90YWlsOwo+ICAgCXVpbnQzMl90IHVudXNlZDsJCS8qIFdhcyAnd3FfaGVhZCcJCSovCj4K PiAtCS8qIEd1QyBzdWJtaXNzaW9uIHN0YXRpc3RpY3MgJiBzdGF0dXMgKi8KPiAtCXVpbnQ2NF90 IHN1Ym1pc3Npb25zW0dVQ19NQVhfRU5HSU5FU19OVU1dOwo+ICsJdWludDMyX3Qgbm9fd3Ffc3Bh Y2U7Cj4gICAJdWludDMyX3QgcV9mYWlsOwo+ICAgCXVpbnQzMl90IGJfZmFpbDsKPiAgIAlpbnQg cmV0Y29kZTsKPiAtCWludCBzcGFyZTsJCQkvKiBwYWQgdG8gMzIgRFdvcmRzCQkqLwo+ICsKPiAr CS8qIFBlci1lbmdpbmUgY291bnRzIG9mIEd1QyBzdWJtaXNzaW9ucyAqLwo+ICsJdWludDY0X3Qg c3VibWlzc2lvbnNbR1VDX01BWF9FTkdJTkVTX05VTV07Cj4gICB9Owo+Cj4gICBlbnVtIGludGVs X2d1Y19md19zdGF0dXMgewo+CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=