From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v4 3/7] drm/i915/guc: add enable_guc_loading parameter Date: Mon, 16 May 2016 20:07:31 +0100 Message-ID: <573A1A73.2040005@intel.com> References: <1463150195-28805-1-git-send-email-david.s.gordon@intel.com> <1463150195-28805-4-git-send-email-david.s.gordon@intel.com> <5735F369.3010601@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 05D8E6E288 for ; Mon, 16 May 2016 19:07:32 +0000 (UTC) In-Reply-To: <5735F369.3010601@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDUvMTYgMTY6MzEsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTMvMDUvMTYg MTU6MzYsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBTcGxpdCB0aGUgZnVuY3Rpb24gb2YgImVuYWJs ZV9ndWNfc3VibWlzc2lvbiIgaW50byB0d28gc2VwYXJhdGUKPj4gb3B0aW9ucy4gIFRoZSBuZXcg b25lICgiZW5hYmxlX2d1Y19sb2FkaW5nIikgY29udHJvbHMgb25seSB0aGUKPj4gKmZldGNoaW5n IGFuZCBsb2FkaW5nKiBvZiB0aGUgR3VDIGZpcm13YXJlIGltYWdlLiBUaGUgZXhpc3RpbmcKPj4g b25lIGlzIHJlZGVmaW5lZCB0byBjb250cm9sIG9ubHkgdGhlICp1c2UqIG9mIHRoZSBHdUMgZm9y IGJhdGNoCj4+IHN1Ym1pc3Npb24gb25jZSB0aGUgZmlybXdhcmUgaXMgbG9hZGVkLgo+Pgo+PiBJ biBhZGRpdGlvbiwgdGhlIGRlZ3JlZSBvZiBjb250cm9sIGhhcyBiZWVuIHJlZmluZWQgZnJvbSBh IHNpbXBsZQo+PiBib29sIHRvIGFuIGludGVnZXIga2V5LCBhbGxvd2luZyBzZXZlcmFsIG9wdGlv bnM6Cj4+IC0xIChkZWZhdWx0KSAgICAgd2hhdGV2ZXIgdGhlIHBsYXRmb3JtIGRlZmF1bHQgaXMK Pj4gICAwICBESVNBQkxFICAgICAgZG9uJ3QgbG9hZC91c2UgdGhlIEd1Qwo+PiAgIDEgIEJFU1Qg RUZGT1JUICB0cnkgdG8gbG9hZC91c2UgdGhlIEd1QywgZmFsbGJhY2sgaWYgbm90IGF2YWlsYWJs ZQo+PiAgIDIgIFJFUVVJUkUgICAgICBtdXN0IGxvYWQvdXNlIHRoZSBHdUMsIGVsc2UgbGVhdmUg dGhlIEdQVSB3ZWRnZWQKPj4KPj4gVGhlIG5ldyBwbGF0Zm9ybSBkZWZhdWx0IChhcyBjb2RlZCBo ZXJlKSB3aWxsIGJlIHRvIGF0dGVtcHQgdG8KPj4gbG9hZCB0aGUgR3VDIGlmZiB0aGUgZGV2aWNl IGhhcyBhIEd1QyB0aGF0IHJlcXVpcmVzIGZpcm13YXJlLAo+PiBidXQgbm90IHlldCB0byB1c2Ug aXQgZm9yIHN1Ym1pc3Npb24uIEEgbGF0ZXIgcGF0Y2ggd2lsbCBjaGFuZ2UKPj4gdG8gZW5hYmxl IGl0IGlmIGFwcHJvcHJpYXRlLgo+Pgo+PiB2NDoKPj4gICAgICBDaGFuZ2VkIHNvbWUgZXJyb3It bWVzc2FnZSBsZXZlbHMsIG1vc3RseSBFUlJPUi0+SU5GTywgcGVyCj4+ICAgICAgcmV2aWV3IGNv bW1lbnRzIGJ5IFR2cnRrbyBVcnN1bGluLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRv biA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jICAgICAgICAgICAgfCAgIDEgLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8ICAgNCArLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcGFyYW1zLmMgICAgICAgICB8ICAxNCArKystCj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wYXJhbXMuaCAgICAgICAgIHwgICAzICstCj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jICAgIHwgMTA4Cj4+ICsrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0tCj4+ICAgNSBmaWxlcyBjaGFuZ2VkLCA3NiBpbnNlcnRpb25zKCspLCA1NCBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+IGluZGV4IDJhN2JlNzEu LjJiZjg3NDMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBAQCAtNDg3MCw3ICs0 ODcwLDYgQEAgaW50IGk5MTVfZ2VtX2luaXRfZW5naW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+PiAgICAgICAgICAgcmV0ID0gaW50ZWxfZ3VjX3NldHVwKGRldik7Cj4+ICAgICAgICAgICBp ZiAocmV0KSB7Cj4+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJGYWlsZWQgdG8gaW5pdGlhbGl6 ZSBHdUMsIGVycm9yICVkXG4iLCByZXQpOwo+Cj4gVGhpcyBlcnJvciBtc2cgc2hvdWxkIGdvIGFz IHdlbGwgSSB0aGluay4KClllcywgaWYgd2UgcmVhY2ggdGhpcyB3ZSdsbCBoYXZlIGp1c3QgcHJp bnRlZCBhIG1lc3NhZ2UgaW4gCmludGVsX2d1Y19zZXR1cCgpIHNvIHdlIGRvbid0IHJlYWxseSBu ZWVkIGJvdGguCgo+PiAtICAgICAgICAgICAgcmV0ID0gLUVJTzsKPj4gICAgICAgICAgICAgICBn b3RvIG91dDsKPj4gICAgICAgICAgIH0KPj4gICAgICAgfQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGluZGV4IDE2OTI0MmEuLjkxNmNkNjcgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gQEAg LTk2OSw3ICs5NjksNyBAQCBpbnQgaW50ZWxfZ3VjX3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPj4gICAgICAgc3RydWN0IGludGVsX2NvbnRleHQgKmN0eDsKPj4gICAgICAgdTMyIGRh dGFbM107Cj4+Cj4+IC0gICAgaWYgKCFpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikKPj4gKyAg ICBpZiAoZ3VjLT5ndWNfZncuZ3VjX2Z3X2xvYWRfc3RhdHVzICE9IEdVQ19GSVJNV0FSRV9TVUND RVNTKQo+PiAgICAgICAgICAgcmV0dXJuIDA7Cj4+Cj4+ICAgICAgIGN0eCA9IGRldl9wcml2LT5r ZXJuZWxfY29udGV4dDsKPj4gQEAgLTk5NSw3ICs5OTUsNyBAQCBpbnQgaW50ZWxfZ3VjX3Jlc3Vt ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgICAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAq Y3R4Owo+PiAgICAgICB1MzIgZGF0YVszXTsKPj4KPj4gLSAgICBpZiAoIWk5MTUuZW5hYmxlX2d1 Y19zdWJtaXNzaW9uKQo+PiArICAgIGlmIChndWMtPmd1Y19mdy5ndWNfZndfbG9hZF9zdGF0dXMg IT0gR1VDX0ZJUk1XQVJFX1NVQ0NFU1MpCj4+ICAgICAgICAgICByZXR1cm4gMDsKPgo+IFdpbGwg dGhlIGFib3ZlIHR3byBkbyB0aGUgcmlnaHQgdGhpbmcgZm9yIHRoZSBmd19wYXRoID09IE5VTEwg Y2FzZT8gVGhhdAo+IGlzICFIQVNfR1VDX1VDT0RFICYmIEhBU19HVUNfU0NIRUQ/IExvb2tzIGxp a2UgbG9hZCBzdGF0dXMgd2lsbCBidCBOT05FCj4gaW4gdGhhdCBjYXNlLCBHdUMgc3VibWlzc2lv biB3aWxsIGJlIGVuYWJsZWQgYW5kIHN1c3BlbmQgYW5kIHJlc3VtZQo+IGhvb2tzIHdpbGwgYmUg c2tpcHBlZD8KPgo+IE1heWJlIGZldGNoIGFuZCBsb2FkIHN0YXR1cyBzaG91bGQgYmUgc2V0IHRv IHN1Y2Nlc3Mgb24gc3VjaCBwbGF0Zm9ybXM/CgpJIHRoaW5rIHByb2JhYmx5IGZldGNoPT1OT05F IGJ1dCBsb2FkPT1TVUNDRVNTLCBpbiB3aGljaCBjYXNlIHRoZSBjb2RlIAphYm92ZSB3aWxsIGJl IGNvcnJlY3QgYWxyZWFkeS4gT1RPSCB0aGVyZSBhcmVuJ3QgYWN0dWFsbHkgYW55IHN1Y2ggCnBs YXRmb3JtcyB5ZXQsIGFuZCBpbnRlbF9ndWNfc2V0dXAoKSBkb2Vzbid0IHJlYWxseSBzdXBwb3J0 IHRoaXMgZnVsbHk7IApmb3IgaW5zdGFuY2UsIHdlIGRvbid0IGtub3cgd2hldGhlciB0aGUgY29y cmVjdCBiZWhhdmlvdXIgb2YgX3NldHVwKCkgb24gCnN1Y2ggYSBoeXBvdGhldGljYWwgcGxhdGZv cm0gd291bGQgYmUgdG8gcmVzZXQgdGhlIEd1QyBhbmQganVzdCBza2lwIHRoZSAKRE1BLCBvciB0 byBza2lwIHRoZSByZXNldCBhcyB3ZWxsLiBDZXJ0YWlubHkgc29tZSBvZiB0aGUgc2V0dXAgd291 bGQgCnN0aWxsIGJlIHJlcXVpcmVkLgoKU28gZm9yIG5vdyBJJ3ZlIGZvcmNlZCBHdUMgc3VibWlz c2lvbiBvZmYgZm9yIGFueSBzdWNoIHBsYXRmb3JtLCBzbyB0aGUgCmNvZGUgYWJvdmUgc2hvdWxk IGJlIE9LIGZvciB0aGUgZm91ciBwb3NzaWJpbGl0aWVzIChubyBHdUMsIEd1QyBub3QgCmxvYWRl ZCwgR3VDIGxvYWRlZCBidXQgbm90IHVzZWQgZm9yIHN1Ym1pc3Npb24sIEd1QyBsb2FkZWQgYW5k IGluIHVzZSkuCgpXZSBjYW4gcmV2aXNpdCB0aGlzIGluIHRoZSBldmVudCB0aGF0IGEgZmlybXdh cmUtZnJlZSBHdUMgZXZlciBhcHBlYXJzIQoKW3NuaXBdCgo+PiBAQCAtNDg2LDcgKzQ3NCw2IEBA IGludCBpbnRlbF9ndWNfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4gICAgICAgcmV0 dXJuIDA7Cj4+Cj4+ICAgZmFpbDoKPj4gLSAgICBEUk1fRVJST1IoIkd1QyBmaXJtd2FyZSBsb2Fk IGZhaWxlZCwgZXJyICVkXG4iLCBlcnIpOwo+PiAgICAgICBpZiAoZ3VjX2Z3LT5ndWNfZndfbG9h ZF9zdGF0dXMgPT0gR1VDX0ZJUk1XQVJFX1BFTkRJTkcpCj4+ICAgICAgICAgICBndWNfZnctPmd1 Y19md19sb2FkX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9GQUlMOwo+Pgo+PiBAQCAtNDk0LDcgKzQ4 MSwzNiBAQCBpbnQgaW50ZWxfZ3VjX3NldHVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAg ICAgIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+PiAgICAgICBpOTE1X2d1Y19z dWJtaXNzaW9uX2ZpbmkoZGV2KTsKPj4KPj4gLSAgICByZXR1cm4gZXJyOwo+PiArICAgIC8qCj4+ ICsgICAgICogV2UndmUgZmFpbGVkIHRvIGxvYWQgdGhlIGZpcm13YXJlIDooCj4+ICsgICAgICoK Pj4gKyAgICAgKiBEZWNpZGUgd2hldGhlciB0byBkaXNhYmxlIEd1QyBzdWJtaXNzaW9uIGFuZCBm YWxsIGJhY2sgdG8KPj4gKyAgICAgKiBleGVjbGlzdCBtb2RlLCBhbmQgd2hldGhlciB0byBoaWRl IHRoZSBlcnJvciBieSByZXR1cm5pbmcKPj4gKyAgICAgKiB6ZXJvIG9yIHRvIHJldHVybiAtRUlP LCB3aGljaCB0aGUgY2FsbGVyIHdpbGwgdHJlYXQgYXMgYQo+PiArICAgICAqIG5vbmZhdGFsIGVy cm9yIChpLmUuIGl0IGRvZXNuJ3QgcHJldmVudCBkcml2ZXIgbG9hZCwgYnV0Cj4+ICsgICAgICog bWFya3MgdGhlIEdQVSBhcyB3ZWRnZWQgdW50aWwgcmVzZXQpLgo+PiArICAgICAqLwo+PiArICAg IGlmIChpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA+IDEpIHsKPj4gKyAgICAgICAgcmV0ID0gLUVJ TzsKPj4gKyAgICB9IGVsc2UgaWYgKEhBU19HVUNfU0NIRUQoZGV2KSAmJiAhSEFTX0dVQ19VQ09E RShkZXYpKSB7Cj4+ICsgICAgICAgIC8qIFRoaXMgR3VDIHdvcmtzIGV2ZW4gd2l0aG91dCBmaXJt d2FyZSA6KSAqLwo+PiArICAgICAgICByZXR1cm4gMDsKPj4gKyAgICB9IGVsc2UgaWYgKGk5MTUu ZW5hYmxlX2d1Y19zdWJtaXNzaW9uID4gMSkgewo+PiArICAgICAgICByZXQgPSAtRUlPOwo+PiAr ICAgIH0gZWxzZSB7Cj4+ICsgICAgICAgIHJldCA9IDA7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAg aWYgKHJldCA9PSAtRUlPKQo+PiArICAgICAgICBEUk1fRVJST1IoIkd1QyBmaXJtd2FyZSBsb2Fk IGZhaWxlZCwgZXJyICVkXG4iLCBlcnIpOwo+PiArICAgIGVsc2UKPj4gKyAgICAgICAgRFJNX0lO Rk8oIkd1QyBmaXJtd2FyZSBsb2FkIGZhaWxlZCwgZXJyICVkXG4iLCBlcnIpOwo+PiArCj4+ICsg ICAgaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKQo+PiArICAgICAgICBEUk1fSU5GTygi ZmFsbGluZyBiYWNrIHRvIGV4ZWNsaXN0IG1vZGUsIHJldCAlZFxuIiwgcmV0KTsKPgo+IHJldCBp cyBhbHdheXMgemVybyBpbiB0aGlzIG1zZz8KCkkgc2hvdWxkbid0IHRoaW5rIHNvOyBBRkFJQ1Mg aXQgY291bGQgYWxzbyBiZSAtRUlPLiBUaGlzIG1lc3NhZ2UgY2FuIGJlIApwcmludGVkIGluIGNv bmp1bmN0aW9uIHdpdGggZWl0aGVyIHZhcmlhbnQgb2YgdGhlIG1lc3NhZ2UgYWJvdmUuCgouRGF2 ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==