Re: [PATCH i-g-t v2] autotools/: Allow building tests/gem_concurrent_{all, blit}

From: Gabriel Feceoru <gabriel.feceoru@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, jani.nikula@intel.com,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH i-g-t v2] autotools/: Allow building tests/gem_concurrent_{all, blit}
Date: Tue, 17 May 2016 15:24:07 +0300	[thread overview]
Message-ID: <573B0D67.1010103@intel.com> (raw)
In-Reply-To: <20160517100205.GU27098@phenom.ffwll.local>

On 17.05.2016 13:02, Daniel Vetter wrote:
> On Mon, May 16, 2016 at 06:09:27PM +0300, Marius Vlad wrote:
>> Trivial. Pushed.
>>
>> On Mon, May 16, 2016 at 01:36:48PM +0300, Marius Vlad wrote:
>>> Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).
>>>
>>> v2: Fix commit typo (Jani Nikula).
>>>
>>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>
> Also review from my side on the offending original commit was ignored -
> imo gem_concurrent_all should just be put into EXTRA, and
> gem_concurrent_blit should be kept in the normal igt set of testcases.
>
> Dropping gem_concurrent_blit from the list of tests means we have a
> massive gap in coverage. If that one still has too many subtests we need
> to filter them harder, but that's a different problem.

gem_concurrent_all can still be tested, using test-list-full.txt instead.
Now, piglit igt profile has hardcoded "test-list.txt" (plus 
"single-tests.txt" and "multi-tests.txt" - which I guess are history).
We can specify which test list to use with a change in piglit (by 
redefining IGT_TEST_ROOT or another var).
Alternatively test-list.txt can be replaced with test-list-full.txt (or 
symlink).

Regards,
Gabriel.

>
> Also pls run $ make distcheck before pushing stuf ...
> -Daniel
>
>>> ---
>>>   tests/Makefile.am | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>>> index 32b9115..c2c2025 100644
>>> --- a/tests/Makefile.am
>>> +++ b/tests/Makefile.am
>>> @@ -30,6 +30,7 @@ pkglibexec_PROGRAMS = \
>>>   	gem_stress \
>>>   	$(TESTS_progs) \
>>>   	$(TESTS_progs_M) \
>>> +	$(TESTS_progs_XM) \
>>>   	$(NULL)
>>>
>>>   dist_pkglibexec_SCRIPTS = \
>>> --
>>> 2.8.0.rc3
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx