From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4 1/2] drm/i915: refactor i915_gem_object_pin_map() Date: Tue, 17 May 2016 14:13:17 +0100 Message-ID: <573B18ED.9090107@linux.intel.com> References: <1463489483-34903-1-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 870D86E6EE for ; Tue, 17 May 2016 13:13:19 +0000 (UTC) In-Reply-To: <1463489483-34903-1-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA1LzE2IDEzOjUxLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaGUgcmVjZW50bHktYWRk ZWQgaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoKSBjYW4gYmUgZnVydGhlciBvcHRpbWlzZWQKPiBm b3IgInNtYWxsIiBvYmplY3RzLiBUbyBmYWNpbGl0YXRlIHRoaXMsIGFuZCBzaW1wbGlmeSB0aGUg ZXJyb3IgcGF0aHMKPiBiZWZvcmUgYWRkaW5nIHRoZSBuZXcgY29kZSwgdGhpcyBwYXRjaCBwdWxs cyBvdXQgdGhlICJtYXBwaW5nIiBwYXJ0IG9mCj4gdGhlIG9wZXJhdGlvbiAoaW52b2x2aW5nIGxv Y2FsIGFsbG9jYXRpb25zIHdoaWNoIG11c3QgYmUgdW5kb25lIGJlZm9yZQo+IHJldHVybikgaW50 byBpdHMgb3duIHN1YmZ1bmN0aW9uLgo+Cj4gVGhlIG5leHQgcGF0Y2ggd2lsbCB0aGVuIGluc2Vy dCB0aGUgbmV3IG9wdGltaXNhdGlvbiBpbnRvIHRoZSBtaWRkbGUgb2YKPiB0aGUgbm93LXNlcGFy YXRlZCBzdWJmdW5jdGlvbi4KPgo+IFRoaXMgcmVvcmdhbmlzYXRpb24gd2lsbCBwcm9iYWJseSBu b3QgYWZmZWN0IHRoZSBnZW5lcmF0ZWQgY29kZSwgYXMgdGhlCj4gY29tcGlsZXIgd2lsbCBtb3N0 IGxpa2VseSBpbmxpbmUgaXQgYW55d2F5LCBidXQgaXQgbWFrZXMgdGhlIGxvZ2ljYWwKPiBzdHJ1 Y3R1cmUgYSBiaXQgY2xlYXJlciBhbmQgZWFzaWVyIHRvIG1vZGlmeS4KPgo+IHYyOgo+ICAgICAg UmVzdHJ1Y3R1cmUgbG9vcC1vdmVyLXBhZ2VzICYgZXJyb3IgY2hlY2sgW0NocmlzIFdpbHNvbl0K Pgo+IHYzOgo+ICAgICAgQWRkIHBhZ2UgY291bnQgdG8gZGVidWcgbWVzc2FnZXMgW0NocmlzIFdp bHNvbl0KPiAgICAgIENvbnZlcnQgV0FSTl9PTigpIHRvIEdFTV9CVUdfT04oKQo+Cj4gdjQ6Cj4g ICAgICBEcm9wIHRoZSBERUJVRyBtZXNzYWdlcyBbVHZydGtvIFVyc3VsaW5dCj4KPiBTaWduZWQt b2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IENjOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgfCA1NCArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggMjRjYWI4OC4uODJhMWJjNCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yMzk4LDYgKzIzOTgsMzggQEAgc3RhdGljIHZv aWQgaTkxNV9nZW1fb2JqZWN0X2ZyZWVfbW1hcF9vZmZzZXQoc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaikKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+ICsvKiBUaGUgJ21hcHBpbmcnIHBh cnQgb2YgaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoKSBiZWxvdyAqLwo+ICtzdGF0aWMgdm9pZCAq aTkxNV9nZW1fb2JqZWN0X21hcChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq KQo+ICt7Cj4gKwl1bnNpZ25lZCBsb25nIG5fcGFnZXMgPSBvYmotPmJhc2Uuc2l6ZSA+PiBQQUdF X1NISUZUOwo+ICsJc3RydWN0IHNnX3RhYmxlICpzZ3QgPSBvYmotPnBhZ2VzOwo+ICsJc3RydWN0 IHNnX3BhZ2VfaXRlciBzZ19pdGVyOwo+ICsJc3RydWN0IHBhZ2UgKipwYWdlczsKPiArCXVuc2ln bmVkIGxvbmcgaSA9IDA7Cj4gKwl2b2lkICphZGRyOwo+ICsKPiArCS8qIEEgc2luZ2xlIHBhZ2Ug Y2FuIGFsd2F5cyBiZSBrbWFwcGVkICovCj4gKwlpZiAobl9wYWdlcyA9PSAxKQo+ICsJCXJldHVy biBrbWFwKHNnX3BhZ2Uoc2d0LT5zZ2wpKTsKPiArCj4gKwlwYWdlcyA9IGRybV9tYWxsb2NfZ2Zw KG5fcGFnZXMsIHNpemVvZigqcGFnZXMpLCBHRlBfVEVNUE9SQVJZKTsKPiArCWlmIChwYWdlcyA9 PSBOVUxMKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCWZvcl9lYWNoX3NnX3BhZ2Uoc2d0LT5z Z2wsICZzZ19pdGVyLCBzZ3QtPm5lbnRzLCAwKQo+ICsJCXBhZ2VzW2krK10gPSBzZ19wYWdlX2l0 ZXJfcGFnZSgmc2dfaXRlcik7Cj4gKwo+ICsJLyogQ2hlY2sgdGhhdCB3ZSBoYXZlIHRoZSBleHBl Y3RlZCBudW1iZXIgb2YgcGFnZXMgKi8KPiArCUdFTV9CVUdfT04oaSAhPSBuX3BhZ2VzKTsKPiAr Cj4gKwlhZGRyID0gdm1hcChwYWdlcywgbl9wYWdlcywgMCwgUEFHRV9LRVJORUwpOwo+ICsKPiAr CWRybV9mcmVlX2xhcmdlKHBhZ2VzKTsKPiArCj4gKwlyZXR1cm4gYWRkcjsKPiArfQo+ICsKPiAr LyogZ2V0LCBwaW4sIGFuZCBtYXAgdGhlIHBhZ2VzIG9mIHRoZSBvYmplY3QgaW50byBrZXJuZWwg c3BhY2UgKi8KPiAgIHZvaWQgKmk5MTVfZ2VtX29iamVjdF9waW5fbWFwKHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmopCj4gICB7Cj4gICAJaW50IHJldDsKPiBAQCAtMjQxMSwyNyArMjQ0 Myw3IEBAIHZvaWQgKmk5MTVfZ2VtX29iamVjdF9waW5fbWFwKHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpvYmopCj4gICAJaTkxNV9nZW1fb2JqZWN0X3Bpbl9wYWdlcyhvYmopOwo+Cj4gICAJ aWYgKG9iai0+bWFwcGluZyA9PSBOVUxMKSB7Cj4gLQkJc3RydWN0IHBhZ2UgKipwYWdlczsKPiAt Cj4gLQkJcGFnZXMgPSBOVUxMOwo+IC0JCWlmIChvYmotPmJhc2Uuc2l6ZSA9PSBQQUdFX1NJWkUp Cj4gLQkJCW9iai0+bWFwcGluZyA9IGttYXAoc2dfcGFnZShvYmotPnBhZ2VzLT5zZ2wpKTsKPiAt CQllbHNlCj4gLQkJCXBhZ2VzID0gZHJtX21hbGxvY19nZnAob2JqLT5iYXNlLnNpemUgPj4gUEFH RV9TSElGVCwKPiAtCQkJCQkgICAgICAgc2l6ZW9mKCpwYWdlcyksCj4gLQkJCQkJICAgICAgIEdG UF9URU1QT1JBUlkpOwo+IC0JCWlmIChwYWdlcyAhPSBOVUxMKSB7Cj4gLQkJCXN0cnVjdCBzZ19w YWdlX2l0ZXIgc2dfaXRlcjsKPiAtCQkJaW50IG47Cj4gLQo+IC0JCQluID0gMDsKPiAtCQkJZm9y X2VhY2hfc2dfcGFnZShvYmotPnBhZ2VzLT5zZ2wsICZzZ19pdGVyLAo+IC0JCQkJCSBvYmotPnBh Z2VzLT5uZW50cywgMCkKPiAtCQkJCXBhZ2VzW24rK10gPSBzZ19wYWdlX2l0ZXJfcGFnZSgmc2df aXRlcik7Cj4gLQo+IC0JCQlvYmotPm1hcHBpbmcgPSB2bWFwKHBhZ2VzLCBuLCAwLCBQQUdFX0tF Uk5FTCk7Cj4gLQkJCWRybV9mcmVlX2xhcmdlKHBhZ2VzKTsKPiAtCQl9Cj4gKwkJb2JqLT5tYXBw aW5nID0gaTkxNV9nZW1fb2JqZWN0X21hcChvYmopOwo+ICAgCQlpZiAob2JqLT5tYXBwaW5nID09 IE5VTEwpIHsKPiAgIAkJCWk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhvYmopOwo+ICAgCQkJ cmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK