From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/9] drm/i915/gvt: Fold vGPU active check into inner functions Date: Wed, 18 May 2016 11:54:54 +0100 Message-ID: <573C49FE.1000301@linux.intel.com> References: <1463473149-5876-1-git-send-email-zhi.a.wang@intel.com> <1463473149-5876-3-git-send-email-zhi.a.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 54FA66E842 for ; Wed, 18 May 2016 10:54:57 +0000 (UTC) In-Reply-To: <1463473149-5876-3-git-send-email-zhi.a.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Zhi Wang , intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com, chris@chris-wilson.co.uk, kevin.tian@intel.com, zhiyuan.lv@intel.com List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA1LzE2IDA5OjE5LCBaaGkgV2FuZyB3cm90ZToKPiB2NToKPiAtIExldCBmdW5jdGlv bnMgdGFrZSBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqLiAoVHZydGtvKQo+Cj4gLSBGb2xkIHZH UFUgcmVsYXRlZCBhY3RpdmUgY2hlY2sgaW50byB0aGUgaW5uZXIgZnVuY3Rpb25zLiAoS2V2aW4p Cj4KPiBTaWduZWQtb2ZmLWJ5OiBaaGkgV2FuZyA8emhpLmEud2FuZ0BpbnRlbC5jb20+Cj4gLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyB8IDExICsrKystLS0tLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZncHUuYyAgICB8IDEzICsrKysrKysrKy0t LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdmdwdS5oICAgIHwgIDQgKystLQo+ICAg MyBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gaW5kZXggN2VhYjYxOS4uODIwYjU5ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTI3MzcsMTEgKzI3MzcsOSBA QCBzdGF0aWMgaW50IGk5MTVfZ2VtX3NldHVwX2dsb2JhbF9ndHQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAgIAlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+YmFzZSwgZGV2X3ByaXYp Owo+ICAgCWdndHQtPmJhc2UudG90YWwgKz0gUEFHRV9TSVpFOwo+Cj4gLQlpZiAoaW50ZWxfdmdw dV9hY3RpdmUoZGV2X3ByaXYpKSB7Cj4gLQkJcmV0ID0gaW50ZWxfdmd0X2JhbGxvb24oZGV2KTsK PiAtCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+IC0JfQo+ICsJcmV0ID0gaW50ZWxfdmd0 X2JhbGxvb24oZGV2X3ByaXYpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+Cj4gICAJ aWYgKCFIQVNfTExDKGRldikpCj4gICAJCWdndHQtPmJhc2UubW0uY29sb3JfYWRqdXN0ID0gaTkx NV9ndHRfY29sb3JfYWRqdXN0Owo+IEBAIC0yODQxLDggKzI4MzksNyBAQCB2b2lkIGk5MTVfZ2d0 dF9jbGVhbnVwX2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJaTkxNV9nZW1fY2xlYW51 cF9zdG9sZW4oZGV2KTsKPgo+ICAgCWlmIChkcm1fbW1faW5pdGlhbGl6ZWQoJmdndHQtPmJhc2Uu bW0pKSB7Cj4gLQkJaWYgKGludGVsX3ZncHVfYWN0aXZlKGRldl9wcml2KSkKPiAtCQkJaW50ZWxf dmd0X2RlYmFsbG9vbigpOwo+ICsJCWludGVsX3ZndF9kZWJhbGxvb24oZGV2X3ByaXYpOwo+Cj4g ICAJCWRybV9tbV90YWtlZG93bigmZ2d0dC0+YmFzZS5tbSk7Cj4gICAJCWxpc3RfZGVsKCZnZ3R0 LT5iYXNlLmdsb2JhbF9saW5rKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV92Z3B1LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZncHUuYwo+IGluZGV4IGQ1 YTdhNWUuLjUzMTI4MTYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92 Z3B1LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZncHUuYwo+IEBAIC0xMDEs MTAgKzEwMSwxMyBAQCBzdGF0aWMgc3RydWN0IF9iYWxsb29uX2luZm9fIGJsX2luZm87Cj4gICAg KiBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB0byBkZWFsbG9jYXRlIHRoZSBiYWxsb29uZWQtb3V0 IGdyYXBoaWMgbWVtb3J5LCB3aGVuCj4gICAgKiBkcml2ZXIgaXMgdW5sb2FkZWQgb3Igd2hlbiBi YWxsb29uaW5nIGZhaWxzLgo+ICAgICovCj4gLXZvaWQgaW50ZWxfdmd0X2RlYmFsbG9vbih2b2lk KQo+ICt2b2lkIGludGVsX3ZndF9kZWJhbGxvb24oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICAgewo+ICAgCWludCBpOwo+Cj4gKwlpZiAoIWludGVsX3ZncHVfYWN0aXZlKGRl dl9wcml2KSkKPiArCQlyZXR1cm47Cj4gKwo+ICAgCURSTV9ERUJVRygiVkdUIGRlYmFsbG9vbi5c biIpOwo+Cj4gICAJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgewo+IEBAIC0xNzcsOSArMTgwLDgg QEAgc3RhdGljIGludCB2Z3RfYmFsbG9vbl9zcGFjZShzdHJ1Y3QgZHJtX21tICptbSwKPiAgICAq IFJldHVybnM6Cj4gICAgKiB6ZXJvIG9uIHN1Y2Nlc3MsIG5vbi16ZXJvIGlmIGNvbmZpZ3VyYXRp b24gaW52YWxpZCBvciBiYWxsb29uaW5nIGZhaWxlZAo+ICAgICovCj4gLWludCBpbnRlbF92Z3Rf YmFsbG9vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtpbnQgaW50ZWxfdmd0X2JhbGxvb24o c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgewo+IC0Jc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAgCXN0cnVjdCBpOTE1X2dn dHQgKmdndHQgPSAmZGV2X3ByaXYtPmdndHQ7Cj4gICAJdW5zaWduZWQgbG9uZyBnZ3R0X2VuZCA9 IGdndHQtPmJhc2Uuc3RhcnQgKyBnZ3R0LT5iYXNlLnRvdGFsOwo+Cj4gQEAgLTE4Nyw2ICsxODks OSBAQCBpbnQgaW50ZWxfdmd0X2JhbGxvb24oc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAl1 bnNpZ25lZCBsb25nIHVubWFwcGFibGVfYmFzZSwgdW5tYXBwYWJsZV9zaXplLCB1bm1hcHBhYmxl X2VuZDsKPiAgIAlpbnQgcmV0Owo+Cj4gKwlpZiAoIWludGVsX3ZncHVfYWN0aXZlKGRldl9wcml2 KSkKPiArCQlyZXR1cm4gMDsKPiArCj4gICAJbWFwcGFibGVfYmFzZSA9IEk5MTVfUkVBRCh2Z3Rp Zl9yZWcoYXZhaWxfcnMubWFwcGFibGVfZ21hZHIuYmFzZSkpOwo+ICAgCW1hcHBhYmxlX3NpemUg PSBJOTE1X1JFQUQodmd0aWZfcmVnKGF2YWlsX3JzLm1hcHBhYmxlX2dtYWRyLnNpemUpKTsKPiAg IAl1bm1hcHBhYmxlX2Jhc2UgPSBJOTE1X1JFQUQodmd0aWZfcmVnKGF2YWlsX3JzLm5vbm1hcHBh YmxlX2dtYWRyLmJhc2UpKTsKPiBAQCAtMjU4LDYgKzI2Myw2IEBAIGludCBpbnRlbF92Z3RfYmFs bG9vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Cj4gICBlcnI6Cj4gICAJRFJNX0VSUk9SKCJW R1QgYmFsbG9vbiBmYWlsXG4iKTsKPiAtCWludGVsX3ZndF9kZWJhbGxvb24oKTsKPiArCWludGVs X3ZndF9kZWJhbGxvb24oZGV2X3ByaXYpOwo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdmdwdS5oIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV92Z3B1LmgKPiBpbmRleCAwN2U2N2Q1Li5mODkxN2M2IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdmdwdS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV92Z3B1LmgKPiBAQCAtMjcsNyArMjcsNyBAQAo+ICAgI2luY2x1ZGUgImk5MTVf cHZpbmZvLmgiCj4KPiAgIGV4dGVybiB2b2lkIGk5MTVfY2hlY2tfdmdwdShzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+IC1leHRlcm4gaW50IGludGVsX3ZndF9iYWxsb29uKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+IC1leHRlcm4gdm9pZCBpbnRlbF92Z3RfZGViYWxsb29u KHZvaWQpOwo+ICtleHRlcm4gaW50IGludGVsX3ZndF9iYWxsb29uKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdik7Cj4gK2V4dGVybiB2b2lkIGludGVsX3ZndF9kZWJhbGxvb24oc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPgo+ICAgI2VuZGlmIC8qIF9JOTE1X1ZH UFVfSF8gKi8KPgoKTG9va3MgY2xlYW4gdG8gbWUuCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==