From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Add ppgtt->kunmap_page_dma vfunc Date: Wed, 18 May 2016 14:31:28 +0100 Message-ID: <573C6EB0.1010701@linux.intel.com> References: <573C57B9.8070706@intel.com> <1463573166-7008-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160518122226.GL30479@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id BE1EC6E870 for ; Wed, 18 May 2016 13:31:30 +0000 (UTC) In-Reply-To: <20160518122226.GL30479@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA1LzE2IDEzOjIyLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gV2VkLCBNYXkgMTgs IDIwMTYgYXQgMDE6MDY6MDZQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IFJhdGhlciB0 aGFuIGFza2luZyBpdHNlbGYgImFtIEkgYSBCcm9hZHdlbGwsIGFtIEkgYSBDaGVycnl2aWV3LAo+ PiBvciBhbSBJIG5laXRoZXIgb2YgdGhlIHR3byIgb24gb24gbG93IGxldmVsIHBhZ2UgdGFibGUg b3BlcmF0aW9ucywKPj4gbGlrZSBpbnNlcnRpbmcgYW5kIGNsZWFyaW5nIFBURXM7IGFkZCBhIG5l dyB2ZnVuYyBrdW5tYXBfcGFnZV9kbWEKPj4gYW5kIHNldCBpdCB0byBhcHByb3ByaWF0ZSBmbGF2 b3VyIGF0IHBwZ3R0IGluaXQgdGltZS4KPj4KPj4gdjI6IEZpeCBwbGF0ZnJvbSBjb25kaXRpb24g YW5kIGdyb3VwIHZmdW5jIGluaXQgbW9yZSB0b2dldGhlci4KPj4gICAgICAoRGFuaWVsZSBDZXJh b2xvIFNwdXJpbykKPgo+IE9yIHdlIGNhbiB0YWtlIGEgZGlmZmVyZW50IGFwcHJvYWNoIGFuZCB1 c2UgYSBXQyBtYXBwaW5nIGZvciB0aGUgcGFnZS4KPgo+IFRoZSBwYXRjaCBpcyBhIGJpdCBtZXNz eSBzaW5jZSB3ZSBuZWVkIHRvIGZlZWQgbm90IHRoZSBkZXZpY2UgaW50byB0aGUKPiB1bm1hcCBm dW5jdGlvbiBidXQgdGhlIHZtLCBidXQgdGhlIGd1dHMgYXJlOgo+Cj4gQEAgLTMyMywxOSArMzIz LDIxIEBAIHN0YXRpYyBnZW42X3B0ZV90IGlyaXNfcHRlX2VuY29kZShkbWFfYWRkcl90IGFkZHIs Cj4gICAgICAgICAgcmV0dXJuIHB0ZTsKPiAgIH0KPgo+IC1zdGF0aWMgaW50IF9fc2V0dXBfcGFn ZV9kbWEoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3RydWN0IGk5MTVfcGFnZV9kbWEgKnAsIGdmcF90IGZsYWdzKQo+ICtzdGF0aWMgaW50IF9f c2V0dXBfcGFnZV9kbWEoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X3BhZ2VfZG1hICpwLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICBnZnBfdCBmbGFncykKPiAgIHsKPiAtICAgICAgIHN0cnVjdCBkZXZp Y2UgKmRldmljZSA9ICZkZXYtPnBkZXYtPmRldjsKPiAtCj4gICAgICAgICAgcC0+cGFnZSA9IGFs bG9jX3BhZ2UoZmxhZ3MpOwo+ICAgICAgICAgIGlmICghcC0+cGFnZSkKPiAgICAgICAgICAgICAg ICAgIHJldHVybiAtRU5PTUVNOwo+Cj4gLSAgICAgICBwLT5kYWRkciA9IGRtYV9tYXBfcGFnZShk ZXZpY2UsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwLT5wYWdlLCAwLCA0MDk2 LCBQQ0lfRE1BX0JJRElSRUNUSU9OQUwpOwo+ICsgICAgICAgaWYgKHZtLT5wdF9rbWFwX3djKQo+ ICsgICAgICAgICAgICAgICBzZXRfcGFnZXNfYXJyYXlfd2MoJnAtPnBhZ2UsIDEpOwo+ICsKPiAr ICAgICAgIHAtPmRhZGRyID0gZG1hX21hcF9wYWdlKHZtLT5kbWEsIHAtPnBhZ2UsIDAsIFBBR0Vf U0laRSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ETUFfQklESVJFQ1RJ T05BTCk7Cj4KPiAtICAgICAgIGlmIChkbWFfbWFwcGluZ19lcnJvcihkZXZpY2UsIHAtPmRhZGRy KSkgewo+ICsgICAgICAgaWYgKGRtYV9tYXBwaW5nX2Vycm9yKHZtLT5kbWEsIHAtPmRhZGRyKSkg ewo+ICAgICAgICAgICAgICAgICAgX19mcmVlX3BhZ2UocC0+cGFnZSk7Cj4gICAgICAgICAgICAg ICAgICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgICB9Cj4gQEAgLTM0Myw5NCArMzQ1LDg5IEBA IHN0YXRpYyBpbnQgX19zZXR1cF9wYWdlX2RtYShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAg ICAgICAgIHJldHVybiAwOwo+ICAgfQo+Cj4gLXN0YXRpYyBpbnQgc2V0dXBfcGFnZV9kbWEoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGk5MTVfcGFnZV9kbWEgKnApCj4gK3N0YXRpYyBp bnQgc2V0dXBfcGFnZV9kbWEoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9wYWdlX2RtYSAqcCkKPiAgIHsKPiAtICAg ICAgIHJldHVybiBfX3NldHVwX3BhZ2VfZG1hKGRldiwgcCwgSTkxNV9HRlBfRE1BKTsKPiArICAg ICAgIHJldHVybiBfX3NldHVwX3BhZ2VfZG1hKHZtLCBwLCBJOTE1X0dGUF9ETUEpOwo+ICAgfQo+ Cj4gLXN0YXRpYyB2b2lkIGNsZWFudXBfcGFnZV9kbWEoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg c3RydWN0IGk5MTVfcGFnZV9kbWEgKnApCj4gK3N0YXRpYyB2b2lkIGNsZWFudXBfcGFnZV9kbWEo c3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdHJ1Y3QgaTkxNV9wYWdlX2RtYSAqcCkKPiAgIHsKPiAtICAgICAgIGlmIChXQVJOX09O KCFwLT5wYWdlKSkKPiAtICAgICAgICAgICAgICAgcmV0dXJuOwo+ICsgICAgICAgZG1hX3VubWFw X3BhZ2Uodm0tPmRtYSwgcC0+ZGFkZHIsIFBBR0VfU0laRSwgUENJX0RNQV9CSURJUkVDVElPTkFM KTsKPiArCj4gKyAgICAgICBpZiAodm0tPnB0X2ttYXBfd2MpCj4gKyAgICAgICAgICAgICAgIHNl dF9wYWdlc19hcnJheV93YigmcC0+cGFnZSwgMSk7Cj4KPiAtICAgICAgIGRtYV91bm1hcF9wYWdl KCZkZXYtPnBkZXYtPmRldiwgcC0+ZGFkZHIsIDQwOTYsIFBDSV9ETUFfQklESVJFQ1RJT05BTCk7 Cj4gICAgICAgICAgX19mcmVlX3BhZ2UocC0+cGFnZSk7Cj4gLSAgICAgICBtZW1zZXQocCwgMCwg c2l6ZW9mKCpwKSk7Cj4gICB9Cj4KPgo+Cj4gQEAgLTE0ODQsOCArMTQ3NSwxNiBAQCBzdGF0aWMg aW50IGdlbjhfcHBndHRfaW5pdChzdHJ1Y3QgaTkxNV9od19wcGd0dCAqcHBndHQpCj4gICAgICAg ICAgcHBndHQtPmJhc2UuYmluZF92bWEgPSBwcGd0dF9iaW5kX3ZtYTsKPiAgICAgICAgICBwcGd0 dC0+ZGVidWdfZHVtcCA9IGdlbjhfZHVtcF9wcGd0dDsKPgo+ICsgICAgICAgLyogVGhlcmUgYXJl IG9ubHkgZmV3IGV4Y2VwdGlvbnMgZm9yIGdlbiA+PTYuIGNodiBhbmQgYnh0Lgo+ICsgICAgICAg ICogQW5kIHdlIGFyZSBub3Qgc3VyZSBhYm91dCB0aGUgbGF0dGVyIHNvIHBsYXkgc2FmZSBmb3Ig bm93Lgo+ICsgICAgICAgICovCj4gKyAgICAgICBpZiAoSVNfQ0hFUlJZVklFVyhwcGd0dC0+YmFz ZS5kZXYpIHx8IElTX0JST1hUT04ocHBndHQtPmJhc2UuZGV2KSkgewo+ICsgICAgICAgICAgICAg ICBwcGd0dC0+YmFzZS5wdF9rbWFwX3djID0gdHJ1ZTsKPiArICAgICAgICAgICAgICAgcHBndHQt PmJhc2UucHRfa21hcF9wcm90ID0gcGdwcm90X3dyaXRlY29tYmluZShQQUdFX0tFUk5FTF9JTyk7 Cj4gKyAgICAgICB9Cj4gKwo+Cj4gQWR2YW50YWdlOiB3ZSBhdm9pZCB0aGUgY2xmbHVzaCBhZnRl ciBldmVyeSB1cGRhdGUKPiBEaXNhZHZhbnRhZ2U6IHdlIGludm9rZSBzZXRfbWVtb3J5XyooKSBv biBldmVyeSBwYWdlIHVzZWQgYnkgdGhlIHBwZ2d0dC4KPiAoVG8gcmVkdWNlIHRoYXQgY29zdCwg SSBoYXZlIGluIG1hZGUga2VlcGluZyBhIHBhZ2V2ZWMgY2FjaGUgb2YgV0MKPiBwYWdlcy4pCj4K PiBTYWRseSwgd2UgY2FuJ3QganVzdCB1c2Uga21hcF9hdG9taWNfcHJvdCgpIGFzIGl0IGlzIDMy LWJpdCBvbmx5ISEhCj4KPiBOb3RlIHRoYXQgSSBzdGFydGVkIHdpdGggZXhhY3RseSB0aGlzIHBh dGNoICh1c2luZyBhIGt1bm1hcCB2ZnVuYykgbWFueQo+IG1vb25zIGFnbyBhbmQgc3dpdGNoZWQg dG8gdGhlIHBncHJvdF90IGJhc2VkIGFwcHJvYWNoIGluc3RlYWQuCgpUaGUgcGF0dGVybiBvZiB3 cml0ZXMgaXMgc3VjaCB0aGF0IHdyaXRlLWNvbWJpbmUgbWFrZXMgYSBkaWZmZXJlbmNlIGhlcmUg CnZlcnN1cyBhbiBleHBsaWNpdCBmbHVzaD8gVGFraW5nIGludG8gY29uc2lkZXJhdGlvbiB0aGUg Y29tcGxleGl0eSBvZiAKdGhlIHBhZ2V2ZWMgY2FjaGUgeW91IG1lbnRpb24gaXMgcmVxdWlyZWQg Zm9yIHRoZSBzZXRfbWVtb3J5X3djIHJvdXRlPwoKTWFueSBtb29ucyBhZ28gY29tbWVudCBtYWtl cyBtZSB0aGluayB3ZSBjb3VsZCBoYXZlIGF0IGxlYXN0IGhhZCBhbiAKaW50ZXItcmltIHZmdW5j IHNvbHV0aW9uIGluIHBsYWNlIGFsbCB0aGlzIHRpbWUuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=