[RFC i-g-t 0/2] Remove build time dependency in libpciaccess.

[RFC i-g-t 0/2] Remove build time dependency in libpciaccess.

[robert.foss]

From: Robert Foss <robert.foss@collabora.com>

Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware,
like ARM platforms.

Robert Foss (2):
  configure.ac: Add support for configure flag --disable-pciaccess.
  overlay/Makefile: Don't try to build overlay if libpciaccess is
    unavailable.

 configure.ac        | 13 ++++++++++++-
 overlay/Makefile.am |  5 ++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[RFC i-g-t 1/2] configure.ac: Add support for configure flag --disable-pciaccess.

[robert.foss]

From: Robert Foss <robert.foss@collabora.com>

Add support for configure flag --disable-pciaccess and the associated
automake define HAVE_PCIACCESS.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 configure.ac | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 11b1d46..e46bbd5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -101,7 +101,6 @@ fi
 AC_SUBST(ASSEMBLER_WARN_CFLAGS)
 
 PKG_CHECK_MODULES(DRM, [libdrm_intel >= 2.4.64 libdrm])
-PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
 
 case "$target_cpu" in
 	x86*)
@@ -175,6 +174,18 @@ if test "x$VC4" = xyes; then
 fi
 AM_CONDITIONAL(HAVE_VC4, [test "x$VC4" = xyes])
 
+AC_ARG_ENABLE(pciaccess, AS_HELP_STRING([--disable-pciaccess],
+	      [Enable use of pci bus access using libpciaccess (default: auto)]),
+	      [PCIACCESS=$enableval], [PCIACCESS=auto])
+if test "x$PCIACCESS" = xauto; then
+	PKG_CHECK_EXISTS([pciaccess], [PCIACCESS=yes], [PCIACCESS=no])
+fi
+if test "x$PCIACCESS" = xyes; then
+	PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
+	AC_DEFINE(HAVE_LIBPCIACCESS, 1, [Have libpciaccess support])
+fi
+AM_CONDITIONAL(HAVE_LIBPCIACCESS, [test "x$PCIACCESS" = xyes])
+
 # Define a configure option for the shader debugger
 AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger],
 	      [Enable shader debugging support [autodetected]]),
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[RFC i-g-t 2/2] overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

[robert.foss]

From: Robert Foss <robert.foss@collabora.com>

Don't try to build overlay if libpciaccess is unavailable.
This is useful for platforms that typically don't have pci hardware, like ARM
platforms.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 overlay/Makefile.am | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/overlay/Makefile.am b/overlay/Makefile.am
index c926557..a60c6b8 100644
--- a/overlay/Makefile.am
+++ b/overlay/Makefile.am
@@ -1,5 +1,8 @@
+
 if BUILD_OVERLAY
-bin_PROGRAMS = intel-gpu-overlay
+	if HAVE_LIBPCIACCESS
+		bin_PROGRAMS = intel-gpu-overlay
+	endif
 endif
 
 AM_CPPFLAGS = -I.
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [RFC i-g-t 2/2] overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

[Chris Wilson]

On Wed, May 25, 2016 at 02:43:59PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
> 
> Don't try to build overlay if libpciaccess is unavailable.
> This is useful for platforms that typically don't have pci hardware, like ARM
> platforms.

Ok, I should be able to make the dependency optional.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Fwd: Re: [RFC i-g-t 2/2] overlay/Makefile: Don't try to build overlay if libpciaccess is unavailable.

[Robert Foss]

Forward to ML.

On Wed, May 25, 2016 at 02:43:59PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Don't try to build overlay if libpciaccess is unavailable.
> This is useful for platforms that typically don't have pci hardware, like ARM
> platforms.

Ok, I should be able to make the dependency optional.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx