intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org
Cc: akash.goel@intel.com
Subject: Re: [PATCH 2/3] igt/gem_stolen: Fix for no_mmap subtest
Date: Fri, 3 Jun 2016 11:53:42 +0100	[thread overview]
Message-ID: <575161B6.5090702@linux.intel.com> (raw)
In-Reply-To: <1464943891-15470-2-git-send-email-ankitprasad.r.sharma@intel.com>


On 03/06/16 09:51, ankitprasad.r.sharma@intel.com wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
>
> no_mmap subtest is expected to fail, but calling gem_mmap__cpu
> will assert the returned value itself, which makes test fail.
> Replacing gem_mmap__cpu by __gem_mmap__cpu and checking the
> returned value.
>
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> ---
>   tests/gem_stolen.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_stolen.c b/tests/gem_stolen.c
> index 3a3cf81..7d329dd 100644
> --- a/tests/gem_stolen.c
> +++ b/tests/gem_stolen.c
> @@ -392,7 +392,7 @@ stolen_no_mmap(int fd)
>
>   	handle = gem_create_stolen(fd, SIZE);
>
> -	addr = gem_mmap__cpu(fd, handle, 0, SIZE, PROT_READ | PROT_WRITE);
> +	addr = __gem_mmap__cpu(fd, handle, 0, SIZE, PROT_READ | PROT_WRITE);
>   	igt_assert(addr == NULL);
>
>   	gem_close(fd, handle);
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-06-03 10:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  8:51 [PATCH 1/3] igt/gem_stolen: Verify contents of stolen-backed objects across hibernation ankitprasad.r.sharma
2016-06-03  8:51 ` [PATCH 2/3] igt/gem_stolen: Fix for no_mmap subtest ankitprasad.r.sharma
2016-06-03 10:53   ` Tvrtko Ursulin [this message]
2016-06-03  8:51 ` [PATCH 3/3] igt/gem_stolen: Check for available stolen memory size ankitprasad.r.sharma
2016-06-03 10:58   ` Tvrtko Ursulin
2016-06-06  9:25     ` Ankitprasad Sharma
2016-06-03 10:52 ` [PATCH 1/3] igt/gem_stolen: Verify contents of stolen-backed objects across hibernation Tvrtko Ursulin
2016-06-03 11:32 ` ✗ Ro.CI.BAT: failure for series starting with [1/3] " Patchwork
2016-06-03 11:39 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575161B6.5090702@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=akash.goel@intel.com \
    --cc=ankitprasad.r.sharma@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).