From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/21] drm/i915: Refactor scratch object allocation for gen2 w/a buffer Date: Mon, 6 Jun 2016 16:09:12 +0100 Message-ID: <57559218.9070805@linux.intel.com> References: <1464970133-29859-1-git-send-email-chris@chris-wilson.co.uk> <1464970133-29859-12-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 2764D6E5C6 for ; Mon, 6 Jun 2016 15:09:43 +0000 (UTC) In-Reply-To: <1464970133-29859-12-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA2LzE2IDE3OjA4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gVGhlIGdlbjIgdy9hIGJ1 ZmZlciBpcyBzdHVmZmVkIGludG8gdGhlIHNhbWUgc2xvdCBhcyB0aGUgZ2VuNSsgc2NyYXRjaAo+ IGJ1ZmZlci4gSWYgd2UgcGFzcyBpbiB0aGUgc2l6ZSB3ZSB3YW50IHRvIGFsbG9jYXRlIGZvciB0 aGUgc2NyYXRjaAo+IGJ1ZmZlciwgYm90aCBjYWxsZXJzIGNhbiB1c2UgdGhlIHNhbWUgcm91dGlu ZS4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgIHwg IDIgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyB8IDMxICsr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuaCB8ICAyICstCj4gICAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKyksIDI1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRl eCBlNDg2ODc4MzdhOTUuLjMyYjVlYWU3ZGQxMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5jCj4gQEAgLTIwNzgsNyArMjA3OCw3IEBAIHN0YXRpYyBpbnQgbG9naWNhbF9yZW5kZXJfcmlu Z19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJZW5naW5lLT5lbWl0X2ZsdXNoID0g Z2VuOF9lbWl0X2ZsdXNoX3JlbmRlcjsKPiAgIAllbmdpbmUtPmVtaXRfcmVxdWVzdCA9IGdlbjhf ZW1pdF9yZXF1ZXN0X3JlbmRlcjsKPgo+IC0JcmV0ID0gaW50ZWxfaW5pdF9waXBlX2NvbnRyb2wo ZW5naW5lKTsKPiArCXJldCA9IGludGVsX2luaXRfcGlwZV9jb250cm9sKGVuZ2luZSwgNDA5Nik7 Cj4gICAJaWYgKHJldCkKPiAgIAkJcmV0dXJuIHJldDsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCBiN2VlYmJlZDk0NWQuLmNhMmU1OTQwNTk5OCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtNjUzLDE2ICs2 NTMsMTYgQEAgdm9pZCBpbnRlbF9maW5pX3BpcGVfY29udHJvbChzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpCj4gICAJZW5naW5lLT5zY3JhdGNoLm9iaiA9IE5VTEw7Cj4gICB9Cj4KPiAt aW50IGludGVsX2luaXRfcGlwZV9jb250cm9sKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZSkKPiAraW50IGludGVsX2luaXRfcGlwZV9jb250cm9sKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSwgaW50IHNpemUpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg Km9iajsKPiAgIAlpbnQgcmV0Owo+Cj4gICAJV0FSTl9PTihlbmdpbmUtPnNjcmF0Y2gub2JqKTsK Pgo+IC0Jb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4oZW5naW5lLT5pOTE1LT5k ZXYsIDQwOTYpOwo+ICsJb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4oZW5naW5l LT5pOTE1LT5kZXYsIHNpemUpOwo+ICAgCWlmIChvYmogPT0gTlVMTCkKPiAtCQlvYmogPSBpOTE1 X2dlbV9vYmplY3RfY3JlYXRlKGVuZ2luZS0+aTkxNS0+ZGV2LCA0MDk2KTsKPiArCQlvYmogPSBp OTE1X2dlbV9vYmplY3RfY3JlYXRlKGVuZ2luZS0+aTkxNS0+ZGV2LCBzaXplKTsKPiAgIAlpZiAo SVNfRVJSKG9iaikpIHsKPiAgIAkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gYWxsb2NhdGUgc2NyYXRj aCBwYWdlXG4iKTsKPiAgIAkJcmV0ID0gUFRSX0VSUihvYmopOwo+IEBAIC0yODYzLDMxICsyODYz LDE2IEBAIGludCBpbnRlbF9pbml0X3JlbmRlcl9yaW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAgCWVuZ2luZS0+aW5pdF9odyA9IGluaXRfcmVuZGVyX3Jpbmc7Cj4gICAJZW5n aW5lLT5jbGVhbnVwID0gcmVuZGVyX3JpbmdfY2xlYW51cDsKPgo+IC0JLyogV29ya2Fyb3VuZCBi YXRjaGJ1ZmZlciB0byBjb21iYXQgQ1MgdGxiIGJ1Zy4gKi8KPiAtCWlmIChIQVNfQlJPS0VOX0NT X1RMQihkZXZfcHJpdikpIHsKPiAtCQlvYmogPSBpOTE1X2dlbV9vYmplY3RfY3JlYXRlKGRldiwg STgzMF9XQV9TSVpFKTsKPiAtCQlpZiAoSVNfRVJSKG9iaikpIHsKPiAtCQkJRFJNX0VSUk9SKCJG YWlsZWQgdG8gYWxsb2NhdGUgYmF0Y2ggYm9cbiIpOwo+IC0JCQlyZXR1cm4gUFRSX0VSUihvYmop Owo+IC0JCX0KPiAtCj4gLQkJcmV0ID0gaTkxNV9nZW1fb2JqX2dndHRfcGluKG9iaiwgMCwgMCk7 Cj4gLQkJaWYgKHJldCAhPSAwKSB7Cj4gLQkJCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZv YmotPmJhc2UpOwo+IC0JCQlEUk1fRVJST1IoIkZhaWxlZCB0byBwaW5nIGJhdGNoIGJvXG4iKTsK PiAtCQkJcmV0dXJuIHJldDsKPiAtCQl9Cj4gLQo+IC0JCWVuZ2luZS0+c2NyYXRjaC5vYmogPSBv Ymo7Cj4gLQkJZW5naW5lLT5zY3JhdGNoLmd0dF9vZmZzZXQgPSBpOTE1X2dlbV9vYmpfZ2d0dF9v ZmZzZXQob2JqKTsKPiAtCX0KPiAtCj4gICAJcmV0ID0gaW50ZWxfaW5pdF9yaW5nX2J1ZmZlcihk ZXYsIGVuZ2luZSk7Cj4gICAJaWYgKHJldCkKPiAgIAkJcmV0dXJuIHJldDsKPgo+ICAgCWlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpID49IDUpIHsKPiAtCQlyZXQgPSBpbnRlbF9pbml0X3BpcGVfY29u dHJvbChlbmdpbmUpOwo+ICsJCXJldCA9IGludGVsX2luaXRfcGlwZV9jb250cm9sKGVuZ2luZSwg NDA5Nik7CgpDb3VsZCBiZSBjb29sIHRvIGRlZmluZSB0aGlzIHNpemUgd2l0aCBhIGRlc2NyaXB0 aXZlIG5hbWUgYXQgdGhpcyBwb2ludC4KCj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsK PiArCX0gZWxzZSBpZiAoSEFTX0JST0tFTl9DU19UTEIoZGV2X3ByaXYpKSB7Cj4gKwkJcmV0ID0g aW50ZWxfaW5pdF9waXBlX2NvbnRyb2woZW5naW5lLCBJODMwX1dBX1NJWkUpOwo+ICAgCQlpZiAo cmV0KQo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAl9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuaAo+IGluZGV4IDRiMmYxOWRlY2IzMC4uY2I1OTlhNTQ5MzFhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC00ODMsOCArNDgzLDgg QEAgdm9pZCBpbnRlbF9yaW5nX2luaXRfc2Vxbm8oc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n aW5lLCB1MzIgc2Vxbm8pOwo+ICAgaW50IGludGVsX3JpbmdfZmx1c2hfYWxsX2NhY2hlcyhzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSk7Cj4gICBpbnQgaW50ZWxfcmluZ19pbnZhbGlk YXRlX2FsbF9jYWNoZXMoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpOwo+Cj4gK2lu dCBpbnRlbF9pbml0X3BpcGVfY29udHJvbChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUs IGludCBzaXplKTsKPiAgIHZvaWQgaW50ZWxfZmluaV9waXBlX2NvbnRyb2woc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lKTsKPiAtaW50IGludGVsX2luaXRfcGlwZV9jb250cm9sKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4KPiAgIGludCBpbnRlbF9pbml0X3JlbmRlcl9y aW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIGludCBpbnRlbF9pbml0X2Jz ZF9yaW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPgoKQW55d2F5LAoKUmV2aWV3 ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRz LAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK